)]}'
{"ceilometer/pipeline.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"8f84845a599cce019848d51a14c5910c6b59c199","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                    return"},{"line_number":270,"context_line":"            return sample"},{"line_number":271,"context_line":"        except Exception as err:"},{"line_number":272,"context_line":"            LOG.warning(_(\"Pipeline %(pipeline)s: \""},{"line_number":273,"context_line":"                          \"Exit after error from transformer \""},{"line_number":274,"context_line":"                          \"%(trans)s for %(smp)s\") % ({\u0027pipeline\u0027: self,"},{"line_number":275,"context_line":"                                                       \u0027trans\u0027: transformer,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_c2054215","line":272,"updated":"2014-11-20 16:29:23.000000000","message":"not related nit: the word \"Exit\" is not very suitable","commit_id":"bd0889abce9bf739414118d16b7f64a13380a620"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"8f84845a599cce019848d51a14c5910c6b59c199","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                          \"Exit after error from transformer \""},{"line_number":274,"context_line":"                          \"%(trans)s for %(smp)s\") % ({\u0027pipeline\u0027: self,"},{"line_number":275,"context_line":"                                                       \u0027trans\u0027: transformer,"},{"line_number":276,"context_line":"                                                       \u0027smp\u0027: sample}))"},{"line_number":277,"context_line":"            LOG.exception(err)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def _publish_samples(self, start, ctxt, samples):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_cd33b3f4","line":276,"updated":"2014-11-20 16:29:23.000000000","message":"non-related nit: I don\u0027t like the LOG.warning, then LOG.exception style, two level messages for one thing.","commit_id":"bd0889abce9bf739414118d16b7f64a13380a620"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"8f84845a599cce019848d51a14c5910c6b59c199","unresolved":false,"context_lines":[{"line_number":288,"context_line":"        \"\"\""},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        transformed_samples \u003d []"},{"line_number":291,"context_line":"        if not self.transformers:"},{"line_number":292,"context_line":"            transformed_samples \u003d samples"},{"line_number":293,"context_line":"        else:"},{"line_number":294,"context_line":"            for sample in samples:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_4df3430a","line":291,"updated":"2014-11-20 16:29:23.000000000","message":"nit: Consider use self.transformers[start:] instead of self.transformers? But since it is not the directly place we use parameter `start`, it is OK too","commit_id":"bd0889abce9bf739414118d16b7f64a13380a620"}]}