)]}'
{"ceilometer/storage/__init__.py":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"6a96d8bc2a02bb34cfe7ab731db91ac976da1cda","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        url \u003d getattr(conf.database, \u0027%s_connection\u0027 % purpose) or url"},{"line_number":97,"context_line":"    # Set max_retries to 0, since oslo.db in certain cases may attempt to retry"},{"line_number":98,"context_line":"    # making the db connection retried max_retries ^ 2 times in failure case"},{"line_number":99,"context_line":"    conf.set_override(\u0027max_retries\u0027, 0, group\u003d\u0027database\u0027)"},{"line_number":100,"context_line":"    return get_connection(url, namespace)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_f7d52b1c","side":"PARENT","line":99,"updated":"2014-11-25 11:36:31.000000000","message":"Could you please clarify why do we care about that overriding, it is seems that line 99 could be easily deleted.\n\nOr may be I have missed something important?","commit_id":"83038a1ddaa133c396b73cbf1535aad8edffa4c2"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"0479a7269982752ddb7a12157a73731544e8cce5","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        url \u003d getattr(conf.database, \u0027%s_connection\u0027 % purpose) or url"},{"line_number":97,"context_line":"    # Set max_retries to 0, since oslo.db in certain cases may attempt to retry"},{"line_number":98,"context_line":"    # making the db connection retried max_retries ^ 2 times in failure case"},{"line_number":99,"context_line":"    conf.set_override(\u0027max_retries\u0027, 0, group\u003d\u0027database\u0027)"},{"line_number":100,"context_line":"    return get_connection(url, namespace)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_77b21b95","side":"PARENT","line":99,"in_reply_to":"5a890539_f7d52b1c","updated":"2014-11-25 11:51:47.000000000","message":"The max_retries parameter maybe break the logic of reconnect in oslo.db when doing the get_connection function. For more information  please take a look at discussion at ps9 and ps10 in https://review.openstack.org/#/c/127128/","commit_id":"83038a1ddaa133c396b73cbf1535aad8edffa4c2"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"c46287131c5b73331c609cdaddeb70f34a8ace99","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    # Set max_retries to 0, since oslo.db in certain cases may attempt to retry"},{"line_number":100,"context_line":"    # making the db connection retried max_retries ^ 2 times in failure case"},{"line_number":101,"context_line":"    conf.set_override(\u0027max_retries\u0027, 0, group\u003d\u0027database\u0027)"},{"line_number":102,"context_line":"    connection \u003d get_connection(url, namespace)"},{"line_number":103,"context_line":"    conf.set_override(\u0027max_retries\u0027, max_retries, group\u003d\u0027database\u0027)"},{"line_number":104,"context_line":"    return connection"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_4f5ca97d","line":102,"updated":"2014-11-25 09:29:51.000000000","message":"looks kind of tricky imho, but I don\u0027t actually see some other variant :)","commit_id":"418c9369e1d677f0f276cf714c106b18f1bafaac"},{"author":{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},"change_message_id":"cd98129b23ad7daf4dd9cacba6a003fc14c1ab3e","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        url \u003d getattr(conf.database, \u0027%s_connection\u0027 % purpose) or url"},{"line_number":97,"context_line":"    # Set max_retries to 0, since oslo.db in certain cases may attempt to retry"},{"line_number":98,"context_line":"    # making the db connection retried max_retries ^ 2 times in failure case"},{"line_number":99,"context_line":"    conf.set_override(\u0027max_retries\u0027, 0, group\u003d\u0027database\u0027)"},{"line_number":100,"context_line":"    return get_connection(url, namespace)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_cd97a538","side":"PARENT","line":99,"updated":"2014-11-25 21:43:32.000000000","message":"Have you checked that there aren\u0027t any other implementations for storage that don\u0027t need this param besides sql_alchemy?","commit_id":"30824df1a40346bcab8e08f5647c1c2427a9f3f2"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"a9bd46c2fe48fdc011fb69cdb7a8d7be1e8961df","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        url \u003d getattr(conf.database, \u0027%s_connection\u0027 % purpose) or url"},{"line_number":97,"context_line":"    # Set max_retries to 0, since oslo.db in certain cases may attempt to retry"},{"line_number":98,"context_line":"    # making the db connection retried max_retries ^ 2 times in failure case"},{"line_number":99,"context_line":"    conf.set_override(\u0027max_retries\u0027, 0, group\u003d\u0027database\u0027)"},{"line_number":100,"context_line":"    return get_connection(url, namespace)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_38130402","side":"PARENT","line":99,"in_reply_to":"5a890539_cd97a538","updated":"2014-11-26 02:23:35.000000000","message":"Yes, the only use case of max_retries is besides mongo in mongo/utils.py","commit_id":"30824df1a40346bcab8e08f5647c1c2427a9f3f2"}],"ceilometer/storage/impl_sqlalchemy.py":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"14c417b8844c8cb01827f63b53b4f1e447292d2e","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    )"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def __init__(self, url):"},{"line_number":223,"context_line":"        # Set max_retries to 0, since oslo.db in certain cases may attempt"},{"line_number":224,"context_line":"        # to retry making the db connection retried max_retries ^ 2 times"},{"line_number":225,"context_line":"        # in failure case"},{"line_number":226,"context_line":"        cfg.CONF.set_override(\u0027max_retries\u0027, 0, group\u003d\u0027database\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_b852a710","line":223,"updated":"2014-11-26 07:28:54.000000000","message":"It is seems that you have taken comment from storage.__init__, here it looks a little bit odd, please change it with the link on retrying decorator that is used in storage.__init__.get_connection_from_config","commit_id":"3d7197c8d72cc5ac64d76066478ad8506bc95f8f"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"e9202511c1915a9dd74c03616779982101df070c","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    )"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def __init__(self, url):"},{"line_number":223,"context_line":"        # Set max_retries to 0, since oslo.db in certain cases may attempt"},{"line_number":224,"context_line":"        # to retry making the db connection retried max_retries ^ 2 times"},{"line_number":225,"context_line":"        # in failure case"},{"line_number":226,"context_line":"        cfg.CONF.set_override(\u0027max_retries\u0027, 0, group\u003d\u0027database\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_0ac6e567","line":223,"in_reply_to":"5a890539_b852a710","updated":"2014-11-26 08:34:48.000000000","message":"Done","commit_id":"3d7197c8d72cc5ac64d76066478ad8506bc95f8f"}]}