)]}'
{"ceilometer/notification.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"e9353f5a6efdbaddbbf1b5cd1832ce8279a63114","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                      {\u0027name\u0027: ext.name,"},{"line_number":95,"context_line":"                       \u0027type\u0027: \u0027, \u0027.join(handler.event_types),"},{"line_number":96,"context_line":"                       \u0027error\u0027: ack_on_error})"},{"line_number":97,"context_line":"            for new_tar in handler.get_targets(cfg.CONF):"},{"line_number":98,"context_line":"                if not any([new_tar \u003d\u003d target for target in targets]):"},{"line_number":99,"context_line":"                    targets.append(new_tar)"},{"line_number":100,"context_line":"            endpoints.append(handler)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_aba7450a","line":97,"updated":"2014-11-29 07:14:14.000000000","message":"I recommend to use set, it will be much cleaner, we can convert it to list finally","commit_id":"e6e1fe5f7302f704f5577fa6ed0bab0588a3ccb5"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"9af3b95b5a1973eadec656429ff3599224eb1dc0","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                      {\u0027name\u0027: ext.name,"},{"line_number":95,"context_line":"                       \u0027type\u0027: \u0027, \u0027.join(handler.event_types),"},{"line_number":96,"context_line":"                       \u0027error\u0027: ack_on_error})"},{"line_number":97,"context_line":"            for new_tar in handler.get_targets(cfg.CONF):"},{"line_number":98,"context_line":"                if not any([new_tar \u003d\u003d target for target in targets]):"},{"line_number":99,"context_line":"                    targets.append(new_tar)"},{"line_number":100,"context_line":"            endpoints.append(handler)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_1f23e558","line":97,"in_reply_to":"5a890539_4bddb46f","updated":"2014-12-02 21:39:58.000000000","message":"will fix and link bug","commit_id":"e6e1fe5f7302f704f5577fa6ed0bab0588a3ccb5"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"baf2f9f2431208ac9f071a07dbf879adad723734","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                      {\u0027name\u0027: ext.name,"},{"line_number":95,"context_line":"                       \u0027type\u0027: \u0027, \u0027.join(handler.event_types),"},{"line_number":96,"context_line":"                       \u0027error\u0027: ack_on_error})"},{"line_number":97,"context_line":"            for new_tar in handler.get_targets(cfg.CONF):"},{"line_number":98,"context_line":"                if not any([new_tar \u003d\u003d target for target in targets]):"},{"line_number":99,"context_line":"                    targets.append(new_tar)"},{"line_number":100,"context_line":"            endpoints.append(handler)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_4bddb46f","line":97,"in_reply_to":"5a890539_a8057516","updated":"2014-12-02 19:46:55.000000000","message":"Yes, you\u0027re right, oslo.messging.target.Target use id(self) as hash value, which seems not right, I\u0027va already report it as a bug https://bugs.launchpad.net/oslo.messaging/+bug/1398511, fix patch will be soon\n\n-1: But still this can be neater.. aha, seems I\u0027m really nit picking...\n\nthe trick is that: builtin method `in` use __eq__, see https://docs.python.org/2/library/stdtypes.html#sequence-types-str-unicode-list-tuple-bytearray-buffer-xrange\n\nso maybe we can short it to\n\n    if new_tar not in targets:\n        targets.append(new_tar)\n\n?","commit_id":"e6e1fe5f7302f704f5577fa6ed0bab0588a3ccb5"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"9317c76c8a13be4e24fdd313f43e44903e76101c","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                      {\u0027name\u0027: ext.name,"},{"line_number":95,"context_line":"                       \u0027type\u0027: \u0027, \u0027.join(handler.event_types),"},{"line_number":96,"context_line":"                       \u0027error\u0027: ack_on_error})"},{"line_number":97,"context_line":"            for new_tar in handler.get_targets(cfg.CONF):"},{"line_number":98,"context_line":"                if not any([new_tar \u003d\u003d target for target in targets]):"},{"line_number":99,"context_line":"                    targets.append(new_tar)"},{"line_number":100,"context_line":"            endpoints.append(handler)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_a8057516","line":97,"in_reply_to":"5a890539_aba7450a","updated":"2014-12-01 14:07:00.000000000","message":"i tried. it doesn\u0027t work since we\u0027re comparing objects... that or my environment was broken when i tried.","commit_id":"e6e1fe5f7302f704f5577fa6ed0bab0588a3ccb5"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"3bdec871500310de6f6709d749bd6b1c8c23ae24","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                       \u0027type\u0027: \u0027, \u0027.join(handler.event_types),"},{"line_number":96,"context_line":"                       \u0027error\u0027: ack_on_error})"},{"line_number":97,"context_line":"            # FIXME(gordc): this could be a set check but oslo.messaging issue"},{"line_number":98,"context_line":"            # https://bugs.launchpad.net/oslo.messaging/+bug/1398511"},{"line_number":99,"context_line":"            for new_tar in handler.get_targets(cfg.CONF):"},{"line_number":100,"context_line":"                if new_tar not in targets:"},{"line_number":101,"context_line":"                    targets.append(new_tar)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_f9e29e2e","line":98,"updated":"2014-12-03 13:41:38.000000000","message":"I think the bug link can be removed or replaced with why we should remove duplicate target (code reader may not read commit message after several months), it is more important than the python trick","commit_id":"185b5f81adc2371d506f618d0a76b45cc3966de7"}]}