)]}'
{"ceilometer/pipeline.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"bbce4dc3e3593fac7aee89dad8ae9edec429cc46","unresolved":false,"context_lines":[{"line_number":521,"context_line":"                    if pipe.name in [p.name for p in self.pipelines]:"},{"line_number":522,"context_line":"                        raise PipelineException("},{"line_number":523,"context_line":"                            \"Duplicate pipeline name: %s. Ensure pipeline\""},{"line_number":524,"context_line":"                            \" names are unique\" % pipe.name, cfg)"},{"line_number":525,"context_line":"                    else:"},{"line_number":526,"context_line":"                        self.pipelines.append(pipe)"},{"line_number":527,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_507fb217","line":524,"updated":"2014-12-05 03:57:09.000000000","message":"since user have no concept of pipeline name, but only source name and sink name, may be we should make sure source name and sink name are unique? or we should modify this exception string to guide them to do so?","commit_id":"163b5548eec38e21a737eaca38555f934c526a55"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"ef60af939e0646ace57652e4038205745db8a699","unresolved":false,"context_lines":[{"line_number":521,"context_line":"                    if pipe.name in [p.name for p in self.pipelines]:"},{"line_number":522,"context_line":"                        raise PipelineException("},{"line_number":523,"context_line":"                            \"Duplicate pipeline name: %s. Ensure pipeline\""},{"line_number":524,"context_line":"                            \" names are unique\" % pipe.name, cfg)"},{"line_number":525,"context_line":"                    else:"},{"line_number":526,"context_line":"                        self.pipelines.append(pipe)"},{"line_number":527,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_8f23a357","line":524,"in_reply_to":"5a890539_507fb217","updated":"2014-12-05 14:49:24.000000000","message":"i\u0027ll make string more detailed. you can still create logically duplicate pipelines if you just check source/sink individual","commit_id":"163b5548eec38e21a737eaca38555f934c526a55"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"4e148f8160a936fb88ecc62c828a00e2121453b9","unresolved":false,"context_lines":[{"line_number":533,"context_line":"                pipe \u003d Pipeline(source, sink)"},{"line_number":534,"context_line":"                if pipe.name in [p.name for p in self.pipelines]:"},{"line_number":535,"context_line":"                    raise PipelineException("},{"line_number":536,"context_line":"                        \"Duplicate pipeline name: %s. Ensure pipeline\""},{"line_number":537,"context_line":"                        \" names are unique\" % pipe.name, cfg)"},{"line_number":538,"context_line":"                else:"},{"line_number":539,"context_line":"                    self.pipelines.append(pipe)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_b076eda1","line":536,"updated":"2014-12-06 02:24:10.000000000","message":"so here need to address Lianhao Lu\u0027s comment too.\n\nI would suggest to create a new exception named DuplicatePipelineException and use L523 as default msg,","commit_id":"90509a3385bc86360651e95b8bf1d15ef8fb9df4"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"a754410fba29b531f19e9a4da3f1840ac5639405","unresolved":false,"context_lines":[{"line_number":533,"context_line":"                pipe \u003d Pipeline(source, sink)"},{"line_number":534,"context_line":"                if pipe.name in [p.name for p in self.pipelines]:"},{"line_number":535,"context_line":"                    raise PipelineException("},{"line_number":536,"context_line":"                        \"Duplicate pipeline name: %s. Ensure pipeline\""},{"line_number":537,"context_line":"                        \" names are unique\" % pipe.name, cfg)"},{"line_number":538,"context_line":"                else:"},{"line_number":539,"context_line":"                    self.pipelines.append(pipe)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_1526f6ba","line":536,"in_reply_to":"3a961159_0fd0a952","updated":"2014-12-07 01:38:38.000000000","message":"Oh, I see, Thanks, plz ignore my last comment","commit_id":"90509a3385bc86360651e95b8bf1d15ef8fb9df4"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"85662b9ac00c7fc55fbc1588acf2b6ee80ee5c2f","unresolved":false,"context_lines":[{"line_number":533,"context_line":"                pipe \u003d Pipeline(source, sink)"},{"line_number":534,"context_line":"                if pipe.name in [p.name for p in self.pipelines]:"},{"line_number":535,"context_line":"                    raise PipelineException("},{"line_number":536,"context_line":"                        \"Duplicate pipeline name: %s. Ensure pipeline\""},{"line_number":537,"context_line":"                        \" names are unique\" % pipe.name, cfg)"},{"line_number":538,"context_line":"                else:"},{"line_number":539,"context_line":"                    self.pipelines.append(pipe)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_0fd0a952","line":536,"in_reply_to":"5a890539_b076eda1","updated":"2014-12-06 18:37:36.000000000","message":"i actually left this one because in deprecated pipeline, we don\u0027t have concept of source/sink... just a single pipeline name.","commit_id":"90509a3385bc86360651e95b8bf1d15ef8fb9df4"},{"author":{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},"change_message_id":"bd7b84cd290a2d1cfbe2e1ca30e307014af28455","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                        raise PipelineException("},{"line_number":523,"context_line":"                            \"Duplicate pipeline name: %s. Ensure pipeline\""},{"line_number":524,"context_line":"                            \" names are unique. (name is the source and sink\""},{"line_number":525,"context_line":"                            \" names combined)\" % pipe.name, cfg)"},{"line_number":526,"context_line":"                    else:"},{"line_number":527,"context_line":"                        self.pipelines.append(pipe)"},{"line_number":528,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_6e1b7d1b","line":525,"updated":"2014-12-10 15:41:56.000000000","message":"Are you making names unique inside the Sources or Sinks or you are making them globally unique?","commit_id":"ce349efc2179b00e9c479629557db6f437fcdae6"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"89f46aaf4335486c20b8a91c7728e016d294ddd7","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                        raise PipelineException("},{"line_number":523,"context_line":"                            \"Duplicate pipeline name: %s. Ensure pipeline\""},{"line_number":524,"context_line":"                            \" names are unique. (name is the source and sink\""},{"line_number":525,"context_line":"                            \" names combined)\" % pipe.name, cfg)"},{"line_number":526,"context_line":"                    else:"},{"line_number":527,"context_line":"                        self.pipelines.append(pipe)"},{"line_number":528,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_29f14802","line":525,"in_reply_to":"3a961159_23e7aaad","updated":"2014-12-11 14:23:26.000000000","message":"as Igor said, i\u0027m making the pair unique... i\u0027m not sure if there\u0027s any cases where it\u0027s duplicate right now... everyone has their own (possibly) modified pipeline. even so i don\u0027t think it\u0027s that hard of a change for people with dup names to fix them on next restart.\n\ni don\u0027t think it\u0027s a bug. it\u0027s just something that we never cared about.","commit_id":"ce349efc2179b00e9c479629557db6f437fcdae6"},{"author":{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},"change_message_id":"6c89e726b89a977a16b1262493f7e590d443db66","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                        raise PipelineException("},{"line_number":523,"context_line":"                            \"Duplicate pipeline name: %s. Ensure pipeline\""},{"line_number":524,"context_line":"                            \" names are unique. (name is the source and sink\""},{"line_number":525,"context_line":"                            \" names combined)\" % pipe.name, cfg)"},{"line_number":526,"context_line":"                    else:"},{"line_number":527,"context_line":"                        self.pipelines.append(pipe)"},{"line_number":528,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_e63f66b2","line":525,"in_reply_to":"3a961159_29f14802","updated":"2014-12-11 16:44:41.000000000","message":"I think having them globally unique is the right approach. Thanks.","commit_id":"ce349efc2179b00e9c479629557db6f437fcdae6"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"07df47542199baf5fcb1b189abbec36eaeac5860","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                        raise PipelineException("},{"line_number":523,"context_line":"                            \"Duplicate pipeline name: %s. Ensure pipeline\""},{"line_number":524,"context_line":"                            \" names are unique. (name is the source and sink\""},{"line_number":525,"context_line":"                            \" names combined)\" % pipe.name, cfg)"},{"line_number":526,"context_line":"                    else:"},{"line_number":527,"context_line":"                        self.pipelines.append(pipe)"},{"line_number":528,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_23e7aaad","line":525,"in_reply_to":"3a961159_6e1b7d1b","updated":"2014-12-11 12:37:50.000000000","message":"AFAIK pipeline.name is combined from source.name and sink.target.name if they are not equal. Do we already have any cases when pipeline names could be duplicated? If so is it a bug now?","commit_id":"ce349efc2179b00e9c479629557db6f437fcdae6"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"9fc4d2edbcc2529c137177754da817c99850b74a","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                        raise PipelineException("},{"line_number":523,"context_line":"                            \"Duplicate pipeline name: %s. Ensure pipeline\""},{"line_number":524,"context_line":"                            \" names are unique. (name is the source and sink\""},{"line_number":525,"context_line":"                            \" names combined)\" % pipe.name, cfg)"},{"line_number":526,"context_line":"                    else:"},{"line_number":527,"context_line":"                        self.pipelines.append(pipe)"},{"line_number":528,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_2f604cce","line":525,"in_reply_to":"3a961159_e63f66b2","updated":"2014-12-12 09:15:46.000000000","message":"Yep gordon, you are right here, it is nice if we finally care about duplication possibility of pipelines. Thank you for that.","commit_id":"ce349efc2179b00e9c479629557db6f437fcdae6"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"07df47542199baf5fcb1b189abbec36eaeac5860","unresolved":false,"context_lines":[{"line_number":534,"context_line":"                if pipe.name in [p.name for p in self.pipelines]:"},{"line_number":535,"context_line":"                    raise PipelineException("},{"line_number":536,"context_line":"                        \"Duplicate pipeline name: %s. Ensure pipeline\""},{"line_number":537,"context_line":"                        \" names are unique\" % pipe.name, cfg)"},{"line_number":538,"context_line":"                else:"},{"line_number":539,"context_line":"                    self.pipelines.append(pipe)"},{"line_number":540,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_c3a50648","line":537,"updated":"2014-12-11 12:37:50.000000000","message":"cfg is redundant here isn\u0027t it?","commit_id":"ce349efc2179b00e9c479629557db6f437fcdae6"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"9fc4d2edbcc2529c137177754da817c99850b74a","unresolved":false,"context_lines":[{"line_number":534,"context_line":"                if pipe.name in [p.name for p in self.pipelines]:"},{"line_number":535,"context_line":"                    raise PipelineException("},{"line_number":536,"context_line":"                        \"Duplicate pipeline name: %s. Ensure pipeline\""},{"line_number":537,"context_line":"                        \" names are unique\" % pipe.name, cfg)"},{"line_number":538,"context_line":"                else:"},{"line_number":539,"context_line":"                    self.pipelines.append(pipe)"},{"line_number":540,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_8f54e0ff","line":537,"in_reply_to":"3a961159_293f8889","updated":"2014-12-12 09:15:46.000000000","message":"Sorry for that question, i thought cfg is a insert param and didn\u0027t find where it was put in. :)) of course it is not redundant.","commit_id":"ce349efc2179b00e9c479629557db6f437fcdae6"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"89f46aaf4335486c20b8a91c7728e016d294ddd7","unresolved":false,"context_lines":[{"line_number":534,"context_line":"                if pipe.name in [p.name for p in self.pipelines]:"},{"line_number":535,"context_line":"                    raise PipelineException("},{"line_number":536,"context_line":"                        \"Duplicate pipeline name: %s. Ensure pipeline\""},{"line_number":537,"context_line":"                        \" names are unique\" % pipe.name, cfg)"},{"line_number":538,"context_line":"                else:"},{"line_number":539,"context_line":"                    self.pipelines.append(pipe)"},{"line_number":540,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_293f8889","line":537,"in_reply_to":"3a961159_c3a50648","updated":"2014-12-11 14:23:26.000000000","message":"the exception shows the pipeline and points out the issue. not sure what is redundant.","commit_id":"ce349efc2179b00e9c479629557db6f437fcdae6"}]}