)]}'
{"ceilometer/pipeline.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"1aa036ec996aa3a8598d40e029f441750bbb7d12","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    def check_source_filtering(self, data, d_type):"},{"line_number":128,"context_line":"        \"\"\"Source data rules checking"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        - At least one meaningful datapoint exist"},{"line_number":131,"context_line":"        - Included type and excluded type can\u0027t co-exist on the same pipeline"},{"line_number":132,"context_line":"        - Included type meter and wildcard can\u0027t co-exist at same pipeline"},{"line_number":133,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_ba62f8aa","line":130,"updated":"2014-12-10 18:10:36.000000000","message":"exists","commit_id":"bf98aae5d5e14bc2f0ef8248b084381195aa8394"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"1aa036ec996aa3a8598d40e029f441750bbb7d12","unresolved":false,"context_lines":[{"line_number":518,"context_line":"        \"\"\""},{"line_number":519,"context_line":"        self.pipelines \u003d []"},{"line_number":520,"context_line":"        # TODO(gordc): add Event Source/Sink support."},{"line_number":521,"context_line":"        if p_type \u003d\u003d \u0027sample\u0027:"},{"line_number":522,"context_line":"            source_type \u003d SampleSource"},{"line_number":523,"context_line":"            sink_type \u003d SampleSink"},{"line_number":524,"context_line":"            pipeline_type \u003d SamplePipeline"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_ba93d84d","line":521,"updated":"2014-12-10 18:10:36.000000000","message":"Rather than passing in a string and then having do a conditional, why not take source_type, sink_type and pipeline_type as args, each of which takes  the desired class (or has the reasonable default).\n\nThen you won\u0027t need to have another section for event and you\u0027ll have some interesting ways to inject test classes (if such a thing is desirable).\n\nOr, in other words, does it make sense to use dependency injection?","commit_id":"bf98aae5d5e14bc2f0ef8248b084381195aa8394"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"32e3f802811d597cd152ad582860e377701aa1dc","unresolved":false,"context_lines":[{"line_number":518,"context_line":"        \"\"\""},{"line_number":519,"context_line":"        self.pipelines \u003d []"},{"line_number":520,"context_line":"        # TODO(gordc): add Event Source/Sink support."},{"line_number":521,"context_line":"        if p_type \u003d\u003d \u0027sample\u0027:"},{"line_number":522,"context_line":"            source_type \u003d SampleSource"},{"line_number":523,"context_line":"            sink_type \u003d SampleSink"},{"line_number":524,"context_line":"            pipeline_type \u003d SamplePipeline"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_ef5d1d17","line":521,"in_reply_to":"3a961159_ba93d84d","updated":"2014-12-15 17:06:18.000000000","message":"hmm.. yeah, maybe i should do something similar to what i did with source/sinks... i think i originally did this because i was planning on having events/samples managed by same manager... but i guess even then it doesn\u0027t make sense...","commit_id":"bf98aae5d5e14bc2f0ef8248b084381195aa8394"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"b9c5d4ad26cbb59b1d6d7458746307d099a57c7e","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                    self.cfg)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def check_source_filtering(self, data, d_type):"},{"line_number":126,"context_line":"        \"\"\"Source data rules checking"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        - At least one meaningful datapoint exist"},{"line_number":129,"context_line":"        - Included type and excluded type can\u0027t co-exist on the same pipeline"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_03e1f9cf","line":126,"updated":"2014-12-18 11:34:11.000000000","message":"First docstring line should to end with dot.","commit_id":"c9560c41de9a33a673e4f3e838ab0be664d47e90"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"0cac325d7d3af4ae294bb94955daed9cf546c64b","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                    self.cfg)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def check_source_filtering(self, data, d_type):"},{"line_number":126,"context_line":"        \"\"\"Source data rules checking"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        - At least one meaningful datapoint exist"},{"line_number":129,"context_line":"        - Included type and excluded type can\u0027t co-exist on the same pipeline"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_7749255f","line":126,"in_reply_to":"3a961159_03e1f9cf","updated":"2014-12-23 15:29:33.000000000","message":"i believe that\u0027s only true for single line docstring and also this isn\u0027t a complete sentence... \n\nthat said, this is moving existing code around.","commit_id":"c9560c41de9a33a673e4f3e838ab0be664d47e90"}],"ceilometer/tests/objectstore/test_swift_middleware.py":[{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"b9c598527a5ee83e74033cd6cedde20abd29ccc4","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            def __init__(self, pipeline_manager):"},{"line_number":72,"context_line":"                self.pipeline_manager \u003d pipeline_manager"},{"line_number":73,"context_line":"                self.samples \u003d []"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            def publish_data(self, ctxt, samples):"},{"line_number":76,"context_line":"                self.samples.extend(samples)"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_a8000403","line":74,"updated":"2015-01-04 15:30:29.000000000","message":"Gordon, why did you change the following here? I mean we have a lot of methods like \u0027publish_samples\u0027 not only in swift middleware. why the changes are only here?","commit_id":"a11848586e30bd37cbefb775b2b9c820e7f88be9"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"e06ce49cc1f8b1c964e0834afb82ac86cc369afc","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            def __init__(self, pipeline_manager):"},{"line_number":72,"context_line":"                self.pipeline_manager \u003d pipeline_manager"},{"line_number":73,"context_line":"                self.samples \u003d []"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            def publish_data(self, ctxt, samples):"},{"line_number":76,"context_line":"                self.samples.extend(samples)"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_0004a116","line":74,"in_reply_to":"3a961159_8d556fc4","updated":"2015-01-13 15:09:06.000000000","message":"yes. that\u0027s exactly it. :)","commit_id":"a11848586e30bd37cbefb775b2b9c820e7f88be9"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"efd3d5d836c87c8f5287e87ecd9d8a8b810ede4b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            def __init__(self, pipeline_manager):"},{"line_number":72,"context_line":"                self.pipeline_manager \u003d pipeline_manager"},{"line_number":73,"context_line":"                self.samples \u003d []"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            def publish_data(self, ctxt, samples):"},{"line_number":76,"context_line":"                self.samples.extend(samples)"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_b2081f81","line":74,"in_reply_to":"3a961159_a8000403","updated":"2015-01-07 11:16:57.000000000","message":"Actually can\u0027t get the point as well here...","commit_id":"a11848586e30bd37cbefb775b2b9c820e7f88be9"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"efd3d5d836c87c8f5287e87ecd9d8a8b810ede4b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            def __init__(self, pipeline_manager):"},{"line_number":72,"context_line":"                self.pipeline_manager \u003d pipeline_manager"},{"line_number":73,"context_line":"                self.samples \u003d []"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            def publish_data(self, ctxt, samples):"},{"line_number":76,"context_line":"                self.samples.extend(samples)"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_d20dab90","line":74,"in_reply_to":"3a961159_a8000403","updated":"2015-01-07 11:16:57.000000000","message":"Actually can\u0027t get the point as well here...","commit_id":"a11848586e30bd37cbefb775b2b9c820e7f88be9"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"4daa21579e47d75b012f106c627d71469f986dbc","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            def __init__(self, pipeline_manager):"},{"line_number":72,"context_line":"                self.pipeline_manager \u003d pipeline_manager"},{"line_number":73,"context_line":"                self.samples \u003d []"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            def publish_data(self, ctxt, samples):"},{"line_number":76,"context_line":"                self.samples.extend(samples)"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_fad7d920","line":74,"in_reply_to":"3a961159_d20dab90","updated":"2015-01-07 15:11:18.000000000","message":"hi, so the reason i changed this is because i chose to rename the publish method of pipeline to \u0027publish_data\u0027 instead of \u0027publish_samples\u0027 (so that when we add event pipeline, we call something more generic and not something samples specific).\n\nso when interacting with a Pipeline, it will call publish_data (see PublishContext in pipeline.py), but the actual processing depending on what type of pipeline it is, will be handled by either publish_samples or publish_events","commit_id":"a11848586e30bd37cbefb775b2b9c820e7f88be9"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"0864076ba0865b8f3bcce1901b74a5e7020f59ea","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            def __init__(self, pipeline_manager):"},{"line_number":72,"context_line":"                self.pipeline_manager \u003d pipeline_manager"},{"line_number":73,"context_line":"                self.samples \u003d []"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            def publish_data(self, ctxt, samples):"},{"line_number":76,"context_line":"                self.samples.extend(samples)"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_8d556fc4","line":74,"in_reply_to":"3a961159_fad7d920","updated":"2015-01-10 17:36:37.000000000","message":"yes, I understand the motivation in renaming here. The question is mostly \u0027why only here?\u0027 E.g. should\u0027t publish_samples be renamed here https://github.com/openstack/ceilometer/blob/master/ceilometer/objectstore/swift_middleware.py#L147 or https://github.com/openstack/ceilometer/blob/master/ceilometer/publisher/__init__.py#L46 ? Or my examples are related to \u0027samples\u0027 publishers only? It seems that I see your point :) Thanks for explanation! I will ask you in irc if needed","commit_id":"a11848586e30bd37cbefb775b2b9c820e7f88be9"}]}