)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13367,"name":"Pradyumna Sampath","email":"pradyumna@hitachi.co.in","username":"prady"},"change_message_id":"f8262d318416c15e3225d510b926d049e034db6a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When we run tools/make_test_data.sh it raises TypeError:"},{"line_number":10,"context_line":"TypeError: unsupported type for timedelta days component: str."},{"line_number":11,"context_line":"This change allows the script tools/make_test_data.sh to work"},{"line_number":12,"context_line":"correctly and to work correctly tools/make_test_data.py."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ib054c3e10d617686928bf03f94c5ff868905afde"},{"line_number":15,"context_line":"Closes-bug: 1389684"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_d123f7ba","line":12,"updated":"2014-12-12 00:02:49.000000000","message":"nit: the sentence construction with using \"to work correctly\" twice is confusing. \n\nSuggested change: TypeError is raised on unsupported type when we run tools/make_test_data.sh. This patch allows both the script \"tools/make_test_data.sh\" and \"tools/make_test_data.py\" to work correctly.","commit_id":"0b66a044fc232bd93038318ad43a2a68b1ed34be"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"e3113bd17b2cca7e621dbccd4fd16e29cf666ec1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2014-12-11 17:25:03 +0400"},{"line_number":4,"context_line":"Commit:     Lena Novokshonova \u003cenovokshonova@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-12-15 12:45:00 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correctly work script tools/make_test_data.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we run tools/make_test_data.sh it raises TypeError:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a961159_049258f5","line":6,"updated":"2014-12-15 13:00:28.000000000","message":"\"Improve tools/make_test_data.sh correctness\" would be better","commit_id":"ab6ab1838490e520c255827c507fd2eb4135893f"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"e3113bd17b2cca7e621dbccd4fd16e29cf666ec1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-12-15 12:45:00 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correctly work script tools/make_test_data.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we run tools/make_test_data.sh it raises TypeError:"},{"line_number":10,"context_line":"TypeError: unsupported type for timedelta days component: str."},{"line_number":11,"context_line":"This change allows the script tools/make_test_data.sh to work"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a961159_04a97823","line":8,"updated":"2014-12-15 13:00:28.000000000","message":"All the following should be in bug description not in commit message, imho.","commit_id":"ab6ab1838490e520c255827c507fd2eb4135893f"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"bc01893d4413b96b2f8c177f931dcc92b142a5fa","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve tools/make_test_data.sh correctness"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change allows the script tools/make_test_data.sh to work"},{"line_number":10,"context_line":"correctly and to work correctly tools/make_test_data.py."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib054c3e10d617686928bf03f94c5ff868905afde"},{"line_number":13,"context_line":"Closes-bug: 1389684"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a961159_e85ec511","line":10,"updated":"2014-12-16 22:02:49.000000000","message":"minor nit: This statement seems redundant and doesnt really\nseem to convey what the fix is. Perhaps rephrase this and add\n whats being corrected\n\n \" This change allows the scripts tools/make_test_data.sh and\ntools/make_test_data.py to work correctly by handing exceptions\nappropriately \" or something on those lines","commit_id":"2eff036668189d24d55c75389830ed7c32019802"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"bd5e129e2ed49581434137df8f6bda0a9ae8047e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve tools/make_test_data.sh correctness"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change allows the script tools/make_test_data.sh to work"},{"line_number":10,"context_line":"correctly and to work correctly tools/make_test_data.py."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib054c3e10d617686928bf03f94c5ff868905afde"},{"line_number":13,"context_line":"Closes-bug: 1389684"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a961159_4d88b922","line":10,"in_reply_to":"3a961159_e85ec511","updated":"2014-12-17 10:09:56.000000000","message":"well, yeah, it\u0027ll be nice rephrase. Lena, it\u0027ll be really nice if you\u0027ll do that","commit_id":"2eff036668189d24d55c75389830ed7c32019802"}],"tools/make_test_data.py":[{"author":{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},"change_message_id":"ab5229026166dcb5ec51efb6bce9930fbeb768f3","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    # Compute the correct time span"},{"line_number":189,"context_line":"    start \u003d datetime.datetime.utcnow() - datetime.timedelta(days\u003dargs.start)"},{"line_number":190,"context_line":"    end \u003d datetime.datetime.utcnow() + datetime.timedelta(days\u003dargs.end)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    make_test_data(conn\u003dconn,"},{"line_number":193,"context_line":"                   name\u003dargs.counter,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_1b06641d","side":"PARENT","line":190,"updated":"2014-12-12 16:20:38.000000000","message":"Eoghan is right. This is the same expression that was here and has been erroneously changed","commit_id":"61eba5455bebb068868488f14a62e47996341c66"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"7313f053624f942472290f3ac9ba13576dfe6da3","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        start \u003d datetime.datetime.utcnow() - datetime.timedelta("},{"line_number":192,"context_line":"            days\u003dint(args.start))"},{"line_number":193,"context_line":"    except ValueError:"},{"line_number":194,"context_line":"        start \u003d datetime.datetime.strptime(args.start, format)"},{"line_number":195,"context_line":"    try:"},{"line_number":196,"context_line":"        end \u003d datetime.datetime.utcnow() - datetime.timedelta("},{"line_number":197,"context_line":"            days\u003dint(args.end))"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_cac32436","line":194,"updated":"2014-12-12 18:23:38.000000000","message":"-1: If we decide to support both int days and string timestamp, then we should update corresponding help string for these two arguments, see L114 and L 119\n\notherwise, let force these two arguments to be int days, and die soon when user inputs invalid type","commit_id":"294cb5abf539c48960d22452f72c9597be782399"},{"author":{"_account_id":13273,"name":"Lena Novokshonova","email":"enovokshonova@mirantis.com","username":"enovokshonova"},"change_message_id":"6ade6f4f4078c7f47972c7dc9f926007aeb50250","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        start \u003d datetime.datetime.utcnow() - datetime.timedelta("},{"line_number":192,"context_line":"            days\u003dint(args.start))"},{"line_number":193,"context_line":"    except ValueError:"},{"line_number":194,"context_line":"        start \u003d datetime.datetime.strptime(args.start, format)"},{"line_number":195,"context_line":"    try:"},{"line_number":196,"context_line":"        end \u003d datetime.datetime.utcnow() - datetime.timedelta("},{"line_number":197,"context_line":"            days\u003dint(args.end))"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_ca3ce1ca","line":194,"in_reply_to":"3a961159_cac32436","updated":"2014-12-15 09:48:17.000000000","message":"ok, i updated corresponding help strings","commit_id":"294cb5abf539c48960d22452f72c9597be782399"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"380a8b3ab0738a52ce2bdf19c5984551892dad7c","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    except ValueError:"},{"line_number":194,"context_line":"        start \u003d datetime.datetime.strptime(args.start, format)"},{"line_number":195,"context_line":"    try:"},{"line_number":196,"context_line":"        end \u003d datetime.datetime.utcnow() - datetime.timedelta("},{"line_number":197,"context_line":"            days\u003dint(args.end))"},{"line_number":198,"context_line":"    except ValueError:"},{"line_number":199,"context_line":"        end \u003d datetime.datetime.strptime(args.end, format)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_498669dc","line":196,"updated":"2014-12-12 16:10:38.000000000","message":"The subtraction here seems to change the meaning of the end arg:\n\n  \u0027The number of days into the future to continue timestamps.\u0027\n\nSurely that delta should be added to datetime.datetime.utcnow() instead of being subtracted?","commit_id":"294cb5abf539c48960d22452f72c9597be782399"},{"author":{"_account_id":13273,"name":"Lena Novokshonova","email":"enovokshonova@mirantis.com","username":"enovokshonova"},"change_message_id":"6ade6f4f4078c7f47972c7dc9f926007aeb50250","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    except ValueError:"},{"line_number":194,"context_line":"        start \u003d datetime.datetime.strptime(args.start, format)"},{"line_number":195,"context_line":"    try:"},{"line_number":196,"context_line":"        end \u003d datetime.datetime.utcnow() - datetime.timedelta("},{"line_number":197,"context_line":"            days\u003dint(args.end))"},{"line_number":198,"context_line":"    except ValueError:"},{"line_number":199,"context_line":"        end \u003d datetime.datetime.strptime(args.end, format)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_a46c2b09","line":196,"in_reply_to":"3a961159_498669dc","updated":"2014-12-15 09:48:17.000000000","message":"oh yeah my mistake! very sorry! thanks!","commit_id":"294cb5abf539c48960d22452f72c9597be782399"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"e3113bd17b2cca7e621dbccd4fd16e29cf666ec1","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    )"},{"line_number":111,"context_line":"    parser.add_argument("},{"line_number":112,"context_line":"        \u0027--start\u0027,"},{"line_number":113,"context_line":"        default\u003d31,"},{"line_number":114,"context_line":"        help\u003d\u0027The number of days in the past or date in the past to start\u0027"},{"line_number":115,"context_line":"             \u0027timestamps.\u0027,"},{"line_number":116,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_6495dc31","line":113,"updated":"2014-12-15 13:00:28.000000000","message":"Lena, could you please rewrite \"The number of days in the past\" ? As I understand, it means \"how many days from now should be stepped back to start\", is it correct? Native speaker would help :)\nBesides, maybe it would be helpful to add what date format is expected?","commit_id":"ab6ab1838490e520c255827c507fd2eb4135893f"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"242bb60ba27c9af248d28d7bb598cca8565a6a52","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    )"},{"line_number":111,"context_line":"    parser.add_argument("},{"line_number":112,"context_line":"        \u0027--start\u0027,"},{"line_number":113,"context_line":"        default\u003d31,"},{"line_number":114,"context_line":"        help\u003d\u0027The number of days in the past or date in the past to start\u0027"},{"line_number":115,"context_line":"             \u0027timestamps.\u0027,"},{"line_number":116,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_5f31ffeb","line":113,"in_reply_to":"3a961159_07bed7ad","updated":"2014-12-18 20:43:24.000000000","message":"Thanks, girls :) Looks great now","commit_id":"ab6ab1838490e520c255827c507fd2eb4135893f"},{"author":{"_account_id":13273,"name":"Lena Novokshonova","email":"enovokshonova@mirantis.com","username":"enovokshonova"},"change_message_id":"701cde01289817a83354d55d4693d6d3c4d08d38","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    )"},{"line_number":111,"context_line":"    parser.add_argument("},{"line_number":112,"context_line":"        \u0027--start\u0027,"},{"line_number":113,"context_line":"        default\u003d31,"},{"line_number":114,"context_line":"        help\u003d\u0027The number of days in the past or date in the past to start\u0027"},{"line_number":115,"context_line":"             \u0027timestamps.\u0027,"},{"line_number":116,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_d4239b02","line":113,"in_reply_to":"3a961159_6495dc31","updated":"2014-12-15 14:24:48.000000000","message":"Nadya, what do you think about this: How many days in the past should be stepped back from now or date in the past to start timestamps? Date must be in the format \u0027YYYY-MM-DDTHH:MM:SS\u0027.","commit_id":"ab6ab1838490e520c255827c507fd2eb4135893f"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"2277cd04f063672698e61833edee801b06b10cb1","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    )"},{"line_number":111,"context_line":"    parser.add_argument("},{"line_number":112,"context_line":"        \u0027--start\u0027,"},{"line_number":113,"context_line":"        default\u003d31,"},{"line_number":114,"context_line":"        help\u003d\u0027The number of days in the past or date in the past to start\u0027"},{"line_number":115,"context_line":"             \u0027timestamps.\u0027,"},{"line_number":116,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_e7c62b67","line":113,"in_reply_to":"3a961159_d4239b02","updated":"2014-12-15 14:44:05.000000000","message":"Number of days to be stepped back from now or date in the past (\u0027YYYY-MM-DDTHH:MM:SS\u0027 format) to define timestamps start range.","commit_id":"ab6ab1838490e520c255827c507fd2eb4135893f"},{"author":{"_account_id":13273,"name":"Lena Novokshonova","email":"enovokshonova@mirantis.com","username":"enovokshonova"},"change_message_id":"7d069efbdb4f21a1d13715e46ef540a8b9edcf37","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    )"},{"line_number":111,"context_line":"    parser.add_argument("},{"line_number":112,"context_line":"        \u0027--start\u0027,"},{"line_number":113,"context_line":"        default\u003d31,"},{"line_number":114,"context_line":"        help\u003d\u0027The number of days in the past or date in the past to start\u0027"},{"line_number":115,"context_line":"             \u0027timestamps.\u0027,"},{"line_number":116,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_07bed7ad","line":113,"in_reply_to":"3a961159_e7c62b67","updated":"2014-12-15 14:46:06.000000000","message":"Dina, thanks!","commit_id":"ab6ab1838490e520c255827c507fd2eb4135893f"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"e3113bd17b2cca7e621dbccd4fd16e29cf666ec1","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    )"},{"line_number":117,"context_line":"    parser.add_argument("},{"line_number":118,"context_line":"        \u0027--end\u0027,"},{"line_number":119,"context_line":"        default\u003d2,"},{"line_number":120,"context_line":"        help\u003d\u0027The number of days into the future or date in the future to\u0027"},{"line_number":121,"context_line":"             \u0027continue timestamps.\u0027,"},{"line_number":122,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_e4a0ec91","line":119,"updated":"2014-12-15 13:00:28.000000000","message":"ditto","commit_id":"ab6ab1838490e520c255827c507fd2eb4135893f"},{"author":{"_account_id":13273,"name":"Lena Novokshonova","email":"enovokshonova@mirantis.com","username":"enovokshonova"},"change_message_id":"701cde01289817a83354d55d4693d6d3c4d08d38","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    )"},{"line_number":117,"context_line":"    parser.add_argument("},{"line_number":118,"context_line":"        \u0027--end\u0027,"},{"line_number":119,"context_line":"        default\u003d2,"},{"line_number":120,"context_line":"        help\u003d\u0027The number of days into the future or date in the future to\u0027"},{"line_number":121,"context_line":"             \u0027continue timestamps.\u0027,"},{"line_number":122,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_940e738a","line":119,"in_reply_to":"3a961159_e4a0ec91","updated":"2014-12-15 14:24:48.000000000","message":"And there: How many days in the future should be stepped forward to continue timestamps or date in the future to stop timestamps? Date must be in the format \u0027YYYY-MM-DDTHH:MM:SS\u0027.","commit_id":"ab6ab1838490e520c255827c507fd2eb4135893f"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"e3113bd17b2cca7e621dbccd4fd16e29cf666ec1","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    try:"},{"line_number":193,"context_line":"        start \u003d datetime.datetime.utcnow() - datetime.timedelta("},{"line_number":194,"context_line":"            days\u003dint(args.start))"},{"line_number":195,"context_line":"    except ValueError:"},{"line_number":196,"context_line":"        start \u003d datetime.datetime.strptime(args.start, format)"},{"line_number":197,"context_line":"    try:"},{"line_number":198,"context_line":"        end \u003d datetime.datetime.utcnow() + datetime.timedelta("}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_a4d344d3","line":195,"updated":"2014-12-15 13:00:28.000000000","message":"The following line may fail with an exception (e.g. user used wrong format). Let\u0027s handle it in this patch? I think it will improve script usability","commit_id":"ab6ab1838490e520c255827c507fd2eb4135893f"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"3cab02f2ed6ec8cd5383056c0270a69081ee29a3","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        try:"},{"line_number":199,"context_line":"            start \u003d datetime.datetime.strptime(args.start, format)"},{"line_number":200,"context_line":"        except ValueError:"},{"line_number":201,"context_line":"            raise"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    try:"},{"line_number":204,"context_line":"        end \u003d datetime.datetime.utcnow() + datetime.timedelta("}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_bcbd866a","line":201,"updated":"2014-12-19 04:19:53.000000000","message":"I suddenly realize there is a question in my head, why do we catch an exception and then directly raise it? could we just remove the try..except block?\n\nAnyway, at least this works, we can merge this and open another discussion","commit_id":"f1c84280069fd8761d29ab7a05f8a4d3211d0299"}]}