)]}'
{"ceilometer/alarm/storage/impl_sqlalchemy.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"579a8a339a2f20ab9e031071fc24d8c91d65e919","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        :param alarm_id: Optional alarm_id to return one alarm."},{"line_number":157,"context_line":"        :param pagination: Optional pagination query."},{"line_number":158,"context_line":"        :param alarm_type: Optional alarm type."},{"line_number":159,"context_line":"        :param severity: Optional alarm level"},{"line_number":160,"context_line":"        \"\"\""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        if pagination:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a930d6b_8a74ec68","line":159,"updated":"2015-01-26 04:33:58.000000000","message":"nit: the docstring for severity is different from base, which mix the level and severity, consider keep consistent?","commit_id":"0caa9ecf120da7c7d721caa5aadd80d375918ac3"}],"ceilometer/alarm/storage/models.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"24708f5ef7e5cd95b89ba867a977adc4c4d4cda1","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    ALARM_LEVEL_LOW \u003d \u0027low\u0027"},{"line_number":38,"context_line":"    ALARM_LEVEL_MODERATE \u003d \u0027moderate\u0027"},{"line_number":39,"context_line":"    ALARM_LEVEL_CRITICAL \u003d \u0027critical\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    \"\"\""},{"line_number":42,"context_line":"    An alarm to monitor."}],"source_content_type":"text/x-python","patch_set":9,"id":"fa81d914_170c1742","line":39,"updated":"2015-01-28 15:46:21.000000000","message":"some tools have: critical, high, medium, low and informational\n\ni have no problem with current 3 levels and adding later but if anyone out there does have preference. please speak up.","commit_id":"5d3f33def56dccf561db00214f3279608ff48d13"}],"ceilometer/alarm/storage/pymongo_base.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"579a8a339a2f20ab9e031071fc24d8c91d65e919","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        :param alarm_id: Optional alarm_id to return one alarm."},{"line_number":94,"context_line":"        :param pagination: Optional pagination query."},{"line_number":95,"context_line":"        :param alarm_type: Optional alarm type."},{"line_number":96,"context_line":"        :param severity: Optional alarm level"},{"line_number":97,"context_line":"        \"\"\""},{"line_number":98,"context_line":"        if pagination:"},{"line_number":99,"context_line":"            raise ceilometer.NotImplementedError(\u0027Pagination not implemented\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a930d6b_aa71a877","line":96,"updated":"2015-01-26 04:33:58.000000000","message":"nit: ditto","commit_id":"0caa9ecf120da7c7d721caa5aadd80d375918ac3"}],"ceilometer/api/controllers/v2.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"252f02236e5095d7da91e04fdd93a98d737aff84","unresolved":false,"context_lines":[{"line_number":85,"context_line":"state_kind \u003d [\"ok\", \"alarm\", \"insufficient data\"]"},{"line_number":86,"context_line":"state_kind_enum \u003d wtypes.Enum(str, *state_kind)"},{"line_number":87,"context_line":"level_kind \u003d [\"low\", \"moderate\", \"critical\"]"},{"line_number":88,"context_line":"level_kind_enum \u003d wtypes.Enum(str, *level_kind)"},{"line_number":89,"context_line":"operation_kind \u003d (\u0027lt\u0027, \u0027le\u0027, \u0027eq\u0027, \u0027ne\u0027, \u0027ge\u0027, \u0027gt\u0027)"},{"line_number":90,"context_line":"operation_kind_enum \u003d wtypes.Enum(str, *operation_kind)"},{"line_number":91,"context_line":"severity_kind \u003d [\"low\", \"moderate\", \"critical\"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a930d6b_aa761fa2","line":88,"updated":"2015-01-23 21:59:04.000000000","message":"i assume you forgot to remove this?","commit_id":"0caa9ecf120da7c7d721caa5aadd80d375918ac3"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"579a8a339a2f20ab9e031071fc24d8c91d65e919","unresolved":false,"context_lines":[{"line_number":85,"context_line":"state_kind \u003d [\"ok\", \"alarm\", \"insufficient data\"]"},{"line_number":86,"context_line":"state_kind_enum \u003d wtypes.Enum(str, *state_kind)"},{"line_number":87,"context_line":"level_kind \u003d [\"low\", \"moderate\", \"critical\"]"},{"line_number":88,"context_line":"level_kind_enum \u003d wtypes.Enum(str, *level_kind)"},{"line_number":89,"context_line":"operation_kind \u003d (\u0027lt\u0027, \u0027le\u0027, \u0027eq\u0027, \u0027ne\u0027, \u0027ge\u0027, \u0027gt\u0027)"},{"line_number":90,"context_line":"operation_kind_enum \u003d wtypes.Enum(str, *operation_kind)"},{"line_number":91,"context_line":"severity_kind \u003d [\"low\", \"moderate\", \"critical\"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a930d6b_2a3f7889","line":88,"in_reply_to":"1a930d6b_aa761fa2","updated":"2015-01-26 04:33:58.000000000","message":"agree\n\n-1: remove it","commit_id":"0caa9ecf120da7c7d721caa5aadd80d375918ac3"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"579a8a339a2f20ab9e031071fc24d8c91d65e919","unresolved":false,"context_lines":[{"line_number":2074,"context_line":"            data.state_timestamp \u003d now"},{"line_number":2075,"context_line":"        else:"},{"line_number":2076,"context_line":"            data.state_timestamp \u003d alarm_in.state_timestamp"},{"line_number":2077,"context_line":"        if alarm_in.severity !\u003d data.severity:"},{"line_number":2078,"context_line":"            alarm_in.severity \u003d data.severity"},{"line_number":2079,"context_line":"        # make sure alarms are unique by name per project."},{"line_number":2080,"context_line":"        if alarm_in.name !\u003d data.name:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a930d6b_0a855c59","line":2077,"updated":"2015-01-26 04:33:58.000000000","message":"why don\u0027t directly use:\n\n    alarm_in.severity \u003d data.severity\n\nthe if statement can be removed","commit_id":"0caa9ecf120da7c7d721caa5aadd80d375918ac3"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"579a8a339a2f20ab9e031071fc24d8c91d65e919","unresolved":false,"context_lines":[{"line_number":2249,"context_line":""},{"line_number":2250,"context_line":"        data.timestamp \u003d now"},{"line_number":2251,"context_line":"        data.state_timestamp \u003d now"},{"line_number":2252,"context_line":"        change \u003d data.as_dict(alarm_models.Alarm)"},{"line_number":2253,"context_line":""},{"line_number":2254,"context_line":"        # make sure alarms are unique by name per project."},{"line_number":2255,"context_line":"        alarms \u003d list(conn.get_alarms(name\u003ddata.name,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a930d6b_6a80a046","line":2252,"updated":"2015-01-26 04:33:58.000000000","message":"unnecessary remove of blank line, if you want to increase the readability, you can move L2252 to L2261","commit_id":"0caa9ecf120da7c7d721caa5aadd80d375918ac3"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"efd223e053f91b3685d7fbcabfdfadf215ec3cfb","unresolved":false,"context_lines":[{"line_number":1925,"context_line":"                   enabled\u003dTrue,"},{"line_number":1926,"context_line":"                   timestamp\u003ddatetime.datetime.utcnow(),"},{"line_number":1927,"context_line":"                   state\u003d\"ok\","},{"line_number":1928,"context_line":"                   severity\u003d\"critical\","},{"line_number":1929,"context_line":"                   state_timestamp\u003ddatetime.datetime.utcnow(),"},{"line_number":1930,"context_line":"                   ok_actions\u003d[\"http://site:8000/ok\"],"},{"line_number":1931,"context_line":"                   alarm_actions\u003d[\"http://site:8000/alarm\"],"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa81d914_35e2bb03","line":1928,"updated":"2015-01-29 14:35:57.000000000","message":"It this an appropriate default severity?\n\nWould \"moderate\" be a better, less opinionated default?","commit_id":"5d3f33def56dccf561db00214f3279608ff48d13"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"f0367d143327dfc13987e43f653a75be7a2a27fa","unresolved":false,"context_lines":[{"line_number":1925,"context_line":"                   enabled\u003dTrue,"},{"line_number":1926,"context_line":"                   timestamp\u003ddatetime.datetime.utcnow(),"},{"line_number":1927,"context_line":"                   state\u003d\"ok\","},{"line_number":1928,"context_line":"                   severity\u003d\"critical\","},{"line_number":1929,"context_line":"                   state_timestamp\u003ddatetime.datetime.utcnow(),"},{"line_number":1930,"context_line":"                   ok_actions\u003d[\"http://site:8000/ok\"],"},{"line_number":1931,"context_line":"                   alarm_actions\u003d[\"http://site:8000/alarm\"],"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa81d914_ee3bf099","line":1928,"in_reply_to":"fa81d914_35e2bb03","updated":"2015-01-29 15:42:34.000000000","message":"I could see how this could be a bit aggressive to set critical by default. I\u0027m ok with moderate. see new patchset","commit_id":"5d3f33def56dccf561db00214f3279608ff48d13"}],"ceilometer/storage/sqlalchemy/migrate_repo/versions/040_add_alarm_severity.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"252f02236e5095d7da91e04fdd93a98d737aff84","unresolved":false,"context_lines":[{"line_number":22,"context_line":"def upgrade(migrate_engine):"},{"line_number":23,"context_line":"    meta \u003d MetaData(bind\u003dmigrate_engine)"},{"line_number":24,"context_line":"    alarm \u003d Table(\u0027alarm\u0027, meta, autoload\u003dTrue)"},{"line_number":25,"context_line":"    severity \u003d Column(\u0027severity\u0027, Text())"},{"line_number":26,"context_line":"    alarm.create_column(severity)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a930d6b_2ac6af9a","line":25,"updated":"2015-01-23 21:59:04.000000000","message":"this is a String(50) in the model... it should probably be a string(50).... or a smallint","commit_id":"0caa9ecf120da7c7d721caa5aadd80d375918ac3"}]}