)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"992524578615fdcbc5e154ef9973e13cfe7a7fb5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Saba Ahmed \u003cahmed.nooras.saba@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-08 11:03:58 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"The meters reading correspond to domblkinfo Statistics : capacity , allocation and physical(usage) ."},{"line_number":8,"context_line":"Storage meters per instance"},{"line_number":9,"context_line":"disk.capacity \u003d Disk Capacity for all the disks of the instance"},{"line_number":10,"context_line":"disk.usage \u003d Disk Usage for all the disks of the instance"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_eddd4142","line":7,"updated":"2015-01-08 16:27:12.000000000","message":"Title of the commit message is not separated from the body and too long. Please take a look\nhttps://wiki.openstack.org/wiki/GitCommitMessages it could be useful foe you.","commit_id":"a18b55ac246e88d13d9c49fbf241ace3cfb2b9fe"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"939fa2fd360e94b27bcba797cb827c78ff4ad21d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Saba Ahmed \u003cahmed.nooras.saba@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-08 11:03:58 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"The meters reading correspond to domblkinfo Statistics : capacity , allocation and physical(usage) ."},{"line_number":8,"context_line":"Storage meters per instance"},{"line_number":9,"context_line":"disk.capacity \u003d Disk Capacity for all the disks of the instance"},{"line_number":10,"context_line":"disk.usage \u003d Disk Usage for all the disks of the instance"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_c20f6fde","line":7,"in_reply_to":"3a961159_eddd4142","updated":"2015-01-08 17:23:11.000000000","message":"Done","commit_id":"a18b55ac246e88d13d9c49fbf241ace3cfb2b9fe"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"b6f8c08b353cf5fa76de8f03821acfb50c5bca0c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added Disk Meters for ceilometer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The new disk meter reading correspond to libvirt domblkinfo Statistics : capacity , allocation and physical(usage) ."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Storage meters per instance"},{"line_number":12,"context_line":"disk.capacity \u003d Disk Capacity for all the disks of the instance"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_a257c358","line":9,"updated":"2015-01-08 17:29:53.000000000","message":"less than 80 characters please, not -1 for this","commit_id":"f654da2f7cc78580e28e157708651c01b4b8732b"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"11b3769e806204560daa50f89fb7d8ba8e53e75d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added Disk Meters for ceilometer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The new disk meter reading correspond to libvirt domblkinfo Statistics : capacity , allocation and physical(usage) ."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Storage meters per instance"},{"line_number":12,"context_line":"disk.capacity \u003d Disk Capacity for all the disks of the instance"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_138547ac","line":9,"in_reply_to":"3a961159_a257c358","updated":"2015-01-08 19:13:49.000000000","message":"Done","commit_id":"f654da2f7cc78580e28e157708651c01b4b8732b"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"f468855ff1063af08d4533cc9e3c0a94c59c8d14","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added Disk Meters for ceilometer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Blueprint :"},{"line_number":10,"context_line":"https://blueprints.launchpad.net/ceilometer/+spec/disk-info-meters"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The new disk meter reading correspond to libvirt domblkinfo Statistics :"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3a961159_6acad747","line":9,"updated":"2015-01-20 10:21:06.000000000","message":"Move this lines logic below","commit_id":"9fdc6bfb424b5e95fa10391a6e2b59ec197d5d3b"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"beeacd9985d330626b3f450057de8e00d3ca1bd1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added Disk Meters for ceilometer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Blueprint :"},{"line_number":10,"context_line":"https://blueprints.launchpad.net/ceilometer/+spec/disk-info-meters"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The new disk meter reading correspond to libvirt domblkinfo Statistics :"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3a961159_2501d604","line":9,"in_reply_to":"3a961159_6acad747","updated":"2015-01-20 14:45:43.000000000","message":"Done","commit_id":"9fdc6bfb424b5e95fa10391a6e2b59ec197d5d3b"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"f468855ff1063af08d4533cc9e3c0a94c59c8d14","unresolved":false,"context_lines":[{"line_number":21,"context_line":"disk.device.capacity \u003d Disk Capacity for each individual disk of an instance"},{"line_number":22,"context_line":"disk.device.usage \u003d Disk Usage for each individual disk of an instance"},{"line_number":23,"context_line":"disk.device.allocation \u003dDisk Allocation for each individual disk of an instance"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Ie5accb8fb75b0d3a6641d090fa273fc8fe100ab3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3a961159_2a00cf65","line":24,"updated":"2015-01-20 10:21:06.000000000","message":"Add line before Change-Id hook like this:\n\nImplements-Blueprint: disk-info-meters","commit_id":"9fdc6bfb424b5e95fa10391a6e2b59ec197d5d3b"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"beeacd9985d330626b3f450057de8e00d3ca1bd1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"disk.device.capacity \u003d Disk Capacity for each individual disk of an instance"},{"line_number":22,"context_line":"disk.device.usage \u003d Disk Usage for each individual disk of an instance"},{"line_number":23,"context_line":"disk.device.allocation \u003dDisk Allocation for each individual disk of an instance"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Ie5accb8fb75b0d3a6641d090fa273fc8fe100ab3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3a961159_a50ce63a","line":24,"in_reply_to":"3a961159_2a00cf65","updated":"2015-01-20 14:45:43.000000000","message":"Done. \nChanged as per wiki at https://wiki.openstack.org/wiki/GitCommitMessages\n\n Implements: blueprint disk-info-meters\n\nThanks","commit_id":"9fdc6bfb424b5e95fa10391a6e2b59ec197d5d3b"},{"author":{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},"change_message_id":"27affa27633d458fb7c9f14fd3c61371e3284cf0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"disk.device.capacity \u003d Disk Capacity for each individual disk of an instance"},{"line_number":22,"context_line":"disk.device.usage \u003d Disk Usage for each individual disk of an instance"},{"line_number":23,"context_line":"disk.device.allocation \u003dDisk Allocation for each individual disk of an instance"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Implements: blueprint disk-info-meters"},{"line_number":26,"context_line":"Change-Id: Ie5accb8fb75b0d3a6641d090fa273fc8fe100ab3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1a930d6b_14ba7ae1","line":24,"updated":"2015-01-20 21:29:14.000000000","message":"please add a \"DocImpact\" string since documentation would require changes.","commit_id":"a9e4a0bcc75f02957dfffda44103f01c83b767db"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"464147474db6818444a3d20e6da60968f434e4bd","unresolved":false,"context_lines":[{"line_number":21,"context_line":"disk.device.capacity \u003d Disk Capacity for each individual disk of an instance"},{"line_number":22,"context_line":"disk.device.usage \u003d Disk Usage for each individual disk of an instance"},{"line_number":23,"context_line":"disk.device.allocation \u003dDisk Allocation for each individual disk of an instance"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Implements: blueprint disk-info-meters"},{"line_number":26,"context_line":"Change-Id: Ie5accb8fb75b0d3a6641d090fa273fc8fe100ab3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1a930d6b_7f5f1773","line":24,"in_reply_to":"1a930d6b_14ba7ae1","updated":"2015-01-20 22:15:21.000000000","message":"Done","commit_id":"a9e4a0bcc75f02957dfffda44103f01c83b767db"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"bf016aa6b5f027bd9c4b9930f4e297ef9977561b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-01-20 22:31:43 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Author: Ahmed Nooras Saba"},{"line_number":8,"context_line":"Date: Tue Jan 20 09:30:00 2015 -0500"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Add Disk Meters for ceilometer"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1a930d6b_c34af126","line":8,"updated":"2015-01-21 06:39:48.000000000","message":"I don\u0027t know why you write L7-L8 into commit message, it should not be here","commit_id":"6edd41a3b8d8de0d25e54a7bf236369d6086ee86"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"ba5d295798a516120b60ab9cca644800dd7e239b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-01-20 22:31:43 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Author: Ahmed Nooras Saba"},{"line_number":8,"context_line":"Date: Tue Jan 20 09:30:00 2015 -0500"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Add Disk Meters for ceilometer"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1a930d6b_f07b1f27","line":8,"in_reply_to":"1a930d6b_c34af126","updated":"2015-01-21 15:48:50.000000000","message":"I referred help from https://wiki.openstack.org/wiki/GitCommitMessages \nBut looks like commit is taking care of it. Thanks","commit_id":"6edd41a3b8d8de0d25e54a7bf236369d6086ee86"}],"ceilometer/compute/pollsters/disk.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"e2d31a0357d2c8a23dcda9f9a9536d8c5368af9b","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        return samples"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":473,"context_line":"class _DiskRatesPollsterBase(plugin.ComputePollster):"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    CACHE_KEY_DISK_RATE \u003d \u0027diskio-rate\u0027"},{"line_number":476,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_221753ef","line":473,"updated":"2015-01-08 17:28:35.000000000","message":"-1: import plugin first then use it","commit_id":"a18b55ac246e88d13d9c49fbf241ace3cfb2b9fe"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"96158f105e135159ea8f0b1a752550772767caf6","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        return samples"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":473,"context_line":"class _DiskRatesPollsterBase(plugin.ComputePollster):"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    CACHE_KEY_DISK_RATE \u003d \u0027diskio-rate\u0027"},{"line_number":476,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_44c0e749","line":473,"in_reply_to":"3a961159_221753ef","updated":"2015-01-08 21:05:38.000000000","message":"Removed DiskRatesPollsterBase and its subclass as it was duplicacy from existing code.\nBut have added the fix in _DiskInfoPollsterBase.\n\nThanks","commit_id":"a18b55ac246e88d13d9c49fbf241ace3cfb2b9fe"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"e2d31a0357d2c8a23dcda9f9a9536d8c5368af9b","unresolved":false,"context_lines":[{"line_number":513,"context_line":"            except virt_inspector.InstanceNotFoundException as err:"},{"line_number":514,"context_line":"                # Instance was deleted while getting samples. Ignore it."},{"line_number":515,"context_line":"                LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":516,"context_line":"            except NotImplementedError:"},{"line_number":517,"context_line":"                # Selected inspector does not implement this pollster."},{"line_number":518,"context_line":"                LOG.debug(_(\u0027%(inspector)s does not provide data for \u0027"},{"line_number":519,"context_line":"                            \u0027 %(pollster)s\u0027), ({"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_425a9f1e","line":516,"updated":"2015-01-08 17:28:35.000000000","message":"-1: except ceilometer.NotImplementedError","commit_id":"a18b55ac246e88d13d9c49fbf241ace3cfb2b9fe"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"96158f105e135159ea8f0b1a752550772767caf6","unresolved":false,"context_lines":[{"line_number":513,"context_line":"            except virt_inspector.InstanceNotFoundException as err:"},{"line_number":514,"context_line":"                # Instance was deleted while getting samples. Ignore it."},{"line_number":515,"context_line":"                LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":516,"context_line":"            except NotImplementedError:"},{"line_number":517,"context_line":"                # Selected inspector does not implement this pollster."},{"line_number":518,"context_line":"                LOG.debug(_(\u0027%(inspector)s does not provide data for \u0027"},{"line_number":519,"context_line":"                            \u0027 %(pollster)s\u0027), ({"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_84a56fb6","line":516,"in_reply_to":"3a961159_425a9f1e","updated":"2015-01-08 21:05:38.000000000","message":"Removed DiskRatesPollsterBase and its subclass as it was duplicacy from existing code.","commit_id":"a18b55ac246e88d13d9c49fbf241ace3cfb2b9fe"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"e2d31a0357d2c8a23dcda9f9a9536d8c5368af9b","unresolved":false,"context_lines":[{"line_number":521,"context_line":"                          \u0027pollster\u0027: self.__class__.__name__}))"},{"line_number":522,"context_line":"            except Exception as err:"},{"line_number":523,"context_line":"                instance_name \u003d util.instance_name(instance)"},{"line_number":524,"context_line":"                LOG.error(_(\u0027Ignoring instance %(name)s: %(error)s\u0027) % ("},{"line_number":525,"context_line":"                    {\u0027name\u0027: instance_name, \u0027error\u0027: err}))"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_62ea3b10","line":524,"updated":"2015-01-08 17:28:35.000000000","message":"instance id can be better?\n\nLOG.exception can be better? actually, if use LOG.exception, err can be redundant","commit_id":"a18b55ac246e88d13d9c49fbf241ace3cfb2b9fe"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"96158f105e135159ea8f0b1a752550772767caf6","unresolved":false,"context_lines":[{"line_number":521,"context_line":"                          \u0027pollster\u0027: self.__class__.__name__}))"},{"line_number":522,"context_line":"            except Exception as err:"},{"line_number":523,"context_line":"                instance_name \u003d util.instance_name(instance)"},{"line_number":524,"context_line":"                LOG.error(_(\u0027Ignoring instance %(name)s: %(error)s\u0027) % ("},{"line_number":525,"context_line":"                    {\u0027name\u0027: instance_name, \u0027error\u0027: err}))"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_e4955340","line":524,"in_reply_to":"3a961159_62ea3b10","updated":"2015-01-08 21:05:38.000000000","message":"Removed DiskRatesPollsterBase and its subclass as it was duplicacy from existing code.","commit_id":"a18b55ac246e88d13d9c49fbf241ace3cfb2b9fe"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"e2d31a0357d2c8a23dcda9f9a9536d8c5368af9b","unresolved":false,"context_lines":[{"line_number":612,"context_line":""},{"line_number":613,"context_line":"    @abc.abstractmethod"},{"line_number":614,"context_line":"    def _get_sample(self, instance, disk_rates_info):"},{"line_number":615,"context_line":"        \"\"\"Return one Sample.\"\"\""},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":618,"context_line":"        self._inspection_duration \u003d self._record_poll_time()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_2273d34e","line":615,"updated":"2015-01-08 17:28:35.000000000","message":"-1: actually, sub class returns a list instead of one sample","commit_id":"a18b55ac246e88d13d9c49fbf241ace3cfb2b9fe"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"96158f105e135159ea8f0b1a752550772767caf6","unresolved":false,"context_lines":[{"line_number":612,"context_line":""},{"line_number":613,"context_line":"    @abc.abstractmethod"},{"line_number":614,"context_line":"    def _get_sample(self, instance, disk_rates_info):"},{"line_number":615,"context_line":"        \"\"\"Return one Sample.\"\"\""},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":618,"context_line":"        self._inspection_duration \u003d self._record_poll_time()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_249cbb69","line":615,"in_reply_to":"3a961159_2273d34e","updated":"2015-01-08 21:05:38.000000000","message":"Changed it to List of Sample","commit_id":"a18b55ac246e88d13d9c49fbf241ace3cfb2b9fe"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"e2d31a0357d2c8a23dcda9f9a9536d8c5368af9b","unresolved":false,"context_lines":[{"line_number":628,"context_line":"            except virt_inspector.InstanceNotFoundException as err:"},{"line_number":629,"context_line":"                # Instance was deleted while getting samples. Ignore it."},{"line_number":630,"context_line":"                LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":631,"context_line":"            except NotImplementedError:"},{"line_number":632,"context_line":"                # Selected inspector does not implement this pollster."},{"line_number":633,"context_line":"                LOG.debug(_(\u0027%(inspector)s does not provide data for \u0027"},{"line_number":634,"context_line":"                            \u0027 %(pollster)s\u0027), ({"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_8293a74d","line":631,"updated":"2015-01-08 17:28:35.000000000","message":"-1: ceilometer.NotImplementedError","commit_id":"a18b55ac246e88d13d9c49fbf241ace3cfb2b9fe"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"96158f105e135159ea8f0b1a752550772767caf6","unresolved":false,"context_lines":[{"line_number":628,"context_line":"            except virt_inspector.InstanceNotFoundException as err:"},{"line_number":629,"context_line":"                # Instance was deleted while getting samples. Ignore it."},{"line_number":630,"context_line":"                LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":631,"context_line":"            except NotImplementedError:"},{"line_number":632,"context_line":"                # Selected inspector does not implement this pollster."},{"line_number":633,"context_line":"                LOG.debug(_(\u0027%(inspector)s does not provide data for \u0027"},{"line_number":634,"context_line":"                            \u0027 %(pollster)s\u0027), ({"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_848c8f36","line":631,"in_reply_to":"3a961159_8293a74d","updated":"2015-01-08 21:05:38.000000000","message":"Changed it tio ceilometer.NotImplementedError","commit_id":"a18b55ac246e88d13d9c49fbf241ace3cfb2b9fe"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"e2d31a0357d2c8a23dcda9f9a9536d8c5368af9b","unresolved":false,"context_lines":[{"line_number":636,"context_line":"                          \u0027pollster\u0027: self.__class__.__name__}))"},{"line_number":637,"context_line":"            except Exception as err:"},{"line_number":638,"context_line":"                instance_name \u003d util.instance_name(instance)"},{"line_number":639,"context_line":"                LOG.error(_(\u0027Ignoring instance %(name)s: %(error)s\u0027) % ("},{"line_number":640,"context_line":"                    {\u0027name\u0027: instance_name, \u0027error\u0027: err}))"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_a296e33b","line":639,"updated":"2015-01-08 17:28:35.000000000","message":"ditto, consider LOG.exception, and use instance.id","commit_id":"a18b55ac246e88d13d9c49fbf241ace3cfb2b9fe"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"96158f105e135159ea8f0b1a752550772767caf6","unresolved":false,"context_lines":[{"line_number":636,"context_line":"                          \u0027pollster\u0027: self.__class__.__name__}))"},{"line_number":637,"context_line":"            except Exception as err:"},{"line_number":638,"context_line":"                instance_name \u003d util.instance_name(instance)"},{"line_number":639,"context_line":"                LOG.error(_(\u0027Ignoring instance %(name)s: %(error)s\u0027) % ("},{"line_number":640,"context_line":"                    {\u0027name\u0027: instance_name, \u0027error\u0027: err}))"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_e47c7322","line":639,"in_reply_to":"3a961159_a296e33b","updated":"2015-01-08 21:05:38.000000000","message":"Added instance.id along with instance name. Having Instance name in exception makes the problem more readable. Thanks","commit_id":"a18b55ac246e88d13d9c49fbf241ace3cfb2b9fe"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"bf016aa6b5f027bd9c4b9930f4e297ef9977561b","unresolved":false,"context_lines":[{"line_number":530,"context_line":"                )"},{"line_number":531,"context_line":"                for disk_info in self._get_sample(instance, disk_size_info):"},{"line_number":532,"context_line":"                    yield disk_info"},{"line_number":533,"context_line":"            except virt_inspector.InstanceNotFoundException as err:"},{"line_number":534,"context_line":"                # Instance was deleted while getting samples. Ignore it."},{"line_number":535,"context_line":"                LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":536,"context_line":"            except ceilometer.NotImplementedError:"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a930d6b_03add988","line":533,"updated":"2015-01-21 06:39:48.000000000","message":"catch InstanceShutOff exception if you agree the comment in libvirt.inspector","commit_id":"6edd41a3b8d8de0d25e54a7bf236369d6086ee86"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"ba5d295798a516120b60ab9cca644800dd7e239b","unresolved":false,"context_lines":[{"line_number":530,"context_line":"                )"},{"line_number":531,"context_line":"                for disk_info in self._get_sample(instance, disk_size_info):"},{"line_number":532,"context_line":"                    yield disk_info"},{"line_number":533,"context_line":"            except virt_inspector.InstanceNotFoundException as err:"},{"line_number":534,"context_line":"                # Instance was deleted while getting samples. Ignore it."},{"line_number":535,"context_line":"                LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":536,"context_line":"            except ceilometer.NotImplementedError:"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a930d6b_0badde31","line":533,"in_reply_to":"1a930d6b_03add988","updated":"2015-01-21 15:48:50.000000000","message":"I agree. I have made required changes. Thanks","commit_id":"6edd41a3b8d8de0d25e54a7bf236369d6086ee86"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"9481a9101ba9ea7967104a9d9cfdcffcf25ec513","unresolved":false,"context_lines":[{"line_number":520,"context_line":"            )"},{"line_number":521,"context_line":"        return i_cache[instance.id]"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    @abc.abstractmethod"},{"line_number":524,"context_line":"    def _get_sample(self, instance, disk_rates_info):"},{"line_number":525,"context_line":"        \"\"\"Returns List of Samples.\"\"\""},{"line_number":526,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1a930d6b_772aa07f","line":523,"updated":"2015-01-22 13:07:44.000000000","message":"nit: _get_samples would be better because it returns a list","commit_id":"0796382a7dc129f418b66706377d2a9afda98147"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"5c56e4c2d04c73438e5b8c817ca53d3b4f184e4a","unresolved":false,"context_lines":[{"line_number":520,"context_line":"            )"},{"line_number":521,"context_line":"        return i_cache[instance.id]"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    @abc.abstractmethod"},{"line_number":524,"context_line":"    def _get_sample(self, instance, disk_rates_info):"},{"line_number":525,"context_line":"        \"\"\"Returns List of Samples.\"\"\""},{"line_number":526,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"fa81d914_015e95e6","line":523,"in_reply_to":"1a930d6b_772aa07f","updated":"2015-01-28 20:42:27.000000000","message":"Done","commit_id":"0796382a7dc129f418b66706377d2a9afda98147"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"8b0036b51806fc867053561f164d488b7295cfcc","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        \"\"\"Returns List of Samples.\"\"\""},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":528,"context_line":"        self._inspection_duration \u003d self._record_poll_time()"},{"line_number":529,"context_line":"        for instance in resources:"},{"line_number":530,"context_line":"            try:"},{"line_number":531,"context_line":"                disk_size_info \u003d self._populate_cache("}],"source_content_type":"text/x-python","patch_set":12,"id":"1a930d6b_ef8039f9","line":528,"updated":"2015-01-23 21:14:52.000000000","message":"copy/paste error? this doesn\u0027t seem to be used and there are no rate meters","commit_id":"0796382a7dc129f418b66706377d2a9afda98147"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"5c56e4c2d04c73438e5b8c817ca53d3b4f184e4a","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        \"\"\"Returns List of Samples.\"\"\""},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":528,"context_line":"        self._inspection_duration \u003d self._record_poll_time()"},{"line_number":529,"context_line":"        for instance in resources:"},{"line_number":530,"context_line":"            try:"},{"line_number":531,"context_line":"                disk_size_info \u003d self._populate_cache("}],"source_content_type":"text/x-python","patch_set":12,"id":"fa81d914_c1639daf","line":528,"in_reply_to":"1a930d6b_ef8039f9","updated":"2015-01-28 20:42:27.000000000","message":"Done","commit_id":"0796382a7dc129f418b66706377d2a9afda98147"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"c57b36d3ab0326fd5ad123189583c4a4cf7e75fb","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                )"},{"line_number":523,"context_line":"                for disk_info in self._get_samples(instance, disk_size_info):"},{"line_number":524,"context_line":"                    yield disk_info"},{"line_number":525,"context_line":"            except virt_inspector.InstanceNotFoundException as err:"},{"line_number":526,"context_line":"                # Instance was deleted while getting samples. Ignore it."},{"line_number":527,"context_line":"                LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":528,"context_line":"            except ceilometer.NotImplementedError:"}],"source_content_type":"text/x-python","patch_set":17,"id":"da86d52c_056c8507","line":525,"updated":"2015-02-04 03:11:59.000000000","message":"-1: InstanceShutOff should be catched","commit_id":"946aa8849e7e3023f3bbba203becf288316fdb82"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"079c94a42ff7d5b10549bf86bd625b5fb2b9e3d5","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                )"},{"line_number":523,"context_line":"                for disk_info in self._get_samples(instance, disk_size_info):"},{"line_number":524,"context_line":"                    yield disk_info"},{"line_number":525,"context_line":"            except virt_inspector.InstanceNotFoundException as err:"},{"line_number":526,"context_line":"                # Instance was deleted while getting samples. Ignore it."},{"line_number":527,"context_line":"                LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":528,"context_line":"            except ceilometer.NotImplementedError:"}],"source_content_type":"text/x-python","patch_set":17,"id":"da86d52c_4934e2dd","line":525,"in_reply_to":"da86d52c_056c8507","updated":"2015-02-10 19:44:34.000000000","message":"Done","commit_id":"946aa8849e7e3023f3bbba203becf288316fdb82"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"19d27fd1b65a836bab81118d69b8d69dda08caf7","unresolved":false,"context_lines":[{"line_number":646,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":647,"context_line":"class _DiskInfoPollsterBase(pollsters.BaseComputePollster):"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"    CACHE_KEY_DISK_RATE \u003d \u0027diskinfo\u0027"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"    def _populate_cache(self, inspector, cache, instance):"},{"line_number":652,"context_line":"        i_cache \u003d cache.setdefault(self.CACHE_KEY_DISK_RATE, {})"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_5c1ae16f","line":649,"updated":"2015-02-10 20:37:51.000000000","message":"copy/paste error? DISK_INFO?","commit_id":"cdf102377de9308727185a87bd1dc2cb08ca3061"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"311116cae5f89435bc7ef69e98985b0020978367","unresolved":false,"context_lines":[{"line_number":646,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":647,"context_line":"class _DiskInfoPollsterBase(pollsters.BaseComputePollster):"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"    CACHE_KEY_DISK_RATE \u003d \u0027diskinfo\u0027"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"    def _populate_cache(self, inspector, cache, instance):"},{"line_number":652,"context_line":"        i_cache \u003d cache.setdefault(self.CACHE_KEY_DISK_RATE, {})"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_5cef41b1","line":649,"in_reply_to":"da86d52c_5c1ae16f","updated":"2015-02-10 20:48:26.000000000","message":"copied from where ?? Diskinfo is attribute of domblkinfo virsh .","commit_id":"cdf102377de9308727185a87bd1dc2cb08ca3061"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"27d96a6f22d527f439213366f7af64a20aa0674c","unresolved":false,"context_lines":[{"line_number":646,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":647,"context_line":"class _DiskInfoPollsterBase(pollsters.BaseComputePollster):"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"    CACHE_KEY_DISK_RATE \u003d \u0027diskinfo\u0027"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"    def _populate_cache(self, inspector, cache, instance):"},{"line_number":652,"context_line":"        i_cache \u003d cache.setdefault(self.CACHE_KEY_DISK_RATE, {})"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_5f31f3eb","line":649,"in_reply_to":"da86d52c_5cef41b1","updated":"2015-02-10 21:01:33.000000000","message":"i meant the variable name. s/CACHE_KEY_DISK_RATE/CACHE_KEY_DISK_INFO/","commit_id":"cdf102377de9308727185a87bd1dc2cb08ca3061"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"9f419b76389d94ab05841d6ad1bb52e374418214","unresolved":false,"context_lines":[{"line_number":646,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":647,"context_line":"class _DiskInfoPollsterBase(pollsters.BaseComputePollster):"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"    CACHE_KEY_DISK_RATE \u003d \u0027diskinfo\u0027"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"    def _populate_cache(self, inspector, cache, instance):"},{"line_number":652,"context_line":"        i_cache \u003d cache.setdefault(self.CACHE_KEY_DISK_RATE, {})"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_82d5d0e6","line":649,"in_reply_to":"da86d52c_5f31f3eb","updated":"2015-02-10 21:42:00.000000000","message":":)  I will fix in next patch. Thanks","commit_id":"cdf102377de9308727185a87bd1dc2cb08ca3061"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"19d27fd1b65a836bab81118d69b8d69dda08caf7","unresolved":false,"context_lines":[{"line_number":810,"context_line":"                volume\u003dvalue,"},{"line_number":811,"context_line":"                resource_id\u003d\"%s-%s\" % (instance.id, disk),"},{"line_number":812,"context_line":"            ))"},{"line_number":813,"context_line":"        return samples"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_dca251fb","line":813,"updated":"2015-02-10 20:37:51.000000000","message":"(nit) seems like these could all yield rather than return.","commit_id":"cdf102377de9308727185a87bd1dc2cb08ca3061"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"26f276b959f67a7add843b9b29cd33cb868ea617","unresolved":false,"context_lines":[{"line_number":723,"context_line":"        return [util.make_sample_from_instance("},{"line_number":724,"context_line":"            instance,"},{"line_number":725,"context_line":"            name\u003d\u0027disk.capacity\u0027,"},{"line_number":726,"context_line":"            type\u003dsample.TYPE_CUMULATIVE,"},{"line_number":727,"context_line":"            unit\u003d\u0027B\u0027,"},{"line_number":728,"context_line":"            volume\u003ddisk_info.capacity,"},{"line_number":729,"context_line":"            additional_metadata\u003d{"}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_d87fb4de","line":726,"updated":"2015-02-11 01:55:40.000000000","message":"uh... why did we change to cumulative here... and also below","commit_id":"76113f0637121b473f44b8e1f4414edb0b906320"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"96ccf12a3bc79a403eb7ec887166cb778ce1c484","unresolved":false,"context_lines":[{"line_number":723,"context_line":"        return [util.make_sample_from_instance("},{"line_number":724,"context_line":"            instance,"},{"line_number":725,"context_line":"            name\u003d\u0027disk.capacity\u0027,"},{"line_number":726,"context_line":"            type\u003dsample.TYPE_CUMULATIVE,"},{"line_number":727,"context_line":"            unit\u003d\u0027B\u0027,"},{"line_number":728,"context_line":"            volume\u003ddisk_info.capacity,"},{"line_number":729,"context_line":"            additional_metadata\u003d{"}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_315aab2a","line":726,"in_reply_to":"da86d52c_d87fb4de","updated":"2015-02-11 03:41:46.000000000","message":"Reverted back. It was a mistake .","commit_id":"76113f0637121b473f44b8e1f4414edb0b906320"}],"ceilometer/compute/virt/inspector.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"e2d31a0357d2c8a23dcda9f9a9536d8c5368af9b","unresolved":false,"context_lines":[{"line_number":138,"context_line":"# physical: usage of the disk"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"DiskInfo \u003d collections.namedtuple(\u0027DiskInfo\u0027,"},{"line_number":141,"context_line":"                                   [\u0027capacity\u0027, \u0027allocation\u0027,"},{"line_number":142,"context_line":"                                    \u0027physical\u0027])"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_42bc5fb5","line":141,"updated":"2015-01-08 17:28:35.000000000","message":"align please, maybe pep8 fail","commit_id":"a18b55ac246e88d13d9c49fbf241ace3cfb2b9fe"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"96158f105e135159ea8f0b1a752550772767caf6","unresolved":false,"context_lines":[{"line_number":138,"context_line":"# physical: usage of the disk"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"DiskInfo \u003d collections.namedtuple(\u0027DiskInfo\u0027,"},{"line_number":141,"context_line":"                                   [\u0027capacity\u0027, \u0027allocation\u0027,"},{"line_number":142,"context_line":"                                    \u0027physical\u0027])"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_446f0728","line":141,"in_reply_to":"3a961159_42bc5fb5","updated":"2015-01-08 21:05:38.000000000","message":"Aligned.\nThanks","commit_id":"a18b55ac246e88d13d9c49fbf241ace3cfb2b9fe"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"e2d31a0357d2c8a23dcda9f9a9536d8c5368af9b","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        :param instance: the target instance"},{"line_number":232,"context_line":"        :return: for each disk , capacity , alloaction and usage"},{"line_number":233,"context_line":"        \"\"\""},{"line_number":234,"context_line":"        raise NotImplementedError()"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"def get_hypervisor_inspector():"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_02cdf75c","line":234,"updated":"2015-01-08 17:28:35.000000000","message":"-1: raise ceilometer.NotImplementedError()","commit_id":"a18b55ac246e88d13d9c49fbf241ace3cfb2b9fe"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"96158f105e135159ea8f0b1a752550772767caf6","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        :param instance: the target instance"},{"line_number":232,"context_line":"        :return: for each disk , capacity , alloaction and usage"},{"line_number":233,"context_line":"        \"\"\""},{"line_number":234,"context_line":"        raise NotImplementedError()"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"def get_hypervisor_inspector():"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_e4547355","line":234,"in_reply_to":"3a961159_02cdf75c","updated":"2015-01-08 21:05:38.000000000","message":"Done.\n\nThanks","commit_id":"a18b55ac246e88d13d9c49fbf241ace3cfb2b9fe"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"45d890c2e6caa17575eb3de4f1806a3113e2e9ea","unresolved":false,"context_lines":[{"line_number":138,"context_line":"# physical: usage of the disk"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"DiskInfo \u003d collections.namedtuple(\u0027DiskInfo\u0027,"},{"line_number":141,"context_line":"                                   [\u0027capacity\u0027,"},{"line_number":142,"context_line":"                                    \u0027allocation\u0027,"},{"line_number":143,"context_line":"                                    \u0027physical\u0027])"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_1b9c6ebf","line":141,"updated":"2015-01-09 11:19:08.000000000","message":"Not correct indent here.","commit_id":"e623f7ca9fe58eda3e1f310f18e1e0051f2a04e7"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"d0f36db2d0f1fca91c575be3ef7f7a45db1621c7","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        raise ceilometer.NotImplementedError"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def inspect_disk_info(self, instance):"},{"line_number":235,"context_line":"        \"\"\"Inspect the disk information for an instance"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        :param instance: the target instance"},{"line_number":238,"context_line":"        :return: for each disk , capacity , alloaction and usage"}],"source_content_type":"text/x-python","patch_set":17,"id":"da86d52c_a1e11b00","line":235,"updated":"2015-02-03 08:35:27.000000000","message":"Please, add a dot at the end of first docstring line.","commit_id":"946aa8849e7e3023f3bbba203becf288316fdb82"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"079c94a42ff7d5b10549bf86bd625b5fb2b9e3d5","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        raise ceilometer.NotImplementedError"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def inspect_disk_info(self, instance):"},{"line_number":235,"context_line":"        \"\"\"Inspect the disk information for an instance"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        :param instance: the target instance"},{"line_number":238,"context_line":"        :return: for each disk , capacity , alloaction and usage"}],"source_content_type":"text/x-python","patch_set":17,"id":"da86d52c_e95af628","line":235,"in_reply_to":"da86d52c_a1e11b00","updated":"2015-02-10 19:44:34.000000000","message":"Done","commit_id":"946aa8849e7e3023f3bbba203becf288316fdb82"}],"ceilometer/compute/virt/libvirt/inspector.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"bf016aa6b5f027bd9c4b9930f4e297ef9977561b","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            raise virt_inspector.NoDataException(msg)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def inspect_disk_info(self, instance):"},{"line_number":205,"context_line":"        instanceName \u003d instance.__dict__[INSTANCE_INFO][INSTANCE_NAME]"},{"line_number":206,"context_line":"        domain \u003d self._lookup_by_name(instanceName)"},{"line_number":207,"context_line":"        (state, __, __, __, __) \u003d domain.info()"},{"line_number":208,"context_line":"        if state \u003d\u003d libvirt.VIR_DOMAIN_SHUTOFF:"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a930d6b_c37bd127","line":205,"updated":"2015-01-21 06:39:48.000000000","message":"use: instance_name \u003d util.instance_name(instance)","commit_id":"6edd41a3b8d8de0d25e54a7bf236369d6086ee86"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"ba5d295798a516120b60ab9cca644800dd7e239b","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            raise virt_inspector.NoDataException(msg)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def inspect_disk_info(self, instance):"},{"line_number":205,"context_line":"        instanceName \u003d instance.__dict__[INSTANCE_INFO][INSTANCE_NAME]"},{"line_number":206,"context_line":"        domain \u003d self._lookup_by_name(instanceName)"},{"line_number":207,"context_line":"        (state, __, __, __, __) \u003d domain.info()"},{"line_number":208,"context_line":"        if state \u003d\u003d libvirt.VIR_DOMAIN_SHUTOFF:"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a930d6b_70ee4f8d","line":205,"in_reply_to":"1a930d6b_c37bd127","updated":"2015-01-21 15:48:50.000000000","message":"Done","commit_id":"6edd41a3b8d8de0d25e54a7bf236369d6086ee86"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"bf016aa6b5f027bd9c4b9930f4e297ef9977561b","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        instanceName \u003d instance.__dict__[INSTANCE_INFO][INSTANCE_NAME]"},{"line_number":206,"context_line":"        domain \u003d self._lookup_by_name(instanceName)"},{"line_number":207,"context_line":"        (state, __, __, __, __) \u003d domain.info()"},{"line_number":208,"context_line":"        if state \u003d\u003d libvirt.VIR_DOMAIN_SHUTOFF:"},{"line_number":209,"context_line":"            LOG.warn(_(\u0027Failed to inspect disks of %(instance_name)s, \u0027"},{"line_number":210,"context_line":"                       \u0027domain is in state of SHUTOFF\u0027),"},{"line_number":211,"context_line":"                     {\u0027instanceName\u0027: instanceName})"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a930d6b_6394dd37","line":208,"updated":"2015-01-21 06:39:48.000000000","message":"use: domain \u003d self._get_domain_not_shut_off_or_raise(instance)\n\nit will check the state and raise exception when it is shut off","commit_id":"6edd41a3b8d8de0d25e54a7bf236369d6086ee86"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"ba5d295798a516120b60ab9cca644800dd7e239b","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        instanceName \u003d instance.__dict__[INSTANCE_INFO][INSTANCE_NAME]"},{"line_number":206,"context_line":"        domain \u003d self._lookup_by_name(instanceName)"},{"line_number":207,"context_line":"        (state, __, __, __, __) \u003d domain.info()"},{"line_number":208,"context_line":"        if state \u003d\u003d libvirt.VIR_DOMAIN_SHUTOFF:"},{"line_number":209,"context_line":"            LOG.warn(_(\u0027Failed to inspect disks of %(instance_name)s, \u0027"},{"line_number":210,"context_line":"                       \u0027domain is in state of SHUTOFF\u0027),"},{"line_number":211,"context_line":"                     {\u0027instanceName\u0027: instanceName})"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a930d6b_0b1dde0f","line":208,"in_reply_to":"1a930d6b_6394dd37","updated":"2015-01-21 15:48:50.000000000","message":"Done. Thanks","commit_id":"6edd41a3b8d8de0d25e54a7bf236369d6086ee86"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"bf016aa6b5f027bd9c4b9930f4e297ef9977561b","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                                           allocation\u003dblock_info[1],"},{"line_number":222,"context_line":"                                           physical\u003dblock_info[2])"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"            yield (disk, info)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a930d6b_8399c970","line":224,"updated":"2015-01-21 06:39:48.000000000","message":"the () pair is not needed","commit_id":"6edd41a3b8d8de0d25e54a7bf236369d6086ee86"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"c57b36d3ab0326fd5ad123189583c4a4cf7e75fb","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                                           allocation\u003dblock_info[1],"},{"line_number":212,"context_line":"                                           physical\u003dblock_info[2])"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"            yield (disk, info)"}],"source_content_type":"text/x-python","patch_set":17,"id":"da86d52c_85a87521","line":214,"updated":"2015-02-04 03:11:59.000000000","message":"nit: the () can be removed","commit_id":"946aa8849e7e3023f3bbba203becf288316fdb82"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"f883006c242cd2cd289e1718cb2073c8b0fdf8cb","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            raise virt_inspector.NoDataException(msg)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def inspect_disk_info(self, instance):"},{"line_number":201,"context_line":"            domain \u003d self._get_domain_not_shut_off_or_raise(instance)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"            tree \u003d etree.fromstring(domain.XMLDesc(0))"},{"line_number":204,"context_line":"            for device in filter("}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_9b529633","line":201,"updated":"2015-02-11 02:53:38.000000000","message":"-1: use 4 spaces to indent instead of 8","commit_id":"76113f0637121b473f44b8e1f4414edb0b906320"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"96ccf12a3bc79a403eb7ec887166cb778ce1c484","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            raise virt_inspector.NoDataException(msg)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def inspect_disk_info(self, instance):"},{"line_number":201,"context_line":"            domain \u003d self._get_domain_not_shut_off_or_raise(instance)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"            tree \u003d etree.fromstring(domain.XMLDesc(0))"},{"line_number":204,"context_line":"            for device in filter("}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_9148b75d","line":201,"in_reply_to":"da86d52c_9b529633","updated":"2015-02-11 03:41:46.000000000","message":"Done","commit_id":"76113f0637121b473f44b8e1f4414edb0b906320"}],"ceilometer/tests/compute/virt/libvirt/test_inspector.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"f883006c242cd2cd289e1718cb2073c8b0fdf8cb","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                               mock.patch.object(self.domain, \u0027info\u0027,"},{"line_number":273,"context_line":"                                                 return_value\u003d(0L, 0L, 0L,"},{"line_number":274,"context_line":"                                                               2L, 999999L))):"},{"line_number":275,"context_line":"                disks \u003d list(self.inspector.inspect_disk_info(self.instance))"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"                self.assertEqual(1, len(disks))"},{"line_number":278,"context_line":"                disk0, info0 \u003d disks[0]"}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_5b23bebc","line":275,"updated":"2015-02-11 02:53:38.000000000","message":"-1: 4 spaces","commit_id":"76113f0637121b473f44b8e1f4414edb0b906320"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"96ccf12a3bc79a403eb7ec887166cb778ce1c484","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                               mock.patch.object(self.domain, \u0027info\u0027,"},{"line_number":273,"context_line":"                                                 return_value\u003d(0L, 0L, 0L,"},{"line_number":274,"context_line":"                                                               2L, 999999L))):"},{"line_number":275,"context_line":"                disks \u003d list(self.inspector.inspect_disk_info(self.instance))"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"                self.assertEqual(1, len(disks))"},{"line_number":278,"context_line":"                disk0, info0 \u003d disks[0]"}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_b145bb44","line":275,"in_reply_to":"da86d52c_5b23bebc","updated":"2015-02-11 03:41:46.000000000","message":"Done","commit_id":"76113f0637121b473f44b8e1f4414edb0b906320"}],"doc/source/measurements.rst":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"e2d31a0357d2c8a23dcda9f9a9536d8c5368af9b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"disk.usage                       g      B          inst ID   n         1              Usage of disk in B"},{"line_number":99,"context_line":"disk.device.capacity             g      B          inst ID   n         1              Capacity per device of disk in B"},{"line_number":100,"context_line":"disk.device.allocation           g      B          inst ID   n         1              Allocation per device of disk in B"},{"line_number":101,"context_line":"disk.device.usage                g      B          inst ID   n         1              Usage per device of  disk in B"},{"line_number":102,"context_line":"network.incoming.bytes           c      B          iface ID  p         1, 2           Number of incoming bytes on a VM network interface"},{"line_number":103,"context_line":"network.incoming.bytes.rate      g      B/s        iface ID  p         1, 2, 3, 4     Average rate per sec of incoming bytes on a VM network interface"},{"line_number":104,"context_line":"network.outgoing.bytes           c      B          iface ID  p         1, 2           Number of outgoing bytes on a VM network interface"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_a2098385","line":101,"updated":"2015-01-08 17:28:35.000000000","message":"no need two spaces","commit_id":"a18b55ac246e88d13d9c49fbf241ace3cfb2b9fe"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"96158f105e135159ea8f0b1a752550772767caf6","unresolved":false,"context_lines":[{"line_number":98,"context_line":"disk.usage                       g      B          inst ID   n         1              Usage of disk in B"},{"line_number":99,"context_line":"disk.device.capacity             g      B          inst ID   n         1              Capacity per device of disk in B"},{"line_number":100,"context_line":"disk.device.allocation           g      B          inst ID   n         1              Allocation per device of disk in B"},{"line_number":101,"context_line":"disk.device.usage                g      B          inst ID   n         1              Usage per device of  disk in B"},{"line_number":102,"context_line":"network.incoming.bytes           c      B          iface ID  p         1, 2           Number of incoming bytes on a VM network interface"},{"line_number":103,"context_line":"network.incoming.bytes.rate      g      B/s        iface ID  p         1, 2, 3, 4     Average rate per sec of incoming bytes on a VM network interface"},{"line_number":104,"context_line":"network.outgoing.bytes           c      B          iface ID  p         1, 2           Number of outgoing bytes on a VM network interface"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_844e4f94","line":101,"in_reply_to":"3a961159_a2098385","updated":"2015-01-08 21:05:38.000000000","message":"Done","commit_id":"a18b55ac246e88d13d9c49fbf241ace3cfb2b9fe"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"bf016aa6b5f027bd9c4b9930f4e297ef9977561b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"disk.capacity                    g      B          inst ID   n         1              Capacity of disk in B"},{"line_number":97,"context_line":"disk.allocation                  g      B          inst ID   n         1              Allocation of disk in B"},{"line_number":98,"context_line":"disk.usage                       g      B          inst ID   n         1              Usage of disk in B"},{"line_number":99,"context_line":"disk.device.capacity             g      B          inst ID   n         1              Capacity per device of disk in B"},{"line_number":100,"context_line":"disk.device.allocation           g      B          inst ID   n         1              Allocation per device of disk in B"},{"line_number":101,"context_line":"disk.device.usage                g      B          inst ID   n         1              Usage per device of disk in B"},{"line_number":102,"context_line":"network.incoming.bytes           c      B          iface ID  p         1, 2           Number of incoming bytes on a VM network interface"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1a930d6b_e3c60d49","line":99,"updated":"2015-01-21 06:39:48.000000000","message":"it is not inst id. use consistent disk id, or precise instID-diskName","commit_id":"6edd41a3b8d8de0d25e54a7bf236369d6086ee86"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"ba5d295798a516120b60ab9cca644800dd7e239b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"disk.capacity                    g      B          inst ID   n         1              Capacity of disk in B"},{"line_number":97,"context_line":"disk.allocation                  g      B          inst ID   n         1              Allocation of disk in B"},{"line_number":98,"context_line":"disk.usage                       g      B          inst ID   n         1              Usage of disk in B"},{"line_number":99,"context_line":"disk.device.capacity             g      B          inst ID   n         1              Capacity per device of disk in B"},{"line_number":100,"context_line":"disk.device.allocation           g      B          inst ID   n         1              Allocation per device of disk in B"},{"line_number":101,"context_line":"disk.device.usage                g      B          inst ID   n         1              Usage per device of disk in B"},{"line_number":102,"context_line":"network.incoming.bytes           c      B          iface ID  p         1, 2           Number of incoming bytes on a VM network interface"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1a930d6b_d01463f7","line":99,"in_reply_to":"1a930d6b_e3c60d49","updated":"2015-01-21 15:48:50.000000000","message":"Changed it to disk ID . Thanks.","commit_id":"6edd41a3b8d8de0d25e54a7bf236369d6086ee86"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"bf016aa6b5f027bd9c4b9930f4e297ef9977561b","unresolved":false,"context_lines":[{"line_number":97,"context_line":"disk.allocation                  g      B          inst ID   n         1              Allocation of disk in B"},{"line_number":98,"context_line":"disk.usage                       g      B          inst ID   n         1              Usage of disk in B"},{"line_number":99,"context_line":"disk.device.capacity             g      B          inst ID   n         1              Capacity per device of disk in B"},{"line_number":100,"context_line":"disk.device.allocation           g      B          inst ID   n         1              Allocation per device of disk in B"},{"line_number":101,"context_line":"disk.device.usage                g      B          inst ID   n         1              Usage per device of disk in B"},{"line_number":102,"context_line":"network.incoming.bytes           c      B          iface ID  p         1, 2           Number of incoming bytes on a VM network interface"},{"line_number":103,"context_line":"network.incoming.bytes.rate      g      B/s        iface ID  p         1, 2, 3, 4     Average rate per sec of incoming bytes on a VM network interface"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1a930d6b_03c4f93e","line":100,"updated":"2015-01-21 06:39:48.000000000","message":"ditto","commit_id":"6edd41a3b8d8de0d25e54a7bf236369d6086ee86"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"ba5d295798a516120b60ab9cca644800dd7e239b","unresolved":false,"context_lines":[{"line_number":97,"context_line":"disk.allocation                  g      B          inst ID   n         1              Allocation of disk in B"},{"line_number":98,"context_line":"disk.usage                       g      B          inst ID   n         1              Usage of disk in B"},{"line_number":99,"context_line":"disk.device.capacity             g      B          inst ID   n         1              Capacity per device of disk in B"},{"line_number":100,"context_line":"disk.device.allocation           g      B          inst ID   n         1              Allocation per device of disk in B"},{"line_number":101,"context_line":"disk.device.usage                g      B          inst ID   n         1              Usage per device of disk in B"},{"line_number":102,"context_line":"network.incoming.bytes           c      B          iface ID  p         1, 2           Number of incoming bytes on a VM network interface"},{"line_number":103,"context_line":"network.incoming.bytes.rate      g      B/s        iface ID  p         1, 2, 3, 4     Average rate per sec of incoming bytes on a VM network interface"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1a930d6b_10f6ebd7","line":100,"in_reply_to":"1a930d6b_03c4f93e","updated":"2015-01-21 15:48:50.000000000","message":"Done","commit_id":"6edd41a3b8d8de0d25e54a7bf236369d6086ee86"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"bf016aa6b5f027bd9c4b9930f4e297ef9977561b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"disk.usage                       g      B          inst ID   n         1              Usage of disk in B"},{"line_number":99,"context_line":"disk.device.capacity             g      B          inst ID   n         1              Capacity per device of disk in B"},{"line_number":100,"context_line":"disk.device.allocation           g      B          inst ID   n         1              Allocation per device of disk in B"},{"line_number":101,"context_line":"disk.device.usage                g      B          inst ID   n         1              Usage per device of disk in B"},{"line_number":102,"context_line":"network.incoming.bytes           c      B          iface ID  p         1, 2           Number of incoming bytes on a VM network interface"},{"line_number":103,"context_line":"network.incoming.bytes.rate      g      B/s        iface ID  p         1, 2, 3, 4     Average rate per sec of incoming bytes on a VM network interface"},{"line_number":104,"context_line":"network.outgoing.bytes           c      B          iface ID  p         1, 2           Number of outgoing bytes on a VM network interface"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1a930d6b_23c1f52e","line":101,"updated":"2015-01-21 06:39:48.000000000","message":"ditto","commit_id":"6edd41a3b8d8de0d25e54a7bf236369d6086ee86"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"ba5d295798a516120b60ab9cca644800dd7e239b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"disk.usage                       g      B          inst ID   n         1              Usage of disk in B"},{"line_number":99,"context_line":"disk.device.capacity             g      B          inst ID   n         1              Capacity per device of disk in B"},{"line_number":100,"context_line":"disk.device.allocation           g      B          inst ID   n         1              Allocation per device of disk in B"},{"line_number":101,"context_line":"disk.device.usage                g      B          inst ID   n         1              Usage per device of disk in B"},{"line_number":102,"context_line":"network.incoming.bytes           c      B          iface ID  p         1, 2           Number of incoming bytes on a VM network interface"},{"line_number":103,"context_line":"network.incoming.bytes.rate      g      B/s        iface ID  p         1, 2, 3, 4     Average rate per sec of incoming bytes on a VM network interface"},{"line_number":104,"context_line":"network.outgoing.bytes           c      B          iface ID  p         1, 2           Number of outgoing bytes on a VM network interface"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1a930d6b_3003e7b9","line":101,"in_reply_to":"1a930d6b_23c1f52e","updated":"2015-01-21 15:48:50.000000000","message":"Done","commit_id":"6edd41a3b8d8de0d25e54a7bf236369d6086ee86"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"9481a9101ba9ea7967104a9d9cfdcffcf25ec513","unresolved":false,"context_lines":[{"line_number":92,"context_line":"disk.device.write.bytes          c      B          disk ID   p         1, 2           Volume of writes in B per device"},{"line_number":93,"context_line":"disk.device.write.bytes.rate     g      B/s        disk ID   p         1, 2, 3        Average volume of writes in B per second per device"},{"line_number":94,"context_line":"disk.root.size                   g      GB         inst ID   n         1, 2           Size of root disk in GB"},{"line_number":95,"context_line":"disk.ephemeral.size              g      GB         inst ID   n         1, 2           Size of ephemeral disk in GB"},{"line_number":96,"context_line":"disk.capacity                    g      B          inst ID   n         1              Capacity of disk in B"},{"line_number":97,"context_line":"disk.allocation                  g      B          inst ID   n         1              Allocation of disk in B"},{"line_number":98,"context_line":"disk.usage                       g      B          inst ID   n         1              Usage of disk in B"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a930d6b_37a9f87b","line":95,"updated":"2015-01-22 13:07:44.000000000","message":"nit: for all lines below \u0027in B\u0027 may be removed because Unit column has already contained this info","commit_id":"0796382a7dc129f418b66706377d2a9afda98147"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"10637430b41d11cf51272d042c4dd04b2110eeee","unresolved":false,"context_lines":[{"line_number":92,"context_line":"disk.device.write.bytes          c      B          disk ID   p         1, 2           Volume of writes in B per device"},{"line_number":93,"context_line":"disk.device.write.bytes.rate     g      B/s        disk ID   p         1, 2, 3        Average volume of writes in B per second per device"},{"line_number":94,"context_line":"disk.root.size                   g      GB         inst ID   n         1, 2           Size of root disk in GB"},{"line_number":95,"context_line":"disk.ephemeral.size              g      GB         inst ID   n         1, 2           Size of ephemeral disk in GB"},{"line_number":96,"context_line":"disk.capacity                    g      B          inst ID   n         1              Capacity of disk in B"},{"line_number":97,"context_line":"disk.allocation                  g      B          inst ID   n         1              Allocation of disk in B"},{"line_number":98,"context_line":"disk.usage                       g      B          inst ID   n         1              Usage of disk in B"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a930d6b_1830a900","line":95,"in_reply_to":"1a930d6b_37a9f87b","updated":"2015-01-22 14:26:19.000000000","message":"I kept it just to be in sync with other meters.","commit_id":"0796382a7dc129f418b66706377d2a9afda98147"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"113211d972729bea71538a342ca21af36296261a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Name                             Type*  Unit       Resource  Origin**  Support***     Note"},{"line_number":70,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":71,"context_line":"instance                         g      instance   inst ID   both      1, 2, 3, 4     Existence of instance"},{"line_number":72,"context_line":"instance:\u003ctype\u003e                  g      instance   inst ID   both      1, 2, 3, 4     Existence of instance \u003ctype\u003e (openstack types)"},{"line_number":73,"context_line":"memory                           g      MB         inst ID   n         1, 2           Volume of RAM allocated in MB"},{"line_number":74,"context_line":"memory.usage                     g      MB         inst ID   p         1, 3, 4        Volume of RAM used in MB"},{"line_number":75,"context_line":"cpu                              c      ns         inst ID   p         1, 2           CPU time used"}],"source_content_type":"text/x-rst","patch_set":15,"id":"da86d52c_3455abc6","line":72,"updated":"2015-02-01 21:47:49.000000000","message":"So we\u0027ve changed the doc and removed duplication like \u0027in bytes\u0027, \u0027in MB\u0027. Could you please remove it too?","commit_id":"a8fc4843d3769ab999b048c85911a3fd98f87768"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"b49dfd8696fd02ad2206a2040d4389631341a09b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Name                             Type*  Unit       Resource  Origin**  Support***     Note"},{"line_number":70,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":71,"context_line":"instance                         g      instance   inst ID   both      1, 2, 3, 4     Existence of instance"},{"line_number":72,"context_line":"instance:\u003ctype\u003e                  g      instance   inst ID   both      1, 2, 3, 4     Existence of instance \u003ctype\u003e (openstack types)"},{"line_number":73,"context_line":"memory                           g      MB         inst ID   n         1, 2           Volume of RAM allocated in MB"},{"line_number":74,"context_line":"memory.usage                     g      MB         inst ID   p         1, 3, 4        Volume of RAM used in MB"},{"line_number":75,"context_line":"cpu                              c      ns         inst ID   p         1, 2           CPU time used"}],"source_content_type":"text/x-rst","patch_set":15,"id":"da86d52c_4f4606c1","line":72,"in_reply_to":"da86d52c_3455abc6","updated":"2015-02-02 00:45:16.000000000","message":"Done","commit_id":"a8fc4843d3769ab999b048c85911a3fd98f87768"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"113211d972729bea71538a342ca21af36296261a","unresolved":false,"context_lines":[{"line_number":531,"context_line":""},{"line_number":532,"context_line":"User-defined sample metadata for Nova"},{"line_number":533,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"Users are allowed to add additional metadata to samples of nova meter."},{"line_number":536,"context_line":"These additional metadata are stored in \u0027resource_metadata.user_metadata.*\u0027 of the sample."},{"line_number":537,"context_line":"To do so, users should add nova user metadata prefixed with \u0027metering.\u0027:"}],"source_content_type":"text/x-rst","patch_set":15,"id":"da86d52c_b4419b0d","line":534,"updated":"2015-02-01 21:47:49.000000000","message":"And below?","commit_id":"a8fc4843d3769ab999b048c85911a3fd98f87768"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"b49dfd8696fd02ad2206a2040d4389631341a09b","unresolved":false,"context_lines":[{"line_number":531,"context_line":""},{"line_number":532,"context_line":"User-defined sample metadata for Nova"},{"line_number":533,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"Users are allowed to add additional metadata to samples of nova meter."},{"line_number":536,"context_line":"These additional metadata are stored in \u0027resource_metadata.user_metadata.*\u0027 of the sample."},{"line_number":537,"context_line":"To do so, users should add nova user metadata prefixed with \u0027metering.\u0027:"}],"source_content_type":"text/x-rst","patch_set":15,"id":"da86d52c_6f12eab5","line":534,"in_reply_to":"da86d52c_b4419b0d","updated":"2015-02-02 00:45:16.000000000","message":"Done","commit_id":"a8fc4843d3769ab999b048c85911a3fd98f87768"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"fc9a4601c9dda4d53d9855d6451804711b3384ae","unresolved":false,"context_lines":[{"line_number":96,"context_line":"disk.device.latency              g      ms         disk ID   p         2              Average disk latency per device"},{"line_number":97,"context_line":"disk.device.iops                 g      count/s    disk ID   p         2              Average disk iops per device"},{"line_number":98,"context_line":"disk.root.size                   g      GB         inst ID   n         1, 2           Size of root disk"},{"line_number":99,"context_line":"disk.ephemeral.size              g      GB         inst ID   n         1, 2           Size of ephemeral disk"},{"line_number":100,"context_line":"disk.capacity                    g      B          inst ID   n         1              Capacity of disk"},{"line_number":101,"context_line":"disk.allocation                  g      B          inst ID   n         1              Allocation of disk"},{"line_number":102,"context_line":"disk.usage                       g      B          inst ID   n         1              Usage of disk"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da86d52c_3b199388","line":99,"updated":"2015-02-11 15:00:51.000000000","message":"\u0027n\u0027 should be changed to \u0027p\u0027 I guess","commit_id":"c9edd2740ccb6535dfdcb6a73efa1879b58c8a12"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"99e023cc728b8210b5e7117ffa2d52523294da67","unresolved":false,"context_lines":[{"line_number":96,"context_line":"disk.device.latency              g      ms         disk ID   p         2              Average disk latency per device"},{"line_number":97,"context_line":"disk.device.iops                 g      count/s    disk ID   p         2              Average disk iops per device"},{"line_number":98,"context_line":"disk.root.size                   g      GB         inst ID   n         1, 2           Size of root disk"},{"line_number":99,"context_line":"disk.ephemeral.size              g      GB         inst ID   n         1, 2           Size of ephemeral disk"},{"line_number":100,"context_line":"disk.capacity                    g      B          inst ID   n         1              Capacity of disk"},{"line_number":101,"context_line":"disk.allocation                  g      B          inst ID   n         1              Allocation of disk"},{"line_number":102,"context_line":"disk.usage                       g      B          inst ID   n         1              Usage of disk"}],"source_content_type":"text/x-rst","patch_set":21,"id":"da86d52c_fe1c49c4","line":99,"in_reply_to":"da86d52c_3b199388","updated":"2015-02-11 15:13:15.000000000","message":"Done. Thanks for pointing this.","commit_id":"c9edd2740ccb6535dfdcb6a73efa1879b58c8a12"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"56479c5e71991f701751a9700de0d4b2ce0d1b8e","unresolved":false,"context_lines":[{"line_number":99,"context_line":"disk.ephemeral.size              g      GB         inst ID   n         1, 2           Size of ephemeral disk"},{"line_number":100,"context_line":"disk.capacity                    g      B          inst ID   p         1              Capacity of disk"},{"line_number":101,"context_line":"disk.allocation                  g      B          inst ID   p         1              Allocation of disk"},{"line_number":102,"context_line":"disk.usage                       g      B          inst ID   p         1              Usage of disk"},{"line_number":103,"context_line":"disk.device.capacity             g      B          disk ID   p         1              Capacity per device of disk"},{"line_number":104,"context_line":"disk.device.allocation           g      B          disk ID   p         1              Allocation per device of disk"},{"line_number":105,"context_line":"disk.device.usage                g      B          disk ID   p         1              Usage per device of disk"}],"source_content_type":"text/x-rst","patch_set":22,"id":"da86d52c_cdcb5070","line":102,"updated":"2015-02-11 17:39:00.000000000","message":"Same as below.","commit_id":"9e3577efe3ad14fcb257f29384a5be9cb3c63f43"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"7ac7611a2bb04f4a28317ecd1d498c6e9d09808c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"disk.usage                       g      B          inst ID   p         1              Usage of disk"},{"line_number":103,"context_line":"disk.device.capacity             g      B          disk ID   p         1              Capacity per device of disk"},{"line_number":104,"context_line":"disk.device.allocation           g      B          disk ID   p         1              Allocation per device of disk"},{"line_number":105,"context_line":"disk.device.usage                g      B          disk ID   p         1              Usage per device of disk"},{"line_number":106,"context_line":"network.incoming.bytes           c      B          iface ID  p         1, 2           Number of incoming bytes"},{"line_number":107,"context_line":"network.incoming.bytes.rate      g      B/s        iface ID  p         1, 2, 3, 4     Average rate of incoming bytes"},{"line_number":108,"context_line":"network.outgoing.bytes           c      B          iface ID  p         1, 2           Number of outgoing bytes"}],"source_content_type":"text/x-rst","patch_set":22,"id":"da86d52c_6488c871","line":105,"updated":"2015-02-11 15:47:41.000000000","message":"Please point it out here that this counter describes the physical disk usage on the host as opposed to the amount of disk used inside of the instance.","commit_id":"9e3577efe3ad14fcb257f29384a5be9cb3c63f43"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"56479c5e71991f701751a9700de0d4b2ce0d1b8e","unresolved":false,"context_lines":[{"line_number":102,"context_line":"disk.usage                       g      B          inst ID   p         1              Usage of disk"},{"line_number":103,"context_line":"disk.device.capacity             g      B          disk ID   p         1              Capacity per device of disk"},{"line_number":104,"context_line":"disk.device.allocation           g      B          disk ID   p         1              Allocation per device of disk"},{"line_number":105,"context_line":"disk.device.usage                g      B          disk ID   p         1              Usage per device of disk"},{"line_number":106,"context_line":"network.incoming.bytes           c      B          iface ID  p         1, 2           Number of incoming bytes"},{"line_number":107,"context_line":"network.incoming.bytes.rate      g      B/s        iface ID  p         1, 2, 3, 4     Average rate of incoming bytes"},{"line_number":108,"context_line":"network.outgoing.bytes           c      B          iface ID  p         1, 2           Number of outgoing bytes"}],"source_content_type":"text/x-rst","patch_set":22,"id":"da86d52c_edc49461","line":105,"in_reply_to":"da86d52c_2aa777a8","updated":"2015-02-11 17:39:00.000000000","message":"Sorry, I wanted to add this comment to the disk.usage basically, but applicable here too. As disk.capacity means the amount of disk that VM can see, I don\u0027t think this would be self descriptive here.","commit_id":"9e3577efe3ad14fcb257f29384a5be9cb3c63f43"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"a5142503f5b9348870f3164c74a9e0334e363a41","unresolved":false,"context_lines":[{"line_number":102,"context_line":"disk.usage                       g      B          inst ID   p         1              Usage of disk"},{"line_number":103,"context_line":"disk.device.capacity             g      B          disk ID   p         1              Capacity per device of disk"},{"line_number":104,"context_line":"disk.device.allocation           g      B          disk ID   p         1              Allocation per device of disk"},{"line_number":105,"context_line":"disk.device.usage                g      B          disk ID   p         1              Usage per device of disk"},{"line_number":106,"context_line":"network.incoming.bytes           c      B          iface ID  p         1, 2           Number of incoming bytes"},{"line_number":107,"context_line":"network.incoming.bytes.rate      g      B/s        iface ID  p         1, 2, 3, 4     Average rate of incoming bytes"},{"line_number":108,"context_line":"network.outgoing.bytes           c      B          iface ID  p         1, 2           Number of outgoing bytes"}],"source_content_type":"text/x-rst","patch_set":22,"id":"da86d52c_2aa777a8","line":105,"in_reply_to":"da86d52c_6488c871","updated":"2015-02-11 16:15:10.000000000","message":"I think as the meter name starts with disk.* , so it is self descriptive that it is related to physical disk usage rather than inside the instance.","commit_id":"9e3577efe3ad14fcb257f29384a5be9cb3c63f43"}]}