)]}'
{"ceilometer/collector.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"7f5b107ca33f179877f765d51328694d339e35da","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            ]"},{"line_number":192,"context_line":"        except Exception:"},{"line_number":193,"context_line":"            LOG.exception(_LE(\"Error processing event, requeue it.\"))"},{"line_number":194,"context_line":"            return oslo.messaging.NotificationResult.REQUEUE"},{"line_number":195,"context_line":"        return super(EventEndpoint, self).sample("},{"line_number":196,"context_line":"            ctxt, publisher_id, event_type, events, metadata)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_352772b7","line":194,"updated":"2015-01-19 11:05:26.000000000","message":"just wondering if requeue_data_on_dispatcher_error\u003dFalse, then the listener will not allow_requeue, however we will return oslo.messaging.NotificationResult.REQUEUE when exception is raised, what will happen finally?","commit_id":"ba0d496de59d4bf10525d081b8b24fbdaa7d6fbe"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"95939c06552885d317c53d16db0d0297da56dd31","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            ]"},{"line_number":192,"context_line":"        except Exception:"},{"line_number":193,"context_line":"            LOG.exception(_LE(\"Error processing event, requeue it.\"))"},{"line_number":194,"context_line":"            return oslo.messaging.NotificationResult.REQUEUE"},{"line_number":195,"context_line":"        return super(EventEndpoint, self).sample("},{"line_number":196,"context_line":"            ctxt, publisher_id, event_type, events, metadata)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_56bde166","line":194,"in_reply_to":"3a961159_352772b7","updated":"2015-01-19 14:53:15.000000000","message":"as i understand, the listener will ignore REQUEUE results if allow_requeue is not enabled explicitly in listener","commit_id":"ba0d496de59d4bf10525d081b8b24fbdaa7d6fbe"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"5bddaed9f7081bf5097269d4185f390bc4b13d2a","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            ]"},{"line_number":207,"context_line":"        except Exception:"},{"line_number":208,"context_line":"            LOG.exception(_LE(\"Error processing event, requeue it.\"))"},{"line_number":209,"context_line":"            return oslo.messaging.NotificationResult.REQUEUE"},{"line_number":210,"context_line":"        return super(EventEndpoint, self).sample("},{"line_number":211,"context_line":"            ctxt, publisher_id, event_type, events, metadata)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_934adb81","line":209,"updated":"2015-02-02 13:40:46.000000000","message":"Shouldn\u0027t this requeue be guarded by:\n\n  if self.requeue_on_error:","commit_id":"a60ea69c44917aeb3d6eefeff7afe6d2bf85b9b0"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"4b15ffa8536c13b6c154e42ba4e34cf36ca3b534","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            ]"},{"line_number":207,"context_line":"        except Exception:"},{"line_number":208,"context_line":"            LOG.exception(_LE(\"Error processing event, requeue it.\"))"},{"line_number":209,"context_line":"            return oslo.messaging.NotificationResult.REQUEUE"},{"line_number":210,"context_line":"        return super(EventEndpoint, self).sample("},{"line_number":211,"context_line":"            ctxt, publisher_id, event_type, events, metadata)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_5c0f8f30","line":209,"in_reply_to":"da86d52c_13f42a5a","updated":"2015-02-02 14:38:11.000000000","message":"I guess I\u0027m also struggling to understand how a requeue would help resolve a failure in the event creation, i.e. is the process of parsing out an Event from the message deterministic such that it would fail in the same way after a requeue?","commit_id":"a60ea69c44917aeb3d6eefeff7afe6d2bf85b9b0"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"b6b511060b3c6afc4a9dfb29aa960825292dc2e2","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            ]"},{"line_number":207,"context_line":"        except Exception:"},{"line_number":208,"context_line":"            LOG.exception(_LE(\"Error processing event, requeue it.\"))"},{"line_number":209,"context_line":"            return oslo.messaging.NotificationResult.REQUEUE"},{"line_number":210,"context_line":"        return super(EventEndpoint, self).sample("},{"line_number":211,"context_line":"            ctxt, publisher_id, event_type, events, metadata)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_13f42a5a","line":209,"in_reply_to":"da86d52c_934adb81","updated":"2015-02-02 13:59:26.000000000","message":"i think i left it as a mandatory requeue because events are (personally) more critical information than a sample. i.e. we don\u0027t shouldn\u0027t really ever miss capturing an event.\n\ni\u0027m ok with adding an option but i don\u0027t think that option should ever be turned off so i didn\u0027t add it... i\u0027m open to opinions though.","commit_id":"a60ea69c44917aeb3d6eefeff7afe6d2bf85b9b0"}],"ceilometer/utils.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"f982af9bfb915bbdd3d4d76b173f53ddcbc9c83c","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    # which stops new messages, and wait(), which processes remaining"},{"line_number":257,"context_line":"    # messages and closes connection"},{"line_number":258,"context_line":"    for listener in listeners:"},{"line_number":259,"context_line":"        listener.stop()"},{"line_number":260,"context_line":"        listener.wait()"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_2ddefa11","line":259,"updated":"2015-02-03 10:22:49.000000000","message":"Would be better to stop all and then wait all.","commit_id":"7fc0d1e6c71198fa865c7cbf9cab6debc7274f4f"}]}