)]}'
{"ceilometer/tests/ipmi/platform/test_intel_node_manager.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"45e507f2c6fce5ba1d9540dd075c2e828d4f6141","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        min_val \u003d node_manager._hex(temperature[\"Minimum_value\"])"},{"line_number":55,"context_line":"        cur_val \u003d node_manager._hex(temperature[\"Current_value\"])"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.assertTrue(self.nm.nm_support)"},{"line_number":58,"context_line":"        # see ipmi_test_data.py for raw data"},{"line_number":59,"context_line":"        self.assertEqual(23, cur_val)"},{"line_number":60,"context_line":"        self.assertEqual(22, min_val)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_561791a3","side":"PARENT","line":57,"updated":"2015-01-28 01:43:32.000000000","message":"why this line should be removed while L42 remains? is it because they are same workflow so only one is needed?","commit_id":"889cc514832563c45c6798120448a4b67a6991f5"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"557b3ceff44bc2fba4cda8247576d119820611b6","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        min_val \u003d node_manager._hex(temperature[\"Minimum_value\"])"},{"line_number":55,"context_line":"        cur_val \u003d node_manager._hex(temperature[\"Current_value\"])"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.assertTrue(self.nm.nm_support)"},{"line_number":58,"context_line":"        # see ipmi_test_data.py for raw data"},{"line_number":59,"context_line":"        self.assertEqual(23, cur_val)"},{"line_number":60,"context_line":"        self.assertEqual(22, min_val)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_b82b5b2f","side":"PARENT","line":57,"in_reply_to":"fa81d914_561791a3","updated":"2015-01-28 02:07:00.000000000","message":"As node_manager is singleton, we get the same instance after initialization. So testing it once is enough.","commit_id":"889cc514832563c45c6798120448a4b67a6991f5"}],"ceilometer/tests/ipmi/platform/test_ipmi_sensor.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"45e507f2c6fce5ba1d9540dd075c2e828d4f6141","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def test_read_sensor_temperature(self):"},{"line_number":40,"context_line":"        sensors \u003d self.ipmi.read_sensor_any(\u0027Temperature\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.assertTrue(self.ipmi.ipmi_support)"},{"line_number":43,"context_line":"        # only temperature data returned."},{"line_number":44,"context_line":"        self.assertIn(\u0027Temperature\u0027, sensors)"},{"line_number":45,"context_line":"        self.assertEqual(1, len(sensors))"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_f61fa5b5","line":42,"updated":"2015-01-28 01:43:32.000000000","message":"why this line is needed while test_read_sensor_voltage and test_read_sensor_current don\u0027t? is it because they are same workflow so only one is needed?","commit_id":"4b37a36fbff3ad7a93b4afb9038f793548a6ef04"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"557b3ceff44bc2fba4cda8247576d119820611b6","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def test_read_sensor_temperature(self):"},{"line_number":40,"context_line":"        sensors \u003d self.ipmi.read_sensor_any(\u0027Temperature\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.assertTrue(self.ipmi.ipmi_support)"},{"line_number":43,"context_line":"        # only temperature data returned."},{"line_number":44,"context_line":"        self.assertIn(\u0027Temperature\u0027, sensors)"},{"line_number":45,"context_line":"        self.assertEqual(1, len(sensors))"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_d8cd6f88","line":42,"in_reply_to":"fa81d914_f61fa5b5","updated":"2015-01-28 02:07:00.000000000","message":"It\u0027s singleton, and we access the same instance after initialization. So testing it once is enough.","commit_id":"4b37a36fbff3ad7a93b4afb9038f793548a6ef04"}]}