)]}'
{"ceilometer/identity/notifications.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"0fd51d88034e400073e8896397442332e6f20658","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    def process_notification(self, message):"},{"line_number":52,"context_line":"        user_id \u003d None"},{"line_number":53,"context_line":"        if \u0027id\u0027 in message.get(\u0027payload\u0027, {}).get(\u0027initiator\u0027, {}):"},{"line_number":54,"context_line":"            user_id \u003d message[\u0027payload\u0027][\u0027initiator\u0027][\u0027id\u0027],"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        yield sample.Sample.from_notification("},{"line_number":57,"context_line":"            name\u003dmessage[\u0027event_type\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa81d914_effcb174","line":54,"updated":"2015-01-30 04:32:15.000000000","message":"I think message definitely has payload, so it can be shorten to\n\n    user_id \u003d message[\u0027payload\u0027].get(\"initiator\", {}).get(\"id\")\n\nI\u0027m not sure if this is OK to add this in base class, project, role, group CRUD have no such user_id attribute\n\nand what about the project_id?","commit_id":"20f26d392508230c63fe301d7bedf239776069e4"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9e9606752fb60a4f49a4e6472f6a96a3036184be","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    def process_notification(self, message):"},{"line_number":52,"context_line":"        user_id \u003d None"},{"line_number":53,"context_line":"        if \u0027id\u0027 in message.get(\u0027payload\u0027, {}).get(\u0027initiator\u0027, {}):"},{"line_number":54,"context_line":"            user_id \u003d message[\u0027payload\u0027][\u0027initiator\u0027][\u0027id\u0027],"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        yield sample.Sample.from_notification("},{"line_number":57,"context_line":"            name\u003dmessage[\u0027event_type\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa81d914_2f608900","line":54,"in_reply_to":"fa81d914_effcb174","updated":"2015-01-30 04:36:33.000000000","message":"++ nice\n\nthe user_id in this case should represent the person who initiated the request, so in a project/role/group CRUD it\u0027ll always be there.\n\nFor the project, we haven\u0027t included that in the CADF payload yet.","commit_id":"20f26d392508230c63fe301d7bedf239776069e4"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"5b0654b1740939773bff824f14def8abb7d90d25","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            type\u003dsample.TYPE_DELTA,"},{"line_number":56,"context_line":"            unit\u003dself.resource_type,"},{"line_number":57,"context_line":"            volume\u003d1,"},{"line_number":58,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027resource_info\u0027],"},{"line_number":59,"context_line":"            user_id\u003duser_id,"},{"line_number":60,"context_line":"            project_id\u003dNone,"},{"line_number":61,"context_line":"            message\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_9ae84b7e","line":58,"updated":"2015-01-31 18:17:52.000000000","message":"i don\u0027t get it, this resource_info tag still exists but there\u0027s also cadf?","commit_id":"8fd6a9f5cb0275625d9a3a02ac0e9f7dbbdce256"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"4d030d586fb2bec3ed320d7312ff60f06257086d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            type\u003dsample.TYPE_DELTA,"},{"line_number":56,"context_line":"            unit\u003dself.resource_type,"},{"line_number":57,"context_line":"            volume\u003d1,"},{"line_number":58,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027resource_info\u0027],"},{"line_number":59,"context_line":"            user_id\u003duser_id,"},{"line_number":60,"context_line":"            project_id\u003dNone,"},{"line_number":61,"context_line":"            message\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_fa8a9a19","line":58,"in_reply_to":"da86d52c_387e101a","updated":"2015-02-04 14:43:57.000000000","message":"should we use attempt to get resource_id from correct cadf spot first before deferring to this? or the opposite? use this, and defer to correct cadf location?","commit_id":"8fd6a9f5cb0275625d9a3a02ac0e9f7dbbdce256"},{"author":{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},"change_message_id":"89e3dfa5a498b1a267ca0f60b4d5374f31d2e94a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            type\u003dsample.TYPE_DELTA,"},{"line_number":56,"context_line":"            unit\u003dself.resource_type,"},{"line_number":57,"context_line":"            volume\u003d1,"},{"line_number":58,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027resource_info\u0027],"},{"line_number":59,"context_line":"            user_id\u003duser_id,"},{"line_number":60,"context_line":"            project_id\u003dNone,"},{"line_number":61,"context_line":"            message\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_15a6c510","line":58,"in_reply_to":"da86d52c_7a68f7f5","updated":"2015-02-02 16:29:25.000000000","message":"I think this is a good approach of backward compatibility","commit_id":"8fd6a9f5cb0275625d9a3a02ac0e9f7dbbdce256"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"220d6b34174e017884041befbf4fb882735d81f8","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            type\u003dsample.TYPE_DELTA,"},{"line_number":56,"context_line":"            unit\u003dself.resource_type,"},{"line_number":57,"context_line":"            volume\u003d1,"},{"line_number":58,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027resource_info\u0027],"},{"line_number":59,"context_line":"            user_id\u003duser_id,"},{"line_number":60,"context_line":"            project_id\u003dNone,"},{"line_number":61,"context_line":"            message\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_9076433d","line":58,"in_reply_to":"da86d52c_7a68f7f5","updated":"2015-02-02 16:49:48.000000000","message":"commented on it... i think the different payloads with same event_type might be inconsistent but that\u0027s just personal opinion on my part.","commit_id":"8fd6a9f5cb0275625d9a3a02ac0e9f7dbbdce256"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"92fa19d8af7b86ba05058db199f98ab5c4b7318f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            type\u003dsample.TYPE_DELTA,"},{"line_number":56,"context_line":"            unit\u003dself.resource_type,"},{"line_number":57,"context_line":"            volume\u003d1,"},{"line_number":58,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027resource_info\u0027],"},{"line_number":59,"context_line":"            user_id\u003duser_id,"},{"line_number":60,"context_line":"            project_id\u003dNone,"},{"line_number":61,"context_line":"            message\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_387e101a","line":58,"in_reply_to":"da86d52c_9076433d","updated":"2015-02-04 03:46:26.000000000","message":"not sure if you\u0027ve had a chance to rethink this gordon, but as discussed in https://review.openstack.org/#/c/151137 the resource_info will remain for backwards compatibility, and the user_id will be there for CADF notifications, but not for the non-CADF notifications.\n\nThe admin can only pick one or the other, so duplicate notifications will not occur.","commit_id":"8fd6a9f5cb0275625d9a3a02ac0e9f7dbbdce256"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"3c1d3b86ee2d200c935c0781910e4915e6edb74d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            type\u003dsample.TYPE_DELTA,"},{"line_number":56,"context_line":"            unit\u003dself.resource_type,"},{"line_number":57,"context_line":"            volume\u003d1,"},{"line_number":58,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027resource_info\u0027],"},{"line_number":59,"context_line":"            user_id\u003duser_id,"},{"line_number":60,"context_line":"            project_id\u003dNone,"},{"line_number":61,"context_line":"            message\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_7a68f7f5","line":58,"in_reply_to":"da86d52c_9ae84b7e","updated":"2015-01-31 18:26:43.000000000","message":"Right, we didn\u0027t want to not expose the notifications that emit just resource_info in the payload. But we also wanted to emit CADF notifications for those types of events. \n\nIn order to re-use this could we decided to create a CADF notification but carry resource_info -\u003e resource_id in the CADF event (the payload).\n\nI added you as a reviewer to https://review.openstack.org/#/c/151137/12/keystone/notifications.py\n\nLet me know if you think i\u0027m doing something that will irreversibly horrible","commit_id":"8fd6a9f5cb0275625d9a3a02ac0e9f7dbbdce256"}],"etc/ceilometer/event_definitions.yaml":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"3afce5848c9127c1a65616d9b0d43be40c28e65e","unresolved":false,"context_lines":[{"line_number":148,"context_line":"  traits: \u0026identity_crud"},{"line_number":149,"context_line":"    resource_id:"},{"line_number":150,"context_line":"      fields: payload.resource_info"},{"line_number":151,"context_line":"    initiator_id:"},{"line_number":152,"context_line":"      fields: payload.initiator.id"},{"line_number":153,"context_line":"- event_type: identity.role_assignment.*"},{"line_number":154,"context_line":"  traits: \u0026identity_role_assignment"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a80dd14_6570aa0b","line":151,"updated":"2015-03-09 09:56:58.000000000","message":"Shouldn\u0027t this be user_id here? Or this mapping is only needed when this event is stored as a meter?","commit_id":"c630b217223959021422cf88605ab4647b341988"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"bd91e2e2d3ce609426e02c1b1635e99def36e87f","unresolved":false,"context_lines":[{"line_number":148,"context_line":"  traits: \u0026identity_crud"},{"line_number":149,"context_line":"    resource_id:"},{"line_number":150,"context_line":"      fields: payload.resource_info"},{"line_number":151,"context_line":"    initiator_id:"},{"line_number":152,"context_line":"      fields: payload.initiator.id"},{"line_number":153,"context_line":"- event_type: identity.role_assignment.*"},{"line_number":154,"context_line":"  traits: \u0026identity_role_assignment"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a80dd14_9244f54a","line":151,"in_reply_to":"9a80dd14_28da024c","updated":"2015-03-09 15:11:54.000000000","message":"Ok, cool, thanks for the clarification, I missed that point.","commit_id":"c630b217223959021422cf88605ab4647b341988"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"4d0f198f5e8cab973c7a4010b55f7e40d07dee72","unresolved":false,"context_lines":[{"line_number":148,"context_line":"  traits: \u0026identity_crud"},{"line_number":149,"context_line":"    resource_id:"},{"line_number":150,"context_line":"      fields: payload.resource_info"},{"line_number":151,"context_line":"    initiator_id:"},{"line_number":152,"context_line":"      fields: payload.initiator.id"},{"line_number":153,"context_line":"- event_type: identity.role_assignment.*"},{"line_number":154,"context_line":"  traits: \u0026identity_role_assignment"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a80dd14_28da024c","line":151,"in_reply_to":"9a80dd14_6570aa0b","updated":"2015-03-09 12:57:31.000000000","message":"ildiko, keystone notifications use CADF as their notification format. this keeps it align to the format","commit_id":"c630b217223959021422cf88605ab4647b341988"}]}