)]}'
{"ceilometer/agent/discovery/localnode.py":[{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"8adb05a2cf09186c742510315358adaba0a05389","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class LocalNodeDiscovery(plugin_base.DiscoveryBase):"},{"line_number":19,"context_line":"    def discover(self, manager, param\u003dNone):"},{"line_number":20,"context_line":"        \"\"\"Return local node as resource.\"\"\""},{"line_number":21,"context_line":"        return [\u0027local_host\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_5abc2fbb","line":20,"updated":"2015-02-06 12:29:44.000000000","message":"why not to return CONF.host? (CONF.import_opt(\u0027host\u0027, \u0027ceilometer.service\u0027)). It seems to be correct... But I may be mistaken here...","commit_id":"b7426c545cfce328cf12b0258b2cf7aafdf26a01"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"ecbec23a0cc88213330482e54d193227e388f6aa","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class LocalNodeDiscovery(plugin_base.DiscoveryBase):"},{"line_number":19,"context_line":"    def discover(self, manager, param\u003dNone):"},{"line_number":20,"context_line":"        \"\"\"Return local node as resource.\"\"\""},{"line_number":21,"context_line":"        return [\u0027local_host\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_ca2208b8","line":20,"in_reply_to":"da86d52c_4abc58bb","updated":"2015-02-06 14:41:24.000000000","message":"IIUC, it can be any value, pollster doesn\u0027t use this resource","commit_id":"b7426c545cfce328cf12b0258b2cf7aafdf26a01"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"2aaae823a73caa0c39e28fe96daae018d5a6a2b5","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class LocalNodeDiscovery(plugin_base.DiscoveryBase):"},{"line_number":19,"context_line":"    def discover(self, manager, param\u003dNone):"},{"line_number":20,"context_line":"        \"\"\"Return local node as resource.\"\"\""},{"line_number":21,"context_line":"        return [\u0027local_host\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_0b731db2","line":20,"in_reply_to":"da86d52c_4abc58bb","updated":"2015-02-09 02:32:05.000000000","message":"It belongs to the pollster\u0027s name space, so not necessarily unique in the whole cloud. e.g. one Node Manager pollster\u0027s localhost resource broken, while IPMI pollster\u0027s localhost resource is still ok.","commit_id":"b7426c545cfce328cf12b0258b2cf7aafdf26a01"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"941021215961df381217603a36b2785ec1415918","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class LocalNodeDiscovery(plugin_base.DiscoveryBase):"},{"line_number":19,"context_line":"    def discover(self, manager, param\u003dNone):"},{"line_number":20,"context_line":"        \"\"\"Return local node as resource.\"\"\""},{"line_number":21,"context_line":"        return [\u0027local_host\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_4abc58bb","line":20,"in_reply_to":"da86d52c_5abc2fbb","updated":"2015-02-06 14:33:14.000000000","message":"same question i guess... does local_host mean anything or can it be any value?","commit_id":"b7426c545cfce328cf12b0258b2cf7aafdf26a01"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"dd30e4ca3af6392facf3d94983534c46025fff04","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class LocalNodeDiscovery(plugin_base.DiscoveryBase):"},{"line_number":19,"context_line":"    def discover(self, manager, param\u003dNone):"},{"line_number":20,"context_line":"        \"\"\"Return local node as resource.\"\"\""},{"line_number":21,"context_line":"        return [\u0027local_host\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_4da712bd","line":20,"in_reply_to":"da86d52c_ca2208b8","updated":"2015-02-06 14:54:09.000000000","message":"good enough for me i guess.","commit_id":"b7426c545cfce328cf12b0258b2cf7aafdf26a01"}],"ceilometer/ipmi/discovery.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"5040b1a6bda2893d94707dd078cc713f38c373bc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Intel"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Author: Zhai Edwin \u003cedwin.zhai@intel.com\u003e"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_aab69088","line":3,"updated":"2015-02-02 02:34:15.000000000","message":"please remove author tag since we agree to enable new hacking rules","commit_id":"efe215ed2715c8ff723d84436062e892a53147fc"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"ddd23d3199df36b1bd73225937e9a2167d50a501","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Intel"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Author: Zhai Edwin \u003cedwin.zhai@intel.com\u003e"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_25901395","line":3,"in_reply_to":"da86d52c_aab69088","updated":"2015-02-02 03:16:51.000000000","message":"ok. I\u0027ll clean other tags, in which I copied from.","commit_id":"efe215ed2715c8ff723d84436062e892a53147fc"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"5bc9439ca6e316026bbb5622393de61571891f56","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    def discover(self, manager, param\u003dNone):"},{"line_number":20,"context_line":"        \"\"\"Discover resources to monitor.\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"        # Make one dummy resource for identification"},{"line_number":23,"context_line":"        if param:"},{"line_number":24,"context_line":"            return [param]"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_8567634c","line":22,"updated":"2015-02-05 05:37:19.000000000","message":"why we need this? I think the whole point of this patch is to have a unified way to have all the pollsters to get the endpoint it needs to poll.\n\nSo how about rename this to IpmiLocalNodeDiscovery and just return a simple [\u0027localhost\u0027]?","commit_id":"492a7a030bcc387f22726382e29d3951e1f621dd"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"ce6aa2b4292c12fb3fa41bc76d9cf5704cd8eaaa","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    def discover(self, manager, param\u003dNone):"},{"line_number":20,"context_line":"        \"\"\"Discover resources to monitor.\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"        # Make one dummy resource for identification"},{"line_number":23,"context_line":"        if param:"},{"line_number":24,"context_line":"            return [param]"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_dba4dca7","line":22,"in_reply_to":"da86d52c_8567634c","updated":"2015-02-05 07:02:12.000000000","message":"ok.\n\nWill also rename it to LocalNodeDiscovery for generic reason.","commit_id":"492a7a030bcc387f22726382e29d3951e1f621dd"}],"ceilometer/ipmi/pollsters/node.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"22507628c0b923493dcc27823bb5b6a535ff7b76","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        \"\"\"Return data sample for IPMI.\"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":46,"context_line":"        for resource in resources:"},{"line_number":47,"context_line":"            stats \u003d self.read_data()"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"            metadata \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_ea76c8d7","line":46,"updated":"2015-02-02 02:39:06.000000000","message":"so you are not really using resource in the for loop, why don\u0027t you keep it untouched?","commit_id":"efe215ed2715c8ff723d84436062e892a53147fc"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"ddd23d3199df36b1bd73225937e9a2167d50a501","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        \"\"\"Return data sample for IPMI.\"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":46,"context_line":"        for resource in resources:"},{"line_number":47,"context_line":"            stats \u003d self.read_data()"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"            metadata \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_85d8df54","line":46,"in_reply_to":"da86d52c_ea76c8d7","updated":"2015-02-02 03:16:51.000000000","message":"Yes, we are not using the resource directly. But we need skip the polling if resources is empty. But given that we have check outside this function, I think we can safely remove it.","commit_id":"efe215ed2715c8ff723d84436062e892a53147fc"}],"ceilometer/ipmi/pollsters/sensor.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"22507628c0b923493dcc27823bb5b6a535ff7b76","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            return []"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def get_samples(self, manager, cache, resources):"},{"line_number":53,"context_line":"        for resource in resources:"},{"line_number":54,"context_line":"            stats \u003d self.ipmi.read_sensor_any(self.METRIC)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"            sensor_type_data \u003d self._get_sensor_types(stats, self.METRIC)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_8a4f0c92","line":53,"updated":"2015-02-02 02:39:06.000000000","message":"ditto","commit_id":"efe215ed2715c8ff723d84436062e892a53147fc"}]}