)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"73beefc614f81d0c689ac7c7401def66ff1cd19c","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch adds iops metrics implementation in Hyper-V Inspector as"},{"line_number":16,"context_line":"well as disk iops and per disk iops pollsters."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I1c6b5d1f3d8b490f0c839124be18deac86979ae7"},{"line_number":19,"context_line":"Implements: blueprint hyper-v-disk-iops-metrics"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa81d914_6241a8a8","line":17,"updated":"2015-01-30 14:31:05.000000000","message":"DocImpact","commit_id":"c02c9b3bb120dd613d182e40158dbf6dfcc96de2"}],"ceilometer/compute/pollsters/disk.py":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"7f82fc0d9005a85ec3e162ee1b4b54ec79f35c26","unresolved":false,"context_lines":[{"line_number":599,"context_line":"            except ceilometer.NotImplementedError:"},{"line_number":600,"context_line":"                # Selected inspector does not implement this pollster."},{"line_number":601,"context_line":"                LOG.debug(_(\u0027%(inspector)s does not provide data for \u0027"},{"line_number":602,"context_line":"                            \u0027 %(pollster)s\u0027),"},{"line_number":603,"context_line":"                          {\u0027inspector\u0027: self.inspector.__class__.__name__,"},{"line_number":604,"context_line":"                           \u0027pollster\u0027: self.__class__.__name__})"},{"line_number":605,"context_line":"            except Exception as err:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_2caa72d4","line":602,"updated":"2015-02-03 14:29:10.000000000","message":"odd space at the start of the quoted line 602.","commit_id":"8eaaffd329a8d9f1f6dec6231e8a6edb33dd79ad"}],"ceilometer/compute/virt/hyperv/utilsv2.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"73beefc614f81d0c689ac7c7401def66ff1cd19c","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            yield {"},{"line_number":157,"context_line":"                \u0027iops_count\u0027: metric_values[0],"},{"line_number":158,"context_line":"                \u0027instance_id\u0027: disk.InstanceID,"},{"line_number":159,"context_line":"                \u0027host_resource\u0027: host_resource"},{"line_number":160,"context_line":"            }"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa81d914_228250c8","line":159,"updated":"2015-01-30 14:31:05.000000000","message":"host_resource isn\u0027t used in the Inspector.","commit_id":"c02c9b3bb120dd613d182e40158dbf6dfcc96de2"}],"ceilometer/tests/compute/pollsters/test_diskio.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"73beefc614f81d0c689ac7c7401def66ff1cd19c","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        cache \u003d {}"},{"line_number":296,"context_line":"        samples \u003d list(pollster.get_samples(mgr, cache, self.instance))"},{"line_number":297,"context_line":"        self.assertIsNotEmpty(samples)"},{"line_number":298,"context_line":"        self.assertIsNotNone(samples)"},{"line_number":299,"context_line":"        self.assertIn(pollster.CACHE_KEY_DISK_IOPS, cache)"},{"line_number":300,"context_line":"        for instance in self.instance:"},{"line_number":301,"context_line":"            self.assertIn(instance.id, cache[pollster.CACHE_KEY_DISK_IOPS])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa81d914_229ed007","line":298,"updated":"2015-01-30 14:31:05.000000000","message":"assertIsNotNone before assertIsNotEmpty?","commit_id":"c02c9b3bb120dd613d182e40158dbf6dfcc96de2"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"7f82fc0d9005a85ec3e162ee1b4b54ec79f35c26","unresolved":false,"context_lines":[{"line_number":327,"context_line":"         virt_inspector.DiskIOPSStats(10)),"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        (virt_inspector.Disk(device\u003d\u0027disk2\u0027),"},{"line_number":330,"context_line":"         virt_inspector.DiskIOPSStats(20))"},{"line_number":331,"context_line":"    ]"},{"line_number":332,"context_line":"    TYPE \u003d \u0027gauge\u0027"},{"line_number":333,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_2c1432f4","line":330,"updated":"2015-02-03 14:29:10.000000000","message":"it is good practice to finish the last item in array with comma, so it will be nice if you add one at the end of line 330","commit_id":"8eaaffd329a8d9f1f6dec6231e8a6edb33dd79ad"}],"ceilometer/tests/compute/virt/hyperv/test_utilsv2.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"73beefc614f81d0c689ac7c7401def66ff1cd19c","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        disk_metrics \u003d list(self._utils.get_disk_iops_count(fake_vm_name))"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        self.assertEqual(1, len(disk_metrics))"},{"line_number":173,"context_line":"        self.assertEqual(fake_iops_count, disk_metrics[0][\u0027iops_count\u0027])"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def test_get_metric_value_instances(self):"},{"line_number":176,"context_line":"        mock_el1 \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa81d914_6204484a","line":173,"updated":"2015-01-30 14:31:05.000000000","message":"also assert instance_id?","commit_id":"c02c9b3bb120dd613d182e40158dbf6dfcc96de2"}]}
