)]}'
{"ceilometer/event/endpoint.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"157f014c19416dbc16430a1b7599bbde9af41bd2","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        # NOTE: the rpc layer currently rips out the notification"},{"line_number":72,"context_line":"        # delivery_info, which is critical to determining the"},{"line_number":73,"context_line":"        # source of the notification. This will have to get added back later."},{"line_number":74,"context_line":"        notification \u003d messaging.convert_to_old_notification_format("},{"line_number":75,"context_line":"            \u0027error\u0027, ctxt, publisher_id, event_type, payload, metadata)"},{"line_number":76,"context_line":"        self.process_notification(notification)"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_1429ab9a","line":74,"updated":"2015-02-06 14:00:06.000000000","message":"Would it make sense to refactor the code to avoid the duplication between this and the \u0027info\u0027 functions?","commit_id":"c857a9b9b9f8cfab668dd2c50251e0fc239688f6"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"373b1fa45d139fb84bb36038bb8daafaf94e9dea","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        # NOTE: the rpc layer currently rips out the notification"},{"line_number":72,"context_line":"        # delivery_info, which is critical to determining the"},{"line_number":73,"context_line":"        # source of the notification. This will have to get added back later."},{"line_number":74,"context_line":"        notification \u003d messaging.convert_to_old_notification_format("},{"line_number":75,"context_line":"            \u0027error\u0027, ctxt, publisher_id, event_type, payload, metadata)"},{"line_number":76,"context_line":"        self.process_notification(notification)"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_caa04892","line":74,"in_reply_to":"da86d52c_1429ab9a","updated":"2015-02-06 14:34:12.000000000","message":"the duplicate code are only two lines.... main part is doc and comment, and docstring should be added separately even they are almost/excatly same\n\nso I think it is ok","commit_id":"c857a9b9b9f8cfab668dd2c50251e0fc239688f6"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"18f307829d4172db96bd8bdbd19d7bf417fe4e9f","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # NOTE: the rpc layer currently rips out the notification"},{"line_number":72,"context_line":"        # delivery_info, which is critical to determining the"},{"line_number":73,"context_line":"        # source of the notification. This will have to get added back later."},{"line_number":74,"context_line":"        notification \u003d messaging.convert_to_old_notification_format("},{"line_number":75,"context_line":"            \u0027error\u0027, ctxt, publisher_id, event_type, payload, metadata)"},{"line_number":76,"context_line":"        self.process_notification(notification)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_36a9e5df","line":73,"updated":"2015-02-10 11:12:26.000000000","message":"Added back later via a change to oslo.messaging?","commit_id":"f7ed2c2a16e8dded6bd2258ea0a5e5954a13bada"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"0c152a8d7c5ab4f1d4c8d0b8d978a7088708090c","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # NOTE: the rpc layer currently rips out the notification"},{"line_number":72,"context_line":"        # delivery_info, which is critical to determining the"},{"line_number":73,"context_line":"        # source of the notification. This will have to get added back later."},{"line_number":74,"context_line":"        notification \u003d messaging.convert_to_old_notification_format("},{"line_number":75,"context_line":"            \u0027error\u0027, ctxt, publisher_id, event_type, payload, metadata)"},{"line_number":76,"context_line":"        self.process_notification(notification)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_7fa64ec2","line":73,"in_reply_to":"da86d52c_36a9e5df","updated":"2015-02-12 20:36:16.000000000","message":"tbh, i didn\u0027t look much into this... i think sileht would be the best person for context.","commit_id":"f7ed2c2a16e8dded6bd2258ea0a5e5954a13bada"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"74b86d3fc76420f616cda351b310e9e0e996052b","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # NOTE: the rpc layer currently rips out the notification"},{"line_number":72,"context_line":"        # delivery_info, which is critical to determining the"},{"line_number":73,"context_line":"        # source of the notification. This will have to get added back later."},{"line_number":74,"context_line":"        notification \u003d messaging.convert_to_old_notification_format("},{"line_number":75,"context_line":"            \u0027error\u0027, ctxt, publisher_id, event_type, payload, metadata)"},{"line_number":76,"context_line":"        self.process_notification(notification)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_289bfac9","line":73,"in_reply_to":"da86d52c_7fa64ec2","updated":"2015-02-18 16:51:48.000000000","message":"OK, I\u0027ll follow up with sileht when he\u0027s back.","commit_id":"f7ed2c2a16e8dded6bd2258ea0a5e5954a13bada"}]}