)]}'
{"ceilometer/agent/base.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"0b5406813502c4c4d7144aed2179d1c96a5d4c40","unresolved":false,"context_lines":[{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def stop(self):"},{"line_number":267,"context_line":"        for group in self._get_partitioning_groups():"},{"line_number":268,"context_line":"            self.partition_coordinator.leave_group(group)"},{"line_number":269,"context_line":"        super(AgentManager, self).stop()"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_7bb12746","line":268,"updated":"2015-02-12 07:15:30.000000000","message":"To make it more clean and tidy, maybe we should add a stop() method in coordination.py and call self.partition_coordinator.stop() here?","commit_id":"41a56f3f0c3ecbf665e00b172cb815e1a12cbcf1"}],"ceilometer/notification.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"fab6b85314f12c5a1ee08c69c69a73b213c683ff","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    NOTIFICATION_IPC \u003d \u0027ceilometer-pipe\u0027"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":74,"context_line":"        super(NotificationService, self).__init__()"},{"line_number":75,"context_line":"        self.partition_coordinator \u003d coordination.PartitionCoordinator()"},{"line_number":76,"context_line":"        self.listeners \u003d self.pipeline_listeners \u003d []"},{"line_number":77,"context_line":"        self.group_id \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_8822d8a0","line":74,"updated":"2015-02-06 15:50:54.000000000","message":"i would think args/kwargs should be passed on.\n\ni\u0027m just wondering why this is needed?","commit_id":"6b6a9e74bfceb121191e9d6e969612bf8a1c6e78"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"01088a09350b222cc9ea2ea5466a7fa41958e802","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    NOTIFICATION_IPC \u003d \u0027ceilometer-pipe\u0027"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":74,"context_line":"        super(NotificationService, self).__init__()"},{"line_number":75,"context_line":"        self.partition_coordinator \u003d coordination.PartitionCoordinator()"},{"line_number":76,"context_line":"        self.listeners \u003d self.pipeline_listeners \u003d []"},{"line_number":77,"context_line":"        self.group_id \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_b73febb4","line":74,"in_reply_to":"da86d52c_8822d8a0","updated":"2015-02-07 00:40:25.000000000","message":"miss that..\n\nI\u0027m not sure if you mean why this patch is needed or why this line is needed, so answer both\n\nthe patch is needed is because I found if os_service.Service.start fails or somewhere in self.start() fails, the self.stop() will be called, but at that time, the self.partition_coordinator, self.listerner, self.pipeline_listeners and self.group_id may not be added as an attribute yet, which will cause exception and super.stop() will never be called\n\nthis line is needed because it is a good practice to always call super.__init__(), especially when parent has defined __init__, although we don\u0027t use there potential arguments yet","commit_id":"6b6a9e74bfceb121191e9d6e969612bf8a1c6e78"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"145f9636a993f6db98ac9f4a300afa75f13cfbce","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":74,"context_line":"        super(NotificationService, self).__init__(*args, **kwargs)"},{"line_number":75,"context_line":"        self.partition_coordinator \u003d coordination.PartitionCoordinator()"},{"line_number":76,"context_line":"        self.listeners \u003d self.pipeline_listeners \u003d []"},{"line_number":77,"context_line":"        self.group_id \u003d None"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_44bebb00","line":76,"updated":"2015-02-09 22:26:33.000000000","message":"this won\u0027t work with multiple workers... all the workers will end up sharing the same coordinator, listener lists","commit_id":"73817d02e17416628bb735240da9c1c0546456f6"}]}