)]}'
{"ceilometer/ipmi/platform/intel_node_manager.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"89a96198fdd3584d0186f12f3d4cac1e31c371d1","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"IPMICMD \u003d {\"sdr_dump\": \"sdr dump\","},{"line_number":48,"context_line":"           \"sdr_info\": \"sdr info\","},{"line_number":49,"context_line":"           \"sensor_dump\": \"sdr -v\"}"},{"line_number":50,"context_line":"IPMIRAWCMD \u003d {\"get_device_id\": \"raw 0x06 0x01\","},{"line_number":51,"context_line":"              \"get_nm_version\": \"raw 0x2e 0xca 0x57 0x01 0x00\","},{"line_number":52,"context_line":"              \"init_sensor_agent\": \"raw 0x0a 0x2c 0x01\","}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_84c32e37","line":49,"updated":"2015-02-17 14:41:20.000000000","message":"is there a link where we can reference for the items below?","commit_id":"45bbc45cd471c8610881985ee129ab4fba7adea4"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"b05d7fb6847d62b12639347f5b72ff76b55857b2","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"IPMICMD \u003d {\"sdr_dump\": \"sdr dump\","},{"line_number":48,"context_line":"           \"sdr_info\": \"sdr info\","},{"line_number":49,"context_line":"           \"sensor_dump\": \"sdr -v\"}"},{"line_number":50,"context_line":"IPMIRAWCMD \u003d {\"get_device_id\": \"raw 0x06 0x01\","},{"line_number":51,"context_line":"              \"get_nm_version\": \"raw 0x2e 0xca 0x57 0x01 0x00\","},{"line_number":52,"context_line":"              \"init_sensor_agent\": \"raw 0x0a 0x2c 0x01\","}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_5973bd7f","line":49,"in_reply_to":"da86d52c_84c32e37","updated":"2015-03-03 07:27:00.000000000","message":"http://www.intel.de/content/dam/www/public/us/en/documents/technical-specifications/intelligent-power-node-manager-specification.pdf","commit_id":"45bbc45cd471c8610881985ee129ab4fba7adea4"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"89a96198fdd3584d0186f12f3d4cac1e31c371d1","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            # across all pollsters"},{"line_number":158,"context_line":"            self.nm_version \u003d -1"},{"line_number":159,"context_line":"            self.channel_slave \u003d \u0027\u0027"},{"line_number":160,"context_line":"            self._inited \u003d True"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"            self.nm_version \u003d self.check_node_manager()"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_84a96e26","line":160,"updated":"2015-02-17 14:41:20.000000000","message":"this should really be first in list step to minimise race.","commit_id":"45bbc45cd471c8610881985ee129ab4fba7adea4"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"b05d7fb6847d62b12639347f5b72ff76b55857b2","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            # across all pollsters"},{"line_number":158,"context_line":"            self.nm_version \u003d -1"},{"line_number":159,"context_line":"            self.channel_slave \u003d \u0027\u0027"},{"line_number":160,"context_line":"            self._inited \u003d True"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"            self.nm_version \u003d self.check_node_manager()"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_b3a7784f","line":160,"in_reply_to":"da86d52c_84a96e26","updated":"2015-03-03 07:27:00.000000000","message":"good point.","commit_id":"45bbc45cd471c8610881985ee129ab4fba7adea4"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"89a96198fdd3584d0186f12f3d4cac1e31c371d1","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        # only available after NM 3.0"},{"line_number":273,"context_line":"        if self.nm_version \u003e\u003d 5:"},{"line_number":274,"context_line":"            return self._read_airflow()"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        return {}"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def read_cups_utilization(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_ef1f6359","line":275,"updated":"2015-02-17 14:41:20.000000000","message":"you could make these inline\n\nreturn self._read_airflow() if self.nm_version \u003e\u003d 5 else {}","commit_id":"45bbc45cd471c8610881985ee129ab4fba7adea4"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"b05d7fb6847d62b12639347f5b72ff76b55857b2","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        # only available after NM 3.0"},{"line_number":273,"context_line":"        if self.nm_version \u003e\u003d 5:"},{"line_number":274,"context_line":"            return self._read_airflow()"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        return {}"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def read_cups_utilization(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_136a04ee","line":275,"in_reply_to":"da86d52c_ef1f6359","updated":"2015-03-03 07:27:00.000000000","message":"ok.","commit_id":"45bbc45cd471c8610881985ee129ab4fba7adea4"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"53d26554871bd1dfdc88e195edb2d5dc5cee23fd","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        return self._read_inlet_temperature() if self.nm_version \u003e 0 else {}"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def read_outlet_temperature(self):"},{"line_number":273,"context_line":"        return self._read_outlet_temperature() if self.nm_version \u003e\u003d 5 else {}"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def read_airflow(self):"},{"line_number":276,"context_line":"        # only available after NM 3.0"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_3472bde5","line":273,"updated":"2015-03-05 21:46:35.000000000","message":"this appears to need nm3.0 as well... i don\u0027t know where a good place to denote this is but i guess for now we\u0027ll have to duplicate message?","commit_id":"8a16911a9da8481092d6c824e0e8b4045eebf854"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"30255c71672710383efa4774925e1bce83832341","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        return self._read_inlet_temperature() if self.nm_version \u003e 0 else {}"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def read_outlet_temperature(self):"},{"line_number":273,"context_line":"        return self._read_outlet_temperature() if self.nm_version \u003e\u003d 5 else {}"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def read_airflow(self):"},{"line_number":276,"context_line":"        # only available after NM 3.0"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_ba676224","line":273,"in_reply_to":"9a80dd14_3472bde5","updated":"2015-03-06 08:28:23.000000000","message":"For now, I think it\u0027s okay as not so many functions. Probably need data structure for each function to indicate required version in future.","commit_id":"8a16911a9da8481092d6c824e0e8b4045eebf854"}],"ceilometer/ipmi/platform/ipmitool.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"89a96198fdd3584d0186f12f3d4cac1e31c371d1","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    if \"translate\" in template:"},{"line_number":98,"context_line":"        ret \u003d _translate_output(output)"},{"line_number":99,"context_line":"    else:"},{"line_number":100,"context_line":"        output_list \u003d output.strip().replace(\u0027\\n\u0027, \u0027\u0027).split(\u0027 \u0027)"},{"line_number":101,"context_line":"        if sum(template.values()) !\u003d len(output_list):"},{"line_number":102,"context_line":"            raise ipmiexcept.IPMIException(_(\"ipmitool output \""},{"line_number":103,"context_line":"                                             \"length mismatch\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_0f5af729","line":100,"updated":"2015-02-17 14:41:20.000000000","message":"i don\u0027t get why this is needed... strip should deal with \\n","commit_id":"45bbc45cd471c8610881985ee129ab4fba7adea4"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"b05d7fb6847d62b12639347f5b72ff76b55857b2","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    if \"translate\" in template:"},{"line_number":98,"context_line":"        ret \u003d _translate_output(output)"},{"line_number":99,"context_line":"    else:"},{"line_number":100,"context_line":"        output_list \u003d output.strip().replace(\u0027\\n\u0027, \u0027\u0027).split(\u0027 \u0027)"},{"line_number":101,"context_line":"        if sum(template.values()) !\u003d len(output_list):"},{"line_number":102,"context_line":"            raise ipmiexcept.IPMIException(_(\"ipmitool output \""},{"line_number":103,"context_line":"                                             \"length mismatch\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_3e5a6f2a","line":100,"in_reply_to":"da86d52c_0f5af729","updated":"2015-03-03 07:27:00.000000000","message":"\u0027\\n\u0027 is probably in the middle of string, which can\u0027t be removed by strip.\n\ngzhai@gzhai-cloud:~/aa$ cat z.str.py\n\nout \u003d \" 03 00 00 00 01\\n 00 00 00 00 07\\n\"\nprint out\nprint \"\u003d\u003d\u003d\u003d\"\nprint out.strip().split(\u0027 \u0027)\nprint \"\u003d\u003d\u003d\u003d\"\nprint out.strip().replace(\u0027\\n\u0027, \u0027\u0027).split(\u0027 \u0027)\n\n\ngzhai@gzhai-cloud:~/aa$ python z.str.py\n 03 00 00 00 01\n 00 00 00 00 07\n\n\u003d\u003d\u003d\u003d\n[\u002703\u0027, \u002700\u0027, \u002700\u0027, \u002700\u0027, \u002701\\n\u0027, \u002700\u0027, \u002700\u0027, \u002700\u0027, \u002700\u0027, \u002707\u0027]\n\u003d\u003d\u003d\u003d\n[\u002703\u0027, \u002700\u0027, \u002700\u0027, \u002700\u0027, \u002701\u0027, \u002700\u0027, \u002700\u0027, \u002700\u0027, \u002700\u0027, \u002707\u0027]","commit_id":"45bbc45cd471c8610881985ee129ab4fba7adea4"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"1fc6be63fc1b78685389ce4c1ac7c88162cb68c1","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    if \"translate\" in template:"},{"line_number":98,"context_line":"        ret \u003d _translate_output(output)"},{"line_number":99,"context_line":"    else:"},{"line_number":100,"context_line":"        output_list \u003d output.strip().replace(\u0027\\n\u0027, \u0027\u0027).split(\u0027 \u0027)"},{"line_number":101,"context_line":"        if sum(template.values()) !\u003d len(output_list):"},{"line_number":102,"context_line":"            raise ipmiexcept.IPMIException(_(\"ipmitool output \""},{"line_number":103,"context_line":"                                             \"length mismatch\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_40d07d50","line":100,"in_reply_to":"da86d52c_0f5af729","updated":"2015-02-21 13:49:40.000000000","message":"Agree with gordon it seems to be an odd change.","commit_id":"45bbc45cd471c8610881985ee129ab4fba7adea4"}],"ceilometer/ipmi/pollsters/node.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"89a96198fdd3584d0186f12f3d4cac1e31c371d1","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.polling_failures \u003d 0"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        # Do not load this extension if no NM support"},{"line_number":45,"context_line":"        if self.nodemanager.nm_version \u003c 0:"},{"line_number":46,"context_line":"            raise plugin_base.ExtensionLoadError()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_4fbeaf01","line":45,"updated":"2015-02-17 14:41:20.000000000","message":"is there actually a version \u003d\u003d 0?","commit_id":"45bbc45cd471c8610881985ee129ab4fba7adea4"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"b05d7fb6847d62b12639347f5b72ff76b55857b2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.polling_failures \u003d 0"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        # Do not load this extension if no NM support"},{"line_number":45,"context_line":"        if self.nodemanager.nm_version \u003c 0:"},{"line_number":46,"context_line":"            raise plugin_base.ExtensionLoadError()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_3ee0aff9","line":45,"in_reply_to":"da86d52c_4fbeaf01","updated":"2015-03-03 07:27:00.000000000","message":"There is no version \u003d\u003d 0, but to flag \"no support\" we use \"-1\" instead. Just in case nm_version is used without initialization by accident.","commit_id":"45bbc45cd471c8610881985ee129ab4fba7adea4"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"1fc6be63fc1b78685389ce4c1ac7c88162cb68c1","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def get_value(self, stats):"},{"line_number":53,"context_line":"        \"\"\"Get value from statistics.\"\"\""},{"line_number":54,"context_line":"        return node_manager._hex(stats[\"Current_value\"])"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @abc.abstractmethod"},{"line_number":57,"context_line":"    def read_data(self, cache):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_c052addc","line":54,"updated":"2015-02-21 13:49:40.000000000","message":"it seems that here you  should use self.nodemanager instead of node_manager wdyt?","commit_id":"45bbc45cd471c8610881985ee129ab4fba7adea4"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"b05d7fb6847d62b12639347f5b72ff76b55857b2","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def get_value(self, stats):"},{"line_number":53,"context_line":"        \"\"\"Get value from statistics.\"\"\""},{"line_number":54,"context_line":"        return node_manager._hex(stats[\"Current_value\"])"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @abc.abstractmethod"},{"line_number":57,"context_line":"    def read_data(self, cache):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_7ecce789","line":54,"in_reply_to":"ba7be1f8_c052addc","updated":"2015-03-03 07:27:00.000000000","message":"node_manager is the alias of intel_node_manager python module. We need share _hex function.","commit_id":"45bbc45cd471c8610881985ee129ab4fba7adea4"}],"ceilometer/tests/ipmi/platform/test_intel_node_manager.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"89a96198fdd3584d0186f12f3d4cac1e31c371d1","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        self.nm \u003d node_manager.NodeManager()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def tearDownClass(cls):"},{"line_number":34,"context_line":"        # reset inited to force an initialization of singleton for next test"},{"line_number":35,"context_line":"        node_manager.NodeManager()._inited \u003d False"},{"line_number":36,"context_line":"        super(TestNodeManagerV3, cls).tearDownClass()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_4f206ff8","line":33,"updated":"2015-02-17 14:41:20.000000000","message":"worth having a common base between testnodemanager and testnodemanagerv3?","commit_id":"45bbc45cd471c8610881985ee129ab4fba7adea4"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"b05d7fb6847d62b12639347f5b72ff76b55857b2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        self.nm \u003d node_manager.NodeManager()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def tearDownClass(cls):"},{"line_number":34,"context_line":"        # reset inited to force an initialization of singleton for next test"},{"line_number":35,"context_line":"        node_manager.NodeManager()._inited \u003d False"},{"line_number":36,"context_line":"        super(TestNodeManagerV3, cls).tearDownClass()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_9ec19b31","line":33,"in_reply_to":"da86d52c_4f206ff8","updated":"2015-03-03 07:27:00.000000000","message":"ok.","commit_id":"45bbc45cd471c8610881985ee129ab4fba7adea4"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"53d26554871bd1dfdc88e195edb2d5dc5cee23fd","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def init_test_engine(self):"},{"line_number":102,"context_line":"        utils.execute \u003d mock.Mock(side_effect\u003dfake_utils.execute_with_nm_v2)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def test_read_power_all(self):"},{"line_number":105,"context_line":"        power \u003d self.nm.read_power_all()"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        avg_val \u003d node_manager._hex(power[\"Average_value\"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_941b691a","line":104,"updated":"2015-03-05 21:46:35.000000000","message":"should we test for v3 support too?","commit_id":"8a16911a9da8481092d6c824e0e8b4045eebf854"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"30255c71672710383efa4774925e1bce83832341","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def init_test_engine(self):"},{"line_number":102,"context_line":"        utils.execute \u003d mock.Mock(side_effect\u003dfake_utils.execute_with_nm_v2)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def test_read_power_all(self):"},{"line_number":105,"context_line":"        power \u003d self.nm.read_power_all()"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        avg_val \u003d node_manager._hex(power[\"Average_value\"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_5a94a6e1","line":104,"in_reply_to":"9a80dd14_941b691a","updated":"2015-03-06 08:28:23.000000000","message":"Tested same function across different versions only when it has different behavior. That is, test it on the version introducing it, and previous version where get nothing.\n\nIt\u0027s a balance of duplicated code and test coverage.","commit_id":"8a16911a9da8481092d6c824e0e8b4045eebf854"}],"ceilometer/tests/ipmi/pollsters/base.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"53d26554871bd1dfdc88e195edb2d5dc5cee23fd","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def fake_data(self):"},{"line_number":29,"context_line":"        \"\"\"Fake data used for test.\"\"\""},{"line_number":30,"context_line":"        return None"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def fake_sensor_data(self, sensor_type):"},{"line_number":33,"context_line":"        \"\"\"Fake sensor data used for test.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_af7742d3","line":30,"updated":"2015-03-05 21:46:35.000000000","message":"a method that returns nothing implicitly returns None already","commit_id":"8a16911a9da8481092d6c824e0e8b4045eebf854"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"30255c71672710383efa4774925e1bce83832341","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def fake_data(self):"},{"line_number":29,"context_line":"        \"\"\"Fake data used for test.\"\"\""},{"line_number":30,"context_line":"        return None"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def fake_sensor_data(self, sensor_type):"},{"line_number":33,"context_line":"        \"\"\"Fake sensor data used for test.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_3a50d25d","line":30,"in_reply_to":"9a80dd14_af7742d3","updated":"2015-03-06 08:28:23.000000000","message":"got it.\nThanks.","commit_id":"8a16911a9da8481092d6c824e0e8b4045eebf854"}],"ceilometer/tests/ipmi/pollsters/test_node.py":[{"author":{"_account_id":13273,"name":"Lena Novokshonova","email":"enovokshonova@mirantis.com","username":"enovokshonova"},"change_message_id":"fc9ec48b50173913695fe6b0158d52d6da3b5773","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        # data after parsing Intel Node Manager output"},{"line_number":72,"context_line":"        return {\"Current_value\": [\u0027be\u0027, \u002700\u0027]}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def fake_sensor_data(self, sensor_type):"},{"line_number":75,"context_line":"        # No use for this test"},{"line_number":76,"context_line":"        return None"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_3bdd1315","line":74,"updated":"2015-02-18 13:05:01.000000000","message":"Why this function is needed? If it\u0027s not needed remove please...","commit_id":"45bbc45cd471c8610881985ee129ab4fba7adea4"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"89a96198fdd3584d0186f12f3d4cac1e31c371d1","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def fake_sensor_data(self, sensor_type):"},{"line_number":75,"context_line":"        # No use for this test"},{"line_number":76,"context_line":"        return None"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def make_pollster(self):"},{"line_number":79,"context_line":"        return node.AirflowPollster()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_4faa2f1b","line":76,"updated":"2015-02-17 14:41:20.000000000","message":"i don\u0027t get why this is None everywhere... why don\u0027t we just get rid of it?","commit_id":"45bbc45cd471c8610881985ee129ab4fba7adea4"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"b05d7fb6847d62b12639347f5b72ff76b55857b2","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def fake_sensor_data(self, sensor_type):"},{"line_number":75,"context_line":"        # No use for this test"},{"line_number":76,"context_line":"        return None"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def make_pollster(self):"},{"line_number":79,"context_line":"        return node.AirflowPollster()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_3eeb4f79","line":76,"in_reply_to":"da86d52c_4faa2f1b","updated":"2015-03-03 07:27:00.000000000","message":"I probably need reorg the classes. Will do it.","commit_id":"45bbc45cd471c8610881985ee129ab4fba7adea4"},{"author":{"_account_id":13273,"name":"Lena Novokshonova","email":"enovokshonova@mirantis.com","username":"enovokshonova"},"change_message_id":"fc9ec48b50173913695fe6b0158d52d6da3b5773","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        # data after parsing Intel Node Manager output"},{"line_number":93,"context_line":"        return {\"CUPS_Index\": [\u00272e\u0027, \u002700\u0027]}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def fake_sensor_data(self, sensor_type):"},{"line_number":96,"context_line":"        # No use for this test"},{"line_number":97,"context_line":"        return None"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_bbd023f8","line":95,"updated":"2015-02-18 13:05:01.000000000","message":"ditto","commit_id":"45bbc45cd471c8610881985ee129ab4fba7adea4"},{"author":{"_account_id":13273,"name":"Lena Novokshonova","email":"enovokshonova@mirantis.com","username":"enovokshonova"},"change_message_id":"fc9ec48b50173913695fe6b0158d52d6da3b5773","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        return {\"CPU_Utilization\":"},{"line_number":115,"context_line":"                [\u002733\u0027, \u002700\u0027, \u002700\u0027, \u002700\u0027, \u002700\u0027, \u002700\u0027, \u002700\u0027, \u002700\u0027]}"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def fake_sensor_data(self, sensor_type):"},{"line_number":118,"context_line":"        # No use for this test"},{"line_number":119,"context_line":"        return None"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_fbd61bf1","line":117,"updated":"2015-02-18 13:05:01.000000000","message":"ditto","commit_id":"45bbc45cd471c8610881985ee129ab4fba7adea4"},{"author":{"_account_id":13273,"name":"Lena Novokshonova","email":"enovokshonova@mirantis.com","username":"enovokshonova"},"change_message_id":"fc9ec48b50173913695fe6b0158d52d6da3b5773","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        return {\"Mem_Utilization\":"},{"line_number":137,"context_line":"                [\u002705\u0027, \u002700\u0027, \u002700\u0027, \u002700\u0027, \u002700\u0027, \u002700\u0027, \u002700\u0027, \u002700\u0027]}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def fake_sensor_data(self, sensor_type):"},{"line_number":140,"context_line":"        # No use for this test"},{"line_number":141,"context_line":"        return None"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_9bffdf65","line":139,"updated":"2015-02-18 13:05:01.000000000","message":"ditto","commit_id":"45bbc45cd471c8610881985ee129ab4fba7adea4"},{"author":{"_account_id":13273,"name":"Lena Novokshonova","email":"enovokshonova@mirantis.com","username":"enovokshonova"},"change_message_id":"fc9ec48b50173913695fe6b0158d52d6da3b5773","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        return {\"IO_Utilization\":"},{"line_number":159,"context_line":"                [\u002700\u0027, \u002700\u0027, \u002700\u0027, \u002700\u0027, \u002700\u0027, \u002700\u0027, \u002700\u0027, \u002700\u0027]}"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def fake_sensor_data(self, sensor_type):"},{"line_number":162,"context_line":"        # No use for this test"},{"line_number":163,"context_line":"        return None"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_dbf4f788","line":161,"updated":"2015-02-18 13:05:01.000000000","message":"ditto","commit_id":"45bbc45cd471c8610881985ee129ab4fba7adea4"}]}