)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"93fb74a6b5d7f51729b4154c706d4f3e944b4087","unresolved":false,"context_lines":[{"line_number":15,"context_line":"This also permits to add these new alarm rules into the documentation."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"And add some tests that cannot be done on the gnocchi side."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I1bbc9f904d55b51cd1b3c51dcdfaf58f01bd9075"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_47742136","line":18,"updated":"2015-02-14 13:41:26.000000000","message":"DocImpact\n\nAPIImpact","commit_id":"9f5893b02cbfe218171e5d7d4c474e75ee15e70d"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f1e394fbaa545ec4a5aa9e5c6dded4baa6998284","unresolved":false,"context_lines":[{"line_number":15,"context_line":"This also permits to add these new alarm rules into the documentation."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"And add some tests that cannot be done on the gnocchi side."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I1bbc9f904d55b51cd1b3c51dcdfaf58f01bd9075"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba7be1f8_f0dbedea","line":18,"in_reply_to":"da86d52c_47742136","updated":"2015-02-23 10:09:23.000000000","message":"I\u0027m not aware about APIImpact, What the underlying process behind that ?","commit_id":"9f5893b02cbfe218171e5d7d4c474e75ee15e70d"}],"ceilometer/alarm/evaluator/gnocchi.py":[{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"28e957e9e3d0619b36190315a1bf9532ed0f314d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import datetime"},{"line_number":17,"context_line":"import operator"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from ceilometer.alarm import evaluator"},{"line_number":20,"context_line":"from ceilometer.i18n import _"},{"line_number":21,"context_line":"from ceilometer.openstack.common import log"},{"line_number":22,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_5c9ed4b9","line":19,"updated":"2015-02-16 16:18:53.000000000","message":"Imports should be ordered accordingly pep8 rules. \nFirstly native libraries, next third party and ceilometer modules in last block.","commit_id":"9f5893b02cbfe218171e5d7d4c474e75ee15e70d"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f1e394fbaa545ec4a5aa9e5c6dded4baa6998284","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import datetime"},{"line_number":17,"context_line":"import operator"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from ceilometer.alarm import evaluator"},{"line_number":20,"context_line":"from ceilometer.i18n import _"},{"line_number":21,"context_line":"from ceilometer.openstack.common import log"},{"line_number":22,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_d0ec2992","line":19,"in_reply_to":"da86d52c_5c9ed4b9","updated":"2015-02-23 10:09:23.000000000","message":"Done","commit_id":"9f5893b02cbfe218171e5d7d4c474e75ee15e70d"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"93fb74a6b5d7f51729b4154c706d4f3e944b4087","unresolved":false,"context_lines":[{"line_number":39,"context_line":"}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"gnocchi_opts \u003d ["},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027gnocchi_url\u0027,"},{"line_number":43,"context_line":"               default\u003d\"http://localhost:8041\","},{"line_number":44,"context_line":"               help\u003d\u0027URL to Gnocchi.\u0027),"},{"line_number":45,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_e7851508","line":42,"updated":"2015-02-14 13:41:26.000000000","message":"you need to list it in ceilometer/opts.py","commit_id":"9f5893b02cbfe218171e5d7d4c474e75ee15e70d"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f1e394fbaa545ec4a5aa9e5c6dded4baa6998284","unresolved":false,"context_lines":[{"line_number":39,"context_line":"}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"gnocchi_opts \u003d ["},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027gnocchi_url\u0027,"},{"line_number":43,"context_line":"               default\u003d\"http://localhost:8041\","},{"line_number":44,"context_line":"               help\u003d\u0027URL to Gnocchi.\u0027),"},{"line_number":45,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_9099d121","line":42,"in_reply_to":"da86d52c_e7851508","updated":"2015-02-23 10:09:23.000000000","message":"Done","commit_id":"9f5893b02cbfe218171e5d7d4c474e75ee15e70d"}],"ceilometer/alarm/utils.py":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"adba5eaac1e4f18ef0a158d04f3b26a6340d9786","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba7be1f8_20ac69a0","line":1,"updated":"2015-02-21 14:02:28.000000000","message":"Do we need that module?","commit_id":"9f5893b02cbfe218171e5d7d4c474e75ee15e70d"}],"ceilometer/api/controllers/v2/alarm_rules/gnocchi.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"93fb74a6b5d7f51729b4154c706d4f3e944b4087","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- encoding: utf-8 -*-"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2015 eNovance"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_a7923d49","line":1,"updated":"2015-02-14 13:41:26.000000000","message":"we decide to remove this line, even it seems useful...","commit_id":"9f5893b02cbfe218171e5d7d4c474e75ee15e70d"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f1e394fbaa545ec4a5aa9e5c6dded4baa6998284","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- encoding: utf-8 -*-"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2015 eNovance"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_c6b1d3e2","line":1,"in_reply_to":"da86d52c_a7923d49","updated":"2015-02-23 10:09:23.000000000","message":"Done","commit_id":"9f5893b02cbfe218171e5d7d4c474e75ee15e70d"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"b5b6d66be7e629789fb66cabd712663d06d2706f","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                   \u0027X-Auth-Token\u0027: ks_client.auth_token}"},{"line_number":72,"context_line":"        try:"},{"line_number":73,"context_line":"            r \u003d requests.get(\"%s/v1/capabilities\" % gnocchi_url,"},{"line_number":74,"context_line":"                             headers\u003dheaders)"},{"line_number":75,"context_line":"        except requests.ConnectionError as e:"},{"line_number":76,"context_line":"            raise GnocchiUnavailable(e)"},{"line_number":77,"context_line":"        if r.status_code // 200 !\u003d 1:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_b831330d","line":74,"updated":"2015-03-02 16:42:14.000000000","message":"Btw I think this is going to be a wrong check. This checks what capabilities the server is capable of doing, but not the capabilities that the archive policy is configured to use once https://review.openstack.org/#/c/154108/ goes in.\n\nBut for now it\u0027s good :)","commit_id":"4eedba6e80f9743f5d0e06245790d73ee386b38d"}],"ceilometer/keystone_client.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"93fb74a6b5d7f51729b4154c706d4f3e944b4087","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_e79c3560","line":1,"updated":"2015-02-14 13:41:26.000000000","message":"by who?","commit_id":"9f5893b02cbfe218171e5d7d4c474e75ee15e70d"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f1e394fbaa545ec4a5aa9e5c6dded4baa6998284","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_3094a5e1","line":1,"in_reply_to":"da86d52c_e79c3560","updated":"2015-02-23 10:09:23.000000000","message":"Done","commit_id":"9f5893b02cbfe218171e5d7d4c474e75ee15e70d"}],"ceilometer/tests/alarm/evaluator/test_gnocchi.py":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"adba5eaac1e4f18ef0a158d04f3b26a6340d9786","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2014 eNovance"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Authors: Mehdi Abaakouk \u003cmehdi.abaakouk@enovance.com\u003e"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_40ba3ddf","line":2,"updated":"2015-02-21 14:02:28.000000000","message":"s/2014/2015","commit_id":"9f5893b02cbfe218171e5d7d4c474e75ee15e70d"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f1e394fbaa545ec4a5aa9e5c6dded4baa6998284","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2014 eNovance"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Authors: Mehdi Abaakouk \u003cmehdi.abaakouk@enovance.com\u003e"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_90c0f1e1","line":2,"in_reply_to":"ba7be1f8_40ba3ddf","updated":"2015-02-23 10:09:23.000000000","message":"Done","commit_id":"9f5893b02cbfe218171e5d7d4c474e75ee15e70d"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"93fb74a6b5d7f51729b4154c706d4f3e944b4087","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2014 eNovance"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Authors: Mehdi Abaakouk \u003cmehdi.abaakouk@enovance.com\u003e"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":7,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_c7973139","line":4,"updated":"2015-02-14 13:41:26.000000000","message":"remove the tag ?\n\nseems hacking not detect authors yet....","commit_id":"9f5893b02cbfe218171e5d7d4c474e75ee15e70d"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f1e394fbaa545ec4a5aa9e5c6dded4baa6998284","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2014 eNovance"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Authors: Mehdi Abaakouk \u003cmehdi.abaakouk@enovance.com\u003e"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":7,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_70bd3d68","line":4,"in_reply_to":"da86d52c_c7973139","updated":"2015-02-23 10:09:23.000000000","message":"Done","commit_id":"9f5893b02cbfe218171e5d7d4c474e75ee15e70d"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"93fb74a6b5d7f51729b4154c706d4f3e944b4087","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        ks_client \u003d mock.Mock(auth_token\u003d\u0027fake_token\u0027)"},{"line_number":51,"context_line":"        ks_client.users.find.return_value \u003d \u0027gnocchi\u0027"},{"line_number":52,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":53,"context_line":"            \u0027ceilometer.keystone_client.ksclient.Client\u0027,"},{"line_number":54,"context_line":"            return_value\u003dks_client))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        super(TestGnocchiThresholdEvaluate, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_47ab4175","line":53,"updated":"2015-02-14 13:41:26.000000000","message":"mock original instead: keystoneclient.v2_0.client.Client?","commit_id":"9f5893b02cbfe218171e5d7d4c474e75ee15e70d"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f1e394fbaa545ec4a5aa9e5c6dded4baa6998284","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        ks_client \u003d mock.Mock(auth_token\u003d\u0027fake_token\u0027)"},{"line_number":51,"context_line":"        ks_client.users.find.return_value \u003d \u0027gnocchi\u0027"},{"line_number":52,"context_line":"        self.useFixture(mockpatch.Patch("},{"line_number":53,"context_line":"            \u0027ceilometer.keystone_client.ksclient.Client\u0027,"},{"line_number":54,"context_line":"            return_value\u003dks_client))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        super(TestGnocchiThresholdEvaluate, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_c6363352","line":53,"in_reply_to":"da86d52c_47ab4175","updated":"2015-02-23 10:09:23.000000000","message":"Done","commit_id":"9f5893b02cbfe218171e5d7d4c474e75ee15e70d"}]}