)]}'
{"id":"openstack%2Fceilometer~15622","triplet_id":"openstack%2Fceilometer~master~I33a98c228d45f7716e46d40d9203188f4e827c11","project":"openstack/ceilometer","branch":"master","topic":"bug/1075463","hashtags":[],"change_id":"I33a98c228d45f7716e46d40d9203188f4e827c11","subject":"Adopted the oslo\u0027s rpc.Service change.","status":"MERGED","created":"2012-11-11 18:15:01.000000000","updated":"2012-11-15 04:02:06.000000000","submitted":"2012-11-15 04:02:06.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"017dadaa7bedc2c3fe8bb7396108482519ddb201","_number":15622,"virtual_id_number":15622,"owner":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},{"value":0,"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},{"value":0,"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":2,"date":"2012-11-15 04:02:06.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"all":[{"value":2,"date":"2012-11-15 03:58:40.000000000","_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},{"value":0,"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},{"value":0,"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"all":[{"value":1,"date":"2012-11-15 03:58:40.000000000","_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},{"value":0,"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},{"value":0,"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-11-11 18:15:01.000000000","updated_by":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"reviewer":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"state":"REVIEWER"},{"updated":"2012-11-15 03:58:40.000000000","updated_by":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"reviewer":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"state":"REVIEWER"},{"updated":"2012-11-15 04:02:06.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ae034d3fbe9d6326d35b13167beee9a99aea03aa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-11 18:15:01.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/15622/1/check/gate-ceilometer-merge/680 : SUCCESS\n- http://logs.openstack.org/15622/1/check/gate-ceilometer-pep8/676 : SUCCESS\n- http://logs.openstack.org/15622/1/check/gate-ceilometer-python26/676 : SUCCESS\n- http://logs.openstack.org/15622/1/check/gate-ceilometer-python27/678 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"0f3ba7c19ebc2975944ba9ed9514f230c2fb892c","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2012-11-11 18:15:01.000000000","message":"Patch Set 1: (2 inline comments)\n\nThanks for your answers! Don\u0027t forgot to fix the commit message too, that\u0027d be nice. :)\n\nYes, it\u0027s better to resubmit this when openstack-common is fixed too so we\u0027re sure it\u0027s accepted there.","accounts_in_message":[],"_revision_number":1},{"id":"3074fcbeb23771656ae7b122f3b0b0f29c31780d","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2012-11-11 18:15:01.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(4 inline comments)\n\nSee my inline comments :)","accounts_in_message":[],"_revision_number":1},{"id":"fd11c0018a86b11c90e9a1d8fb135f8222b29002","author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"date":"2012-11-11 18:15:01.000000000","message":"Patch Set 1: (2 inline comments)\n\nI\u0027ve created a patch for openstack-common. Should I submit this only after the openstack-common accpet that patch?","accounts_in_message":[],"_revision_number":1},{"id":"4462c72cd007d8a3fde61ac2950a56bb3a1581e3","author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"date":"2012-11-11 18:15:01.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nSo the openstack-common/* part needs to be first submitted\nto the openstack-common project then merged across to ceilometer.\n\n(so I have no objection to the code change, just we don\u0027t want to diverge from common).\n\nSee: http://wiki.openstack.org/CommonLibrary\n\n\"Projects which are using such incubating APIs must avoid ever modifying their copies of the code. All changes should be made in openstack-common itself and copied into the project.\"","accounts_in_message":[],"_revision_number":1},{"id":"778ca95bd4e92cbe1b66511f336006c7c3bf3f4e","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2012-11-14 16:22:22.000000000","message":"Patch Set 1:\n\nChange has been merged in oslo (under a different form), so this could be updated and be merged soon! :)","accounts_in_message":[],"_revision_number":1},{"id":"4d18ee2d7a36766cb4c501a91765179b4524e50f","author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"date":"2012-11-15 03:55:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"3d239de11d3bfad408d59b6ee49f616a26cbd912","author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"date":"2012-11-15 03:58:40.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"a14112001ee3d48627ed29000b50c1e7881cbcc4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-15 03:58:47.000000000","message":"Patch Set 2:\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":2},{"id":"8fdd9eb018b601e4f9fabf832f448b013c1fea5d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-15 03:59:05.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/15622/2/check/gate-ceilometer-merge/724 : SUCCESS\n- http://logs.openstack.org/15622/2/check/gate-ceilometer-pep8/719 : SUCCESS\n- http://logs.openstack.org/15622/2/check/gate-ceilometer-python26/719 : SUCCESS\n- http://logs.openstack.org/15622/2/check/gate-ceilometer-python27/721 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"fde727d41f1f14d13e4411900c27e09f32685900","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-15 04:02:06.000000000","message":"Patch Set 2: Verified\n\nBuild successful\n\n- http://logs.openstack.org/15622/2/gate/gate-ceilometer-merge/725 : SUCCESS\n- http://logs.openstack.org/15622/2/gate/gate-ceilometer-pep8/720 : SUCCESS\n- http://logs.openstack.org/15622/2/gate/gate-ceilometer-python26/720 : SUCCESS\n- http://logs.openstack.org/15622/2/gate/gate-ceilometer-python27/722 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"7f0fae0e439585733059c465b2ad5109550d279f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-15 04:02:06.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2b30965869701fbbb5ed03b020820f7e04274748","revisions":{"ead7975cd7946809d62a664eb599232769f1262a":{"kind":"REWORK","_number":1,"created":"2012-11-11 18:15:01.000000000","uploader":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"ref":"refs/changes/22/15622/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/22/15622/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/22/15622/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/22/15622/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/22/15622/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/22/15622/1"}}},"commit":{"parents":[{"commit":"a5f966c5fb873fde9122e30b37dfde685d596e10","subject":"Merge \"document utc naive timestamp\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/a5f966c5fb873fde9122e30b37dfde685d596e10"}]}],"author":{"name":"Lianhao Lu","email":"lianhao.lu@intel.com","date":"2012-11-08 08:28:16.000000000","tz":480},"committer":{"name":"Lianhao Lu","email":"lianhao.lu@intel.com","date":"2012-11-08 08:28:16.000000000","tz":480},"subject":"Added pre_consume_hook for rpc.Service.","message":"Added pre_consume_hook for rpc.Service.\n\nThis fixes the collector part of the bug 1075463.\n\nDeclaring a consumer topic on the same rpc connection after the consume\nthread has started would result the eventlet raise RuntimeError\nexception. So all the declaring work should be done before calling\nrpc.conn.consume_in_thread().\n\nIf the manager of the rpc.Service wants to declare other topic consumers\nthan the default ones created by rpc.Service.start(), it could define\nthe following hook in the manager class:\n\n  def pre_consume_hook(self, service):\n    # delcare addtional consumer topics\n\nThe service paramter is the handle to the rpc.Service instance.\n\nChange-Id: I33a98c228d45f7716e46d40d9203188f4e827c11\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/ead7975cd7946809d62a664eb599232769f1262a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/ead7975cd7946809d62a664eb599232769f1262a"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"a5f966c5fb873fde9122e30b37dfde685d596e10","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"2b30965869701fbbb5ed03b020820f7e04274748":{"kind":"REWORK","_number":2,"created":"2012-11-15 03:55:00.000000000","uploader":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"ref":"refs/changes/22/15622/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/22/15622/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/22/15622/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/22/15622/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/22/15622/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/22/15622/2"}}},"commit":{"parents":[{"commit":"7e595e8f2885fc706230ba4145b76405bdeec36b","subject":"Use libvirt num_cpu for CPU utilization calculation.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/7e595e8f2885fc706230ba4145b76405bdeec36b"}]}],"author":{"name":"Lianhao Lu","email":"lianhao.lu@intel.com","date":"2012-11-08 08:28:16.000000000","tz":480},"committer":{"name":"Lianhao Lu","email":"lianhao.lu@intel.com","date":"2012-11-15 03:50:30.000000000","tz":480},"subject":"Adopted the oslo\u0027s rpc.Service change.","message":"Adopted the oslo\u0027s rpc.Service change.\n\nThis fixes the collector part of the bug 1075463.\n\nDeclaring a consumer topic on the same rpc connection after the consume\nthread has started would result the eventlet raise RuntimeError\nexception. So all the declaring work should be done before calling\nrpc.conn.consume_in_thread().\n\nUsing the hook \u0027initialize_service_hook()\u0027 provided by rpc.Service in\noslo to decalre the collector\u0027s specific topic consumers before starting\nthe consuming thread.\n\nChange-Id: I33a98c228d45f7716e46d40d9203188f4e827c11\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/2b30965869701fbbb5ed03b020820f7e04274748"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/2b30965869701fbbb5ed03b020820f7e04274748"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"7e595e8f2885fc706230ba4145b76405bdeec36b","is_merged_in_target_branch":true,"change_id":"I23e2ad30696f11f413fd1570fe85c3a12fb0bf1e","change_number":16079,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}