)]}'
{"ceilometer/agent/plugin_base.py":[{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"746e906c970f1d4f6112c02c4dd84417f9f820a9","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    meters."},{"line_number":196,"context_line":"    \"\"\""},{"line_number":197,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":198,"context_line":"        super(NonMetricNotificationBase, self).__init__(*args, **kwargs)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"class ExtensionLoadError(Exception):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_44c0862a","line":198,"updated":"2015-02-23 00:53:18.000000000","message":"do you really need this constructor? Seems like you could have:\n\nNonMetricNotificationBase \u003d object\n\nor with the \u0027pass\u0027 in the class below.","commit_id":"3e09898212a9b04b7f60859195a2711f2af95d7f"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"81a4a6547f5994618511d5c7e6f3f68eba815eb1","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    meters."},{"line_number":196,"context_line":"    \"\"\""},{"line_number":197,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":198,"context_line":"        super(NonMetricNotificationBase, self).__init__(*args, **kwargs)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"class ExtensionLoadError(Exception):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_655e0f78","line":198,"in_reply_to":"ba7be1f8_44c0862a","updated":"2015-02-24 22:07:31.000000000","message":"testing now","commit_id":"3e09898212a9b04b7f60859195a2711f2af95d7f"}],"ceilometer/notification.py":[{"author":{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},"change_message_id":"7ce92a0c5cb67759524f5e40873c18c64ed6f8fe","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                deprecated_group\u003d\u0027collector\u0027,"},{"line_number":42,"context_line":"                default\u003dFalse,"},{"line_number":43,"context_line":"                help\u003d\u0027Save event details.\u0027),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027store_events_as_samples\u0027,"},{"line_number":45,"context_line":"                default\u003dFalse,"},{"line_number":46,"context_line":"                help\u003d\u0027Store stupidity.\u0027),"},{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027workload_partitioning\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_f33740fc","line":44,"updated":"2015-02-17 21:28:19.000000000","message":"I would change the name of this to:\nstore_exist_notification_as_events\nThere is already an option to store all the notification as events. The difference here is how you treat the exist notifications.","commit_id":"f83d2bc8ce61b3d4204f375bc07fc3db70f3477c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"6b031e38f650ed9b35a350906851d20ef4ddf6d1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                deprecated_group\u003d\u0027collector\u0027,"},{"line_number":42,"context_line":"                default\u003dFalse,"},{"line_number":43,"context_line":"                help\u003d\u0027Save event details.\u0027),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027store_events_as_samples\u0027,"},{"line_number":45,"context_line":"                default\u003dFalse,"},{"line_number":46,"context_line":"                help\u003d\u0027Store stupidity.\u0027),"},{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027workload_partitioning\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_82a94b7e","line":44,"in_reply_to":"da86d52c_2e7c0b20","updated":"2015-02-17 22:05:57.000000000","message":"sure... or disable_non_metric_meters?","commit_id":"f83d2bc8ce61b3d4204f375bc07fc3db70f3477c"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"fe2fc705867c68995f939e4fa874d95e6c2bfd16","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                deprecated_group\u003d\u0027collector\u0027,"},{"line_number":42,"context_line":"                default\u003dFalse,"},{"line_number":43,"context_line":"                help\u003d\u0027Save event details.\u0027),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027store_events_as_samples\u0027,"},{"line_number":45,"context_line":"                default\u003dFalse,"},{"line_number":46,"context_line":"                help\u003d\u0027Store stupidity.\u0027),"},{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027workload_partitioning\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_565e2c46","line":44,"in_reply_to":"da86d52c_82a94b7e","updated":"2015-02-18 07:25:43.000000000","message":"I like this one as it is a bit shorter and maybe more understandable. I still think that it requires a brief explanation in the help string just to be sure that users get the point. :)","commit_id":"f83d2bc8ce61b3d4204f375bc07fc3db70f3477c"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"93fb6b65d53da2baa78b3632b3158f54caf8ef91","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                deprecated_group\u003d\u0027collector\u0027,"},{"line_number":42,"context_line":"                default\u003dFalse,"},{"line_number":43,"context_line":"                help\u003d\u0027Save event details.\u0027),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027store_events_as_samples\u0027,"},{"line_number":45,"context_line":"                default\u003dFalse,"},{"line_number":46,"context_line":"                help\u003d\u0027Store stupidity.\u0027),"},{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027workload_partitioning\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_2e7c0b20","line":44,"in_reply_to":"da86d52c_f33740fc","updated":"2015-02-17 21:44:47.000000000","message":"It\u0027s not just about the existence, but all the create|delete|update|etc. meters/events too. But maybe the opposite version would be more informative though. I mean smth like \u0027disable_store_events_as_samples\u0027. As the default behaviour is to store all meters that are available, therefore the config option should disable this portion of the default mechanism.","commit_id":"f83d2bc8ce61b3d4204f375bc07fc3db70f3477c"},{"author":{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},"change_message_id":"7ce92a0c5cb67759524f5e40873c18c64ed6f8fe","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                default\u003dFalse,"},{"line_number":43,"context_line":"                help\u003d\u0027Save event details.\u0027),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027store_events_as_samples\u0027,"},{"line_number":45,"context_line":"                default\u003dFalse,"},{"line_number":46,"context_line":"                help\u003d\u0027Store stupidity.\u0027),"},{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027workload_partitioning\u0027,"},{"line_number":48,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_2e3a4bcd","line":45,"updated":"2015-02-17 21:28:19.000000000","message":"I don\u0027t want to enter in the argument if storing exist notifications as sample is stupid or not, but I just want to point out that you are breaking backward compatibility with an optional param.\nNow if Ceilometer is updated, and configuration is not changed, there will be missing data in the sample. This could be hard to debug as well as frustrating for people using Ceilometer.\nI would recommend to preserve the default behavior and enable to configure differently if wanted/needed.","commit_id":"f83d2bc8ce61b3d4204f375bc07fc3db70f3477c"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"93fb6b65d53da2baa78b3632b3158f54caf8ef91","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                default\u003dFalse,"},{"line_number":43,"context_line":"                help\u003d\u0027Save event details.\u0027),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027store_events_as_samples\u0027,"},{"line_number":45,"context_line":"                default\u003dFalse,"},{"line_number":46,"context_line":"                help\u003d\u0027Store stupidity.\u0027),"},{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027workload_partitioning\u0027,"},{"line_number":48,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_8ed417ea","line":45,"in_reply_to":"da86d52c_2e3a4bcd","updated":"2015-02-17 21:44:47.000000000","message":"The problem here is visibility, but I understand the backward compatibility concern. This can be highlighted in docco, or maybe in the logs too, just not in a too verbose way. If the event collection is turned on, then the data will be there, but it will not be duplicated anymore.","commit_id":"f83d2bc8ce61b3d4204f375bc07fc3db70f3477c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"dbae8620693708e798975e711dae531b7305b9e0","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                default\u003dFalse,"},{"line_number":43,"context_line":"                help\u003d\u0027Save event details.\u0027),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027store_events_as_samples\u0027,"},{"line_number":45,"context_line":"                default\u003dFalse,"},{"line_number":46,"context_line":"                help\u003d\u0027Store stupidity.\u0027),"},{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027workload_partitioning\u0027,"},{"line_number":48,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_0abab30a","line":45,"in_reply_to":"da86d52c_56770cd4","updated":"2015-02-18 15:08:25.000000000","message":"i\u0027ll add a log.\n\ni personally don\u0027t understand the backward compatibility concern (for openstack in general) but i\u0027m a nihilist. :)","commit_id":"f83d2bc8ce61b3d4204f375bc07fc3db70f3477c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"6b031e38f650ed9b35a350906851d20ef4ddf6d1","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                default\u003dFalse,"},{"line_number":43,"context_line":"                help\u003d\u0027Save event details.\u0027),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027store_events_as_samples\u0027,"},{"line_number":45,"context_line":"                default\u003dFalse,"},{"line_number":46,"context_line":"                help\u003d\u0027Store stupidity.\u0027),"},{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027workload_partitioning\u0027,"},{"line_number":48,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_a25baf20","line":45,"in_reply_to":"da86d52c_8ed417ea","updated":"2015-02-17 22:05:57.000000000","message":"so i\u0027m not adamant on having this either true or false i just put false because i was testing it. i think we do need a way so operators know without a doubt that they are doing something that will probably crash their meter db.\n\nhow about i force it to throw a LOG each time we build a non-metric meter","commit_id":"f83d2bc8ce61b3d4204f375bc07fc3db70f3477c"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"fe2fc705867c68995f939e4fa874d95e6c2bfd16","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                default\u003dFalse,"},{"line_number":43,"context_line":"                help\u003d\u0027Save event details.\u0027),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027store_events_as_samples\u0027,"},{"line_number":45,"context_line":"                default\u003dFalse,"},{"line_number":46,"context_line":"                help\u003d\u0027Store stupidity.\u0027),"},{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027workload_partitioning\u0027,"},{"line_number":48,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_56770cd4","line":45,"in_reply_to":"da86d52c_a25baf20","updated":"2015-02-18 07:25:43.000000000","message":"Yeap, logging was in my head too. I think we could point them to the events DB even in the logs, but it was just a quick idea. The rest of the ways of communicating this is not as effective as logs IMHO.","commit_id":"f83d2bc8ce61b3d4204f375bc07fc3db70f3477c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"9a4a6117db14d031a8e2b019cb77635239b16522","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                help\u003d\u0027Save event details.\u0027),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027store_events_as_samples\u0027,"},{"line_number":45,"context_line":"                default\u003dFalse,"},{"line_number":46,"context_line":"                help\u003d\u0027Store stupidity.\u0027),"},{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027workload_partitioning\u0027,"},{"line_number":48,"context_line":"                default\u003dFalse,"},{"line_number":49,"context_line":"                help\u003d\u0027Enable workload partitioning, allowing multiple \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_c8a0c7f6","line":46,"updated":"2015-02-17 20:42:59.000000000","message":"i will fix this.","commit_id":"f83d2bc8ce61b3d4204f375bc07fc3db70f3477c"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"d453fa58f8c2e1aecbac0bdc531f6626ceab4de1","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                default\u003dFalse,"},{"line_number":43,"context_line":"                help\u003d\u0027Save event details.\u0027),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027disable_non_metric_meters\u0027,"},{"line_number":45,"context_line":"                default\u003dFalse,"},{"line_number":46,"context_line":"                help\u003d\u0027WARNING: Ceilometer historically offered the ability to \u0027"},{"line_number":47,"context_line":"                     \u0027store events as meters. With the improvements to \u0027"},{"line_number":48,"context_line":"                     \u0027events, this usage is NOT advised as it can flood the \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_8f2b0281","line":45,"updated":"2015-02-18 20:51:38.000000000","message":"Plan is to change the default to True in Liberty?","commit_id":"e5c98d5677026b5f855731f6908ef9b72da7fa77"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"60e82b8284d34f48a981f0acb2455ed4992c53ee","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                default\u003dFalse,"},{"line_number":43,"context_line":"                help\u003d\u0027Save event details.\u0027),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027disable_non_metric_meters\u0027,"},{"line_number":45,"context_line":"                default\u003dFalse,"},{"line_number":46,"context_line":"                help\u003d\u0027WARNING: Ceilometer historically offered the ability to \u0027"},{"line_number":47,"context_line":"                     \u0027store events as meters. With the improvements to \u0027"},{"line_number":48,"context_line":"                     \u0027events, this usage is NOT advised as it can flood the \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_6260a535","line":45,"in_reply_to":"da86d52c_8f2b0281","updated":"2015-02-18 21:35:56.000000000","message":"I hope so. :)\n\nDo we plan any deprecation, like turning it to True by default in Liberty and then remove the \u0027M\u0027 release?","commit_id":"e5c98d5677026b5f855731f6908ef9b72da7fa77"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"b421da07f4187abfa928000d0f420d8843323b10","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                default\u003dFalse,"},{"line_number":43,"context_line":"                help\u003d\u0027Save event details.\u0027),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027disable_non_metric_meters\u0027,"},{"line_number":45,"context_line":"                default\u003dFalse,"},{"line_number":46,"context_line":"                help\u003d\u0027WARNING: Ceilometer historically offered the ability to \u0027"},{"line_number":47,"context_line":"                     \u0027store events as meters. With the improvements to \u0027"},{"line_number":48,"context_line":"                     \u0027events, this usage is NOT advised as it can flood the \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_c236b150","line":45,"in_reply_to":"da86d52c_8f2b0281","updated":"2015-02-18 21:40:03.000000000","message":"liberty seems like a safe middle ground. i\u0027ll note this in msg","commit_id":"e5c98d5677026b5f855731f6908ef9b72da7fa77"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"60e82b8284d34f48a981f0acb2455ed4992c53ee","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                help\u003d\u0027WARNING: Ceilometer historically offered the ability to \u0027"},{"line_number":47,"context_line":"                     \u0027store events as meters. With the improvements to \u0027"},{"line_number":48,"context_line":"                     \u0027events, this usage is NOT advised as it can flood the \u0027"},{"line_number":49,"context_line":"                     \u0027metering database and cause performance degradation.\u0027),"},{"line_number":50,"context_line":"    cfg.BoolOpt(\u0027workload_partitioning\u0027,"},{"line_number":51,"context_line":"                default\u003dFalse,"},{"line_number":52,"context_line":"                help\u003d\u0027Enable workload partitioning, allowing multiple \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_a29b7d15","line":49,"updated":"2015-02-18 21:35:56.000000000","message":"Maybe add a half sentence for stating the obvious that change this to True will stop the collection of this data. Just for making it bullet proof. Not a must if you don\u0027t agree.","commit_id":"e5c98d5677026b5f855731f6908ef9b72da7fa77"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"b421da07f4187abfa928000d0f420d8843323b10","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                help\u003d\u0027WARNING: Ceilometer historically offered the ability to \u0027"},{"line_number":47,"context_line":"                     \u0027store events as meters. With the improvements to \u0027"},{"line_number":48,"context_line":"                     \u0027events, this usage is NOT advised as it can flood the \u0027"},{"line_number":49,"context_line":"                     \u0027metering database and cause performance degradation.\u0027),"},{"line_number":50,"context_line":"    cfg.BoolOpt(\u0027workload_partitioning\u0027,"},{"line_number":51,"context_line":"                default\u003dFalse,"},{"line_number":52,"context_line":"                help\u003d\u0027Enable workload partitioning, allowing multiple \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_056533e0","line":49,"in_reply_to":"da86d52c_a29b7d15","updated":"2015-02-18 21:40:03.000000000","message":"fair enough.","commit_id":"e5c98d5677026b5f855731f6908ef9b72da7fa77"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"60e82b8284d34f48a981f0acb2455ed4992c53ee","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        if not cfg.CONF.notification.disable_non_metric_meters:"},{"line_number":152,"context_line":"            LOG.warning(_LW(\u0027Non-metric meters may be collected. It is highly \u0027"},{"line_number":153,"context_line":"                            \u0027advisable to disable these meters using in \u0027"},{"line_number":154,"context_line":"                            \u0027ceilometer.conf or the pipeline.yaml\u0027))"},{"line_number":155,"context_line":"        # Add a dummy thread to have wait() working"},{"line_number":156,"context_line":"        self.tg.add_timer(604800, lambda: None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_e26c9538","line":153,"updated":"2015-02-18 21:35:56.000000000","message":"I think it should be either \u0027using\u0027 or \u0027in\u0027.","commit_id":"e5c98d5677026b5f855731f6908ef9b72da7fa77"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"b421da07f4187abfa928000d0f420d8843323b10","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        if not cfg.CONF.notification.disable_non_metric_meters:"},{"line_number":152,"context_line":"            LOG.warning(_LW(\u0027Non-metric meters may be collected. It is highly \u0027"},{"line_number":153,"context_line":"                            \u0027advisable to disable these meters using in \u0027"},{"line_number":154,"context_line":"                            \u0027ceilometer.conf or the pipeline.yaml\u0027))"},{"line_number":155,"context_line":"        # Add a dummy thread to have wait() working"},{"line_number":156,"context_line":"        self.tg.add_timer(604800, lambda: None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_65742f9c","line":153,"in_reply_to":"da86d52c_e26c9538","updated":"2015-02-18 21:40:03.000000000","message":"you\u0027re right.","commit_id":"e5c98d5677026b5f855731f6908ef9b72da7fa77"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"d453fa58f8c2e1aecbac0bdc531f6626ceab4de1","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        for ext in notification_manager:"},{"line_number":173,"context_line":"            handler \u003d ext.obj"},{"line_number":174,"context_line":"            if (cfg.CONF.notification.disable_non_metric_meters and"},{"line_number":175,"context_line":"                    isinstance(handler, base.NonMetricNotificationBase)):"},{"line_number":176,"context_line":"                continue"},{"line_number":177,"context_line":"            LOG.debug(_(\u0027Event types from %(name)s: %(type)s\u0027"},{"line_number":178,"context_line":"                        \u0027 (ack_on_error\u003d%(error)s)\u0027) %"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_cf6fbac2","line":175,"updated":"2015-02-18 20:51:38.000000000","message":"Should we log a warning the first time a non-metric notification is dropped?\n\nJust a left-field idea ... should we require that notification.store_events is also true before dropping the notification on the floor?","commit_id":"e5c98d5677026b5f855731f6908ef9b72da7fa77"},{"author":{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},"change_message_id":"fadf7b51eb0645be58e538abb7614151d8b3e342","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        for ext in notification_manager:"},{"line_number":173,"context_line":"            handler \u003d ext.obj"},{"line_number":174,"context_line":"            if (cfg.CONF.notification.disable_non_metric_meters and"},{"line_number":175,"context_line":"                    isinstance(handler, base.NonMetricNotificationBase)):"},{"line_number":176,"context_line":"                continue"},{"line_number":177,"context_line":"            LOG.debug(_(\u0027Event types from %(name)s: %(type)s\u0027"},{"line_number":178,"context_line":"                        \u0027 (ack_on_error\u003d%(error)s)\u0027) %"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_c16f8a26","line":175,"in_reply_to":"da86d52c_42ff2102","updated":"2015-02-19 00:19:39.000000000","message":"I think it should be independent. One thing is that you want notifications as events the other is to drop \"exist/non metric\" events.","commit_id":"e5c98d5677026b5f855731f6908ef9b72da7fa77"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"60e82b8284d34f48a981f0acb2455ed4992c53ee","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        for ext in notification_manager:"},{"line_number":173,"context_line":"            handler \u003d ext.obj"},{"line_number":174,"context_line":"            if (cfg.CONF.notification.disable_non_metric_meters and"},{"line_number":175,"context_line":"                    isinstance(handler, base.NonMetricNotificationBase)):"},{"line_number":176,"context_line":"                continue"},{"line_number":177,"context_line":"            LOG.debug(_(\u0027Event types from %(name)s: %(type)s\u0027"},{"line_number":178,"context_line":"                        \u0027 (ack_on_error\u003d%(error)s)\u0027) %"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_227dcdb2","line":175,"in_reply_to":"da86d52c_cf6fbac2","updated":"2015-02-18 21:35:56.000000000","message":"Maybe raise a warning or smth like, but the admins should be able to turn the collection of the meters off IMHO.","commit_id":"e5c98d5677026b5f855731f6908ef9b72da7fa77"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"b421da07f4187abfa928000d0f420d8843323b10","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        for ext in notification_manager:"},{"line_number":173,"context_line":"            handler \u003d ext.obj"},{"line_number":174,"context_line":"            if (cfg.CONF.notification.disable_non_metric_meters and"},{"line_number":175,"context_line":"                    isinstance(handler, base.NonMetricNotificationBase)):"},{"line_number":176,"context_line":"                continue"},{"line_number":177,"context_line":"            LOG.debug(_(\u0027Event types from %(name)s: %(type)s\u0027"},{"line_number":178,"context_line":"                        \u0027 (ack_on_error\u003d%(error)s)\u0027) %"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_42ff2102","line":175,"in_reply_to":"da86d52c_cf6fbac2","updated":"2015-02-18 21:40:03.000000000","message":"i made it (debatably) aggressive and logged  a warning just for not disabling the meters. see log in line 151\n\nsort of torn. i guess there\u0027s the duplication of context between non metric meters and events... but i sort of feel like the option itself is independent of it. ie operator doesn\u0027t want non-metric meters regardless of events or not.","commit_id":"e5c98d5677026b5f855731f6908ef9b72da7fa77"}]}