)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"f0830f634c8bf14707094acc8432b05db2ee5cd4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"add ability to dispatch events to http target"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"because it was requested. add support to http dispatch events."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ib9690658bcaff049d4fa910b5db82630741eb789"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_29938d5d","line":10,"updated":"2015-03-17 09:37:52.000000000","message":"soft -1: I think it is better to add DocImpact since new option is added","commit_id":"f2d43fd01f02774f77e58061ef90974c5b4d11e5"}],"ceilometer/dispatcher/http.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"13a957ec051d7d5fe6e51b06119abc9c9508d4dc","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            except Exception:"},{"line_number":126,"context_line":"                error_code \u003d res.status_code if res else \u0027unknown\u0027"},{"line_number":127,"context_line":"                LOG.exception(_LE(\u0027Status Code: %{code}s. Failed to dispatch \u0027"},{"line_number":128,"context_line":"                                  \u0027event: %{event}s\u0027),"},{"line_number":129,"context_line":"                              {\u0027code\u0027: error_code,"},{"line_number":130,"context_line":"                               \u0027event\u0027: event.serialize()})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_6dd958f2","line":128,"updated":"2015-02-26 04:05:18.000000000","message":"nit: maybe it is better if we print the Exception message as well","commit_id":"524f3fc0c7f7be85ed3d9b25c5f573e8fb5b5571"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"1626f16c0808385f44293e7dad060522fe1ba9ed","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            except Exception:"},{"line_number":126,"context_line":"                error_code \u003d res.status_code if res else \u0027unknown\u0027"},{"line_number":127,"context_line":"                LOG.exception(_LE(\u0027Status Code: %{code}s. Failed to dispatch \u0027"},{"line_number":128,"context_line":"                                  \u0027event: %{event}s\u0027),"},{"line_number":129,"context_line":"                              {\u0027code\u0027: error_code,"},{"line_number":130,"context_line":"                               \u0027event\u0027: event.serialize()})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_b330b1e9","line":128,"in_reply_to":"ba7be1f8_6dd958f2","updated":"2015-02-27 19:57:36.000000000","message":"as i understand it, the error message will be returned implicitly when using exception vs error\n\nhttps://docs.python.org/2/library/logging.html#logging.Logger.exception","commit_id":"524f3fc0c7f7be85ed3d9b25c5f573e8fb5b5571"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"54cf477cfe831c8cd21b2d85f81bd91b8675693a","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            res \u003d None"},{"line_number":121,"context_line":"            try:"},{"line_number":122,"context_line":"                res \u003d requests.post(self.target, data\u003devent.serialize(),"},{"line_number":123,"context_line":"                                    headers\u003dself.headers, timeout\u003dself.timeout)"},{"line_number":124,"context_line":"                res.raise_for_status()"},{"line_number":125,"context_line":"            except Exception:"},{"line_number":126,"context_line":"                error_code \u003d res.status_code if res else \u0027unknown\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_2f63521b","line":123,"updated":"2015-03-12 06:39:53.000000000","message":"I think we need a different target URL for event, otherwise we can\u0027t distinguish events from meters if we use them both","commit_id":"3b4a888fdecd79834a3170b8bd509b98d13c08ef"}],"ceilometer/tests/dispatcher/test_http.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"13a957ec051d7d5fe6e51b06119abc9c9508d4dc","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                                   [])"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        with mock.patch(\u0027ceilometer.dispatcher.http.LOG\u0027,"},{"line_number":155,"context_line":"                        mock.MagicMock())as LOG:"},{"line_number":156,"context_line":"            dispatcher.record_events(event)"},{"line_number":157,"context_line":"            self.assertTrue(LOG.exception.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_4d29f4e4","line":155,"updated":"2015-02-26 04:05:18.000000000","message":"nit: don\u0027t know why pep8 doesn\u0027t detect the required space before \u0027as\u0027","commit_id":"524f3fc0c7f7be85ed3d9b25c5f573e8fb5b5571"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"1626f16c0808385f44293e7dad060522fe1ba9ed","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                                   [])"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        with mock.patch(\u0027ceilometer.dispatcher.http.LOG\u0027,"},{"line_number":155,"context_line":"                        mock.MagicMock())as LOG:"},{"line_number":156,"context_line":"            dispatcher.record_events(event)"},{"line_number":157,"context_line":"            self.assertTrue(LOG.exception.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_f351490f","line":155,"in_reply_to":"ba7be1f8_4d29f4e4","updated":"2015-02-27 19:57:36.000000000","message":"Done","commit_id":"524f3fc0c7f7be85ed3d9b25c5f573e8fb5b5571"}]}