)]}'
{"ceilometer/agent/base.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"80776089075d871ee89b782df33e275477b6734f","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            namespaces \u003d [namespaces]"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        if len(namespaces) !\u003d len(set(namespaces)):"},{"line_number":223,"context_line":"            raise NamespacesDuplication(namespaces)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        # we\u0027ll have default [\u0027compute\u0027, \u0027central\u0027] here if no namespaces will"},{"line_number":226,"context_line":"        # be passed"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_255872f9","line":223,"updated":"2015-03-09 09:41:32.000000000","message":"I wonder if it wouldn\u0027t be better to remove duplications and add a log message about it here rather than throw an exception. What do you think?","commit_id":"78a3cd884a02367f097e7fa0ad9b88f19f0693f5"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"66b4570ffc14adfbb998b4c513ef21985264c9b5","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            namespaces \u003d [namespaces]"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        if len(namespaces) !\u003d len(set(namespaces)):"},{"line_number":223,"context_line":"            raise NamespacesDuplication(namespaces)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        # we\u0027ll have default [\u0027compute\u0027, \u0027central\u0027] here if no namespaces will"},{"line_number":226,"context_line":"        # be passed"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_cc8c6d38","line":223,"updated":"2015-03-06 03:47:55.000000000","message":"the same issue will exist in pollster-list\n\nmaybe it will be better to check in MultiChoicesOpt, which is defined by https://github.com/openstack/ceilometer/blob/1e5f830fe76b96731d7a95f2baf099a3334bbe3a/ceilometer/cmd/polling.py#L26","commit_id":"78a3cd884a02367f097e7fa0ad9b88f19f0693f5"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"b10fbb3182f817f8efde62c0147525b73e9e5623","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            namespaces \u003d [namespaces]"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        if len(namespaces) !\u003d len(set(namespaces)):"},{"line_number":223,"context_line":"            raise NamespacesDuplication(namespaces)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        # we\u0027ll have default [\u0027compute\u0027, \u0027central\u0027] here if no namespaces will"},{"line_number":226,"context_line":"        # be passed"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_32a480a5","line":223,"in_reply_to":"9a80dd14_cc8c6d38","updated":"2015-03-06 05:14:52.000000000","message":"1. Yeah, I have noticed that, but it is better to fix in a separated patch? I will do that :)\n\n2. I have considered that, but I didn\u0027t find any oslo related  implementation about this, but maybe your suggestion is better :) let we wait for other reviewers opinions :)","commit_id":"78a3cd884a02367f097e7fa0ad9b88f19f0693f5"}],"ceilometer/cmd/polling.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"c0512353487ca801dd2e2502c3b5a39a572127c2","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        if len(value) !\u003d len(set(value)):"},{"line_number":50,"context_line":"            LOG.warning(_LW(\"Duplicated values: %s found in CLI options, \""},{"line_number":51,"context_line":"                            \"auto de-duplidated\"), value)"},{"line_number":52,"context_line":"            value \u003d list(set(value))"},{"line_number":53,"context_line":"        return value"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_efc3fa35","line":52,"updated":"2015-03-12 06:26:47.000000000","message":"instead of hacking this, can we define a new type which inherits cfg.types.List() but only return the de-duplicated value? to follow oslo.config\u0027s routine?","commit_id":"2fcc3910d289b77535c8258fa6c954ac0d4c13d2"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"c5bafc65ebdc1d9973eb8bc729568933265885dc","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        if len(value) !\u003d len(set(value)):"},{"line_number":50,"context_line":"            LOG.warning(_LW(\"Duplicated values: %s found in CLI options, \""},{"line_number":51,"context_line":"                            \"auto de-duplidated\"), value)"},{"line_number":52,"context_line":"            value \u003d list(set(value))"},{"line_number":53,"context_line":"        return value"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_375529fa","line":52,"in_reply_to":"9a80dd14_efc3fa35","updated":"2015-03-13 09:13:59.000000000","message":"thanks for suggestion, done.","commit_id":"2fcc3910d289b77535c8258fa6c954ac0d4c13d2"}]}