)]}'
{"ceilometer/network/statistics/floatingip.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"0d03f7916c1bfe0f548b7a32c93e45fb9cbdbd9f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from ceilometer import sample"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class FloatingIPPollsterReceivePackets(statistics._Base):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    meter_name \u003d \u0027ip.floating.receive.packets\u0027"},{"line_number":24,"context_line":"    meter_type \u003d sample.TYPE_CUMULATIVE"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_c4ca9a4f","line":21,"updated":"2015-03-30 02:24:06.000000000","message":"Well, I don\u0027t think neither the opencontrail or the opendaylight driver support these pollsters now. Please see \n\nhttps://github.com/openstack/ceilometer/blob/master/ceilometer/network/statistics/opencontrail/driver.py#L87\n\nhttps://github.com/openstack/ceilometer/blob/master/ceilometer/network/statistics/opendaylight/driver.py#L184","commit_id":"db2c6b6be3aeb8a2fa2e3633f6b892bb2250f4d6"},{"author":{"_account_id":15680,"name":"Megh Bhatt","email":"meghb@juniper.net","username":"meghb"},"change_message_id":"07bc341ef6d38764307e3feba29426452be5f969","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from ceilometer import sample"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class FloatingIPPollsterReceivePackets(statistics._Base):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    meter_name \u003d \u0027ip.floating.receive.packets\u0027"},{"line_number":24,"context_line":"    meter_type \u003d sample.TYPE_CUMULATIVE"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aaa499b_d92a942c","line":21,"in_reply_to":"baa041b7_924a64c4","updated":"2015-04-11 00:50:14.000000000","message":"Hi Lianhoa,\nI\u0027ve updated the patch with the opencontrail driver changes.\n\nThanks for the review.\n\nMegh","commit_id":"db2c6b6be3aeb8a2fa2e3633f6b892bb2250f4d6"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"529d42b687116ad5d091cfa1a1c40e141f42cc28","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from ceilometer import sample"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class FloatingIPPollsterReceivePackets(statistics._Base):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    meter_name \u003d \u0027ip.floating.receive.packets\u0027"},{"line_number":24,"context_line":"    meter_type \u003d sample.TYPE_CUMULATIVE"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_924a64c4","line":21,"in_reply_to":"baa041b7_9f795696","updated":"2015-04-03 02:22:10.000000000","message":"Hi Megh, the RC1 cut is Apr 9th. I don\u0027t know if you\u0027re able to get the driver changes merged by then. If we missed the driver by then, then we will have some meters defined but never be able to get any actually data if we only get this patch merged in. It might be confusing to the users. \n\nI personally would suggest you get the opencontrail driver proposed for others to review ASAP if you don\u0027t want to miss RC1 cut.","commit_id":"db2c6b6be3aeb8a2fa2e3633f6b892bb2250f4d6"},{"author":{"_account_id":15680,"name":"Megh Bhatt","email":"meghb@juniper.net","username":"meghb"},"change_message_id":"2807825fcb034fc16b52c55d181f5a202544bb90","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from ceilometer import sample"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class FloatingIPPollsterReceivePackets(statistics._Base):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    meter_name \u003d \u0027ip.floating.receive.packets\u0027"},{"line_number":24,"context_line":"    meter_type \u003d sample.TYPE_CUMULATIVE"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_fbce5c82","line":21,"in_reply_to":"da9b358b_c4ca9a4f","updated":"2015-03-30 05:06:50.000000000","message":"Hi Lianhao Lu,\nOnce this driver independent checkin is done, I will adding support to the opencontrail driver for the same. This is just to separate the two checkins\n\nThanks\n\nMegh","commit_id":"db2c6b6be3aeb8a2fa2e3633f6b892bb2250f4d6"},{"author":{"_account_id":15680,"name":"Megh Bhatt","email":"meghb@juniper.net","username":"meghb"},"change_message_id":"b238d326b240a163afe06f250ee1c91644ac6ea4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from ceilometer import sample"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class FloatingIPPollsterReceivePackets(statistics._Base):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    meter_name \u003d \u0027ip.floating.receive.packets\u0027"},{"line_number":24,"context_line":"    meter_type \u003d sample.TYPE_CUMULATIVE"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_9f795696","line":21,"in_reply_to":"da9b358b_df123b09","updated":"2015-04-02 20:09:15.000000000","message":"Hi Lianhao,\nI have not yet made the final changes in the opencontrail driver. It needs some restructuring also. I have a draft version but my thinking was to first commit this and then start working on it. Please let me know if you have any concerns just committing this patch alone without the opencontrail driver changes.\n\nThanks\n\nMegh","commit_id":"db2c6b6be3aeb8a2fa2e3633f6b892bb2250f4d6"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"60bf792fe5d12ea6a7bcde0b6d3b4caf8392ff83","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from ceilometer import sample"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class FloatingIPPollsterReceivePackets(statistics._Base):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    meter_name \u003d \u0027ip.floating.receive.packets\u0027"},{"line_number":24,"context_line":"    meter_type \u003d sample.TYPE_CUMULATIVE"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_df123b09","line":21,"in_reply_to":"da9b358b_fbce5c82","updated":"2015-03-31 01:48:32.000000000","message":"Ok. It\u0027d be much better if you could make a dependency between the 2 patches. :)","commit_id":"db2c6b6be3aeb8a2fa2e3633f6b892bb2250f4d6"}],"ceilometer/network/statistics/opencontrail/client.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"ad1b8daf17b6eed46af0ad3fe4dd14160ff4c9af","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        \"\"\""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        path \u003d \u0027/analytics/uves/virtual-machine/\u0027"},{"line_number":123,"context_line":"        resp \u003d self.request(path, fqdn_uuid, flat\u003dTrue, data\u003ddata)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        return resp.json()"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_727350e8","line":123,"updated":"2015-04-21 15:27:08.000000000","message":"just curious why we need flat as a parameter? do we expect future use?","commit_id":"0f7a0c341c75306fc9d7046411b45a43a1217e5a"},{"author":{"_account_id":15680,"name":"Megh Bhatt","email":"meghb@juniper.net","username":"meghb"},"change_message_id":"c1b1af7be9359c693053c8a194a65e5f86366881","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        \"\"\""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        path \u003d \u0027/analytics/uves/virtual-machine/\u0027"},{"line_number":123,"context_line":"        resp \u003d self.request(path, fqdn_uuid, flat\u003dTrue, data\u003ddata)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        return resp.json()"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_9302bc6e","line":123,"in_reply_to":"dac4157f_727350e8","updated":"2015-05-06 01:00:05.000000000","message":"\u0027flat\u0027 provides a mean to return the result in a succinct JSON rather than verbose. We do expect future uses to use the flat.","commit_id":"0f7a0c341c75306fc9d7046411b45a43a1217e5a"}],"ceilometer/network/statistics/opencontrail/driver.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"ad1b8daf17b6eed46af0ad3fe4dd14160ff4c9af","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        data \u003d self._prepare_cache(endpoint, params, cache)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        floatingips \u003d data[\u0027n_client\u0027].floatingip_get_all()"},{"line_number":122,"context_line":"        port_floatingip_map \u003d \\"},{"line_number":123,"context_line":"            dict((floatingip[\u0027port_id\u0027], floatingip) for floatingip in"},{"line_number":124,"context_line":"                 floatingips if floatingip[\u0027port_id\u0027] is not None and"},{"line_number":125,"context_line":"                 floatingip[\u0027floating_ip_address\u0027] is not None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_d86d9b05","line":122,"updated":"2015-04-21 15:27:08.000000000","message":"use brackets instead of \\","commit_id":"0f7a0c341c75306fc9d7046411b45a43a1217e5a"},{"author":{"_account_id":15680,"name":"Megh Bhatt","email":"meghb@juniper.net","username":"meghb"},"change_message_id":"c1b1af7be9359c693053c8a194a65e5f86366881","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        data \u003d self._prepare_cache(endpoint, params, cache)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        floatingips \u003d data[\u0027n_client\u0027].floatingip_get_all()"},{"line_number":122,"context_line":"        port_floatingip_map \u003d \\"},{"line_number":123,"context_line":"            dict((floatingip[\u0027port_id\u0027], floatingip) for floatingip in"},{"line_number":124,"context_line":"                 floatingips if floatingip[\u0027port_id\u0027] is not None and"},{"line_number":125,"context_line":"                 floatingip[\u0027floating_ip_address\u0027] is not None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_d32f14f5","line":122,"in_reply_to":"dac4157f_d86d9b05","updated":"2015-05-06 01:00:05.000000000","message":"Will do","commit_id":"0f7a0c341c75306fc9d7046411b45a43a1217e5a"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"ad1b8daf17b6eed46af0ad3fe4dd14160ff4c9af","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            port_info \u003d data[\u0027n_client\u0027].port_get(port_id)"},{"line_number":128,"context_line":"            if port_info is None:"},{"line_number":129,"context_line":"                continue"},{"line_number":130,"context_line":"            if \u0027device_id\u0027 not in port_info:"},{"line_number":131,"context_line":"                continue"},{"line_number":132,"context_line":"            vm_fqdn_uuid \u003d port_info[\u0027device_id\u0027]"},{"line_number":133,"context_line":"            vm_statistics \u003d \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_b83e67d8","line":130,"updated":"2015-04-21 15:27:08.000000000","message":"you can probably merge this if with the above into a single IF x OR y:","commit_id":"0f7a0c341c75306fc9d7046411b45a43a1217e5a"},{"author":{"_account_id":15680,"name":"Megh Bhatt","email":"meghb@juniper.net","username":"meghb"},"change_message_id":"c1b1af7be9359c693053c8a194a65e5f86366881","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            port_info \u003d data[\u0027n_client\u0027].port_get(port_id)"},{"line_number":128,"context_line":"            if port_info is None:"},{"line_number":129,"context_line":"                continue"},{"line_number":130,"context_line":"            if \u0027device_id\u0027 not in port_info:"},{"line_number":131,"context_line":"                continue"},{"line_number":132,"context_line":"            vm_fqdn_uuid \u003d port_info[\u0027device_id\u0027]"},{"line_number":133,"context_line":"            vm_statistics \u003d \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_b334984a","line":130,"in_reply_to":"dac4157f_b83e67d8","updated":"2015-05-06 01:00:05.000000000","message":"Will do","commit_id":"0f7a0c341c75306fc9d7046411b45a43a1217e5a"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"ad1b8daf17b6eed46af0ad3fe4dd14160ff4c9af","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                data[\u0027o_client\u0027].networks.get_vm_statistics(vm_fqdn_uuid)"},{"line_number":135,"context_line":"            if vm_statistics is None:"},{"line_number":136,"context_line":"                continue"},{"line_number":137,"context_line":"            timestamp \u003d timeutils.utcnow().isoformat()"},{"line_number":138,"context_line":"            floatingip_info \u003d port_floatingip_map[port_id]"},{"line_number":139,"context_line":"            for sample in \\"},{"line_number":140,"context_line":"                self._get_floatingip_sample(extractor, port_info,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_c3836ccb","line":137,"updated":"2015-04-21 15:27:08.000000000","message":"do we need to generate a timestamp for each port or is it ok for each poll cycle?","commit_id":"0f7a0c341c75306fc9d7046411b45a43a1217e5a"},{"author":{"_account_id":15680,"name":"Megh Bhatt","email":"meghb@juniper.net","username":"meghb"},"change_message_id":"c1b1af7be9359c693053c8a194a65e5f86366881","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                data[\u0027o_client\u0027].networks.get_vm_statistics(vm_fqdn_uuid)"},{"line_number":135,"context_line":"            if vm_statistics is None:"},{"line_number":136,"context_line":"                continue"},{"line_number":137,"context_line":"            timestamp \u003d timeutils.utcnow().isoformat()"},{"line_number":138,"context_line":"            floatingip_info \u003d port_floatingip_map[port_id]"},{"line_number":139,"context_line":"            for sample in \\"},{"line_number":140,"context_line":"                self._get_floatingip_sample(extractor, port_info,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_93399c44","line":137,"in_reply_to":"dac4157f_c3836ccb","updated":"2015-05-06 01:00:05.000000000","message":"It should be fine for each poll cycle","commit_id":"0f7a0c341c75306fc9d7046411b45a43a1217e5a"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"ad1b8daf17b6eed46af0ad3fe4dd14160ff4c9af","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                               floatingip_info, vm_statistics):"},{"line_number":154,"context_line":"        stats \u003d vm_statistics[\u0027UveVirtualMachineAgent\u0027].get(\u0027fip_stats_list\u0027,"},{"line_number":155,"context_line":"                                                            [])"},{"line_number":156,"context_line":"        if type(stats) is list:"},{"line_number":157,"context_line":"            for stat in stats:"},{"line_number":158,"context_line":"                if \u0027ip_address\u0027 in stat and \\"},{"line_number":159,"context_line":"                        stat[\u0027ip_address\u0027] \u003d\u003d \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_a301986c","line":156,"updated":"2015-04-21 15:27:08.000000000","message":"will fip_stats_list not be a list ever? if not i don\u0027t think this check is needed.","commit_id":"0f7a0c341c75306fc9d7046411b45a43a1217e5a"},{"author":{"_account_id":15680,"name":"Megh Bhatt","email":"meghb@juniper.net","username":"meghb"},"change_message_id":"c1b1af7be9359c693053c8a194a65e5f86366881","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                               floatingip_info, vm_statistics):"},{"line_number":154,"context_line":"        stats \u003d vm_statistics[\u0027UveVirtualMachineAgent\u0027].get(\u0027fip_stats_list\u0027,"},{"line_number":155,"context_line":"                                                            [])"},{"line_number":156,"context_line":"        if type(stats) is list:"},{"line_number":157,"context_line":"            for stat in stats:"},{"line_number":158,"context_line":"                if \u0027ip_address\u0027 in stat and \\"},{"line_number":159,"context_line":"                        stat[\u0027ip_address\u0027] \u003d\u003d \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_733f2026","line":156,"in_reply_to":"dac4157f_a301986c","updated":"2015-05-06 01:00:05.000000000","message":"I\u0027ll confirm and remove if so","commit_id":"0f7a0c341c75306fc9d7046411b45a43a1217e5a"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"41e850cfade444119c809abf24a0c2e53d61f624","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            port_info \u003d data[\u0027n_client\u0027].port_get(port_id)"},{"line_number":128,"context_line":"            if port_info is None or \u0027device_id\u0027 not in port_info:"},{"line_number":129,"context_line":"                continue"},{"line_number":130,"context_line":"            vm_fqdn_uuid \u003d port_info[\u0027device_id\u0027]"},{"line_number":131,"context_line":"            vm_statistics \u003d ("},{"line_number":132,"context_line":"                data[\u0027o_client\u0027].networks.get_vm_statistics(vm_fqdn_uuid))"},{"line_number":133,"context_line":"            if vm_statistics is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_26e73642","line":130,"updated":"2015-05-13 23:07:37.000000000","message":"we probably don\u0027t need to set a variable for this.. it\u0027s only used once","commit_id":"cab990de2a011e9401f71ce605612fcf11cd02d8"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"41e850cfade444119c809abf24a0c2e53d61f624","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                data[\u0027o_client\u0027].networks.get_vm_statistics(vm_fqdn_uuid))"},{"line_number":133,"context_line":"            if vm_statistics is None:"},{"line_number":134,"context_line":"                continue"},{"line_number":135,"context_line":"            timestamp \u003d timeutils.utcnow().isoformat()"},{"line_number":136,"context_line":"            floatingip_info \u003d port_floatingip_map[port_id]"},{"line_number":137,"context_line":"            for sample in ("},{"line_number":138,"context_line":"                self._get_floatingip_sample(extractor, port_info,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a0c5dc1_8b133166","line":135,"updated":"2015-05-13 23:07:37.000000000","message":"can we move this out of loop since it\u0027s ok for timestamp to be shared for single poll cycle","commit_id":"cab990de2a011e9401f71ce605612fcf11cd02d8"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"41e850cfade444119c809abf24a0c2e53d61f624","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        stats \u003d vm_statistics[\u0027UveVirtualMachineAgent\u0027].get(\u0027fip_stats_list\u0027,"},{"line_number":153,"context_line":"                                                            [])"},{"line_number":154,"context_line":"        for stat in stats:"},{"line_number":155,"context_line":"            if \u0027ip_address\u0027 in stat and ("},{"line_number":156,"context_line":"                    stat[\u0027ip_address\u0027] \u003d\u003d"},{"line_number":157,"context_line":"                    floatingip_info[\u0027floating_ip_address\u0027]):"},{"line_number":158,"context_line":"                rid \u003d floatingip_info[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_26be1600","line":155,"updated":"2015-05-13 23:07:37.000000000","message":"can you format to if (x in y and x \u003d\u003d y): rather than if x in y (x \u003d\u003d y):","commit_id":"cab990de2a011e9401f71ce605612fcf11cd02d8"}],"setup.cfg":[{"author":{"_account_id":13630,"name":"Luo Gangyi","email":"luogangyi@corp.netease.com","username":"luogangyi"},"change_message_id":"153ef4699c3b2aa92272d079ca526f7965d34a19","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    ip.floating \u003d ceilometer.network.floatingip:FloatingIPPollster"},{"line_number":169,"context_line":"    ip.floating.receive.packets \u003d ceilometer.network.statistics.floatingip:FloatingIPPollsterReceivePackets"},{"line_number":170,"context_line":"    ip.floating.transmit.packets \u003d ceilometer.network.statistics.floatingip:FloatingIPPollsterTransmitPackets"},{"line_number":171,"context_line":"    ip.floating.receive.bytes \u003d ceilometer.network.statistics.floatingip:FloatingIPPollsterReceiveBytes"},{"line_number":172,"context_line":"    ip.floating.transmit.bytes \u003d ceilometer.network.statistics.floatingip:FloatingIPPollsterTransmitBytes"},{"line_number":173,"context_line":"    image \u003d ceilometer.image.glance:ImagePollster"},{"line_number":174,"context_line":"    image.size \u003d ceilometer.image.glance:ImageSizePollster"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"da9b358b_0a309a55","line":171,"updated":"2015-03-28 09:09:22.000000000","message":"Should we called it FloatingIPXXXXXXPollster? which seems more compatible with other pollsters\u0027 name.","commit_id":"db2c6b6be3aeb8a2fa2e3633f6b892bb2250f4d6"},{"author":{"_account_id":15680,"name":"Megh Bhatt","email":"meghb@juniper.net","username":"meghb"},"change_message_id":"07bc341ef6d38764307e3feba29426452be5f969","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    ip.floating \u003d ceilometer.network.floatingip:FloatingIPPollster"},{"line_number":169,"context_line":"    ip.floating.receive.packets \u003d ceilometer.network.statistics.floatingip:FloatingIPPollsterReceivePackets"},{"line_number":170,"context_line":"    ip.floating.transmit.packets \u003d ceilometer.network.statistics.floatingip:FloatingIPPollsterTransmitPackets"},{"line_number":171,"context_line":"    ip.floating.receive.bytes \u003d ceilometer.network.statistics.floatingip:FloatingIPPollsterReceiveBytes"},{"line_number":172,"context_line":"    ip.floating.transmit.bytes \u003d ceilometer.network.statistics.floatingip:FloatingIPPollsterTransmitBytes"},{"line_number":173,"context_line":"    image \u003d ceilometer.image.glance:ImagePollster"},{"line_number":174,"context_line":"    image.size \u003d ceilometer.image.glance:ImageSizePollster"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"7aaa499b_392cd849","line":171,"in_reply_to":"9aa53dc9_958e94ce","updated":"2015-04-11 00:50:14.000000000","message":"Hi ZhiQiang Fan,\nI\u0027ve made the suggested changes.\n\nThanks for the review.\n\nMegh","commit_id":"db2c6b6be3aeb8a2fa2e3633f6b892bb2250f4d6"},{"author":{"_account_id":15680,"name":"Megh Bhatt","email":"meghb@juniper.net","username":"meghb"},"change_message_id":"2807825fcb034fc16b52c55d181f5a202544bb90","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    ip.floating \u003d ceilometer.network.floatingip:FloatingIPPollster"},{"line_number":169,"context_line":"    ip.floating.receive.packets \u003d ceilometer.network.statistics.floatingip:FloatingIPPollsterReceivePackets"},{"line_number":170,"context_line":"    ip.floating.transmit.packets \u003d ceilometer.network.statistics.floatingip:FloatingIPPollsterTransmitPackets"},{"line_number":171,"context_line":"    ip.floating.receive.bytes \u003d ceilometer.network.statistics.floatingip:FloatingIPPollsterReceiveBytes"},{"line_number":172,"context_line":"    ip.floating.transmit.bytes \u003d ceilometer.network.statistics.floatingip:FloatingIPPollsterTransmitBytes"},{"line_number":173,"context_line":"    image \u003d ceilometer.image.glance:ImagePollster"},{"line_number":174,"context_line":"    image.size \u003d ceilometer.image.glance:ImageSizePollster"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"da9b358b_fb7c1c22","line":171,"in_reply_to":"da9b358b_0a309a55","updated":"2015-03-30 05:06:50.000000000","message":"Hi Luo Gangyi,\nI followed the\nswitch.port.receive.packets \u003d ceilometer.network.statistics.port:PortPollsterReceivePackets\n\nentry. Seems that there are both types.\n\nPlease let me know if you have a preference to change the name to FloatingIPXXXXPollster and I\u0027ll submit a new patch right away.\n\nThanks\n\nMegh","commit_id":"db2c6b6be3aeb8a2fa2e3633f6b892bb2250f4d6"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"545dabf7431e83b7e473091b2e9be6467d392708","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    ip.floating \u003d ceilometer.network.floatingip:FloatingIPPollster"},{"line_number":169,"context_line":"    ip.floating.receive.packets \u003d ceilometer.network.statistics.floatingip:FloatingIPPollsterReceivePackets"},{"line_number":170,"context_line":"    ip.floating.transmit.packets \u003d ceilometer.network.statistics.floatingip:FloatingIPPollsterTransmitPackets"},{"line_number":171,"context_line":"    ip.floating.receive.bytes \u003d ceilometer.network.statistics.floatingip:FloatingIPPollsterReceiveBytes"},{"line_number":172,"context_line":"    ip.floating.transmit.bytes \u003d ceilometer.network.statistics.floatingip:FloatingIPPollsterTransmitBytes"},{"line_number":173,"context_line":"    image \u003d ceilometer.image.glance:ImagePollster"},{"line_number":174,"context_line":"    image.size \u003d ceilometer.image.glance:ImageSizePollster"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"9aa53dc9_958e94ce","line":171,"in_reply_to":"da9b358b_fb7c1c22","updated":"2015-04-09 03:41:48.000000000","message":"personally, I think FloatingIPXXXXXXPollster is better","commit_id":"db2c6b6be3aeb8a2fa2e3633f6b892bb2250f4d6"}]}