)]}'
{"ceilometer/image/glance.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"11b2e560d6f1324ac0ce2aec42d6bcb84d83e622","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        \"\"\"Iterate over all images.\"\"\""},{"line_number":75,"context_line":"        key \u003d \u0027%s-images\u0027 % endpoint"},{"line_number":76,"context_line":"        if key not in cache:"},{"line_number":77,"context_line":"            cache[key] \u003d list(self._get_images(ksclient, endpoint))"},{"line_number":78,"context_line":"        return iter(cache[key])"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6ced46_a74f426a","line":77,"updated":"2015-03-25 12:42:16.000000000","message":"do we still need to wrap this in list if above isn\u0027t a generator anymore?","commit_id":"e5717f5f59d5afdb5d38c522900d244fe09895be"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"afe286a033c804826ff8a8cf84e823df8bedf31f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        \"\"\"Iterate over all images.\"\"\""},{"line_number":75,"context_line":"        key \u003d \u0027%s-images\u0027 % endpoint"},{"line_number":76,"context_line":"        if key not in cache:"},{"line_number":77,"context_line":"            cache[key] \u003d list(self._get_images(ksclient, endpoint))"},{"line_number":78,"context_line":"        return iter(cache[key])"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6ced46_bd7813c5","line":77,"in_reply_to":"1a6ced46_a74f426a","updated":"2015-03-26 01:14:14.000000000","message":"Actually, the above is still a generator :), please see:\nhttps://github.com/openstack/python-glanceclient/blob/master/glanceclient/v1/images.py#L263","commit_id":"e5717f5f59d5afdb5d38c522900d244fe09895be"}],"ceilometer/tests/image/test_glance.py":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"f61edf7d7f191d8922419fbb44d45bd6f6faa756","unresolved":false,"context_lines":[{"line_number":92,"context_line":"          u\u0027properties\u0027: {},"},{"line_number":93,"context_line":"          u\u0027min_disk\u0027: 0,"},{"line_number":94,"context_line":"          u\u0027protected\u0027: False,"},{"line_number":95,"context_line":"          u\u0027id\u0027: u\u0027e753b196-49b4-48e8-8ca5-09ebd9805f40\u0027,"},{"line_number":96,"context_line":"          u\u0027location\u0027: None,"},{"line_number":97,"context_line":"          u\u0027checksum\u0027: None,"},{"line_number":98,"context_line":"          u\u0027owner\u0027: u\u00274c8364fc20184ed7971b76602aa96184\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_fa202db2","line":95,"updated":"2015-03-24 08:17:05.000000000","message":"It seems that this Image should be duplicate one of the previous, as it is written in comment string, so it seems that its \u0027id\u0027 shouldn\u0027t be changed. Is it correct or I\u0027ve missed something?\n\nCheers, Igor.","commit_id":"7fb73fb5a65c7a7c03f47ab3f01f7feefb650724"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"7acbf91b24f717faa986692bcb06ec195788087b","unresolved":false,"context_lines":[{"line_number":92,"context_line":"          u\u0027properties\u0027: {},"},{"line_number":93,"context_line":"          u\u0027min_disk\u0027: 0,"},{"line_number":94,"context_line":"          u\u0027protected\u0027: False,"},{"line_number":95,"context_line":"          u\u0027id\u0027: u\u0027e753b196-49b4-48e8-8ca5-09ebd9805f40\u0027,"},{"line_number":96,"context_line":"          u\u0027location\u0027: None,"},{"line_number":97,"context_line":"          u\u0027checksum\u0027: None,"},{"line_number":98,"context_line":"          u\u0027owner\u0027: u\u00274c8364fc20184ed7971b76602aa96184\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_85935e4e","line":95,"in_reply_to":"1a6ced46_fa202db2","updated":"2015-03-24 08:37:55.000000000","message":"Normally, the uuids of images shouldn\u0027t be duplicated (actually it is.), previously, here the id of image is duplicated with the first mocked image object, that just to construct the case that an admin user have public images and private images, in this case, when we use image-list command with \"--is-public True\" and \"--is-public False\", the two results have duplicated images (as the comments in ceilometer/image/glance.py mentioned). Now, when we use image-list --all-tenants, the return will include all tenants\u0027s public and private images and with no duplication.\n\nBut I should remove the comments of L83, will be done :)\n\nCheers Liusheng","commit_id":"7fb73fb5a65c7a7c03f47ab3f01f7feefb650724"}]}