)]}'
{"ceilometer/tests/api/v2/test_alarm_scenarios.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"4398d107c983861e8407eb32202522b320e743c5","unresolved":false,"context_lines":[{"line_number":916,"context_line":"        self.assertEqual(7, len(alarms))"},{"line_number":917,"context_line":""},{"line_number":918,"context_line":"        # threshold_rule and combination_rule order is not"},{"line_number":919,"context_line":"        # predictable so it is not possible to do an exact match"},{"line_number":920,"context_line":"        # here"},{"line_number":921,"context_line":"        error_faultstring \u003d resp.json[\u0027error_message\u0027][\u0027faultstring\u0027]"},{"line_number":922,"context_line":"        for expected_string in [\u0027threshold_rule\u0027, \u0027combination_rule\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa963961_f05e7744","line":919,"updated":"2015-03-27 01:39:53.000000000","message":"we can make it predictable, use `sorted(ALARM_RULES)` instead of raw ALARM_RULES in here: https://github.com/openstack/ceilometer/blob/e14a4edc81c365a84289d72f34703eff03a37e8b/ceilometer/api/controllers/v2/alarms.py#L296","commit_id":"6eb068a703d096d0d7103be5e5ff309aba901912"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"0cd2d2c6666fee705eb883d3ab92b3a93135e3e2","unresolved":false,"context_lines":[{"line_number":916,"context_line":"        self.assertEqual(7, len(alarms))"},{"line_number":917,"context_line":""},{"line_number":918,"context_line":"        # threshold_rule and combination_rule order is not"},{"line_number":919,"context_line":"        # predictable so it is not possible to do an exact match"},{"line_number":920,"context_line":"        # here"},{"line_number":921,"context_line":"        error_faultstring \u003d resp.json[\u0027error_message\u0027][\u0027faultstring\u0027]"},{"line_number":922,"context_line":"        for expected_string in [\u0027threshold_rule\u0027, \u0027combination_rule\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da9b358b_8adb8fed","line":919,"in_reply_to":"fa963961_e56589e1","updated":"2015-03-28 01:29:40.000000000","message":"end user will get unpredictable error message either, I think it may not a good idea for end user to get two different error messages (yet same by meaning) with same request\n\nanyway, I don\u0027t against current impl","commit_id":"6eb068a703d096d0d7103be5e5ff309aba901912"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"65d2ff15cb60367ee4c43e96a17b24ef4c056592","unresolved":false,"context_lines":[{"line_number":916,"context_line":"        self.assertEqual(7, len(alarms))"},{"line_number":917,"context_line":""},{"line_number":918,"context_line":"        # threshold_rule and combination_rule order is not"},{"line_number":919,"context_line":"        # predictable so it is not possible to do an exact match"},{"line_number":920,"context_line":"        # here"},{"line_number":921,"context_line":"        error_faultstring \u003d resp.json[\u0027error_message\u0027][\u0027faultstring\u0027]"},{"line_number":922,"context_line":"        for expected_string in [\u0027threshold_rule\u0027, \u0027combination_rule\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa963961_e56589e1","line":919,"in_reply_to":"fa963961_f05e7744","updated":"2015-03-27 11:19:34.000000000","message":"Sure, but I didn\u0027t want (at least in this patchset) to invade the real code just to get this test working. Seems wrong somehow.","commit_id":"6eb068a703d096d0d7103be5e5ff309aba901912"}],"tox.ini":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"4398d107c983861e8407eb32202522b320e743c5","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"[testenv:docs]"},{"line_number":73,"context_line":"commands \u003d python setup.py build_sphinx"},{"line_number":74,"context_line":"setenv \u003d PYTHONHASHSEED\u003d0"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"[testenv:pylint]"},{"line_number":77,"context_line":"commands \u003d bash tools/lintstack.sh"}],"source_content_type":"text/x-properties","patch_set":5,"id":"fa963961_3044df72","line":74,"updated":"2015-03-27 01:39:53.000000000","message":"clever","commit_id":"6eb068a703d096d0d7103be5e5ff309aba901912"}]}