)]}'
{"ceilometer/tests/publisher/test_udp.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"825d67700925de93b84e4f1276642d3b38a22857","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        self.CONF \u003d self.useFixture(fixture_config.Config()).conf"},{"line_number":114,"context_line":"        self.CONF.publisher.telemetry_secret \u003d \u0027not-so-secret\u0027"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def test_publisher_udp_socket(self):"},{"line_number":117,"context_line":"        self.data_sent \u003d []"},{"line_number":118,"context_line":"        sock \u003d self._make_fake_socket(self.data_sent)"},{"line_number":119,"context_line":"        with mock.patch.object(socket, \u0027socket\u0027) as mock_socket:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_01cf4857","line":116,"updated":"2015-03-27 07:43:52.000000000","message":"I think this test case name can be more precise to: test_publisher_udp_socket_ipv6, or we can add ipv4 check as well","commit_id":"4165ab016503ee4775b173f712edf6aa16511a29"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"fbae3e711b5a323c83f867f871a89de92f850050","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        self.CONF \u003d self.useFixture(fixture_config.Config()).conf"},{"line_number":114,"context_line":"        self.CONF.publisher.telemetry_secret \u003d \u0027not-so-secret\u0027"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def test_publisher_udp_socket(self):"},{"line_number":117,"context_line":"        self.data_sent \u003d []"},{"line_number":118,"context_line":"        sock \u003d self._make_fake_socket(self.data_sent)"},{"line_number":119,"context_line":"        with mock.patch.object(socket, \u0027socket\u0027) as mock_socket:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_c41a8e6e","line":116,"in_reply_to":"fa963961_01cf4857","updated":"2015-03-27 07:59:56.000000000","message":"Done","commit_id":"4165ab016503ee4775b173f712edf6aa16511a29"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"825d67700925de93b84e4f1276642d3b38a22857","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def test_publisher_udp_socket(self):"},{"line_number":117,"context_line":"        self.data_sent \u003d []"},{"line_number":118,"context_line":"        sock \u003d self._make_fake_socket(self.data_sent)"},{"line_number":119,"context_line":"        with mock.patch.object(socket, \u0027socket\u0027) as mock_socket:"},{"line_number":120,"context_line":"            mock_socket.return_value \u003d sock"},{"line_number":121,"context_line":"            udp.UDPPublisher("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_e1f2249a","line":118,"updated":"2015-03-27 07:43:52.000000000","message":"IIUC, this line and the L120 `mock_socket.return_value \u003d sock` are not needed, since we don\u0027t really care about what is returned, but just want to check what is called, the __iniit__ doesn\u0027t use that socket","commit_id":"4165ab016503ee4775b173f712edf6aa16511a29"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"fbae3e711b5a323c83f867f871a89de92f850050","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def test_publisher_udp_socket(self):"},{"line_number":117,"context_line":"        self.data_sent \u003d []"},{"line_number":118,"context_line":"        sock \u003d self._make_fake_socket(self.data_sent)"},{"line_number":119,"context_line":"        with mock.patch.object(socket, \u0027socket\u0027) as mock_socket:"},{"line_number":120,"context_line":"            mock_socket.return_value \u003d sock"},{"line_number":121,"context_line":"            udp.UDPPublisher("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_6420629c","line":118,"in_reply_to":"fa963961_e1f2249a","updated":"2015-03-27 07:59:56.000000000","message":"you\u0027re right, thanks for catching this","commit_id":"4165ab016503ee4775b173f712edf6aa16511a29"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"cac477231899baa6e245e84a6ad5efe92a3a6cdf","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        self.CONF.publisher.telemetry_secret \u003d \u0027not-so-secret\u0027"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def _check_udp_socket(self, url, expected_addr_family):"},{"line_number":117,"context_line":"        self.data_sent \u003d []"},{"line_number":118,"context_line":"        with mock.patch.object(socket, \u0027socket\u0027) as mock_socket:"},{"line_number":119,"context_line":"            udp.UDPPublisher(netutils.urlsplit(url))"},{"line_number":120,"context_line":"            mock_socket.assert_called_with(expected_addr_family,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa963961_44143ef4","line":117,"updated":"2015-03-27 08:13:17.000000000","message":"oops, is this line can be removed too?","commit_id":"99601ca5d1ef530a710241929a0b00e35d2181ed"}]}