)]}'
{"id":"openstack%2Fceilometer~17192","triplet_id":"openstack%2Fceilometer~master~I625caa09605239e7554b9a897377a9ac457bf8ae","project":"openstack/ceilometer","branch":"master","topic":"bp/multi-dimensions","hashtags":[],"change_id":"I625caa09605239e7554b9a897377a9ac457bf8ae","subject":"Add the ability to filter on metadata.","status":"MERGED","created":"2012-11-30 13:11:17.000000000","updated":"2012-12-07 09:03:21.000000000","submitted":"2012-12-07 09:03:21.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3ac6717b94a9e5fc25302fa92d071be75d12d198","_number":17192,"virtual_id_number":17192,"owner":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2012-12-07 09:03:21.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":595,"name":"Nick Barcet","email":"nicolas@barcet.com","username":"nijaba"},{"value":0,"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":4458,"name":"Shane Wang","email":"shane.wang@intel.com","username":"shane-wang"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":595,"name":"Nick Barcet","email":"nicolas@barcet.com","username":"nijaba"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2012-12-07 08:00:12.000000000","_account_id":595,"name":"Nick Barcet","email":"nicolas@barcet.com","username":"nijaba"},{"value":2,"date":"2012-12-07 08:59:30.000000000","_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":4458,"name":"Shane Wang","email":"shane.wang@intel.com","username":"shane-wang"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2012-12-07 08:00:12.000000000","_account_id":595,"name":"Nick Barcet","email":"nicolas@barcet.com","username":"nijaba"},{"value":1,"date":"2012-12-07 08:59:30.000000000","_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":4458,"name":"Shane Wang","email":"shane.wang@intel.com","username":"shane-wang"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":595,"name":"Nick Barcet","email":"nicolas@barcet.com","username":"nijaba"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":4458,"name":"Shane Wang","email":"shane.wang@intel.com","username":"shane-wang"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-12-03 06:41:37.000000000","updated_by":{"_account_id":4458,"name":"Shane Wang","email":"shane.wang@intel.com","username":"shane-wang"},"reviewer":{"_account_id":4458,"name":"Shane Wang","email":"shane.wang@intel.com","username":"shane-wang"},"state":"REVIEWER"},{"updated":"2012-12-05 11:10:25.000000000","updated_by":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"reviewer":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"state":"REVIEWER"},{"updated":"2012-12-07 08:00:12.000000000","updated_by":{"_account_id":595,"name":"Nick Barcet","email":"nicolas@barcet.com","username":"nijaba"},"reviewer":{"_account_id":595,"name":"Nick Barcet","email":"nicolas@barcet.com","username":"nijaba"},"state":"REVIEWER"},{"updated":"2012-12-07 08:59:30.000000000","updated_by":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"reviewer":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"state":"REVIEWER"},{"updated":"2012-12-07 09:03:21.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f212b391702d04c51a67946b2d4209ccb0096e91","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-30 13:15:39.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/17192/1/check/gate-ceilometer-merge/828 : SUCCESS\n- http://logs.openstack.org/17192/1/check/gate-ceilometer-pep8/823 : SUCCESS\n- http://logs.openstack.org/17192/1/check/gate-ceilometer-python26/823 : SUCCESS\n- http://logs.openstack.org/17192/1/check/gate-ceilometer-python27/825 : SUCCESS\n- http://logs.openstack.org/17192/1/check/gate-ceilometer-python26-folsom/30 : SUCCESS\n- http://logs.openstack.org/17192/1/check/gate-ceilometer-python27-folsom/30 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"3f113d21cff032dc6fc5b469160b40ea84a62211","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2012-11-30 13:24:10.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nGreat. I think it misses at least:\n\n- some doc on function using _list_events to indicate it\u0027s possible to filter\n- implementation for SQL\n- unit tests","accounts_in_message":[],"_revision_number":1},{"id":"d6ae2c95738265775dae69f30a90bdce1875e069","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2012-11-30 13:42:46.000000000","message":"Patch Set 1: Do not merge\n\n","accounts_in_message":[],"_revision_number":1},{"id":"fb68cf6ef6d13536107ef9f8783d44bf8b6bad25","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2012-11-30 14:55:32.000000000","message":"Patch Set 1:\n\nI like this syntax better than the proposal in the dimension blueprint.\n\nI agree with Julien\u0027s comments about wanting tests and doc. The SQLAlchemy support may require more work, so I wouldn\u0027t be opposed to putting that in a separate changeset for now.","accounts_in_message":[],"_revision_number":1},{"id":"73c1e432cd3e0febcc0b61cd94a637256add9571","author":{"_account_id":4458,"name":"Shane Wang","email":"shane.wang@intel.com","username":"shane-wang"},"date":"2012-12-01 15:21:56.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nI don\u0027t know the purpose and usage case. And wish some doc and test cases to describe it.","accounts_in_message":[],"_revision_number":1},{"id":"5fb572fb934e8cfb410823a57f503d32031f3f90","author":{"_account_id":595,"name":"Nick Barcet","email":"nicolas@barcet.com","username":"nijaba"},"date":"2012-12-02 08:19:05.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nShane, have you looked at the blueprint which is pointed to in the commit message?","accounts_in_message":[],"_revision_number":1},{"id":"fc7b8a62fe455b6c2c26371222dc6eb240f8b4fc","author":{"_account_id":4458,"name":"Shane Wang","email":"shane.wang@intel.com","username":"shane-wang"},"date":"2012-12-03 06:41:37.000000000","message":"Patch Set 1: No score\n\nYes, I have. Thank you for pointing out.\n\nYou are going to implement something like query language, such as XPath or XQuery for XML. The syntax is similar as this multi-dimension. I just don\u0027t know why metadata is implemented for meter only. Is there any others we should consider as well? If yes, I\u0027d like to have the whole syntax well considered and defined. If no, forget my question.\n\nThanks.","accounts_in_message":[],"_revision_number":1},{"id":"ef5ca0a643bb5210dab260cc79eb7f545467bd28","author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"date":"2012-12-05 06:27:07.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c89632e6ebf31029a7a8147b90cbc9d7c1d9c8e4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-05 06:31:10.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/17192/2/check/gate-ceilometer-merge/980 : SUCCESS\n- http://logs.openstack.org/17192/2/check/gate-ceilometer-pep8/975 : SUCCESS\n- http://logs.openstack.org/17192/2/check/gate-ceilometer-python26/975 : SUCCESS\n- http://logs.openstack.org/17192/2/check/gate-ceilometer-python27/977 : SUCCESS\n- http://logs.openstack.org/17192/2/check/gate-ceilometer-python26-folsom/182 : SUCCESS\n- http://logs.openstack.org/17192/2/check/gate-ceilometer-python27-folsom/182 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"6d6b6c389e77c99570107500d51167af716a0969","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2012-12-05 09:59:20.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nLooks much better. I think I\u0027d be more comfortable with something raising an error in SQL if a request is made with metadata query. Otherwise, I\u0027ve the feeling the engine is going to accept request but returns wrong result, and that\u0027s not something we should do.","accounts_in_message":[],"_revision_number":2},{"id":"2fa65cd847779bacaf1d501fc32f7bafd90728d4","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2012-12-05 11:10:25.000000000","message":"Patch Set 2:\n\nThis looks good, but I agree about having the sqlalchemy driver raise an error.","accounts_in_message":[],"_revision_number":2},{"id":"1e12f606a93193fcf3458f23463e89590c81d9a8","author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"date":"2012-12-07 00:24:54.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"1799742887aeeb14a5b78ea494dac899245350ca","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-07 00:33:49.000000000","message":"Patch Set 3: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/17192/3/check/gate-ceilometer-merge/1007 : SUCCESS\n- http://logs.openstack.org/17192/3/check/gate-ceilometer-pep8/1002 : SUCCESS\n- http://logs.openstack.org/17192/3/check/gate-ceilometer-python26/1002 : SUCCESS\n- http://logs.openstack.org/17192/3/check/gate-ceilometer-python27/1004 : SUCCESS\n- http://logs.openstack.org/17192/3/check/gate-ceilometer-python26-folsom/209 : SUCCESS\n- http://logs.openstack.org/17192/3/check/gate-ceilometer-python27-folsom/209 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"b84b8d90304f54801ea794ead4c640abdbb804f1","author":{"_account_id":595,"name":"Nick Barcet","email":"nicolas@barcet.com","username":"nijaba"},"date":"2012-12-07 08:00:12.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"d4df88b6514ca448054dff3186d088974609c31b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-07 08:59:30.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":3},{"id":"4c1101d408b80865b05605364be1a93cdd113e57","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2012-12-07 08:59:30.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"36ef524a06ee28b99c7ab91cedee24df67c64243","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-07 09:03:21.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3},{"id":"d2008abcb8ae4bed7b26fc7692408c1e5120a98c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-07 09:03:21.000000000","message":"Patch Set 3: Verified\n\nBuild successful\n\n- http://logs.openstack.org/17192/3/gate/gate-ceilometer-merge/1009 : SUCCESS\n- http://logs.openstack.org/17192/3/gate/gate-ceilometer-pep8/1004 : SUCCESS\n- http://logs.openstack.org/17192/3/gate/gate-ceilometer-python26/1004 : SUCCESS\n- http://logs.openstack.org/17192/3/gate/gate-ceilometer-python27/1006 : SUCCESS\n- http://logs.openstack.org/17192/3/gate/gate-ceilometer-python26-folsom/211 : SUCCESS\n- http://logs.openstack.org/17192/3/gate/gate-ceilometer-python27-folsom/211 : SUCCESS\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"adef6f07aafc150f173dc73a13baf3d0bb999413","revisions":{"127c1d5a78189db65bda67032eb50bfb638a8371":{"kind":"REWORK","_number":1,"created":"2012-11-30 13:11:17.000000000","uploader":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"ref":"refs/changes/92/17192/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/92/17192/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/92/17192/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/92/17192/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/92/17192/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/92/17192/1"}}},"commit":{"parents":[{"commit":"4a42901485d54ceef5db0dd0845a8b5908732a04","subject":"Merge \"add migration migrate.cfg file to the python package\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/4a42901485d54ceef5db0dd0845a8b5908732a04"}]}],"author":{"name":"Angus Salkeld","email":"asalkeld@redhat.com","date":"2012-11-29 23:44:55.000000000","tz":660},"committer":{"name":"Angus Salkeld","email":"asalkeld@redhat.com","date":"2012-11-30 13:09:14.000000000","tz":660},"subject":"Add the ability to filter on metadata.","message":"Add the ability to filter on metadata.\n\nSo the syntax would be like this:\n/resources/\u003cresource\u003e/meters/\u003cmeter\u003e?metadata.image\u003dfruit\u0026metadata.flavor\u003dapples\n\nblueprint multi-dimensions\n\nChange-Id: I625caa09605239e7554b9a897377a9ac457bf8ae\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/127c1d5a78189db65bda67032eb50bfb638a8371"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/127c1d5a78189db65bda67032eb50bfb638a8371"}]},"branch":"refs/heads/master"},"55ca199a0332d044fff38e6262bcb2bd54a94172":{"kind":"REWORK","_number":2,"created":"2012-12-05 06:27:07.000000000","uploader":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"ref":"refs/changes/92/17192/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/92/17192/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/92/17192/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/92/17192/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/92/17192/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/92/17192/2"}}},"commit":{"parents":[{"commit":"81f149854ffe1badcddee4e89bb4144252bba610","subject":"Remove debug print in V2 API","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/81f149854ffe1badcddee4e89bb4144252bba610"}]}],"author":{"name":"Angus Salkeld","email":"asalkeld@redhat.com","date":"2012-12-05 06:18:43.000000000","tz":660},"committer":{"name":"Angus Salkeld","email":"asalkeld@redhat.com","date":"2012-12-05 06:26:44.000000000","tz":660},"subject":"Add the ability to filter on metadata.","message":"Add the ability to filter on metadata.\n\nSo the syntax would be like this:\n/resources/\u003cresource\u003e/meters/\u003cmeter\u003e?metadata.image\u003dfruit\u0026metadata.flavor\u003dapples\n\nIt works on resources, meters and events.\n\nThis is a basic version for the v1 API, the syntax might need to be different\nfor the v2 API.\n\nblueprint multi-dimensions\n\nChange-Id: I625caa09605239e7554b9a897377a9ac457bf8ae\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/55ca199a0332d044fff38e6262bcb2bd54a94172"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/55ca199a0332d044fff38e6262bcb2bd54a94172"}]},"branch":"refs/heads/master"},"adef6f07aafc150f173dc73a13baf3d0bb999413":{"kind":"REWORK","_number":3,"created":"2012-12-07 00:24:54.000000000","uploader":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"ref":"refs/changes/92/17192/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/92/17192/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/92/17192/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/92/17192/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/92/17192/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/92/17192/3"}}},"commit":{"parents":[{"commit":"81f149854ffe1badcddee4e89bb4144252bba610","subject":"Remove debug print in V2 API","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/81f149854ffe1badcddee4e89bb4144252bba610"}]}],"author":{"name":"Angus Salkeld","email":"asalkeld@redhat.com","date":"2012-12-07 00:23:21.000000000","tz":660},"committer":{"name":"Angus Salkeld","email":"asalkeld@redhat.com","date":"2012-12-07 00:24:24.000000000","tz":660},"subject":"Add the ability to filter on metadata.","message":"Add the ability to filter on metadata.\n\nSo the syntax would be like this:\n/resources/\u003cresource\u003e/meters/\u003cmeter\u003e?metadata.image\u003dfruit\u0026metadata.flavor\u003dapples\n\nIt works on resources, meters and events.\n\nThis is a basic version for the v1 API, the syntax might need to be different\nfor the v2 API.\n\nblueprint multi-dimensions\n\nChange-Id: I625caa09605239e7554b9a897377a9ac457bf8ae\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/adef6f07aafc150f173dc73a13baf3d0bb999413"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/adef6f07aafc150f173dc73a13baf3d0bb999413"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}