)]}'
{"ceilometer/compute/notifications/instance.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"e334ce93d6aa4072f15b3175f526eb2bd12405fb","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        else:"},{"line_number":75,"context_line":"            start_end \u003d message[\u0027event_type\u0027].split(\u0027.\u0027)[-1]"},{"line_number":76,"context_line":"            yield sample.Sample.from_notification("},{"line_number":77,"context_line":"                name\u003d\u0027instance.schedule.\u0027 + start_end,"},{"line_number":78,"context_line":"                type\u003dsample.TYPE_DELTA,"},{"line_number":79,"context_line":"                volume\u003d1,"},{"line_number":80,"context_line":"                unit\u003d\u0027instance\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_d78da27c","line":77,"updated":"2015-04-13 11:24:04.000000000","message":"this problem exists in stable/juno as well, we need backport after  this is merged.\n\nI think keep old meter name *may be* better, like what we do for instance which represents all compute.instance.* event, we can tell each other by resource_metadata.event_type","commit_id":"62707c10b36c9e247826a12b1f615e6d44b471f1"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"64860f7583524e89618d799374749522c7af10e9","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        else:"},{"line_number":75,"context_line":"            start_end \u003d message[\u0027event_type\u0027].split(\u0027.\u0027)[-1]"},{"line_number":76,"context_line":"            yield sample.Sample.from_notification("},{"line_number":77,"context_line":"                name\u003d\u0027instance.schedule.\u0027 + start_end,"},{"line_number":78,"context_line":"                type\u003dsample.TYPE_DELTA,"},{"line_number":79,"context_line":"                volume\u003d1,"},{"line_number":80,"context_line":"                unit\u003d\u0027instance\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_685905fe","line":77,"in_reply_to":"7aaa499b_0969718b","updated":"2015-04-15 01:07:24.000000000","message":"hi gordon, thanks for review, you are right, but if so, should we need to remove the useless code (the old \u0027InstanceScheduled\u0027 implementation) on master? On the other hand, we have added a config option to disable these meters and highly advisable to do that, but we\u0027d better to keep the inadvisable side usable.","commit_id":"62707c10b36c9e247826a12b1f615e6d44b471f1"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"c4fde97d9552d3fd5820ba0aa5202163968ca490","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        else:"},{"line_number":75,"context_line":"            start_end \u003d message[\u0027event_type\u0027].split(\u0027.\u0027)[-1]"},{"line_number":76,"context_line":"            yield sample.Sample.from_notification("},{"line_number":77,"context_line":"                name\u003d\u0027instance.schedule.\u0027 + start_end,"},{"line_number":78,"context_line":"                type\u003dsample.TYPE_DELTA,"},{"line_number":79,"context_line":"                volume\u003d1,"},{"line_number":80,"context_line":"                unit\u003d\u0027instance\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_740673cf","line":77,"in_reply_to":"7aaa499b_685905fe","updated":"2015-04-15 11:37:43.000000000","message":"Discouraging to create \u0027volume\u003d1\u0027 meters is nice, but maintaining existing code might be different. I think it OK to merge into master. We can create new patch to delete those meters as another work.","commit_id":"62707c10b36c9e247826a12b1f615e6d44b471f1"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"1016977502bc582c8b420b563f4c0b94f4fd324b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        else:"},{"line_number":75,"context_line":"            start_end \u003d message[\u0027event_type\u0027].split(\u0027.\u0027)[-1]"},{"line_number":76,"context_line":"            yield sample.Sample.from_notification("},{"line_number":77,"context_line":"                name\u003d\u0027instance.schedule.\u0027 + start_end,"},{"line_number":78,"context_line":"                type\u003dsample.TYPE_DELTA,"},{"line_number":79,"context_line":"                volume\u003d1,"},{"line_number":80,"context_line":"                unit\u003d\u0027instance\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aa745d1_0f6e482f","line":77,"in_reply_to":"7aaa499b_740673cf","updated":"2015-04-16 18:48:32.000000000","message":"it was decided to mark as deprecated in kilo, disable by default in liberty, and remove in M*.\n\nmy main concern is this is going a bit beyond maintenance. it is actually adding \u0027meter\u0027 events. while it is more flexible this way to add start/end in the meter name, i would rather not surface this information.\n\nalso, i don\u0027t know if we deployers are doing this but i don\u0027t see why juno/kilo/liberty should support an event_type that exists only in icehouse nova","commit_id":"62707c10b36c9e247826a12b1f615e6d44b471f1"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"7efb07fd46742a9c6d71d3078a2204a90ab163cd","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        else:"},{"line_number":75,"context_line":"            start_end \u003d message[\u0027event_type\u0027].split(\u0027.\u0027)[-1]"},{"line_number":76,"context_line":"            yield sample.Sample.from_notification("},{"line_number":77,"context_line":"                name\u003d\u0027instance.schedule.\u0027 + start_end,"},{"line_number":78,"context_line":"                type\u003dsample.TYPE_DELTA,"},{"line_number":79,"context_line":"                volume\u003d1,"},{"line_number":80,"context_line":"                unit\u003d\u0027instance\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_0969718b","line":77,"in_reply_to":"7aaa499b_d703620e","updated":"2015-04-14 18:25:40.000000000","message":"i don\u0027t know if we need this exact fix in master(liberty)\n\nwe\u0027ve made the commitment to stop generating \u0027volume\u003d1\u0027 meters as of Kilo as they are really just events rather than meters.\n\nwe might want to target this at juno/kilo specifically but not master","commit_id":"62707c10b36c9e247826a12b1f615e6d44b471f1"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"883149fdf8edb507556d1f70d534647fa561718f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        else:"},{"line_number":75,"context_line":"            start_end \u003d message[\u0027event_type\u0027].split(\u0027.\u0027)[-1]"},{"line_number":76,"context_line":"            yield sample.Sample.from_notification("},{"line_number":77,"context_line":"                name\u003d\u0027instance.schedule.\u0027 + start_end,"},{"line_number":78,"context_line":"                type\u003dsample.TYPE_DELTA,"},{"line_number":79,"context_line":"                volume\u003d1,"},{"line_number":80,"context_line":"                unit\u003d\u0027instance\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_d703620e","line":77,"in_reply_to":"7aaa499b_d78da27c","updated":"2015-04-13 11:57:38.000000000","message":"ZhiQiang Fan, thanks for review! :) I have considered that, I\u0027m not sure if there is usage that need count the \"instance.scheduled\" of instance in a duration, if so, two instance.scheduled samples will be recorded when an instance was scheduled (by scheduler.select_destinations.start and scheduler.select_destinations.end notifications)","commit_id":"62707c10b36c9e247826a12b1f615e6d44b471f1"}]}