)]}'
{"ceilometer/event/storage/impl_elasticsearch.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"7b50f7f27310b1fafa9c32efb9bb41338fc54434","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            if not ok:"},{"line_number":105,"context_line":"                __, result \u003d result.popitem()"},{"line_number":106,"context_line":"                if result[\u0027status\u0027] \u003d\u003d 409:"},{"line_number":107,"context_line":"                    LOG.warning(_LW(\u0027Failed to record duplicated event: %s\u0027)"},{"line_number":108,"context_line":"                                % result)"},{"line_number":109,"context_line":"                else:"},{"line_number":110,"context_line":"                    LOG.exception(_LE(\u0027Failed to record event: %s\u0027) % result)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aa745d1_914bbe59","line":107,"updated":"2015-04-16 08:11:43.000000000","message":"Because this message can\u0027t be fixed by deployer I suggest something like:\n\n  LOG.info(_LI(\"Duplicate event detected, skipping it: %s\" % e)","commit_id":"35cba05d8bfbd6e91ec866c6003e8b8821d90d29"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"0eae90c6b9eb4f037823a0a8b5ca68ca858d6fdb","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            if not ok:"},{"line_number":105,"context_line":"                __, result \u003d result.popitem()"},{"line_number":106,"context_line":"                if result[\u0027status\u0027] \u003d\u003d 409:"},{"line_number":107,"context_line":"                    LOG.warning(_LW(\u0027Failed to record duplicated event: %s\u0027)"},{"line_number":108,"context_line":"                                % result)"},{"line_number":109,"context_line":"                else:"},{"line_number":110,"context_line":"                    LOG.exception(_LE(\u0027Failed to record event: %s\u0027) % result)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aa745d1_3ed5ca42","line":107,"in_reply_to":"5aa745d1_914bbe59","updated":"2015-04-16 13:26:41.000000000","message":"Done","commit_id":"35cba05d8bfbd6e91ec866c6003e8b8821d90d29"}],"ceilometer/event/storage/impl_hbase.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"7b50f7f27310b1fafa9c32efb9bb41338fc54434","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                    events_table.put(row, record)"},{"line_number":119,"context_line":"                except Exception as ex:"},{"line_number":120,"context_line":"                    LOG.exception(_LE(\"Failed to record event: %s\") % ex)"},{"line_number":121,"context_line":"                    error \u003d ex"},{"line_number":122,"context_line":"        if error:"},{"line_number":123,"context_line":"            raise error"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5aa745d1_911dfe68","line":121,"updated":"2015-04-16 08:11:43.000000000","message":"Perhaps we should wrap this exception in a StorageUnknownWriteError to have the same interface in all drivers, or completly remove this except block, WDYT ?","commit_id":"35cba05d8bfbd6e91ec866c6003e8b8821d90d29"}],"ceilometer/event/storage/impl_sqlalchemy.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"7b50f7f27310b1fafa9c32efb9bb41338fc54434","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            except Exception as e:"},{"line_number":213,"context_line":"                LOG.exception(_(\u0027Failed to record event: %s\u0027) % e)"},{"line_number":214,"context_line":"                problem_events.append((api_models.Event.UNKNOWN_PROBLEM,"},{"line_number":215,"context_line":"                                       event_model))"},{"line_number":216,"context_line":"        return problem_events"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def get_events(self, event_filter):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aa745d1_0eb6698a","side":"PARENT","line":215,"updated":"2015-04-16 08:11:43.000000000","message":"I think we have broke something here in the past.\n\nBefore, we requeue message if the recording of one of the event returns api_models.Event.UNKNOWN_PROBLEM, but since the event pipeline exists, we requeue message only if a exceptions is raised but they are all catched here, your change seems reintroduce the correct behavior.","commit_id":"f0026ca9abcdfa7f4181a70601c9f3def5862c4e"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"0eae90c6b9eb4f037823a0a8b5ca68ca858d6fdb","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            except Exception as e:"},{"line_number":213,"context_line":"                LOG.exception(_(\u0027Failed to record event: %s\u0027) % e)"},{"line_number":214,"context_line":"                problem_events.append((api_models.Event.UNKNOWN_PROBLEM,"},{"line_number":215,"context_line":"                                       event_model))"},{"line_number":216,"context_line":"        return problem_events"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def get_events(self, event_filter):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aa745d1_79312cec","side":"PARENT","line":215,"in_reply_to":"5aa745d1_0eb6698a","updated":"2015-04-16 13:26:41.000000000","message":"yeah, it was some non-sense.","commit_id":"f0026ca9abcdfa7f4181a70601c9f3def5862c4e"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"7b50f7f27310b1fafa9c32efb9bb41338fc54434","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                            session.execute(model.__table__.insert(),"},{"line_number":196,"context_line":"                                            trait_map[dtype])"},{"line_number":197,"context_line":"            except dbexc.DBDuplicateEntry as e:"},{"line_number":198,"context_line":"                LOG.warning(_LW(\"Failed to record duplicated event: %s\") % e)"},{"line_number":199,"context_line":"            except KeyError as e:"},{"line_number":200,"context_line":"                LOG.exception(_LE(\u0027Failed to record event: %s\u0027) % e)"},{"line_number":201,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aa745d1_2e65a544","line":198,"updated":"2015-04-16 08:11:43.000000000","message":"Because this message can\u0027t be fixed by deployer I suggest something like:\n\n  LOG.info(_LI(\"Duplicate event detected, skipping it: %s\" % e)","commit_id":"35cba05d8bfbd6e91ec866c6003e8b8821d90d29"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"7b50f7f27310b1fafa9c32efb9bb41338fc54434","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                LOG.exception(_LE(\u0027Failed to record event: %s\u0027) % e)"},{"line_number":201,"context_line":"            except Exception as e:"},{"line_number":202,"context_line":"                LOG.exception(_LE(\u0027Failed to record event: %s\u0027) % e)"},{"line_number":203,"context_line":"                error \u003d e"},{"line_number":204,"context_line":"        if error:"},{"line_number":205,"context_line":"            raise error"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5aa745d1_d1c4a693","line":203,"updated":"2015-04-16 08:11:43.000000000","message":"Perhaps we should wrap this exception in a StorageUnknownWriteError to have the same interface in all drivers, or completly remove this except block, WDYT ?","commit_id":"35cba05d8bfbd6e91ec866c6003e8b8821d90d29"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"7f05e84ff2b1ce1ff5bbb29a7e8ca21bca5801f3","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            except dbexc.DBDuplicateEntry as e:"},{"line_number":198,"context_line":"                LOG.info(_LI(\"Duplicate event detected, skipping it: %s\") % e)"},{"line_number":199,"context_line":"            except KeyError as e:"},{"line_number":200,"context_line":"                LOG.exception(_LE(\u0027Failed to record event: %s\u0027) % e)"},{"line_number":201,"context_line":"            except Exception as e:"},{"line_number":202,"context_line":"                LOG.exception(_LE(\u0027Failed to record event: %s\u0027) % e)"},{"line_number":203,"context_line":"                error \u003d e"}],"source_content_type":"text/x-python","patch_set":8,"id":"9af37de9_c4a4dc09","line":200,"updated":"2015-05-10 17:30:26.000000000","message":"error \u003d e is missing","commit_id":"4fd6ab051695ec4b45cf92f61e30d4ad59369716"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"2926c57d095db52c659d8cd95fd911e014bdfc74","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            except dbexc.DBDuplicateEntry as e:"},{"line_number":198,"context_line":"                LOG.info(_LI(\"Duplicate event detected, skipping it: %s\") % e)"},{"line_number":199,"context_line":"            except KeyError as e:"},{"line_number":200,"context_line":"                LOG.exception(_LE(\u0027Failed to record event: %s\u0027) % e)"},{"line_number":201,"context_line":"            except Exception as e:"},{"line_number":202,"context_line":"                LOG.exception(_LE(\u0027Failed to record event: %s\u0027) % e)"},{"line_number":203,"context_line":"                error \u003d e"}],"source_content_type":"text/x-python","patch_set":8,"id":"9af37de9_0c7e86e4","line":200,"in_reply_to":"9af37de9_98a3d49e","updated":"2015-05-11 04:28:31.000000000","message":"Ok, cool that makes sense, thanks for clarification.","commit_id":"4fd6ab051695ec4b45cf92f61e30d4ad59369716"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"ee9c7383a1730fdb83846e3cbd374f7afa09eb87","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            except dbexc.DBDuplicateEntry as e:"},{"line_number":198,"context_line":"                LOG.info(_LI(\"Duplicate event detected, skipping it: %s\") % e)"},{"line_number":199,"context_line":"            except KeyError as e:"},{"line_number":200,"context_line":"                LOG.exception(_LE(\u0027Failed to record event: %s\u0027) % e)"},{"line_number":201,"context_line":"            except Exception as e:"},{"line_number":202,"context_line":"                LOG.exception(_LE(\u0027Failed to record event: %s\u0027) % e)"},{"line_number":203,"context_line":"                error \u003d e"}],"source_content_type":"text/x-python","patch_set":8,"id":"9af37de9_98a3d49e","line":200,"in_reply_to":"9af37de9_c4a4dc09","updated":"2015-05-10 21:22:19.000000000","message":"i left this off on purpose because we don\u0027t want to keep requeueing a known error. ie a key error won\u0027t fix itself the second time around.","commit_id":"4fd6ab051695ec4b45cf92f61e30d4ad59369716"}],"ceilometer/event/storage/pymongo_base.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"7b50f7f27310b1fafa9c32efb9bb41338fc54434","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                     \u0027timestamp\u0027: event_model.generated,"},{"line_number":65,"context_line":"                     \u0027traits\u0027: traits, \u0027raw\u0027: event_model.raw})"},{"line_number":66,"context_line":"            except pymongo.errors.DuplicateKeyError as ex:"},{"line_number":67,"context_line":"                LOG.warning(_LW(\"Failed to record duplicated event: %s\") % ex)"},{"line_number":68,"context_line":"            except Exception as ex:"},{"line_number":69,"context_line":"                LOG.exception(_LE(\"Failed to record event: %s\") % ex)"},{"line_number":70,"context_line":"                error \u003d ex"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aa745d1_11d1eecd","line":67,"updated":"2015-04-16 08:11:43.000000000","message":"Because this message can\u0027t be fixed by deployer I suggest something like:\n\n  LOG.info(_LI(\"Duplicate event detected, skipping it: %s\" % e)","commit_id":"35cba05d8bfbd6e91ec866c6003e8b8821d90d29"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"7b50f7f27310b1fafa9c32efb9bb41338fc54434","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            except pymongo.errors.DuplicateKeyError as ex:"},{"line_number":67,"context_line":"                LOG.warning(_LW(\"Failed to record duplicated event: %s\") % ex)"},{"line_number":68,"context_line":"            except Exception as ex:"},{"line_number":69,"context_line":"                LOG.exception(_LE(\"Failed to record event: %s\") % ex)"},{"line_number":70,"context_line":"                error \u003d ex"},{"line_number":71,"context_line":"        if error:"},{"line_number":72,"context_line":"            raise error"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aa745d1_91e5fea9","line":69,"updated":"2015-04-16 08:11:43.000000000","message":"Perhaps we should wrap this exception in a StorageUnknownWriteError to have the same interface in all drivers, or completly remove this except block, WDYT ?","commit_id":"35cba05d8bfbd6e91ec866c6003e8b8821d90d29"}]}