)]}'
{"ceilometer/compute/nova_notifier.py":[{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"4e73e0310173d6cbe980d05162d80f4a19e33112","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        try:"},{"line_number":63,"context_line":"            from nova.conductor import api"},{"line_number":64,"context_line":"        except ImportError:"},{"line_number":65,"context_line":"        # keep capability with folsom."},{"line_number":66,"context_line":"            _agent_manager.poll_instance(context,"},{"line_number":67,"context_line":"            db.instance_get_by_uuid(context, instance_id))"},{"line_number":68,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMX%2F%2F5Ok%3D","line":65,"updated":"2012-12-10 07:55:12.000000000","message":"Should be align with the followed line? \"keep\"-\u003e\"Keep\"? \"capability\" -\u003e \"compatibility\"?","commit_id":"e968ba28b9b4de54251d7e4a27c19d1d1f8a4633"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"bda00681c57007d1f83ad3dcc1172b353e9838dd","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        try:"},{"line_number":63,"context_line":"            from nova.conductor import api"},{"line_number":64,"context_line":"        except ImportError:"},{"line_number":65,"context_line":"        # keep capability with folsom."},{"line_number":66,"context_line":"            _agent_manager.poll_instance(context,"},{"line_number":67,"context_line":"            db.instance_get_by_uuid(context, instance_id))"},{"line_number":68,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMX%2F%2F5K0%3D","line":65,"in_reply_to":"AAAAMX%2F%2F5Ok%3D","updated":"2012-12-10 09:59:11.000000000","message":"Compatibility at least.","commit_id":"e968ba28b9b4de54251d7e4a27c19d1d1f8a4633"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"bda00681c57007d1f83ad3dcc1172b353e9838dd","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        except ImportError:"},{"line_number":65,"context_line":"        # keep capability with folsom."},{"line_number":66,"context_line":"            _agent_manager.poll_instance(context,"},{"line_number":67,"context_line":"            db.instance_get_by_uuid(context, instance_id))"},{"line_number":68,"context_line":"        else:"},{"line_number":69,"context_line":"            _agent_manager.poll_instance(context,"},{"line_number":70,"context_line":"            api.instance_get_by_uuid(context, instance_id))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMX%2F%2F5Kw%3D","line":67,"updated":"2012-12-10 09:59:11.000000000","message":"Could you aligne this properly, with at least one more tab?","commit_id":"e968ba28b9b4de54251d7e4a27c19d1d1f8a4633"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"1ff6a0f053b4860a7b54bef750cb8146a71e0079","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        try:"},{"line_number":63,"context_line":"            from nova.conductor import api"},{"line_number":64,"context_line":"        except ImportError:"},{"line_number":65,"context_line":"        # Keep compatibility with folsom."},{"line_number":66,"context_line":"            _agent_manager.poll_instance(context,"},{"line_number":67,"context_line":"                db.instance_get_by_uuid(context, instance_id))"},{"line_number":68,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAMX%2F%2F4Nw%3D","line":65,"updated":"2012-12-11 08:01:02.000000000","message":"You need an extra 4-space indent in the line above.","commit_id":"800b28860bf5eec1ec9fb28c33cc4cb83ed30332"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"2dd083075d8e906a0fee16107e813eb9fc2ae273","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    if message[\u0027event_type\u0027] \u003d\u003d \u0027compute.instance.delete.start\u0027:"},{"line_number":60,"context_line":"        instance_id \u003d message[\u0027payload\u0027][\u0027instance_id\u0027]"},{"line_number":61,"context_line":"        LOG.debug(\u0027polling final stats for %r\u0027, instance_id)"},{"line_number":62,"context_line":"        try:"},{"line_number":63,"context_line":"            from nova.conductor import api"},{"line_number":64,"context_line":"        except ImportError:"},{"line_number":65,"context_line":"            # Keep compatibility with folsom."}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2F4eA%3D","line":62,"updated":"2012-12-26 21:18:04.000000000","message":"It would be better if this import test was executed once, either on startup or the first time notify() is called. That way we don\u0027t add the overhead of searching for a missing module on every call. The method of the db and api objects appear to be the same, so it should be possible to do something like:\n\ntry:\n    from nova.conductor import api\n    instance_info_source \u003d api.API()\nexcept ImportError:\n    from nova import db as instance_info_source\n\nat the top of the module, then here do something like:\n\n_agent_manager.poll_instance(context, instance_info_source.instance_get_by_uuid(context, instance_id))","commit_id":"23ff2f9bbfc14e435c4c04ddddfba473cf2a829b"}],"tests/compute/test_nova_notifier.py":[{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"1f7ab5ef640377735defe0f96b8bd47e939ffa73","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                         \"access_ip_v6\": \"someip\","},{"line_number":120,"context_line":"                         \"metadata\": {},"},{"line_number":121,"context_line":"                         \"uuid\": \"144e08f4-00cb-11e2-888e-5453ed1bbb5f\"}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        self.stubs.Set(db, \u0027instance_info_cache_delete\u0027, self.do_nothing)"},{"line_number":124,"context_line":"        self.stubs.Set(db, \u0027instance_destroy\u0027, self.do_nothing)"},{"line_number":125,"context_line":"        self.stubs.Set(db, \u0027instance_system_metadata_get\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F5Rw%3D","line":122,"updated":"2012-12-10 06:44:37.000000000","message":"remove the extra blank line here?","commit_id":"985f49b6a31586c592b7d302f149f7af6deaa586"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"1f7ab5ef640377735defe0f96b8bd47e939ffa73","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            # expect the message bus to be available, or the remote"},{"line_number":166,"context_line":"            # controller to be there if the message bus is online."},{"line_number":167,"context_line":"            self.stubs.Set(nova.conductor.api.API, \u0027instance_get_by_uuid\u0027,"},{"line_number":168,"context_line":"            self.fake_db_instance_get)"},{"line_number":169,"context_line":"            with mock.patch(\u0027nova.conductor.api.API.instance_update\u0027):"},{"line_number":170,"context_line":"                self.compute.terminate_instance(self.context,"},{"line_number":171,"context_line":"                                                instance\u003dself.instance)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F5Rs%3D","line":168,"updated":"2012-12-10 06:44:37.000000000","message":"The alignment here need be fixed.","commit_id":"985f49b6a31586c592b7d302f149f7af6deaa586"}]}