)]}'
{"ceilometer/event/endpoint.py":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"121ce17554267b31a23818301fc56a4ddfc7dedd","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                if pipeline.source.support_event(notification[\u0027event_type\u0027]):"},{"line_number":79,"context_line":"                    supported_pipelines.append(pipeline)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        if not hasattr(self.manager, \"pipelines\") or supported_pipelines:"},{"line_number":82,"context_line":"            try:"},{"line_number":83,"context_line":"                event \u003d self.event_converter.to_event(notification)"},{"line_number":84,"context_line":"                if event is not None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_bb480dcd","line":81,"updated":"2015-05-22 11:11:47.000000000","message":"It seems that case when we have pipelines in manager will never try to convert notification to event, and tests do not cover it also.","commit_id":"757db3f0794f4d62b421dd4a655d2d7a20ad480f"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"1dba69470f9bb3bf7d5206aaed116a7e5e1fce93","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.process_notification(notification)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def process_notification(self, notification):"},{"line_number":75,"context_line":"        supported_pipelines \u003d []"},{"line_number":76,"context_line":"        if hasattr(self.manager, \"pipelines\"):"},{"line_number":77,"context_line":"            for pipeline in self.manager.pipelines:"},{"line_number":78,"context_line":"                if pipeline.source.support_event(notification[\u0027event_type\u0027]):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_0ce8c27b","line":75,"updated":"2015-06-05 13:03:34.000000000","message":"i think we can handle this a little simpler. as we use endpoints, oslo.messaging as the ability to define filter_rules to define whether the endpoint should receive the notification message or not. i think in ceilometer/notification.py we can actually  set the filter rule for this endpoint based on the pipeline... that way we don\u0027t have to pass pipelines around.\n\nsee: https://github.com/openstack/ceilometer/blob/e71e391a4f787e3875862b71cb1377537ef1a97e/ceilometer/agent/plugin_base.py#L96-L97\n\nand \n\nhttps://github.com/openstack/oslo.messaging/blob/097fb235b2a2de216d591ea9cf674b7ceeab4b06/oslo_messaging/notify/filter.py#L19-L37","commit_id":"699e2e6cceb8366c086e47edf4f1effcf5f475ec"}]}