)]}'
{"ceilometer/pipeline.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"afe61bcbac3f3569b323b671ecaed26f3838c914","unresolved":false,"context_lines":[{"line_number":284,"context_line":"            raise PipelineException("},{"line_number":285,"context_line":"                \"Required field %s not specified\" % err.args[0], cfg)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        self.interval \u003d cfg.get(\u0027interval\u0027)"},{"line_number":288,"context_line":"        try:"},{"line_number":289,"context_line":"            self.interval \u003d int(self.interval) if self.interval \\"},{"line_number":290,"context_line":"                else self.default_interval"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_d690b545","line":287,"updated":"2015-05-04 09:31:00.000000000","message":"self.interval \u003d cfg.get(\u0027interval\u0027, self.default_interval)","commit_id":"23900d4220b82bc484744ad332a1424c26d0e780"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"afe61bcbac3f3569b323b671ecaed26f3838c914","unresolved":false,"context_lines":[{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        self.interval \u003d cfg.get(\u0027interval\u0027)"},{"line_number":288,"context_line":"        try:"},{"line_number":289,"context_line":"            self.interval \u003d int(self.interval) if self.interval \\"},{"line_number":290,"context_line":"                else self.default_interval"},{"line_number":291,"context_line":"        except ValueError:"},{"line_number":292,"context_line":"            raise PipelineException(\"Invalid interval value\", cfg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_b693f94e","line":289,"updated":"2015-05-04 09:31:00.000000000","message":"self.interval \u003d int(self.interval)","commit_id":"23900d4220b82bc484744ad332a1424c26d0e780"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"afe61bcbac3f3569b323b671ecaed26f3838c914","unresolved":false,"context_lines":[{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    @property"},{"line_number":321,"context_line":"    def default_interval(self):"},{"line_number":322,"context_line":"        return 600"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"class Sink(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_76868114","line":322,"updated":"2015-05-04 09:31:00.000000000","message":"consider making this configurable?","commit_id":"23900d4220b82bc484744ad332a1424c26d0e780"},{"author":{"_account_id":16150,"name":"Lei Zhang","email":"lei.a.zhang@intel.com","username":"leizhang"},"change_message_id":"f0d50f03ef1ee4f50fea2b0e4217811b857ab64b","unresolved":false,"context_lines":[{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    @property"},{"line_number":321,"context_line":"    def default_interval(self):"},{"line_number":322,"context_line":"        return 600"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"class Sink(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_16950ddd","line":322,"in_reply_to":"3acd31a7_76868114","updated":"2015-05-04 10:19:48.000000000","message":"Thanks, I know it looks ugly, you mean give deployer control over this property？","commit_id":"23900d4220b82bc484744ad332a1424c26d0e780"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f33441356bd87b95e86c0c2bfaed9aa49feaee26","unresolved":false,"context_lines":[{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        self.interval \u003d cfg.get(\u0027interval\u0027, self.default_interval)"},{"line_number":288,"context_line":"        try:"},{"line_number":289,"context_line":"            self.interval \u003d int(self.interval)"},{"line_number":290,"context_line":"        except ValueError:"},{"line_number":291,"context_line":"            raise PipelineException(\"Invalid interval value\", cfg)"},{"line_number":292,"context_line":"        if self.interval \u003c\u003d 0:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_f5bf24f9","line":289,"updated":"2015-05-04 12:57:10.000000000","message":"i don\u0027t think we need the default_interval property as we don\u0027t actually use it anywhere. we can probably just use:\n\n  self.interval \u003d int(cfg.get(\u0027interval\u0027, 600))","commit_id":"4ba5a830ee47a4ef336e0cc1793122ac3e4175ce"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"6cbcfe3ab1a38a93861ef586fe07d7c7c06566ec","unresolved":false,"context_lines":[{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        self.interval \u003d cfg.get(\u0027interval\u0027, self.default_interval)"},{"line_number":288,"context_line":"        try:"},{"line_number":289,"context_line":"            self.interval \u003d int(self.interval)"},{"line_number":290,"context_line":"        except ValueError:"},{"line_number":291,"context_line":"            raise PipelineException(\"Invalid interval value\", cfg)"},{"line_number":292,"context_line":"        if self.interval \u003c\u003d 0:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_215d4979","line":289,"in_reply_to":"3acd31a7_2b440a19","updated":"2015-05-05 03:27:00.000000000","message":"yes, i think it\u0027s ok to hardcode it -- i don\u0027t think we should be adding it just for unittest.","commit_id":"4ba5a830ee47a4ef336e0cc1793122ac3e4175ce"},{"author":{"_account_id":16150,"name":"Lei Zhang","email":"lei.a.zhang@intel.com","username":"leizhang"},"change_message_id":"3f6994354c99a9ef43462646330846fe2c68f101","unresolved":false,"context_lines":[{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        self.interval \u003d cfg.get(\u0027interval\u0027, self.default_interval)"},{"line_number":288,"context_line":"        try:"},{"line_number":289,"context_line":"            self.interval \u003d int(self.interval)"},{"line_number":290,"context_line":"        except ValueError:"},{"line_number":291,"context_line":"            raise PipelineException(\"Invalid interval value\", cfg)"},{"line_number":292,"context_line":"        if self.interval \u003c\u003d 0:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_2b440a19","line":289,"in_reply_to":"3acd31a7_f5bf24f9","updated":"2015-05-05 00:54:49.000000000","message":"I use that value in unittest too, so it\u0027s ok to hard code 600 in unittest?","commit_id":"4ba5a830ee47a4ef336e0cc1793122ac3e4175ce"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"f30ea590a17fcf15d6036e042055a285cd9770cf","unresolved":false,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    @property"},{"line_number":320,"context_line":"    def default_interval(self):"},{"line_number":321,"context_line":"        return 600"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"class Sink(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_f1ba9b09","line":321,"updated":"2015-05-04 10:20:23.000000000","message":"I think this is better to be configurable, let\u0027s wait for other reviewers\u0027 opinion","commit_id":"4ba5a830ee47a4ef336e0cc1793122ac3e4175ce"}],"ceilometer/tests/pipeline_base.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"afe61bcbac3f3569b323b671ecaed26f3838c914","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def test_no_counters(self):"},{"line_number":200,"context_line":"        self._unset_pipeline_cfg(\u0027counters\u0027)"},{"line_number":201,"context_line":"        self._exception_create_pipelinemanager()"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def test_no_transformers(self):"},{"line_number":204,"context_line":"        self._unset_pipeline_cfg(\u0027transformers\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_76afa194","side":"PARENT","line":201,"updated":"2015-05-04 09:31:00.000000000","message":"why this line should be removed?","commit_id":"9f76e5b58044914066af972b118ad68b567e3b97"}]}