)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"29c234aa74c0f25ab2a23948b2371860e7efd23c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Added the following metrics for cinder pool monitoring"},{"line_number":8,"context_line":"1. storage_pool.free"},{"line_number":9,"context_line":"2. storage_pool.total"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I47d040ba5d647a5971ad7f04ba5e29802b0a29be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a016987_d54da69a","line":10,"updated":"2015-05-25 18:34:00.000000000","message":"add \u0027DocImpact\u0027 so we can document it accordingly","commit_id":"0d7094731225e8d1340aa2cf1e8803a2524fff52"}],"ceilometer/volume/notifications.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"209b7f26afea45c0d19951d52a094dbbcb33dd75","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            name\u003d\u0027storage_pool\u0027,"},{"line_number":88,"context_line":"            type\u003dsample.TYPE_GAUGE,"},{"line_number":89,"context_line":"            unit\u003d\u0027volume\u0027,"},{"line_number":90,"context_line":"            volume\u003d1,"},{"line_number":91,"context_line":"            user_id\u003dmessage[\u0027payload\u0027][\u0027user_id\u0027],"},{"line_number":92,"context_line":"            project_id\u003dmessage[\u0027payload\u0027][\u0027tenant_id\u0027],"},{"line_number":93,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027pool_uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_80959be5","line":90,"updated":"2015-05-06 19:13:36.000000000","message":"we are deprecating meters that do not measure anything going forward. this should be represented as an event and not a sample. see: https://github.com/openstack/ceilometer/blob/master/etc/ceilometer/event_definitions.yaml#L63-L78\n\nall this code will likely be removed sometime in Liberty but i\u0027m ok with adding this for now as that code is not ready","commit_id":"c6a5a4240298375d3afe76cd8f7668a1f6121a6e"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"15d81ae17ac2cf7fce5f34a6242eed3fa3b907e2","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            name\u003d\u0027storage_pool\u0027,"},{"line_number":88,"context_line":"            type\u003dsample.TYPE_GAUGE,"},{"line_number":89,"context_line":"            unit\u003d\u0027volume\u0027,"},{"line_number":90,"context_line":"            volume\u003d1,"},{"line_number":91,"context_line":"            user_id\u003dmessage[\u0027payload\u0027][\u0027user_id\u0027],"},{"line_number":92,"context_line":"            project_id\u003dmessage[\u0027payload\u0027][\u0027tenant_id\u0027],"},{"line_number":93,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027pool_uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_1f640fe2","line":90,"in_reply_to":"1aca2d91_47abec1d","updated":"2015-05-07 22:02:44.000000000","message":"well this could be captured as an event in Ceilometer. that might be useful. but i agree, as a meter it\u0027s not useful and should not be included","commit_id":"c6a5a4240298375d3afe76cd8f7668a1f6121a6e"},{"author":{"_account_id":15252,"name":"Anurag Palsule","email":"anurag@netapp.com","username":"anurag"},"change_message_id":"8488b019ab719cbf82d683af1c673a35d7ac4727","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            name\u003d\u0027storage_pool\u0027,"},{"line_number":88,"context_line":"            type\u003dsample.TYPE_GAUGE,"},{"line_number":89,"context_line":"            unit\u003d\u0027volume\u0027,"},{"line_number":90,"context_line":"            volume\u003d1,"},{"line_number":91,"context_line":"            user_id\u003dmessage[\u0027payload\u0027][\u0027user_id\u0027],"},{"line_number":92,"context_line":"            project_id\u003dmessage[\u0027payload\u0027][\u0027tenant_id\u0027],"},{"line_number":93,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027pool_uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_47abec1d","line":90,"in_reply_to":"1aca2d91_80959be5","updated":"2015-05-07 18:15:15.000000000","message":"I can remove these meters. They are not much helpful anyway.","commit_id":"c6a5a4240298375d3afe76cd8f7668a1f6121a6e"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"29c234aa74c0f25ab2a23948b2371860e7efd23c","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class PoolCRUDBase(VolumeBase):"},{"line_number":51,"context_line":"    \"\"\"Convert volume notifications into Counters.\"\"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    event_types \u003d ["},{"line_number":54,"context_line":"        \u0027storage_pool.exists\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_5573f6e7","line":51,"updated":"2015-05-25 18:34:00.000000000","message":"s/counters/samples/","commit_id":"0d7094731225e8d1340aa2cf1e8803a2524fff52"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"058127b4a13c534a1b0a4e82b10386c01a65a0dd","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                for topic in conf.notification_topics]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class PoolCRUDBase(VolumeBase):"},{"line_number":51,"context_line":"    \"\"\"Convert storage pool notifications into samples.\"\"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    event_types \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_56bca4ba","line":50,"updated":"2015-05-28 15:58:48.000000000","message":"nit: CRUD is a misnomer here. The class is only handling the exists case and not create, update or delete. So unless you\u0027re planning to add those events as well, i suggest you rename the class to PoolBase or something that suggests similar.","commit_id":"ebe44f87d9d04aa916678d44b6bc8d0ef8a8ab1d"}]}