)]}'
{"ceilometer/api/hooks.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"3b47539986053233f4012bc7f14ba82a23f730b1","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        try:"},{"line_number":54,"context_line":"            return storage.get_connection_from_config(cfg.CONF, purpose)"},{"line_number":55,"context_line":"        except Exception as e:"},{"line_number":56,"context_line":"            LOG.exception(e)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class PipelineHook(hooks.PecanHook):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_5c520868","line":56,"updated":"2015-05-25 13:49:26.000000000","message":"(nit) can we add a brief explanation? ie. https://github.com/openstack/ceilometer/blob/476045fe16f466cab8330f3cb8643894abdfcc03/ceilometer/dispatcher/database.py#L50-L51","commit_id":"506ea9030a1628bd956f22b284ecefba1aed77cc"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"f191696ac637027fcc48ab0606c9837aeee647a1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        except Exception as err:"},{"line_number":57,"context_line":"            params \u003d {\"purpose\": purpose, \"err\": err}"},{"line_number":58,"context_line":"            LOG.exception(_LE(\"Failed to connect to db, purpose %(purpose)s \""},{"line_number":59,"context_line":"                              \"re-try later: %(err)s\") % params)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class PipelineHook(hooks.PecanHook):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_be2622b8","line":59,"updated":"2015-05-28 09:06:58.000000000","message":"exception level log will print the exception message, so i think it is redundant, you can check in devstack and decide whether fix it or not","commit_id":"d887405ae75c23b11a0d473da9ce18bd621d2b01"},{"author":{"_account_id":13560,"name":"Rohit Jaiswal","email":"rohit.jaiswal@gmail.com","username":"rjaiswal"},"change_message_id":"1ccd055893fe351581db0f9c7cf69bc27a7ca849","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        except Exception as err:"},{"line_number":57,"context_line":"            params \u003d {\"purpose\": purpose, \"err\": err}"},{"line_number":58,"context_line":"            LOG.exception(_LE(\"Failed to connect to db, purpose %(purpose)s \""},{"line_number":59,"context_line":"                              \"re-try later: %(err)s\") % params)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class PipelineHook(hooks.PecanHook):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_1db9b279","line":59,"in_reply_to":"7a016987_be2622b8","updated":"2015-05-28 14:09:30.000000000","message":"@zqfan: this is the only exception log i get with a stack trace. The other message i get is this - WARNING ceilometer.storage.mongo.utils [-] Unable to connect to the database server: [Errno 111] ECONNREFUSED.","commit_id":"d887405ae75c23b11a0d473da9ce18bd621d2b01"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"9e80eaa36809eaadc33f1d070a61dbaa7528337b","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def __init__(self, conn, event_conn, alarm_conn):"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        if DBHook.conn_count \u003d\u003d DBHook.fail_conn_count:"},{"line_number":46,"context_line":"            raise Exception(\"Api failed to start. Failed to connect to \""},{"line_number":47,"context_line":"                            \"dbs, purpose:  %s\" % \u0027,\u0027.join(DBHook.fail_dbs))"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5afe65bd_8e3c56e3","line":45,"updated":"2015-06-03 18:39:12.000000000","message":"tbh, this counting is a bit odd. i\u0027m not sure why we pass in anything for init anything. we could initialise it all internally in the Hook no?","commit_id":"0a9fe122dfb78e47ec05410481fbb103434a3ba1"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"c14fdedc39e337ec4fe389c5425a242257e026e1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                not self.event_storage_connection and"},{"line_number":50,"context_line":"                not self.alarm_storage_connection):"},{"line_number":51,"context_line":"            raise Exception(\"Api failed to start. Failed to connect to \""},{"line_number":52,"context_line":"                            \"dbs, purpose:  %s\" %"},{"line_number":53,"context_line":"                            \u0027, \u0027.join([\u0027metering\u0027, \u0027event\u0027, \u0027alarm\u0027]))"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def before(self, state):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5afe65bd_5cd4ca45","line":52,"updated":"2015-06-04 03:34:58.000000000","message":"only complaint is that since this is user facing we should probably not use \u0027dbs\u0027, maybe make it \u0027databases\u0027","commit_id":"40eb254ba77e0c345fca4651b64159cec511de4b"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"c14fdedc39e337ec4fe389c5425a242257e026e1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            return storage.get_connection_from_config(cfg.CONF, purpose)"},{"line_number":64,"context_line":"        except Exception as err:"},{"line_number":65,"context_line":"            params \u003d {\"purpose\": purpose, \"err\": err}"},{"line_number":66,"context_line":"            LOG.exception(_LE(\"Failed to connect to db, purpose %(purpose)s \""},{"line_number":67,"context_line":"                              \"re-try later: %(err)s\") % params)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5afe65bd_fc97f68d","line":66,"updated":"2015-06-04 03:34:58.000000000","message":"s/re-try/retry/","commit_id":"40eb254ba77e0c345fca4651b64159cec511de4b"}],"ceilometer/tests/test_bin.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"ce4cbfbd2f06df1cb4ba2eba2f734a6bb9aaefbe","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                          self.paste,"},{"line_number":180,"context_line":"                          self.api_port))"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        if six.PY3:"},{"line_number":183,"context_line":"            content \u003d content.encode(\u0027utf-8\u0027)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        self.tempfile \u003d fileutils.write_to_tempfile(content\u003dcontent,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_a91dee67","line":182,"updated":"2015-05-27 14:33:35.000000000","message":"not a blocker but it\u0027d be nicer if we shared code a bit more.","commit_id":"b507acaf79cef75fdb31e3e5b04513e5251c1c09"}]}