)]}'
{"ceilometer/dispatcher/file.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"69777b1ee213a5d02619da0d2c46416f3d43276e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            # create rotating file handler which logs meters"},{"line_number":64,"context_line":"            rfh \u003d logging.handlers.RotatingFileHandler("},{"line_number":65,"context_line":"                self.conf.dispatcher_file.file_path,"},{"line_number":66,"context_line":"                maxBytes\u003dself.conf.dispatcher_file.max_bytes or 0,"},{"line_number":67,"context_line":"                backupCount\u003dself.conf.dispatcher_file.backup_count,"},{"line_number":68,"context_line":"                encoding\u003d\u0027utf8\u0027)"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_a0002302","line":66,"updated":"2015-05-28 19:24:05.000000000","message":"why do we need \u0027or 0\u0027 here but not for the one below?","commit_id":"683968b1bc87029db33f3dce73c2dd156aa58a79"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"b537e84a0bc5ecd83c25a47f4080f438050238a0","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            # create rotating file handler which logs meters"},{"line_number":64,"context_line":"            rfh \u003d logging.handlers.RotatingFileHandler("},{"line_number":65,"context_line":"                self.conf.dispatcher_file.file_path,"},{"line_number":66,"context_line":"                maxBytes\u003dself.conf.dispatcher_file.max_bytes or 0,"},{"line_number":67,"context_line":"                backupCount\u003dself.conf.dispatcher_file.backup_count,"},{"line_number":68,"context_line":"                encoding\u003d\u0027utf8\u0027)"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_c02e7f8b","line":66,"in_reply_to":"7a016987_a0002302","updated":"2015-05-28 19:25:21.000000000","message":"whoops i should read commit message... that said, the default is \u00270\u0027... maybe the test is incorrectly passing in None?","commit_id":"683968b1bc87029db33f3dce73c2dd156aa58a79"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"b638300be76ec4c778f2e245ab167df0f110f858","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            # create rotating file handler which logs meters"},{"line_number":64,"context_line":"            rfh \u003d logging.handlers.RotatingFileHandler("},{"line_number":65,"context_line":"                self.conf.dispatcher_file.file_path,"},{"line_number":66,"context_line":"                maxBytes\u003dself.conf.dispatcher_file.max_bytes or 0,"},{"line_number":67,"context_line":"                backupCount\u003dself.conf.dispatcher_file.backup_count,"},{"line_number":68,"context_line":"                encoding\u003d\u0027utf8\u0027)"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_eef73389","line":66,"in_reply_to":"7a016987_c02e7f8b","updated":"2015-06-09 09:47:55.000000000","message":"You\u0027re right. This change was a workaround specific to unit tests. I reverted this changed and fixed the unit test instead. Thanks for the advice.","commit_id":"683968b1bc87029db33f3dce73c2dd156aa58a79"}],"ceilometer/tests/storage/test_get_connection.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"61be1ee532ac124824caa22963e96fccd4240070","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        conn \u003d storage.get_connection_from_config(self.CONF, \u0027event\u0027)"},{"line_number":107,"context_line":"        self.assertIsInstance(conn, impl_hbase_event.Connection)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @unittest.skipIf(impl_hbase_event is None, \u0027need hbase implementation\u0027)"},{"line_number":110,"context_line":"    def test_three_urls_no_default(self):"},{"line_number":111,"context_line":"        self.CONF.set_override(\"connection\", None, group\u003d\"database\")"},{"line_number":112,"context_line":"        self.CONF.set_override(\"metering_connection\", \"log://\","}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_efbe2afe","line":109,"updated":"2015-05-28 06:34:00.000000000","message":"skipUnless(impl_hbase_event, …)","commit_id":"8977d4e7c67945657583edfff4ffaeeb9c7a6e3f"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"68d534d22c2bdd264b1a5f1ec34932896f177d09","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        conn \u003d storage.get_connection_from_config(self.CONF, \u0027event\u0027)"},{"line_number":107,"context_line":"        self.assertIsInstance(conn, impl_hbase_event.Connection)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @unittest.skipIf(impl_hbase_event is None, \u0027need hbase implementation\u0027)"},{"line_number":110,"context_line":"    def test_three_urls_no_default(self):"},{"line_number":111,"context_line":"        self.CONF.set_override(\"connection\", None, group\u003d\"database\")"},{"line_number":112,"context_line":"        self.CONF.set_override(\"metering_connection\", \"log://\","}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_e8b4e035","line":109,"in_reply_to":"7a016987_efbe2afe","updated":"2015-05-28 08:01:20.000000000","message":"Oh sorry, I missed your comment. I changed it too in patch set 3. I also modified the existing skipIf().","commit_id":"8977d4e7c67945657583edfff4ffaeeb9c7a6e3f"}]}