)]}'
{"ceilometer/objectstore/swift_middleware.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"38422e6e57c20f04d808fcd017bdcaac2f2182c3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    from swift.common.utils import InputProxy"},{"line_number":40,"context_line":"except ImportError:"},{"line_number":41,"context_line":"    # Swift \u003c\u003d 1.7.5"},{"line_number":42,"context_line":"    from swift.common.middleware.proxy_logging import InputProxy"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class CeilometerMiddleware(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fz00%3D","line":42,"updated":"2013-01-04 09:43:33.000000000","message":"Can we roll the attempts to import Request and InputProxy into a single try block?\n\n(i.e. if the 1.7.5+ version of the one class is loadable, presumably the other would be also, and conversely if one is not available)","commit_id":"cd0f6c28f11b5aceec4f7dafcea1bb4449fac965"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"a903a54e5b2145710b84e50669dfe17f1c646c69","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    from swift.common.utils import InputProxy"},{"line_number":40,"context_line":"except ImportError:"},{"line_number":41,"context_line":"    # Swift \u003c\u003d 1.7.5"},{"line_number":42,"context_line":"    from swift.common.middleware.proxy_logging import InputProxy"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class CeilometerMiddleware(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fz0Q%3D","line":42,"in_reply_to":"AAAAM3%2F%2Fz00%3D","updated":"2013-01-04 09:58:16.000000000","message":"That would look like:\n\n\ntry:\n    # Swift \u003e 1.7.5\n    from swift.common.utils import InputProxy\n    from swift.common.swob import Request\nexcept ImportError:\n    try:\n        # Swift \u003e\u003d 1.7.5\n        from swift.common.middleware.proxy_logging import InputProxy\n        from swift.common.swob import Request\n    except ImportError:\n        from swift.common.middleware.proxy_logging import InputProxy\n        from webob import Request\n\n\nIs this really better?","commit_id":"cd0f6c28f11b5aceec4f7dafcea1bb4449fac965"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"f3197eca7d35fba92ca39810ad5035be26dacf8c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    from swift.common.utils import InputProxy"},{"line_number":40,"context_line":"except ImportError:"},{"line_number":41,"context_line":"    # Swift \u003c\u003d 1.7.5"},{"line_number":42,"context_line":"    from swift.common.middleware.proxy_logging import InputProxy"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class CeilometerMiddleware(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fzyw%3D","line":42,"in_reply_to":"AAAAM3%2F%2Fz0Q%3D","updated":"2013-01-04 10:42:41.000000000","message":"A-ha, I see, I missed the \u003e1.7.5 versus \u003e\u003d1.7.5 distinction.","commit_id":"cd0f6c28f11b5aceec4f7dafcea1bb4449fac965"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"86f177434244163baa22bcb3ee85916537600d63","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    from swift.common.utils import InputProxy"},{"line_number":40,"context_line":"except ImportError:"},{"line_number":41,"context_line":"    # Swift \u003c\u003d 1.7.5"},{"line_number":42,"context_line":"    from swift.common.middleware.proxy_logging import InputProxy"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class CeilometerMiddleware(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fzx4%3D","line":42,"in_reply_to":"AAAAM3%2F%2Fzyw%3D","updated":"2013-01-04 11:04:58.000000000","message":"Hehe I thought so :)","commit_id":"cd0f6c28f11b5aceec4f7dafcea1bb4449fac965"}]}