)]}'
{"tests/compute/test_nova_notifier.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"bc612c70cb2f836b9cf2bd8a54c66f141b3eef27","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                                    self.Pollster(),"},{"line_number":141,"context_line":"                                    ),"},{"line_number":142,"context_line":"                ])"},{"line_number":143,"context_line":"        nova_notifier.initialize_manager(agent_manager)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def tearDown(self):"},{"line_number":146,"context_line":"        self.Pollster.counters \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fvww%3D","line":143,"updated":"2013-01-07 20:45:02.000000000","message":"This is going to leave the AgentManager instantiated by the test configured in the nova_notifier module after the test runs. I don\u0027t think that will be an issue, now, but it would be a good idea to update tearDown() to clear the object to avoid issues in the future.","commit_id":"0f17cada7530ec5c4ca955c183af66b2ca4acb17"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"79f93c8cc8dd7dce8ad34abf49692ed252891287","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                                    self.Pollster(),"},{"line_number":141,"context_line":"                                    ),"},{"line_number":142,"context_line":"                ])"},{"line_number":143,"context_line":"        nova_notifier.initialize_manager(agent_manager)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def tearDown(self):"},{"line_number":146,"context_line":"        self.Pollster.counters \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fvhw%3D","line":143,"in_reply_to":"AAAAM3%2F%2Fvww%3D","updated":"2013-01-08 09:00:35.000000000","message":"Doug, I think it will be ok. The reason is, the setup() will be called for each test case, and  the  _agent_manager will be reset to new AgentManager instance, thus the old one will lost the reference and be freed.\n\nOf course, if other test suites import this module also and does not call initialize_manager, it will be a issue.(BTW, I think we have such issue on current implementation also, right)? \n\nI update the teadDown() to clean the _agent_manager. I\u0027m not sure if it\u0027s ok to access the _agent_manager directly from the test case, but I don\u0027t want to add a new method like clear_manager to the nova_notifier module purely for test purpose.\n\nThanks\n\n--jyh","commit_id":"0f17cada7530ec5c4ca955c183af66b2ca4acb17"}]}