)]}'
{"ceilometer/tests/publisher/test_messaging_publisher.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"0354d39dfd339710ce0b5d9657033c27a25ad577","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            fake_send.assert_called_once_with("},{"line_number":295,"context_line":"                mock.ANY, self.topic, mock.ANY)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    @mock.patch(\u0027ceilometer.publisher.messaging.LOG\u0027, mock.Mock())"},{"line_number":298,"context_line":"    def test_published_with_policy_drop_and_rpc_down(self):"},{"line_number":299,"context_line":"        publisher \u003d self.publisher_cls("},{"line_number":300,"context_line":"            netutils.urlsplit(\u0027%s://?policy\u003ddrop\u0027 % self.protocol))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_c998cc77","line":297,"updated":"2015-06-25 06:37:29.000000000","message":"I think we don\u0027t need mock.Mock() here, just follow Ln280, mock.patch will use MagicMock() by default.\n\nAlso, would it be possible to put all the negative tests into a single test class and have it mock.patch() once instead of using the decorator on every test cases?","commit_id":"0abf3f9b444b3e642bd6d74c680ee8bb8d85cd06"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"3130d2a921a03c1f6c19d846d2e353fabafef843","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            fake_send.assert_called_once_with("},{"line_number":295,"context_line":"                mock.ANY, self.topic, mock.ANY)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    @mock.patch(\u0027ceilometer.publisher.messaging.LOG\u0027, mock.Mock())"},{"line_number":298,"context_line":"    def test_published_with_policy_drop_and_rpc_down(self):"},{"line_number":299,"context_line":"        publisher \u003d self.publisher_cls("},{"line_number":300,"context_line":"            netutils.urlsplit(\u0027%s://?policy\u003ddrop\u0027 % self.protocol))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_97fbafc0","line":297,"in_reply_to":"fa32b979_c998cc77","updated":"2015-06-25 12:19:26.000000000","message":"if you don\u0027t add mock you have to add it to method parameters... and i don\u0027t ever intend on using it.","commit_id":"0abf3f9b444b3e642bd6d74c680ee8bb8d85cd06"}]}