)]}'
{"ceilometer/api/controllers/v2/alarm_rules/event.py":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"c104193e71a6687e2c57a59fb777507219da1a76","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self, event_type\u003dNone, query\u003dNone):"},{"line_number":39,"context_line":"        if event_type is None:"},{"line_number":40,"context_line":"            event_type \u003d \u0027*\u0027"},{"line_number":41,"context_line":"        if query is None:"},{"line_number":42,"context_line":"            query \u003d []"},{"line_number":43,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_d3b2bd48","line":40,"updated":"2015-06-25 05:06:58.000000000","message":"can be simplified to:\n\nevent_type \u003d event_type or \u0027*\u0027\n\nquery \u003d query or []","commit_id":"e46e9d708beeb47930da3f73ea646d48b039eeda"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"5c9bf6e83c8b70f2aefacf928241e1ac290995e9","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self, event_type\u003dNone, query\u003dNone):"},{"line_number":39,"context_line":"        if event_type is None:"},{"line_number":40,"context_line":"            event_type \u003d \u0027*\u0027"},{"line_number":41,"context_line":"        if query is None:"},{"line_number":42,"context_line":"            query \u003d []"},{"line_number":43,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_5a8d357a","line":40,"in_reply_to":"fa32b979_d3b2bd48","updated":"2015-06-29 04:37:05.000000000","message":"OK\n\nI will merge L41-44 to a single line.","commit_id":"e46e9d708beeb47930da3f73ea646d48b039eeda"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"c104193e71a6687e2c57a59fb777507219da1a76","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @staticmethod"},{"line_number":49,"context_line":"    def validate(event_rule):"},{"line_number":50,"context_line":"        return event_rule"},{"line_number":51,"context_line":"        v2_utils.validate_query(event_rule.query,"},{"line_number":52,"context_line":"                                storage.EventFilter.__init__,"},{"line_number":53,"context_line":"                                allow_timestamps\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_b33299f0","line":50,"updated":"2015-06-25 05:06:58.000000000","message":"I guess this is your mistake :-)","commit_id":"e46e9d708beeb47930da3f73ea646d48b039eeda"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"5c9bf6e83c8b70f2aefacf928241e1ac290995e9","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @staticmethod"},{"line_number":49,"context_line":"    def validate(event_rule):"},{"line_number":50,"context_line":"        return event_rule"},{"line_number":51,"context_line":"        v2_utils.validate_query(event_rule.query,"},{"line_number":52,"context_line":"                                storage.EventFilter.__init__,"},{"line_number":53,"context_line":"                                allow_timestamps\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_1a3c8d92","line":50,"in_reply_to":"fa32b979_b33299f0","updated":"2015-06-29 04:37:05.000000000","message":"Ah, actually I\u0027m still wondering why we need this function. Maybe I will use validate_alarm for the alarm validation as the same as gnocchi types.","commit_id":"e46e9d708beeb47930da3f73ea646d48b039eeda"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"c104193e71a6687e2c57a59fb777507219da1a76","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        return event_rule"},{"line_number":51,"context_line":"        v2_utils.validate_query(event_rule.query,"},{"line_number":52,"context_line":"                                storage.EventFilter.__init__,"},{"line_number":53,"context_line":"                                allow_timestamps\u003dFalse)"},{"line_number":54,"context_line":"        return event_rule"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_f3a581a1","line":53,"updated":"2015-06-25 05:06:58.000000000","message":"should the format of event_type also be validated ?","commit_id":"e46e9d708beeb47930da3f73ea646d48b039eeda"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"5c9bf6e83c8b70f2aefacf928241e1ac290995e9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        return event_rule"},{"line_number":51,"context_line":"        v2_utils.validate_query(event_rule.query,"},{"line_number":52,"context_line":"                                storage.EventFilter.__init__,"},{"line_number":53,"context_line":"                                allow_timestamps\u003dFalse)"},{"line_number":54,"context_line":"        return event_rule"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_1a632db3","line":53,"in_reply_to":"fa32b979_f3a581a1","updated":"2015-06-29 04:37:05.000000000","message":"This can be done by Alarm.validate().","commit_id":"e46e9d708beeb47930da3f73ea646d48b039eeda"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"51e5c9fa870d6cf0435ef45a0a4cb748fd93e3c6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ceilometer.api.controllers.v2 import base"},{"line_number":22,"context_line":"from ceilometer.i18n import _"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo_log import log"},{"line_number":25,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_f86b15b7","line":24,"updated":"2015-07-09 14:11:52.000000000","message":"Please, order imports in next order:\n\nstandard library imports\nrelated third party imports\nlocal application/library specific imports.\n\nIt\u0027s a pep8 requirement","commit_id":"4d10c14cccca8a559b8abfc3cfef222d36ed6e38"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"7bbf650f4d7187f94e6883578bd5003e61322d14","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ceilometer.api.controllers.v2 import base"},{"line_number":22,"context_line":"from ceilometer.i18n import _"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo_log import log"},{"line_number":25,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_e4548f55","line":24,"in_reply_to":"ba3cc151_f86b15b7","updated":"2015-07-13 01:25:25.000000000","message":"LOG isn\u0027t be used - I\u0027ll remove line 23-24.","commit_id":"4d10c14cccca8a559b8abfc3cfef222d36ed6e38"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"51e5c9fa870d6cf0435ef45a0a4cb748fd93e3c6","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class AlarmEventRule(base.AlarmRule):"},{"line_number":29,"context_line":"    \"\"\"Alarm Event Rule"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    Describe when to trigger the alarm based on an event"},{"line_number":32,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_0d455d6d","line":29,"updated":"2015-07-09 14:11:52.000000000","message":"Please, add period to the end of the first docsting line.","commit_id":"4d10c14cccca8a559b8abfc3cfef222d36ed6e38"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"7bbf650f4d7187f94e6883578bd5003e61322d14","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class AlarmEventRule(base.AlarmRule):"},{"line_number":29,"context_line":"    \"\"\"Alarm Event Rule"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    Describe when to trigger the alarm based on an event"},{"line_number":32,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_245a7784","line":29,"in_reply_to":"ba3cc151_0d455d6d","updated":"2015-07-13 01:25:25.000000000","message":"Done","commit_id":"4d10c14cccca8a559b8abfc3cfef222d36ed6e38"}],"ceilometer/tests/api/v2/test_alarm_scenarios.py":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"c104193e71a6687e2c57a59fb777507219da1a76","unresolved":false,"context_lines":[{"line_number":2858,"context_line":"            \u0027enabled\u0027: True,"},{"line_number":2859,"context_line":"            \u0027name\u0027: \u0027added_alarm_defaults\u0027,"},{"line_number":2860,"context_line":"            \u0027state\u0027: \u0027insufficient data\u0027,"},{"line_number":2861,"context_line":"            \u0027description\u0027: (\u0027Alarm when * event occurred.\u0027),"},{"line_number":2862,"context_line":"            \u0027type\u0027: \u0027event\u0027,"},{"line_number":2863,"context_line":"            \u0027ok_actions\u0027: [],"},{"line_number":2864,"context_line":"            \u0027alarm_actions\u0027: [],"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_f374a168","line":2861,"updated":"2015-06-25 05:06:58.000000000","message":"the parentheses is redundant.","commit_id":"e46e9d708beeb47930da3f73ea646d48b039eeda"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"5c9bf6e83c8b70f2aefacf928241e1ac290995e9","unresolved":false,"context_lines":[{"line_number":2858,"context_line":"            \u0027enabled\u0027: True,"},{"line_number":2859,"context_line":"            \u0027name\u0027: \u0027added_alarm_defaults\u0027,"},{"line_number":2860,"context_line":"            \u0027state\u0027: \u0027insufficient data\u0027,"},{"line_number":2861,"context_line":"            \u0027description\u0027: (\u0027Alarm when * event occurred.\u0027),"},{"line_number":2862,"context_line":"            \u0027type\u0027: \u0027event\u0027,"},{"line_number":2863,"context_line":"            \u0027ok_actions\u0027: [],"},{"line_number":2864,"context_line":"            \u0027alarm_actions\u0027: [],"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_fa81a94e","line":2861,"in_reply_to":"fa32b979_f374a168","updated":"2015-06-29 04:37:05.000000000","message":"Done","commit_id":"e46e9d708beeb47930da3f73ea646d48b039eeda"}]}