)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"14f7e3d8518b8f587fb69091035e913ff4a91212","unresolved":false,"context_lines":[{"line_number":14,"context_line":"changed the error message to add the valid operators as part of suggestion."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The fix is same as previous just run the pep8 test and changed the formatting accordingly."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I82ed0b8b61ed5bf297efe890cee10000f5ffb7a8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_d516f654","line":17,"updated":"2015-06-29 06:18:11.000000000","message":"please see the wiki of the format of commit message or reference other patches.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"b05140864eaed70be0589fb63607e9bdc1e413cc"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"9b30c7b73308c8cc71d683add0ad222e8f4242cb","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2015-06-29 10:17:45 +0530"},{"line_number":4,"context_line":"Commit:     Shubham Chitranshi \u003cshubham@hitachi.co.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-29 12:37:03 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Author: shubham_chitranshi"},{"line_number":8,"context_line":"Date: Mon 29th June 2015 10:20 AM (Indian Standard Time)"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_fbce88b3","line":6,"updated":"2015-06-30 01:56:11.000000000","message":"https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"50c15108b694723d807c9b8e5ae97d3fe9e1e62a"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"511236bc143bb28a8f54197abef255b87009ee97","unresolved":false,"context_lines":[{"line_number":10,"context_line":"BugFix for BugID - https://bugs.launchpad.net/ceilometer/+bug/1407378"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"File Changed - ceilometer/api/controllers/v2/events.py"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"changed the error message to add the valid operators as part of suggestion."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The fix is same as previous just run the pep8 test and changed the formatting accordingly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_a7f8da7d","line":13,"updated":"2015-06-29 13:44:11.000000000","message":"remove the above lines. These are covered by the git message. See the commit message format https://wiki.openstack.org/wiki/GitCommitMessages#Examples_of_good_practice","commit_id":"50c15108b694723d807c9b8e5ae97d3fe9e1e62a"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"511236bc143bb28a8f54197abef255b87009ee97","unresolved":false,"context_lines":[{"line_number":14,"context_line":"changed the error message to add the valid operators as part of suggestion."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The fix is same as previous just run the pep8 test and changed the formatting accordingly."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"changed the code to use one format string"},{"line_number":19,"context_line":"Change-Id: I82ed0b8b61ed5bf297efe890cee10000f5ffb7a8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_073ae636","line":17,"updated":"2015-06-29 13:44:11.000000000","message":"Add\n\nCloses-Bug: #1407378","commit_id":"50c15108b694723d807c9b8e5ae97d3fe9e1e62a"},{"author":{"_account_id":13367,"name":"Pradyumna Sampath","email":"pradyumna@hitachi.co.in","username":"prady"},"change_message_id":"b7b9f11888d69754e167af6ed7b6e60f3830fef9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shubham Chitranshi \u003cshubham@hitachi.co.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-07 10:45:34 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Author: shubham_chitranshi"},{"line_number":8,"context_line":"Date: Mon 29th June 2015 10:20 AM (Indian Standard Time)"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"BugFix for BugID - https://bugs.launchpad.net/ceilometer/+bug/1407378"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba3cc151_6ef1186a","line":7,"updated":"2015-07-07 05:26:26.000000000","message":"Redundant information. Please see earlier review comments.","commit_id":"14d0aac3c85d5efe74cb3d12d592f5ef1065dc1b"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"da565c3e5f6e4c87755017f7c0af22ce5fa4d6f2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shubham Chitranshi \u003cshubham@hitachi.co.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-07 10:45:34 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Author: shubham_chitranshi"},{"line_number":8,"context_line":"Date: Mon 29th June 2015 10:20 AM (Indian Standard Time)"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"BugFix for BugID - https://bugs.launchpad.net/ceilometer/+bug/1407378"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba3cc151_c93a9ecd","line":7,"updated":"2015-07-07 05:33:29.000000000","message":"The correct syntax of the commit should be:\n\n\u003ccommit change subject\u003e\nnew-line\n\u003ccommit-description\u003e\n\nDont need to state changed files, we can see that, also add the following line\nto the commit:\n\n\"Closes-Bug: #\u003cbug-id\u003e\"\n\nFor the bug you addressed in your commit","commit_id":"14d0aac3c85d5efe74cb3d12d592f5ef1065dc1b"},{"author":{"_account_id":13367,"name":"Pradyumna Sampath","email":"pradyumna@hitachi.co.in","username":"prady"},"change_message_id":"b7b9f11888d69754e167af6ed7b6e60f3830fef9","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Date: Mon 29th June 2015 10:20 AM (Indian Standard Time)"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"BugFix for BugID - https://bugs.launchpad.net/ceilometer/+bug/1407378"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"File Changed - ceilometer/api/controllers/v2/events.py"},{"line_number":13,"context_line":"File Changed - ceilometer/tests/api/v2/test_event_scenarios.py"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba3cc151_8efc9c3f","line":11,"updated":"2015-07-07 05:26:26.000000000","message":"See earlier comments.","commit_id":"14d0aac3c85d5efe74cb3d12d592f5ef1065dc1b"},{"author":{"_account_id":13367,"name":"Pradyumna Sampath","email":"pradyumna@hitachi.co.in","username":"prady"},"change_message_id":"744fd70439e47babf12b748c1d10c33e3645712c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shubham Chitranshi \u003cshubham@hitachi.co.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-07 11:27:26 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding valid values of operator to response, when query operator is invalid for ceilometer event api call"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1) when the event query is requested with invalid operator as query parameter,"},{"line_number":10,"context_line":"added the valid operator list to the response."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba3cc151_e4cc6763","line":7,"updated":"2015-07-07 06:33:04.000000000","message":"Please summarize with a shorter title.","commit_id":"d78b075d2b8bf069c94fc3c4bf89ed5530b8cdfb"},{"author":{"_account_id":13367,"name":"Pradyumna Sampath","email":"pradyumna@hitachi.co.in","username":"prady"},"change_message_id":"744fd70439e47babf12b748c1d10c33e3645712c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding valid values of operator to response, when query operator is invalid for ceilometer event api call"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1) when the event query is requested with invalid operator as query parameter,"},{"line_number":10,"context_line":"added the valid operator list to the response."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1407378"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba3cc151_6492974d","line":9,"updated":"2015-07-07 06:33:04.000000000","message":"nit: Why is \"1)\" required ?","commit_id":"d78b075d2b8bf069c94fc3c4bf89ed5530b8cdfb"},{"author":{"_account_id":13367,"name":"Pradyumna Sampath","email":"pradyumna@hitachi.co.in","username":"prady"},"change_message_id":"744fd70439e47babf12b748c1d10c33e3645712c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adding valid values of operator to response, when query operator is invalid for ceilometer event api call"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1) when the event query is requested with invalid operator as query parameter,"},{"line_number":10,"context_line":"added the valid operator list to the response."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1407378"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba3cc151_c4a3639d","line":10,"updated":"2015-07-07 06:33:04.000000000","message":"Isnt this redundant with the title ?","commit_id":"d78b075d2b8bf069c94fc3c4bf89ed5530b8cdfb"}],"ceilometer/api/controllers/v2/events.py":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"14f7e3d8518b8f587fb69091035e913ff4a91212","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        elif i.op not in base.operation_kind:"},{"line_number":172,"context_line":"            error \u003d (_((\u0027operator {} is not supported. the supported\u0027"},{"line_number":173,"context_line":"                        \u0027 data type is: %(supported)s\u0027) %"},{"line_number":174,"context_line":"                     {\u0027type\u0027: type, \u0027supported\u0027: base.operation_kind}"},{"line_number":175,"context_line":"                       ).format(i.op))"},{"line_number":176,"context_line":"            raise base.ClientSideError(error)"},{"line_number":177,"context_line":"        if i.field in evt_model_filter:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_c71f2d5a","line":174,"updated":"2015-06-29 06:18:11.000000000","message":"please don\u0027t use both the *format* method of string and the string formatting operator \"%\" meanwhile.","commit_id":"b05140864eaed70be0589fb63607e9bdc1e413cc"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"429033e0b09ac37aaf22e0c9c030cf5225649f7d","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        if not i.op:"},{"line_number":170,"context_line":"            i.op \u003d \u0027eq\u0027"},{"line_number":171,"context_line":"        elif i.op not in base.operation_kind:"},{"line_number":172,"context_line":"            error \u003d (_(\u0027operator %(operator)s is not supported. the supported\u0027"},{"line_number":173,"context_line":"                       \u0027 data type is: %(supported)s\u0027) %"},{"line_number":174,"context_line":"                     {\u0027operator\u0027: i.op, \u0027supported\u0027: base.operation_kind})"},{"line_number":175,"context_line":"            raise base.ClientSideError(error)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_3fb49133","line":172,"updated":"2015-07-07 09:37:06.000000000","message":"you forgot a \u0027The\u0027 befor \"operator ...\" that cause the jenkins failure. or change the test.","commit_id":"d78b075d2b8bf069c94fc3c4bf89ed5530b8cdfb"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"65a5b25a88fccabfaea5025226bd07b43b6d7b7e","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            i.op \u003d \u0027eq\u0027"},{"line_number":171,"context_line":"        elif i.op not in base.operation_kind:"},{"line_number":172,"context_line":"            error \u003d (_(\u0027operator %(operator)s is not supported. the supported\u0027"},{"line_number":173,"context_line":"                       \u0027 data type is: %(supported)s\u0027) %"},{"line_number":174,"context_line":"                     {\u0027operator\u0027: i.op, \u0027supported\u0027: base.operation_kind})"},{"line_number":175,"context_line":"            raise base.ClientSideError(error)"},{"line_number":176,"context_line":"        if i.field in evt_model_filter:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_cd3775e1","line":173,"updated":"2015-07-09 13:53:11.000000000","message":"the \u0027data type\u0027 is a bit confusing, maybe \u0027operators\u0027 or \u0027operation kind\u0027 is better.","commit_id":"027519d59cc44fcf7c5c7e0c58f04cf8beda3738"}],"ceilometer/tests/api/v2/test_event_scenarios.py":[{"author":{"_account_id":13367,"name":"Pradyumna Sampath","email":"pradyumna@hitachi.co.in","username":"prady"},"change_message_id":"b7b9f11888d69754e167af6ed7b6e60f3830fef9","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                         \"supported data type list is: [\\\u0027integer\\\u0027, \""},{"line_number":207,"context_line":"                         \"\\\u0027float\\\u0027, \\\u0027string\\\u0027, \\\u0027datetime\\\u0027]\","},{"line_number":208,"context_line":"                         resp.json[\u0027error_message\u0027][\u0027faultstring\u0027])"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def test_get_events_filter_operator_invalid_type(self):"},{"line_number":212,"context_line":"        resp \u003d self.get_json(self.PATH, headers\u003dheaders,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_8eaa5c18","line":209,"updated":"2015-07-07 05:26:26.000000000","message":"Please remove this additional line.","commit_id":"14d0aac3c85d5efe74cb3d12d592f5ef1065dc1b"}]}