)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"7b5a49e7a3b533212dfa7356cddee4b975df9202","unresolved":false,"context_lines":[{"line_number":9,"context_line":"this patch makes existing limit options in meter and samples apis"},{"line_number":10,"context_line":"mandatory. if not set explicitly, a default limit will be applied."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie354e8e64a6f8677a0be7e75c34e8901cdffbc6a"},{"line_number":13,"context_line":"Implements: blueprint mandatory-limit"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_dc6a1381","line":12,"updated":"2015-07-01 16:58:28.000000000","message":"-1: DocImpact tag is needed since new option is introduced\n\nand maybe ApiImpact is needed as well","commit_id":"2f9a3723105fd4e2e92c93c80f42610231276650"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"ad7f11b62ea76cb22aeee19b56593060b0b2f71a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"this patch makes existing limit options in meter and samples apis"},{"line_number":10,"context_line":"mandatory. if not set explicitly, a default limit will be applied."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie354e8e64a6f8677a0be7e75c34e8901cdffbc6a"},{"line_number":13,"context_line":"Implements: blueprint mandatory-limit"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_42710e75","line":12,"in_reply_to":"ba3cc151_dc6a1381","updated":"2015-07-02 14:30:05.000000000","message":"will do","commit_id":"2f9a3723105fd4e2e92c93c80f42610231276650"}],"ceilometer/api/app.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"cacb44ddc41be558d57faa802fa7af3947c671fd","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                default\u003dFalse,"},{"line_number":48,"context_line":"                help\u003d\u0027Toggle Pecan Debug Middleware.\u0027),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027default_api_return_limit\u0027,"},{"line_number":50,"context_line":"               default\u003d100,"},{"line_number":51,"context_line":"               help\u003d\u0027Default maximum number of items returned by API request.\u0027"},{"line_number":52,"context_line":"               ),"},{"line_number":53,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_d0f8d34b","line":50,"updated":"2015-07-01 08:35:41.000000000","message":"for backward compatibility and upgrade issue, I think maybe default\u003dNone will be better, if we decide to use this value (or maybe larger one, like 1000) to avoid silly use cases, I think we should add some notes for dev/admin/user doc... especially the way to get all entries while limit is used (api page) for end users","commit_id":"2f9a3723105fd4e2e92c93c80f42610231276650"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"ad7f11b62ea76cb22aeee19b56593060b0b2f71a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                default\u003dFalse,"},{"line_number":48,"context_line":"                help\u003d\u0027Toggle Pecan Debug Middleware.\u0027),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027default_api_return_limit\u0027,"},{"line_number":50,"context_line":"               default\u003d100,"},{"line_number":51,"context_line":"               help\u003d\u0027Default maximum number of items returned by API request.\u0027"},{"line_number":52,"context_line":"               ),"},{"line_number":53,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_c232fea6","line":50,"in_reply_to":"ba3cc151_d0f8d34b","updated":"2015-07-02 14:30:05.000000000","message":"i think the idea is to break them. i will set to 1000 but the idea is to enforce users to pass a limit.","commit_id":"2f9a3723105fd4e2e92c93c80f42610231276650"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"97088fe8975181fc18e8b223be041505f00c08c5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                default\u003dFalse,"},{"line_number":48,"context_line":"                help\u003d\u0027Toggle Pecan Debug Middleware.\u0027),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027default_api_return_limit\u0027,"},{"line_number":50,"context_line":"               default\u003d1000,"},{"line_number":51,"context_line":"               help\u003d\u0027Default maximum number of items returned by API request.\u0027"},{"line_number":52,"context_line":"               ),"},{"line_number":53,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_103a4599","line":50,"updated":"2015-07-03 10:07:59.000000000","message":"Bummer, I liked it when it was lower.","commit_id":"1c546b10b88256c96467c541f725fd753397e09d"}],"ceilometer/api/controllers/v2/utils.py":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"a603b96ae7e2bff6e288219e57e6f7c1448ecee5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        \"\"\"Ensure limit is defined and is valid. if not, set a default.\"\"\""},{"line_number":45,"context_line":"        if limit and limit \u003c 0:"},{"line_number":46,"context_line":"            raise base.ClientSideError(_(\"Limit must be positive\"))"},{"line_number":47,"context_line":"        if not limit:"},{"line_number":48,"context_line":"            limit \u003d cfg.CONF.api.default_api_return_limit"},{"line_number":49,"context_line":"            LOG.info(_LI(\u0027No limit value provided, result set will be\u0027"},{"line_number":50,"context_line":"                         \u0027limited to %(limit)d.\u0027), {limit: limit})"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_37a85c1f","line":47,"updated":"2015-06-30 01:35:05.000000000","message":"here we cannot use \u0027not\u0027 operator, because when we specifying \u0027limit\u003d0\u0027, it will go into \u0027if not limit\u0027 logical, I guess that is why the Jenkins failed.\n\nhttp://logs.openstack.org/92/196792/1/check/gate-ceilometer-python27/42920b9/testr_results.html.gz","commit_id":"fc4e9feef8e95f36b313b463f9d5434f93d4776a"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"cacb44ddc41be558d57faa802fa7af3947c671fd","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if limit and limit \u003c 0:"},{"line_number":46,"context_line":"            raise base.ClientSideError(_(\"Limit must be positive\"))"},{"line_number":47,"context_line":"        if limit is None:"},{"line_number":48,"context_line":"            limit \u003d cfg.CONF.api.default_api_return_limit"},{"line_number":49,"context_line":"            LOG.info(_LI(\u0027No limit value provided, result set will be\u0027"},{"line_number":50,"context_line":"                         \u0027limited to %(limit)d.\u0027), {limit: limit})"},{"line_number":51,"context_line":"        return limit"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_b04aefc3","line":48,"updated":"2015-07-01 08:35:41.000000000","message":"-1: we need to check the default_api_return_limit as well, so maybe we should switch the order of the two if blocks","commit_id":"2f9a3723105fd4e2e92c93c80f42610231276650"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"ad7f11b62ea76cb22aeee19b56593060b0b2f71a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if limit and limit \u003c 0:"},{"line_number":46,"context_line":"            raise base.ClientSideError(_(\"Limit must be positive\"))"},{"line_number":47,"context_line":"        if limit is None:"},{"line_number":48,"context_line":"            limit \u003d cfg.CONF.api.default_api_return_limit"},{"line_number":49,"context_line":"            LOG.info(_LI(\u0027No limit value provided, result set will be\u0027"},{"line_number":50,"context_line":"                         \u0027limited to %(limit)d.\u0027), {limit: limit})"},{"line_number":51,"context_line":"        return limit"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_22ebaae0","line":48,"in_reply_to":"ba3cc151_b04aefc3","updated":"2015-07-02 14:30:05.000000000","message":"will do.","commit_id":"2f9a3723105fd4e2e92c93c80f42610231276650"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"cedcb89dab1c07bf3fc4f41e52c88258447f39d8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if limit is None:"},{"line_number":46,"context_line":"            limit \u003d cfg.CONF.api.default_api_return_limit"},{"line_number":47,"context_line":"            LOG.info(_LI(\u0027No limit value provided, result set will be\u0027"},{"line_number":48,"context_line":"                         \u0027limited to %(limit)d.\u0027), {limit: limit})"},{"line_number":49,"context_line":"        if limit and limit \u003c 0:"},{"line_number":50,"context_line":"            raise base.ClientSideError(_(\"Limit must be positive\"))"},{"line_number":51,"context_line":"        return limit"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_38ec1d29","line":48,"updated":"2015-07-03 03:33:17.000000000","message":"I\u0027m wondering if user set default_api_return_limit to None, then the %(limit)d may not work, consider %(limit)s ?","commit_id":"1c546b10b88256c96467c541f725fd753397e09d"}]}