)]}'
{"ceilometer/event/storage/pymongo_base.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"3ce84373fbbf79b2009e6397c3e4cff9633f13e6","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        if limit \u003d\u003d 0:"},{"line_number":82,"context_line":"            return"},{"line_number":83,"context_line":"        limit \u003d limit if limit is not None else 0"},{"line_number":84,"context_line":"        q \u003d pymongo_utils.make_events_query_from_filter(event_filter)"},{"line_number":85,"context_line":"        for event in self.db.event.find(q, limit\u003dlimit):"},{"line_number":86,"context_line":"            traits \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_bfca164e","line":83,"updated":"2015-07-20 11:13:32.000000000","message":"I don\u0027t really get this line. If I understand correctly the enforce_limit function will ensure that the limit is not None and it is a positive value. But let\u0027s assume that limit can be None here, it still looks odd that it is set to \u00270\u0027 as opposed to the default value. Shouldn\u0027t this be the default value?","commit_id":"52b7fa9ad410322d0a6b6a36a53303aac08f0e8a"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"9680544de656a6d26d4590e6b06ddd3df822c267","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        if limit \u003d\u003d 0:"},{"line_number":82,"context_line":"            return"},{"line_number":83,"context_line":"        limit \u003d limit if limit is not None else 0"},{"line_number":84,"context_line":"        q \u003d pymongo_utils.make_events_query_from_filter(event_filter)"},{"line_number":85,"context_line":"        for event in self.db.event.find(q, limit\u003dlimit):"},{"line_number":86,"context_line":"            traits \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_2dd18bfa","line":83,"in_reply_to":"3a50d1a3_18ddf26e","updated":"2015-07-22 08:47:23.000000000","message":"My concern here is that we have a default value set as a config parameter and here we don\u0027t set the limit to that value but just kind of remove it.","commit_id":"52b7fa9ad410322d0a6b6a36a53303aac08f0e8a"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"1295a44cd49981cdb56757ed21ee4b9b717928cb","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        if limit \u003d\u003d 0:"},{"line_number":82,"context_line":"            return"},{"line_number":83,"context_line":"        limit \u003d limit if limit is not None else 0"},{"line_number":84,"context_line":"        q \u003d pymongo_utils.make_events_query_from_filter(event_filter)"},{"line_number":85,"context_line":"        for event in self.db.event.find(q, limit\u003dlimit):"},{"line_number":86,"context_line":"            traits \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_7928a7e2","line":83,"in_reply_to":"3a50d1a3_2dd18bfa","updated":"2015-07-22 12:57:45.000000000","message":"you win Ildiko","commit_id":"52b7fa9ad410322d0a6b6a36a53303aac08f0e8a"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"1d81fb6d9798c5ac0189565a28f49472e2571332","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        if limit \u003d\u003d 0:"},{"line_number":82,"context_line":"            return"},{"line_number":83,"context_line":"        limit \u003d limit if limit is not None else 0"},{"line_number":84,"context_line":"        q \u003d pymongo_utils.make_events_query_from_filter(event_filter)"},{"line_number":85,"context_line":"        for event in self.db.event.find(q, limit\u003dlimit):"},{"line_number":86,"context_line":"            traits \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_18ddf26e","line":83,"in_reply_to":"3a50d1a3_bfca164e","updated":"2015-07-22 05:58:51.000000000","message":"Hi,\n\nAccording to pymongo manual [1], \u00270\u0027 in this line means \u0027no limit\u0027.\nIt\u0027s different from the meaning from what this functions API.\nIt should be better to have dedicated line for handling the case \u0027limit\u003d\u003dNone\u0027 with some notes.\n\n[1] http://api.mongodb.org/python/current/api/pymongo/cursor.html#pymongo.cursor.Cursor.limit","commit_id":"52b7fa9ad410322d0a6b6a36a53303aac08f0e8a"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"b4016c90edcff525a8780d990ab1b121d7b41ebb","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        if limit is not None:"},{"line_number":86,"context_line":"            results \u003d self.db.event.find(q, limit\u003dlimit)"},{"line_number":87,"context_line":"        else:"},{"line_number":88,"context_line":"            results \u003d self.db.event.find(q)"},{"line_number":89,"context_line":"        for event in results:"},{"line_number":90,"context_line":"            traits \u003d []"},{"line_number":91,"context_line":"            for trait in event[\u0027traits\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_647c7eb5","line":88,"updated":"2015-07-22 13:18:38.000000000","message":"Hmm, it seems I wasn\u0027t clear with my question/concern. So if I understand correctly we are forcing to have a limit on queries. Is that correct? If yes, then do we have a case here when the limit is None? Is it even correct that it is an optional parameter here?\n\nI can only think about statistics, where we wouldn\u0027t want to use limits, but it does not seem to be applicable for events.","commit_id":"29c161fed778f65828335f656fca6a2f2c002c89"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"1a91ad6b03b6e656ab95a1fc28a1b305b41b4951","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        if limit is not None:"},{"line_number":86,"context_line":"            results \u003d self.db.event.find(q, limit\u003dlimit)"},{"line_number":87,"context_line":"        else:"},{"line_number":88,"context_line":"            results \u003d self.db.event.find(q)"},{"line_number":89,"context_line":"        for event in results:"},{"line_number":90,"context_line":"            traits \u003d []"},{"line_number":91,"context_line":"            for trait in event[\u0027traits\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_8add13e2","line":88,"in_reply_to":"3a50d1a3_2a963f3f","updated":"2015-07-22 13:40:43.000000000","message":"But do we want to allow here to not have limit specified and not using the default limit?","commit_id":"29c161fed778f65828335f656fca6a2f2c002c89"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"47aa777aa281076a77ba959a25077a5d52e7cc97","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        if limit is not None:"},{"line_number":86,"context_line":"            results \u003d self.db.event.find(q, limit\u003dlimit)"},{"line_number":87,"context_line":"        else:"},{"line_number":88,"context_line":"            results \u003d self.db.event.find(q)"},{"line_number":89,"context_line":"        for event in results:"},{"line_number":90,"context_line":"            traits \u003d []"},{"line_number":91,"context_line":"            for trait in event[\u0027traits\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_2a963f3f","line":88,"in_reply_to":"3a50d1a3_647c7eb5","updated":"2015-07-22 13:38:15.000000000","message":"considering this isn\u0027t a private method. i believe there could be various places that have limit \u003d\u003d None... i\u0027d assume mostly testing but i have no idea","commit_id":"29c161fed778f65828335f656fca6a2f2c002c89"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"a1762a3a6939d62123ba690df7b85ad8047cc861","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        if limit is not None:"},{"line_number":86,"context_line":"            results \u003d self.db.event.find(q, limit\u003dlimit)"},{"line_number":87,"context_line":"        else:"},{"line_number":88,"context_line":"            results \u003d self.db.event.find(q)"},{"line_number":89,"context_line":"        for event in results:"},{"line_number":90,"context_line":"            traits \u003d []"},{"line_number":91,"context_line":"            for trait in event[\u0027traits\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_255430fd","line":88,"in_reply_to":"3a50d1a3_8add13e2","updated":"2015-07-22 13:45:41.000000000","message":"oh... i forgot to remove original line.","commit_id":"29c161fed778f65828335f656fca6a2f2c002c89"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"0fb19fc5be49c03620e0977197270f2e88035d19","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        if limit is not None:"},{"line_number":85,"context_line":"            results \u003d self.db.event.find(q, limit\u003dlimit)"},{"line_number":86,"context_line":"        else:"},{"line_number":87,"context_line":"            results \u003d self.db.event.find(q)"},{"line_number":88,"context_line":"        for event in results:"},{"line_number":89,"context_line":"            traits \u003d []"},{"line_number":90,"context_line":"            for trait in event[\u0027traits\u0027]:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_4c1956d6","line":87,"updated":"2015-07-22 19:22:27.000000000","message":"I hope find() is a generator","commit_id":"50fc88183cc0b5e44b102d3cdccbd76aa4e0003a"}]}