)]}'
{"ceilometer/storage/impl_hbase.py":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"565062ff88cfee33927b4f8b7a3ae33f7d597578","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        :param limit: Maximum number of results to return."},{"line_number":254,"context_line":"        \"\"\""},{"line_number":255,"context_line":"        if limit \u003d\u003d 0:"},{"line_number":256,"context_line":"            return"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        metaquery \u003d metaquery or {}"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_59712b43","line":256,"updated":"2015-07-22 13:07:46.000000000","message":"according to https://review.openstack.org/#/c/199180/ , the 0 will be treated as a invalid value, maybe we don\u0027t need this check.","commit_id":"8c1425c43c0aa9c9b00a3cc617ccc86536ccfe5e"}],"ceilometer/storage/impl_sqlalchemy.py":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"565062ff88cfee33927b4f8b7a3ae33f7d597578","unresolved":false,"context_lines":[{"line_number":475,"context_line":"        :param limit: Maximum number of results to return."},{"line_number":476,"context_line":"        \"\"\""},{"line_number":477,"context_line":"        if limit \u003d\u003d 0:"},{"line_number":478,"context_line":"            return"},{"line_number":479,"context_line":"        s_filter \u003d storage.SampleFilter(user\u003duser,"},{"line_number":480,"context_line":"                                        project\u003dproject,"},{"line_number":481,"context_line":"                                        source\u003dsource,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_d928db35","line":478,"updated":"2015-07-22 13:07:46.000000000","message":"according to https://review.openstack.org/#/c/199180/ , the 0 will be treated as a invalid value, maybe we don\u0027t need this check.","commit_id":"8c1425c43c0aa9c9b00a3cc617ccc86536ccfe5e"}],"ceilometer/storage/pymongo_base.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"400e80443b7ee5a755f13779c102cc5ee075a871","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        count \u003d 0"},{"line_number":80,"context_line":"        for r in self.db.resource.find(q):"},{"line_number":81,"context_line":"            for r_meter in r[\u0027meter\u0027]:"},{"line_number":82,"context_line":"                if count \u003c limit:"},{"line_number":83,"context_line":"                    count +\u003d 1"},{"line_number":84,"context_line":"                else:"},{"line_number":85,"context_line":"                    return"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_cd37074c","line":82,"updated":"2015-07-07 07:36:15.000000000","message":"what if limit\u003dNone?","commit_id":"559f1a4ddc09206e73427d4b336d772df5208e5f"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"565062ff88cfee33927b4f8b7a3ae33f7d597578","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        :param limit: Maximum number of results to return."},{"line_number":62,"context_line":"        \"\"\""},{"line_number":63,"context_line":"        if limit \u003d\u003d 0:"},{"line_number":64,"context_line":"            return"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        metaquery \u003d pymongo_utils.improve_keys(metaquery, metaquery\u003dTrue) or {}"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_b9fb8f7a","line":64,"updated":"2015-07-22 13:07:46.000000000","message":"according to https://review.openstack.org/#/c/199180/ , the 0 will be treated as a invalid value, maybe we don\u0027t need this check.","commit_id":"8c1425c43c0aa9c9b00a3cc617ccc86536ccfe5e"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"622f0bfaff43273f3d961c1b69dc25228779adde","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        :param limit: Maximum number of results to return."},{"line_number":62,"context_line":"        \"\"\""},{"line_number":63,"context_line":"        if limit \u003d\u003d 0:"},{"line_number":64,"context_line":"            return"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        metaquery \u003d pymongo_utils.improve_keys(metaquery, metaquery\u003dTrue) or {}"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_ebf7ef88","line":64,"in_reply_to":"3a50d1a3_b9fb8f7a","updated":"2015-07-22 16:47:16.000000000","message":"i will remove this all later","commit_id":"8c1425c43c0aa9c9b00a3cc617ccc86536ccfe5e"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"4a088df2d19cfb82a24f475d29142bcbf385b411","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        q.update(metaquery)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        count \u003d 0"},{"line_number":80,"context_line":"        for r in self.db.resource.find(q):"},{"line_number":81,"context_line":"            for r_meter in r[\u0027meter\u0027]:"},{"line_number":82,"context_line":"                if limit and count \u003e\u003d limit:"},{"line_number":83,"context_line":"                    return"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_ba41c43b","line":80,"updated":"2015-07-20 11:23:20.000000000","message":"Wouldn\u0027t it be better to add the limit to the DB query?","commit_id":"8c1425c43c0aa9c9b00a3cc617ccc86536ccfe5e"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"559a2ab7db1947a5ea91c339bbcb7727c5f142e4","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        q.update(metaquery)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        count \u003d 0"},{"line_number":80,"context_line":"        for r in self.db.resource.find(q):"},{"line_number":81,"context_line":"            for r_meter in r[\u0027meter\u0027]:"},{"line_number":82,"context_line":"                if limit and count \u003e\u003d limit:"},{"line_number":83,"context_line":"                    return"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_a3e200d4","line":80,"in_reply_to":"3a50d1a3_a01756a2","updated":"2015-07-20 12:29:29.000000000","message":"Nah, sorry, my bad, I missed the embedded \u0027for\u0027 here...","commit_id":"8c1425c43c0aa9c9b00a3cc617ccc86536ccfe5e"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"830b883f9ee8d955bf29b3700c4ecc254ac2d753","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        q.update(metaquery)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        count \u003d 0"},{"line_number":80,"context_line":"        for r in self.db.resource.find(q):"},{"line_number":81,"context_line":"            for r_meter in r[\u0027meter\u0027]:"},{"line_number":82,"context_line":"                if limit and count \u003e\u003d limit:"},{"line_number":83,"context_line":"                    return"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_a01756a2","line":80,"in_reply_to":"3a50d1a3_ba41c43b","updated":"2015-07-20 12:05:58.000000000","message":"can\u0027t. because of the way mongo is modeled, to get the meters, we have to search the resources. if i add limit to query, it will limit resource not the meters which is what we want to return...\n\nbasically the mongo backend is modeled is a very very strange way.","commit_id":"8c1425c43c0aa9c9b00a3cc617ccc86536ccfe5e"}]}