)]}'
{"ceilometer/api/controllers/v2/utils.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"2803e612721583beb9cc1c489bc8d12a54e99152","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            limit \u003d cfg.CONF.api.default_api_return_limit"},{"line_number":47,"context_line":"            LOG.info(_LI(\u0027No limit value provided, result set will be\u0027"},{"line_number":48,"context_line":"                         \u0027limited to %(limit)d.\u0027), {\u0027limit\u0027: limit})"},{"line_number":49,"context_line":"        if not limit or limit \u003c\u003d 0:"},{"line_number":50,"context_line":"            raise base.ClientSideError(_(\"Limit must be positive\"))"},{"line_number":51,"context_line":"        return limit"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_9ae4083c","line":49,"updated":"2015-07-20 11:27:49.000000000","message":"Is it ok to change the behaviour for all types of queries now?","commit_id":"90dfa734f92e30d795e4fde2c6d8a4584e28d01e"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"629a9645cba588516e32541cc3f30a0e6b2226c3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            limit \u003d cfg.CONF.api.default_api_return_limit"},{"line_number":47,"context_line":"            LOG.info(_LI(\u0027No limit value provided, result set will be\u0027"},{"line_number":48,"context_line":"                         \u0027limited to %(limit)d.\u0027), {\u0027limit\u0027: limit})"},{"line_number":49,"context_line":"        if not limit or limit \u003c\u003d 0:"},{"line_number":50,"context_line":"            raise base.ClientSideError(_(\"Limit must be positive\"))"},{"line_number":51,"context_line":"        return limit"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_f932770f","line":49,"in_reply_to":"3a50d1a3_9ae4083c","updated":"2015-07-22 13:02:38.000000000","message":"i think it\u0027s safe. if you entered 0 originally, we interpreted it as 0 results. why would anyone purposely use a query that returned 0 results.","commit_id":"90dfa734f92e30d795e4fde2c6d8a4584e28d01e"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"fbca95c3f738c78cdc016c9bfa781abbcf138f46","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            LOG.info(_LI(\u0027No limit value provided, result set will be\u0027"},{"line_number":48,"context_line":"                         \u0027limited to %(limit)d.\u0027), {\u0027limit\u0027: limit})"},{"line_number":49,"context_line":"        if not limit or limit \u003c\u003d 0:"},{"line_number":50,"context_line":"            raise base.ClientSideError(_(\"Limit must be positive\"))"},{"line_number":51,"context_line":"        return limit"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_f555161d","line":50,"updated":"2015-07-20 14:13:14.000000000","message":"here check the default limit value and inputted limit value in uniformly way, and the 0 value is treat as invalid value, but if operators has configured the cfg.CONF.api.default_api_return_limit, we cannot realize the configure fault by \u0027Limit must be positive\u0027 message.\n\nthis can be addressed by specifying \u0027min\u0027 in IntOpt[1], and also, this can be checked when services being started than api request.\n\n[1] https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L1032","commit_id":"90dfa734f92e30d795e4fde2c6d8a4584e28d01e"}]}