)]}'
{"ceilometer/event/storage/impl_elasticsearch.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"fe96bea79e31f9d3d44a7b456ceaa536129525fe","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            \u0027mappings\u0027: {\u0027_default_\u0027:"},{"line_number":85,"context_line":"                         {\u0027_timestamp\u0027: {\u0027enabled\u0027: True,"},{"line_number":86,"context_line":"                                         \u0027store\u0027: True},"},{"line_number":87,"context_line":"                          \u0027_ttl\u0027: {\u0027enabled\u0027: True},"},{"line_number":88,"context_line":"                          \u0027properties\u0027: {\u0027traits\u0027: {\u0027type\u0027: \u0027nested\u0027}}}}}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # NOTE(ityaptin) updating mapping for old indices"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_50104e01","line":87,"updated":"2015-07-21 16:50:27.000000000","message":"you\u0027re not setting ttl value... just enabling it. the default value will be set to 1day.","commit_id":"6dbb23002f58dd5cba66fed7ec28f0b66c7bcd64"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"5cfb8a5ebfbeec472d8fe93be7fbe4da210a97d9","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            \u0027mappings\u0027: {\u0027_default_\u0027:"},{"line_number":85,"context_line":"                         {\u0027_timestamp\u0027: {\u0027enabled\u0027: True,"},{"line_number":86,"context_line":"                                         \u0027store\u0027: True},"},{"line_number":87,"context_line":"                          \u0027_ttl\u0027: {\u0027enabled\u0027: True},"},{"line_number":88,"context_line":"                          \u0027properties\u0027: {\u0027traits\u0027: {\u0027type\u0027: \u0027nested\u0027}}}}}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # NOTE(ityaptin) updating mapping for old indices"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_1ace512d","line":87,"in_reply_to":"3a50d1a3_134090a4","updated":"2015-08-11 14:42:59.000000000","message":"Gordon it will expire if defaul value is set while ttl is enable, \n\nyour case required:\n  \u0027_ttl\u0027: {\u0027enabled\u0027: True, \u0027default\u0027 : \u00271d\u0027 }\n\notherwise ttl \u003d\u003d infinitive","commit_id":"6dbb23002f58dd5cba66fed7ec28f0b66c7bcd64"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f1d0b8eab3b1fa0169d21a4d7e78b5461607eb43","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            \u0027mappings\u0027: {\u0027_default_\u0027:"},{"line_number":85,"context_line":"                         {\u0027_timestamp\u0027: {\u0027enabled\u0027: True,"},{"line_number":86,"context_line":"                                         \u0027store\u0027: True},"},{"line_number":87,"context_line":"                          \u0027_ttl\u0027: {\u0027enabled\u0027: True},"},{"line_number":88,"context_line":"                          \u0027properties\u0027: {\u0027traits\u0027: {\u0027type\u0027: \u0027nested\u0027}}}}}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # NOTE(ityaptin) updating mapping for old indices"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_134090a4","line":87,"in_reply_to":"3a50d1a3_375d4315","updated":"2015-07-27 14:43:08.000000000","message":"but iiuc, it will expire. if you enable ttl but dont set a date, it will expire after a day by default","commit_id":"6dbb23002f58dd5cba66fed7ec28f0b66c7bcd64"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"2d28aef270ca924fb85f15c7806204938f4569b9","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            \u0027mappings\u0027: {\u0027_default_\u0027:"},{"line_number":85,"context_line":"                         {\u0027_timestamp\u0027: {\u0027enabled\u0027: True,"},{"line_number":86,"context_line":"                                         \u0027store\u0027: True},"},{"line_number":87,"context_line":"                          \u0027_ttl\u0027: {\u0027enabled\u0027: True},"},{"line_number":88,"context_line":"                          \u0027properties\u0027: {\u0027traits\u0027: {\u0027type\u0027: \u0027nested\u0027}}}}}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # NOTE(ityaptin) updating mapping for old indices"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_375d4315","line":87,"in_reply_to":"3a50d1a3_50104e01","updated":"2015-07-22 14:08:27.000000000","message":"\u003e\u003e If no default is set and no _ttl value is given then the document has an infinite _ttl and will not expire","commit_id":"6dbb23002f58dd5cba66fed7ec28f0b66c7bcd64"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"e13582b797482181a19246557c3bdf69cc87cb83","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                       \u0027_source\u0027: {\u0027timestamp\u0027: ev.generated.isoformat(),"},{"line_number":112,"context_line":"                                   \u0027traits\u0027: traits,"},{"line_number":113,"context_line":"                                   \u0027raw\u0027: ev.raw},"},{"line_number":114,"context_line":"                       \u0027_ttl\u0027: self.ttl,"},{"line_number":115,"context_line":"                       }"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        error \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_10e966e6","line":114,"updated":"2015-07-21 16:51:23.000000000","message":"i\u0027m wondering if we need to set this or just let it take the default.","commit_id":"6dbb23002f58dd5cba66fed7ec28f0b66c7bcd64"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"b0e3ea7b8b7fc10b488a35d0399b55b67a363a03","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                    iclient.delete(indice)"},{"line_number":321,"context_line":"                except Exception as e:"},{"line_number":322,"context_line":"                    LOG.warn(_LW(\"Error during the expired index %s \""},{"line_number":323,"context_line":"                                 \"deleting.\"), indice)"},{"line_number":324,"context_line":"                    LOG.exception(e)"},{"line_number":325,"context_line":"                else:"},{"line_number":326,"context_line":"                    deleted.append(indice)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_6c0ccc94","line":323,"updated":"2015-08-27 13:48:38.000000000","message":"This should maybe be: \"Error deleting the expired index %s\"","commit_id":"a664f5e3416fd1e4bd85e70369379ff678a65b24"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"37a4a979d88846e50599f7d8a41cf1aed1b94693","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                    iclient.delete(indice)"},{"line_number":321,"context_line":"                except Exception as e:"},{"line_number":322,"context_line":"                    LOG.warn(_LW(\"Error during the expired index %s \""},{"line_number":323,"context_line":"                                 \"deleting.\"), indice)"},{"line_number":324,"context_line":"                    LOG.exception(e)"},{"line_number":325,"context_line":"                else:"},{"line_number":326,"context_line":"                    deleted.append(indice)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_05740333","line":323,"in_reply_to":"da20952f_6c0ccc94","updated":"2015-08-27 14:32:56.000000000","message":"Agree","commit_id":"a664f5e3416fd1e4bd85e70369379ff678a65b24"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"b0e3ea7b8b7fc10b488a35d0399b55b67a363a03","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                else:"},{"line_number":326,"context_line":"                    deleted.append(indice)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        LOG.debug(\"Expirer has deleted next indices: %s\" %"},{"line_number":329,"context_line":"                  filter(None, deleted))"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_4c24680c","line":328,"updated":"2015-08-27 13:48:38.000000000","message":"I don\u0027t think you need the word \"next\"","commit_id":"a664f5e3416fd1e4bd85e70369379ff678a65b24"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"37a4a979d88846e50599f7d8a41cf1aed1b94693","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                else:"},{"line_number":326,"context_line":"                    deleted.append(indice)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        LOG.debug(\"Expirer has deleted next indices: %s\" %"},{"line_number":329,"context_line":"                  filter(None, deleted))"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_a58f5722","line":328,"in_reply_to":"da20952f_4c24680c","updated":"2015-08-27 14:32:56.000000000","message":"Ok, agree.","commit_id":"a664f5e3416fd1e4bd85e70369379ff678a65b24"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"7edd6b15066369c999f16dac7cf6cd681f25c85b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            \u0027mappings\u0027: {\u0027_default_\u0027:"},{"line_number":85,"context_line":"                         {\u0027_timestamp\u0027: {\u0027enabled\u0027: True,"},{"line_number":86,"context_line":"                                         \u0027store\u0027: True},"},{"line_number":87,"context_line":"                          \u0027_ttl\u0027: {\u0027enabled\u0027: True, \u0027default\u0027: None},"},{"line_number":88,"context_line":"                          \u0027properties\u0027: {\u0027traits\u0027: {\u0027type\u0027: \u0027nested\u0027}}}}}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # NOTE(ityaptin) updating mapping for old indices"}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_4095fbe1","line":87,"range":{"start_line":87,"start_character":52,"end_line":87,"end_character":67},"updated":"2015-09-02 19:03:30.000000000","message":"Ilya could you please explain is None suitable value for default key in ttl dict, if so what is changed now comparing to the case where default was not set?","commit_id":"0fff03b7ec574f005ce2712abb98e9a0fa6faac8"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"899c1fc7028eb723bc833f7756ccd94cf516eab6","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            \u0027mappings\u0027: {\u0027_default_\u0027:"},{"line_number":85,"context_line":"                         {\u0027_timestamp\u0027: {\u0027enabled\u0027: True,"},{"line_number":86,"context_line":"                                         \u0027store\u0027: True},"},{"line_number":87,"context_line":"                          \u0027_ttl\u0027: {\u0027enabled\u0027: True, \u0027default\u0027: None},"},{"line_number":88,"context_line":"                          \u0027properties\u0027: {\u0027traits\u0027: {\u0027type\u0027: \u0027nested\u0027}}}}}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # NOTE(ityaptin) updating mapping for old indices"}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_2b0f632f","line":87,"range":{"start_line":87,"start_character":52,"end_line":87,"end_character":67},"in_reply_to":"da20952f_4095fbe1","updated":"2015-09-03 13:18:38.000000000","message":"I decide what clearly defining of this option is better for code reading and will work even if elasticsearch change own default parameters in new versions.","commit_id":"0fff03b7ec574f005ce2712abb98e9a0fa6faac8"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"9ce65c85d6e61a939656c5e883e85ade6034f81a","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                        value\u003dmodels.Trait.convert_value("},{"line_number":297,"context_line":"                            t_types[trait],"},{"line_number":298,"context_line":"                            ev[\u0027_source\u0027][\u0027traits\u0027][trait]))"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    def clear_expired_event_data(self, ttl):"},{"line_number":301,"context_line":"        \"\"\"Clear expired data from the backend storage system."},{"line_number":302,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_6077c83b","line":299,"updated":"2015-09-10 08:21:13.000000000","message":"I believe you don\u0027t need to pass ttl. It\u0027s already in self.ttl.\n\nAlso, if ttl may be None","commit_id":"0fff03b7ec574f005ce2712abb98e9a0fa6faac8"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"cbed33c1a7c71b781de0fd29a2023376aaefe0d2","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                        value\u003dmodels.Trait.convert_value("},{"line_number":297,"context_line":"                            t_types[trait],"},{"line_number":298,"context_line":"                            ev[\u0027_source\u0027][\u0027traits\u0027][trait]))"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    def clear_expired_event_data(self, ttl):"},{"line_number":301,"context_line":"        \"\"\"Clear expired data from the backend storage system."},{"line_number":302,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_6197da90","line":299,"in_reply_to":"da20952f_6077c83b","updated":"2015-09-15 13:37:12.000000000","message":"This ttl is used for correct function signature","commit_id":"0fff03b7ec574f005ce2712abb98e9a0fa6faac8"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"7edd6b15066369c999f16dac7cf6cd681f25c85b","unresolved":false,"context_lines":[{"line_number":297,"context_line":"                            t_types[trait],"},{"line_number":298,"context_line":"                            ev[\u0027_source\u0027][\u0027traits\u0027][trait]))"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    def clear_expired_event_data(self, ttl):"},{"line_number":301,"context_line":"        \"\"\"Clear expired data from the backend storage system."},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        Clearing occurs according to the time-to-live."}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_404adb84","line":300,"range":{"start_line":300,"start_character":8,"end_line":300,"end_character":32},"updated":"2015-09-02 19:03:30.000000000","message":"amiright that we need it to clear all expired data even if  it doesn\u0027t have ttl indexes?","commit_id":"0fff03b7ec574f005ce2712abb98e9a0fa6faac8"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"899c1fc7028eb723bc833f7756ccd94cf516eab6","unresolved":false,"context_lines":[{"line_number":297,"context_line":"                            t_types[trait],"},{"line_number":298,"context_line":"                            ev[\u0027_source\u0027][\u0027traits\u0027][trait]))"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    def clear_expired_event_data(self, ttl):"},{"line_number":301,"context_line":"        \"\"\"Clear expired data from the backend storage system."},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        Clearing occurs according to the time-to-live."}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_cb026809","line":300,"range":{"start_line":300,"start_character":8,"end_line":300,"end_character":32},"in_reply_to":"da20952f_404adb84","updated":"2015-09-03 13:18:38.000000000","message":"Yes, i think it\u0027s better to remove expired indexes even if early (then they have been created) we have not set event_ttl option.","commit_id":"0fff03b7ec574f005ce2712abb98e9a0fa6faac8"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"9ce65c85d6e61a939656c5e883e85ade6034f81a","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    def clear_expired_event_data(self, ttl):"},{"line_number":301,"context_line":"        \"\"\"Clear expired data from the backend storage system."},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        Clearing occurs according to the time-to-live."},{"line_number":304,"context_line":"        In Elastic-Search case only indices which are strictly older than"},{"line_number":305,"context_line":"        now() - ttl will be deleted."},{"line_number":306,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_404ba42b","line":303,"updated":"2015-09-10 08:21:13.000000000","message":"The correct name is \u0027Elasticsearch\u0027","commit_id":"0fff03b7ec574f005ce2712abb98e9a0fa6faac8"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"cbed33c1a7c71b781de0fd29a2023376aaefe0d2","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    def clear_expired_event_data(self, ttl):"},{"line_number":301,"context_line":"        \"\"\"Clear expired data from the backend storage system."},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        Clearing occurs according to the time-to-live."},{"line_number":304,"context_line":"        In Elastic-Search case only indices which are strictly older than"},{"line_number":305,"context_line":"        now() - ttl will be deleted."},{"line_number":306,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_61b03a44","line":303,"in_reply_to":"da20952f_404ba42b","updated":"2015-09-15 13:37:12.000000000","message":"I\u0027ll fix it","commit_id":"0fff03b7ec574f005ce2712abb98e9a0fa6faac8"}],"ceilometer/tests/unit/event/storage/test_elasticsearch.py":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"7edd6b15066369c999f16dac7cf6cd681f25c85b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    @mock.patch(\"oslo_utils.timeutils.utcnow\")"},{"line_number":38,"context_line":"    def test_clear_expired_event_data(self, mock_utcnow, mock_indices_client,"},{"line_number":39,"context_line":"                                      mock_es_client):"},{"line_number":40,"context_line":"        ttl \u003d 1000"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        mock_utcnow.return_value \u003d datetime.datetime(2015, 8, 4, 12, 0, 0)"},{"line_number":43,"context_line":"        indices_client \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_432c254a","line":40,"updated":"2015-09-02 19:03:30.000000000","message":"ttl \u003d 1000 is near 16 m amiright?\nYou set in test utcnow to noon and it is seems that stored event have timestamps 2015-08-04-0-0-0 if so it is seems that all data are out of date? It seems that I\u0027ve missed something could you help me get what?","commit_id":"0fff03b7ec574f005ce2712abb98e9a0fa6faac8"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"cbed33c1a7c71b781de0fd29a2023376aaefe0d2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    @mock.patch(\"oslo_utils.timeutils.utcnow\")"},{"line_number":38,"context_line":"    def test_clear_expired_event_data(self, mock_utcnow, mock_indices_client,"},{"line_number":39,"context_line":"                                      mock_es_client):"},{"line_number":40,"context_line":"        ttl \u003d 1000"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        mock_utcnow.return_value \u003d datetime.datetime(2015, 8, 4, 12, 0, 0)"},{"line_number":43,"context_line":"        indices_client \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_e1d0ca55","line":40,"in_reply_to":"da20952f_432c254a","updated":"2015-09-15 13:37:12.000000000","message":"Ok, good note. I have made mistake.","commit_id":"0fff03b7ec574f005ce2712abb98e9a0fa6faac8"}]}