)]}'
{"ceilometer/dispatcher/gnocchi.py":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"2728079dffb019cba8c3d035d9c0edbcbca0794d","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        # So perhaps the next step will be to pool the received data from"},{"line_number":312,"context_line":"        # message bus."},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        resource_grouped_samples \u003d itertools.groupby("},{"line_number":315,"context_line":"            data, key\u003doperator.itemgetter(\u0027resource_id\u0027))"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        for resource_id, samples_of_resource in resource_grouped_samples:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_a8fc3f73","line":314,"updated":"2015-07-16 15:06:41.000000000","message":"I think it is better to sort the inputted data before grouping operations, could you please see: https://review.openstack.org/201444","commit_id":"96106e41f7e6f52156006342c3b5ca61d32bfb73"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"2728079dffb019cba8c3d035d9c0edbcbca0794d","unresolved":false,"context_lines":[{"line_number":335,"context_line":"                update_resource \u003d (number_of_samples_processed \u003d\u003d"},{"line_number":336,"context_line":"                                   number_of_samples)"},{"line_number":337,"context_line":"                for rd in self.resources_definition:"},{"line_number":338,"context_line":"                    if rd.match(samples[0]):"},{"line_number":339,"context_line":"                        resource_type \u003d rd.cfg[\u0027resource_type\u0027]"},{"line_number":340,"context_line":"                        resource_attrs.update(rd.attributes_from("},{"line_number":341,"context_line":"                            samples[-1]))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_d30ff486","line":338,"updated":"2015-07-16 15:06:41.000000000","message":"is there any possible that resource need to be updated (the last time of this loop) but sample don\u0027t match definition ?\nI am not sure ;-)","commit_id":"96106e41f7e6f52156006342c3b5ca61d32bfb73"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"54c5a052c6d00e834066b28e99fac088c3ade617","unresolved":false,"context_lines":[{"line_number":335,"context_line":"                update_resource \u003d (number_of_samples_processed \u003d\u003d"},{"line_number":336,"context_line":"                                   number_of_samples)"},{"line_number":337,"context_line":"                for rd in self.resources_definition:"},{"line_number":338,"context_line":"                    if rd.match(samples[0]):"},{"line_number":339,"context_line":"                        resource_type \u003d rd.cfg[\u0027resource_type\u0027]"},{"line_number":340,"context_line":"                        resource_attrs.update(rd.attributes_from("},{"line_number":341,"context_line":"                            samples[-1]))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_06239ca8","line":338,"in_reply_to":"9a41bdd9_d30ff486","updated":"2015-07-17 16:29:33.000000000","message":"Yes it seems there are an issue.\n\nI will clearly separate the resource stuffs from the samples stuffs, the code is really too confusing.","commit_id":"96106e41f7e6f52156006342c3b5ca61d32bfb73"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"2728079dffb019cba8c3d035d9c0edbcbca0794d","unresolved":false,"context_lines":[{"line_number":385,"context_line":"            self._post_measure(resource_type, resource_id, metric_name,"},{"line_number":386,"context_line":"                               measure_attributes)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        if resource_need_to_be_updated:"},{"line_number":389,"context_line":"            resource_attributes \u003d resource_attributes.copy()"},{"line_number":390,"context_line":"            del resource_attributes[\"id\"]"},{"line_number":391,"context_line":"            del resource_attributes[\"user_id\"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_73daa8eb","line":388,"updated":"2015-07-16 15:06:41.000000000","message":"how about separate this \u0027if ...\u0027 part as a method?","commit_id":"96106e41f7e6f52156006342c3b5ca61d32bfb73"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"2fd2494e6c84baed7fa0acbab3fc18415a544e37","unresolved":false,"context_lines":[{"line_number":358,"context_line":"                    self._post_measure(resource_type, resource_id, metric_name,"},{"line_number":359,"context_line":"                                       measures)"},{"line_number":360,"context_line":"                except NoSuchMetric:"},{"line_number":361,"context_line":"                    # TODO(sileht): Make gnocchi smarted to be able to detect"},{"line_number":362,"context_line":"                    # 404 for \u0027resource doesn\u0027t exist\u0027 and for"},{"line_number":363,"context_line":"                    # \u0027metric doesn\u0027t exist\u0027"},{"line_number":364,"context_line":"                    try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a43c5e1_1d2013f7","line":361,"updated":"2015-07-18 18:10:06.000000000","message":"smarter\n\nmind opening a bug in Gnocchi for that?","commit_id":"5451b1081185bbe8c0c0349a4cc86222fcef764c"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"ceb6b630d24027f51c7195b13eee5a555c77d573","unresolved":false,"context_lines":[{"line_number":358,"context_line":"                    self._post_measure(resource_type, resource_id, metric_name,"},{"line_number":359,"context_line":"                                       measures)"},{"line_number":360,"context_line":"                except NoSuchMetric:"},{"line_number":361,"context_line":"                    # TODO(sileht): Make gnocchi smarted to be able to detect"},{"line_number":362,"context_line":"                    # 404 for \u0027resource doesn\u0027t exist\u0027 and for"},{"line_number":363,"context_line":"                    # \u0027metric doesn\u0027t exist\u0027"},{"line_number":364,"context_line":"                    try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_e9c1d081","line":361,"in_reply_to":"5a43c5e1_1d2013f7","updated":"2015-07-20 10:23:40.000000000","message":"Done https://bugs.launchpad.net/gnocchi/+bug/1476186","commit_id":"5451b1081185bbe8c0c0349a4cc86222fcef764c"}]}