)]}'
{"ceilometer/agent/base.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"824985f23389d5a90401a6c683af313d148a8864","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                                sample, cfg.CONF.publisher.telemetry_secret"},{"line_number":186,"context_line":"                            ))"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"                        if cfg.CONF.batch_polled_samples is False:"},{"line_number":189,"context_line":"                            self._send_notification([sample_dict])"},{"line_number":190,"context_line":"                        else:"},{"line_number":191,"context_line":"                            sample_batch.append(sample_dict)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_2aa15ff8","line":188,"updated":"2015-07-28 12:51:17.000000000","message":"maybe instead of checking each sample we can set during init:\n\nmethod \u003d self._send_notification if batched is false else self.sample_batch\n\nand then after we can flush if sample_batch is not empty... just so we can minimise the checks.","commit_id":"3bc9051a40cd409ee45aaee307996c4efa6f7045"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"953279c0f4c4ce0a021b32e781b8fdfe75689e62","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                                sample, cfg.CONF.publisher.telemetry_secret"},{"line_number":186,"context_line":"                            ))"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"                        if cfg.CONF.batch_polled_samples is False:"},{"line_number":189,"context_line":"                            self._send_notification([sample_dict])"},{"line_number":190,"context_line":"                        else:"},{"line_number":191,"context_line":"                            sample_batch.append(sample_dict)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_ca955b32","line":188,"in_reply_to":"3a50d1a3_2aa15ff8","updated":"2015-07-28 12:58:09.000000000","message":"Do you like unreadable code? Ternaries? Method naming at a distance?\n\nNot checking the conf setting every time is a good idea, but I hadn\u0027t bothered since the pre-existing code already user a direct call into conf. I\u0027ll updated that.\n\nI don\u0027t understand what you\u0027re suggesting with flushing?","commit_id":"3bc9051a40cd409ee45aaee307996c4efa6f7045"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"0b0f7262909c7c8464ef1583c9e42026163fb76a","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                                sample, cfg.CONF.publisher.telemetry_secret"},{"line_number":186,"context_line":"                            ))"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"                        if cfg.CONF.batch_polled_samples is False:"},{"line_number":189,"context_line":"                            self._send_notification([sample_dict])"},{"line_number":190,"context_line":"                        else:"},{"line_number":191,"context_line":"                            sample_batch.append(sample_dict)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_a55cc04b","line":188,"in_reply_to":"3a50d1a3_ca955b32","updated":"2015-07-28 13:26:38.000000000","message":"i like code i can read :) we can optimise later... i just want to avoid checks we don\u0027t need.\n\nregarding flushing, the idea was that if batched was off, it\u0027d send the sample to send_notification. if batch was off, it\u0027d append to list which would need to be flushed/(sent to send_notification).","commit_id":"3bc9051a40cd409ee45aaee307996c4efa6f7045"}]}