)]}'
{"ceilometer/collector.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"d06e799f4323f06542c9bc80d08e4298e74b5b24","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                help\u003d\u0027Requeue the event on the collector event queue \u0027"},{"line_number":47,"context_line":"                \u0027when the collector fails to dispatch it.\u0027),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027disable_rpc\u0027,"},{"line_number":49,"context_line":"                default\u003dFalse,"},{"line_number":50,"context_line":"                help\u003d\u0027Disable the RPC functionality of collector. This \u0027"},{"line_number":51,"context_line":"                \u0027functionality is now deprecated in favour of notifier \u0027"},{"line_number":52,"context_line":"                \u0027publisher and queues.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_0f8cec7d","line":49,"updated":"2015-08-11 08:07:27.000000000","message":"I\u0027d prefer to have \"enable_rpc\u003dFalse\" by default.\n\nWay better to make sure people notice that they are enabling something that is deprecated. And better to have a toggle to enable, not to disable.","commit_id":"567f7ba61766d8fbd54c9f22c6b1d718e691bd9f"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"ffbb0c5f977573b6edc59b63d5bc98642b75b92b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                help\u003d\u0027Requeue the event on the collector event queue \u0027"},{"line_number":47,"context_line":"                \u0027when the collector fails to dispatch it.\u0027),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027disable_rpc\u0027,"},{"line_number":49,"context_line":"                default\u003dFalse,"},{"line_number":50,"context_line":"                help\u003d\u0027Disable the RPC functionality of collector. This \u0027"},{"line_number":51,"context_line":"                \u0027functionality is now deprecated in favour of notifier \u0027"},{"line_number":52,"context_line":"                \u0027publisher and queues.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_4b85fa04","line":49,"in_reply_to":"1a4dcd0f_0f8cec7d","updated":"2015-08-11 12:50:39.000000000","message":"Done","commit_id":"567f7ba61766d8fbd54c9f22c6b1d718e691bd9f"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"81fb8d668f8d0142e87c30920afe5af9bebeed3c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                help\u003d\u0027Requeue the event on the collector event queue \u0027"},{"line_number":47,"context_line":"                \u0027when the collector fails to dispatch it.\u0027),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027enable_rpc\u0027,"},{"line_number":49,"context_line":"                default\u003dTrue,"},{"line_number":50,"context_line":"                help\u003d\u0027Enable the RPC functionality of collector. This \u0027"},{"line_number":51,"context_line":"                \u0027functionality is now deprecated in favour of notifier \u0027"},{"line_number":52,"context_line":"                \u0027publisher and queues.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_9a7ee1ad","line":49,"updated":"2015-08-11 14:45:45.000000000","message":"I really think we should default it to False.\nEmitting deprecation by default sounds wrong.\n\nWho\u0027s with me?","commit_id":"4f20601a50c38febb96c3f81c0625edc9b05bbca"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"c7a986191c8bd32d797dddf721543d5463b5f81c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                help\u003d\u0027Requeue the event on the collector event queue \u0027"},{"line_number":47,"context_line":"                \u0027when the collector fails to dispatch it.\u0027),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027enable_rpc\u0027,"},{"line_number":49,"context_line":"                default\u003dTrue,"},{"line_number":50,"context_line":"                help\u003d\u0027Enable the RPC functionality of collector. This \u0027"},{"line_number":51,"context_line":"                \u0027functionality is now deprecated in favour of notifier \u0027"},{"line_number":52,"context_line":"                \u0027publisher and queues.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_d4a43d4c","line":49,"in_reply_to":"1a4dcd0f_05f836c2","updated":"2015-08-11 15:23:20.000000000","message":"The valid reason is the cost of code maintenance, mainly. I think this is too long and that we shouldn\u0027t have a so long cycle.","commit_id":"4f20601a50c38febb96c3f81c0625edc9b05bbca"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"54bc9a7ccb31b4c1c5605ee06acdc0bbcc7d757b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                help\u003d\u0027Requeue the event on the collector event queue \u0027"},{"line_number":47,"context_line":"                \u0027when the collector fails to dispatch it.\u0027),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027enable_rpc\u0027,"},{"line_number":49,"context_line":"                default\u003dTrue,"},{"line_number":50,"context_line":"                help\u003d\u0027Enable the RPC functionality of collector. This \u0027"},{"line_number":51,"context_line":"                \u0027functionality is now deprecated in favour of notifier \u0027"},{"line_number":52,"context_line":"                \u0027publisher and queues.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_05f836c2","line":49,"in_reply_to":"1a4dcd0f_9a7ee1ad","updated":"2015-08-11 14:51:31.000000000","message":"i have a guess to what ildikov will say. i\u0027m following the same process as non-metric meters: cycle1, give option; cycle2, disable by default; cycle3, delete\n\nwe can make the process quicker, i just don\u0027t have a valid reason to (i didn\u0027t benchmark how much extra load having an unused rpc_server is)","commit_id":"4f20601a50c38febb96c3f81c0625edc9b05bbca"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"354fca805cb43d481c6cdf2b3d2441fb4bd99d7f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                help\u003d\u0027Requeue the event on the collector event queue \u0027"},{"line_number":47,"context_line":"                \u0027when the collector fails to dispatch it.\u0027),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027enable_rpc\u0027,"},{"line_number":49,"context_line":"                default\u003dTrue,"},{"line_number":50,"context_line":"                help\u003d\u0027Enable the RPC functionality of collector. This \u0027"},{"line_number":51,"context_line":"                \u0027functionality is now deprecated in favour of notifier \u0027"},{"line_number":52,"context_line":"                \u0027publisher and queues.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_c8a7be4e","line":49,"in_reply_to":"1a4dcd0f_b74bb3b0","updated":"2015-08-11 16:27:16.000000000","message":"Yes.","commit_id":"4f20601a50c38febb96c3f81c0625edc9b05bbca"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"21519b3de4f14cea9c2fdc4e06882de0262c38ff","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                help\u003d\u0027Requeue the event on the collector event queue \u0027"},{"line_number":47,"context_line":"                \u0027when the collector fails to dispatch it.\u0027),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027enable_rpc\u0027,"},{"line_number":49,"context_line":"                default\u003dTrue,"},{"line_number":50,"context_line":"                help\u003d\u0027Enable the RPC functionality of collector. This \u0027"},{"line_number":51,"context_line":"                \u0027functionality is now deprecated in favour of notifier \u0027"},{"line_number":52,"context_line":"                \u0027publisher and queues.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_b74bb3b0","line":49,"in_reply_to":"1a4dcd0f_d4a43d4c","updated":"2015-08-11 15:36:22.000000000","message":"i\u0027m not against this. asked on IRC but is the proposal to disable by default in L* and remove in M*?","commit_id":"4f20601a50c38febb96c3f81c0625edc9b05bbca"}]}