)]}'
{"ceilometer/api/controllers/v2/events.py":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e7665422937235056a46e4c4ea2974a20962b643","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    @v2_utils.requires_admin"},{"line_number":232,"context_line":"    @wsme_pecan.wsexpose([six.text_type])"},{"line_number":233,"context_line":"    def get_all(self):"},{"line_number":234,"context_line":"        \"\"\"Get all event types.\"\"\""},{"line_number":235,"context_line":"        return list(pecan.request.event_storage_conn.get_event_types())"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"da20952f_9e1ddd75","line":233,"updated":"2015-08-27 07:28:26.000000000","message":"should events type api be applied RBAC ? or will be done in another patch?","commit_id":"a3eb35e078ffad2a1f89ade746189f8a372d2b35"},{"author":{"_account_id":13637,"name":"Divya K Konoor","email":"dikonoor@in.ibm.com","username":"dikonoor"},"change_message_id":"4e8ac81c95196d0d7c525114bca0ef715550f9f9","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    @v2_utils.requires_admin"},{"line_number":232,"context_line":"    @wsme_pecan.wsexpose([six.text_type])"},{"line_number":233,"context_line":"    def get_all(self):"},{"line_number":234,"context_line":"        \"\"\"Get all event types.\"\"\""},{"line_number":235,"context_line":"        return list(pecan.request.event_storage_conn.get_event_types())"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"da20952f_4cad48e8","line":233,"in_reply_to":"da20952f_9e1ddd75","updated":"2015-08-27 13:39:13.000000000","message":"The changes being made are for this bp \u003e\u003e https://github.com/openstack/ceilometer-specs/blob/master/specs/liberty/events-rbac.rst , which is specifically for improving rbac for events rest api because of the sensitivity in the data that gets stored as events.","commit_id":"a3eb35e078ffad2a1f89ade746189f8a372d2b35"}],"ceilometer/tests/functional/api/v2/policy_fixture.json":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"96e406759762e10fe454802e264c6094340a4154","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    \"default\" : \"!\","},{"line_number":9,"context_line":"    \"telemetry:events:index\": \"rule:context_is_admin\","},{"line_number":10,"context_line":"    \"telemetry:events:show\": \"rule:context_is_admin\""},{"line_number":11,"context_line":"}"}],"source_content_type":"application/json","patch_set":6,"id":"fa1b9901_350a9527","line":11,"updated":"2015-08-18 12:54:06.000000000","message":"you should create a tempfile... something like this: https://github.com/openstack/ceilometer/blob/master/ceilometer/tests/functional/test_bin.py#L34-L42","commit_id":"c1ab25c39e6a7ef100ebc7f77c545ba5ed11b8ed"}],"ceilometer/tests/functional/api/v2/test_event_scenarios.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"96e406759762e10fe454802e264c6094340a4154","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    def setUp(self):"},{"line_number":135,"context_line":"        super(TestEventAPI_rbac, self).setUp()"},{"line_number":136,"context_line":"        file \u003d \u0027ceilometer/tests/functional/api/v2/policy_fixture.json\u0027"},{"line_number":137,"context_line":"        self.CONF.set_override(\"policy_file\","},{"line_number":138,"context_line":"                               self.path_get(file),"},{"line_number":139,"context_line":"                               group\u003d\u0027oslo_policy\u0027)"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_303f03b6","line":137,"updated":"2015-08-18 12:54:06.000000000","message":"this will probably fail still. the app is already made in the super.setUp() . i think you should just copy the entire setup and adjust as necessary.\n\n[1] https://github.com/openstack/ceilometer/blob/master/ceilometer/tests/functional/api/__init__.py#L55","commit_id":"c1ab25c39e6a7ef100ebc7f77c545ba5ed11b8ed"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"a41340157261d2b42f7acb7259474a0c4ab9caa2","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def test_get_events_rbac(self):"},{"line_number":161,"context_line":"        headers_rbac \u003d {\"X-Roles\": \"non-admin\"}"},{"line_number":162,"context_line":"        self.get_json(self.PATH, headers\u003dheaders_rbac)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"class TestEventAPI(EventTestBase):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa1b9901_ea2661b9","line":162,"updated":"2015-08-18 20:56:33.000000000","message":"interesting. does this work because you aren\u0027t passing in userid or projectid so it thinks it\u0027s admin?","commit_id":"2bc0d7a65a99722d08133e8e616486336de3e058"},{"author":{"_account_id":13637,"name":"Divya K Konoor","email":"dikonoor@in.ibm.com","username":"dikonoor"},"change_message_id":"4f7cf6bcd9c9b9f05dbe5aae9e60185328de46be","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def test_get_events_rbac(self):"},{"line_number":161,"context_line":"        headers_rbac \u003d {\"X-Roles\": \"non-admin\"}"},{"line_number":162,"context_line":"        self.get_json(self.PATH, headers\u003dheaders_rbac)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"class TestEventAPI(EventTestBase):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa1b9901_e040ef37","line":162,"in_reply_to":"fa1b9901_ea2661b9","updated":"2015-08-23 14:39:40.000000000","message":"In the events.py, I have removed the utils.admin_required call.So the /events call never hits the get_limited_to check. I had expected this testcase to fail but it passes.","commit_id":"2bc0d7a65a99722d08133e8e616486336de3e058"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"ed3faf9bdeed3d51b8d78b42558281219055f8ed","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        data \u003d self.get_json(self.PATH + \"/100\","},{"line_number":163,"context_line":"                             headers\u003dheaders_rbac,"},{"line_number":164,"context_line":"                             status\u003d403)"},{"line_number":165,"context_line":"        self.assertEqual(403, data.status_int)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def test_get_events_rbac(self):"},{"line_number":168,"context_line":"        headers_rbac \u003d {\"X-Roles\": \"non-admin\"}"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa1b9901_25dd8014","line":165,"updated":"2015-08-24 12:22:07.000000000","message":"as I have checked, the data is a dict and don\u0027t have \u0027status_int\u0027 attribute, see:\n\n(Pdb) p type(data)\n\n\u003ctype \u0027dict\u0027\u003e\n\n(Pdb) p data\n\n{u\u0027error_message\u0027: {u\u0027debuginfo\u0027: None, u\u0027faultcode\u0027: u\u0027Client\u0027, u\u0027faultstring\u0027: u\u0027RBAC Authorization Failed\u0027}}\n\nshould we just assert the error message ?","commit_id":"c3a88a635034376181f35028ff366e1680ffd388"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"b113a3e726ba14dab166ef44d2c8ed24fab5df34","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        data \u003d self.get_json(self.PATH + \"/100\","},{"line_number":163,"context_line":"                             headers\u003dheaders_rbac,"},{"line_number":164,"context_line":"                             status\u003d403)"},{"line_number":165,"context_line":"        self.assertEqual(403, data.status_int)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def test_get_events_rbac(self):"},{"line_number":168,"context_line":"        headers_rbac \u003d {\"X-Roles\": \"non-admin\"}"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa1b9901_a841673b","line":165,"in_reply_to":"fa1b9901_25dd8014","updated":"2015-08-24 12:31:51.000000000","message":"self.assertEqual(\u0027RBAC Authorization Failed\u0027, data[\u0027error_message\u0027][\u0027faultstring\u0027])\n\nbut we still need a 403 code, maybe something wrong about return code in api side.","commit_id":"c3a88a635034376181f35028ff366e1680ffd388"}]}