)]}'
{"ceilometer/pipeline.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"8c51dbae93ec68d30e4bbf4388bc355fc9f11316","unresolved":false,"context_lines":[{"line_number":398,"context_line":"                LOG.exception(_(\"Unable to load publisher %s\"), p)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        if len(self.publishers) \u003e 1:"},{"line_number":401,"context_line":"            self.multi_publish \u003d True"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        self.transformers \u003d self._setup_transformers(cfg, transformer_manager)"},{"line_number":404,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_7f5a2c2c","line":401,"updated":"2015-08-14 17:41:35.000000000","message":"you can do this one line\n\n  self.multi_publish \u003d True if len(self.publishers) \u003e 1 else False","commit_id":"1424bdf6b457f24f7edee3c6a3c6558145d3b2a3"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"8c51dbae93ec68d30e4bbf4388bc355fc9f11316","unresolved":false,"context_lines":[{"line_number":436,"context_line":"                    p.publish_events(ctxt, events)"},{"line_number":437,"context_line":"                except Exception:"},{"line_number":438,"context_line":"                    LOG.exception(_("},{"line_number":439,"context_line":"                        \"Pipeline %(pipeline)s: Exit after error \""},{"line_number":440,"context_line":"                        \"from publisher %(pub)s\") % ({\u0027pipeline\u0027: self,"},{"line_number":441,"context_line":"                                                      \u0027pub\u0027: p}))"},{"line_number":442,"context_line":"                    if not self.multi_publish:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_9ffdb80a","line":439,"updated":"2015-08-14 17:41:35.000000000","message":"i think this string becomes conditional too.","commit_id":"1424bdf6b457f24f7edee3c6a3c6558145d3b2a3"}],"ceilometer/tests/unit/event/test_endpoint.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f1b236346fb98c032d7c9a9bb28c3ed6e53ddd24","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                           TEST_NOTICE_PAYLOAD, TEST_NOTICE_METADATA)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def test_message_to_event_bad_event(self):"},{"line_number":139,"context_line":"        self.fake_publisher.publish_events.side_effect \u003d Exception"},{"line_number":140,"context_line":"        self.CONF.set_override(\"ack_on_event_error\", False,"},{"line_number":141,"context_line":"                               group\u003d\"notification\")"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_a3520fdc","line":139,"updated":"2015-08-17 20:34:49.000000000","message":"i might be missing something here but what behaviour changed? the tests don\u0027t seem to have changed.","commit_id":"55fc49140a7cdd3b203267c10f5f430bd003c80b"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"5058ca57c5ae0f2e303260b817ea2e4fff51f9f6","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                           TEST_NOTICE_PAYLOAD, TEST_NOTICE_METADATA)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def test_message_to_event_bad_event(self):"},{"line_number":139,"context_line":"        self.fake_publisher.publish_events.side_effect \u003d Exception"},{"line_number":140,"context_line":"        self.CONF.set_override(\"ack_on_event_error\", False,"},{"line_number":141,"context_line":"                               group\u003d\"notification\")"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_d4a01b93","line":139,"in_reply_to":"fa1b9901_19400e56","updated":"2015-08-17 22:00:25.000000000","message":"ah, i see... any chance we can test the multi-publisher path as well... maybe mock the logger to ensure we get the right error message?","commit_id":"55fc49140a7cdd3b203267c10f5f430bd003c80b"},{"author":{"_account_id":13560,"name":"Rohit Jaiswal","email":"rohit.jaiswal@gmail.com","username":"rjaiswal"},"change_message_id":"e89c2b793b7ad7b1894dc8133f56475f8ce1fd2d","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                           TEST_NOTICE_PAYLOAD, TEST_NOTICE_METADATA)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def test_message_to_event_bad_event(self):"},{"line_number":139,"context_line":"        self.fake_publisher.publish_events.side_effect \u003d Exception"},{"line_number":140,"context_line":"        self.CONF.set_override(\"ack_on_event_error\", False,"},{"line_number":141,"context_line":"                               group\u003d\"notification\")"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_19400e56","line":139,"in_reply_to":"fa1b9901_a3520fdc","updated":"2015-08-17 21:49:01.000000000","message":"gordc: Previously, the pipeline was mocked, so the publish_events method in pipeline:EventSink was not being tested, now with a real pipeline, only the publisher is mocked, so the code in EventSink:publish_events is being tested with the mock publisher for the exception scenario.","commit_id":"55fc49140a7cdd3b203267c10f5f430bd003c80b"},{"author":{"_account_id":13560,"name":"Rohit Jaiswal","email":"rohit.jaiswal@gmail.com","username":"rjaiswal"},"change_message_id":"a815a035f92b4fe2e181c1d6a52483a08813987b","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                           TEST_NOTICE_PAYLOAD, TEST_NOTICE_METADATA)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def test_message_to_event_bad_event(self):"},{"line_number":139,"context_line":"        self.fake_publisher.publish_events.side_effect \u003d Exception"},{"line_number":140,"context_line":"        self.CONF.set_override(\"ack_on_event_error\", False,"},{"line_number":141,"context_line":"                               group\u003d\"notification\")"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_b4548754","line":139,"in_reply_to":"fa1b9901_d4a01b93","updated":"2015-08-17 22:05:06.000000000","message":"sure, will do","commit_id":"55fc49140a7cdd3b203267c10f5f430bd003c80b"}],"ceilometer/tests/unit/test_event_pipeline.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"dc77cfbc14703ee47d31636e5c5401d3b72f2aed","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                                                    self.transformer_manager,"},{"line_number":361,"context_line":"                                                    self.p_type)"},{"line_number":362,"context_line":"        with pipeline_manager.publisher(None) as p:"},{"line_number":363,"context_line":"            self.assertRaises(FakeException, p, ([self.test_event]))"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        publisher \u003d pipeline_manager.pipelines[0].publishers[0]"},{"line_number":366,"context_line":"        self.assertEqual(1, len(publisher.events))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_56d1832e","line":363,"updated":"2015-08-14 02:43:43.000000000","message":"i don\u0027t understand why this test changed... is it because except:// gets processed first and it never gets to new://?","commit_id":"632c79197a0dd9da22ce4610e5bb0208674154aa"}]}