)]}'
{"ceilometer/api/controllers/v2/meters.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"7bd058a5d2d7c717cfb15dafa09de40815c83e56","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                pecan.response.location \u003d \"%(host)s/%(res)s/%(id)s\" % \\"},{"line_number":365,"context_line":"                                          {\u0027host\u0027: pecan.request.host_url,"},{"line_number":366,"context_line":"                                           \u0027res\u0027: \u0027v2/samples\u0027,"},{"line_number":367,"context_line":"                                           \u0027id\u0027: published_sample.id}"},{"line_number":368,"context_line":"            else:"},{"line_number":369,"context_line":"                published_samples.append(sample_dict)"},{"line_number":370,"context_line":"        if not direct:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_40e7a9ab","line":367,"updated":"2015-08-21 03:34:19.000000000","message":"Does this means the location header in response will only contains the last sample? Maybe we should add Links (https://github.com/openstack/ceilometer/blob/master/ceilometer/api/controllers/v2/base.py#L111) in the returned sample body, but that requires API versions changes I guess.","commit_id":"295be22b5d10ec6e60839ea117eb45018dac4cc0"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"92eebdcc922bcd6129b1ea9f6337f9ee459be4a0","unresolved":false,"context_lines":[{"line_number":373,"context_line":"            # here the \"container\" should be /v2/samples"},{"line_number":374,"context_line":"            pecan.response.location \u003d \"%(host)s/%(res)s\" % \\"},{"line_number":375,"context_line":"                                      {\u0027host\u0027: pecan.request.host_url,"},{"line_number":376,"context_line":"                                       \u0027res\u0027: \u0027v2/samples\u0027}"},{"line_number":377,"context_line":"            ctxt \u003d context.RequestContext(user\u003ddef_user_id,"},{"line_number":378,"context_line":"                                          tenant\u003ddef_project_id,"},{"line_number":379,"context_line":"                                          is_admin\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_7bece229","line":376,"updated":"2015-08-21 03:43:18.000000000","message":"also, this might be an another bug here. In indirect mode, the returned code should be 202, because we can\u0027t guarantee that all the user posted meters are stored in the DB because the configured pipeline might eat up some meters and generate new one, e.g. rateofchange transformer.","commit_id":"295be22b5d10ec6e60839ea117eb45018dac4cc0"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"16f4c929579862c0756713276ca0fb1094524eaf","unresolved":false,"context_lines":[{"line_number":359,"context_line":"                                        {\u0027host\u0027: pecan.request.host_url,"},{"line_number":360,"context_line":"                                         \u0027res\u0027: \u0027v2/samples\u0027,"},{"line_number":361,"context_line":"                                         \u0027id\u0027: published_sample.id},"},{"line_number":362,"context_line":"                                   rel\u003d\u0027sample\u0027))"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"            sample_dict \u003d publisher_utils.meter_message_from_counter("},{"line_number":365,"context_line":"                published_sample, cfg.CONF.publisher.telemetry_secret)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_d175caca","line":362,"updated":"2015-08-21 06:46:18.000000000","message":"should \u0027rel\u0027 be sample or self?","commit_id":"bd45f4b411033733687605f82a10fe32c33b2270"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"16f4c929579862c0756713276ca0fb1094524eaf","unresolved":false,"context_lines":[{"line_number":377,"context_line":"            notifier \u003d pecan.request.notifier"},{"line_number":378,"context_line":"            notifier.info(ctxt.to_dict(), \u0027telemetry.api\u0027, published_samples)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        return links"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    @wsme_pecan.wsexpose([Statistics],"},{"line_number":383,"context_line":"                         [base.Query], [six.text_type], int, [Aggregate])"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_f16b2eef","line":380,"updated":"2015-08-21 06:46:18.000000000","message":"why return links? we should still return samples I think","commit_id":"bd45f4b411033733687605f82a10fe32c33b2270"}]}
